hc
2023-11-06 e3e12f52b214121840b44c91de5b3e5af5d3eb84
kernel/drivers/gpu/drm/rockchip/inno_hdmi.c
....@@ -55,11 +55,28 @@
5555 struct completion cmp;
5656 };
5757
58
+enum inno_hdmi_dev_type {
59
+ RK3036_HDMI,
60
+ RK3128_HDMI,
61
+};
62
+
63
+struct inno_hdmi_phy_config {
64
+ unsigned long mpixelclock;
65
+ u8 pre_emphasis; /* pre-emphasis value */
66
+ u8 vlev_ctr; /* voltage level control */
67
+};
68
+
69
+struct inno_hdmi_plat_data {
70
+ enum inno_hdmi_dev_type dev_type;
71
+ struct inno_hdmi_phy_config *phy_config;
72
+};
73
+
5874 struct inno_hdmi {
5975 struct device *dev;
6076 struct drm_device *drm_dev;
6177
6278 int irq;
79
+ struct clk *aclk;
6380 struct clk *pclk;
6481 void __iomem *regs;
6582
....@@ -70,6 +87,7 @@
7087 struct i2c_adapter *ddc;
7188
7289 unsigned int tmds_rate;
90
+ const struct inno_hdmi_plat_data *plat_data;
7391
7492 struct hdmi_data_info hdmi_data;
7593 struct drm_display_mode previous_mode;
....@@ -197,12 +215,20 @@
197215
198216 static void inno_hdmi_set_pwr_mode(struct inno_hdmi *hdmi, int mode)
199217 {
218
+ const struct inno_hdmi_phy_config *phy_config =
219
+ hdmi->plat_data->phy_config;
220
+
200221 switch (mode) {
201222 case NORMAL:
202223 inno_hdmi_sys_power(hdmi, false);
203
-
204
- hdmi_writeb(hdmi, HDMI_PHY_PRE_EMPHASIS, 0x6f);
205
- hdmi_writeb(hdmi, HDMI_PHY_DRIVER, 0xbb);
224
+ for (; phy_config->mpixelclock != ~0UL; phy_config++)
225
+ if (hdmi->tmds_rate <= phy_config->mpixelclock)
226
+ break;
227
+ if (!phy_config->mpixelclock)
228
+ return;
229
+ hdmi_writeb(hdmi, HDMI_PHY_PRE_EMPHASIS,
230
+ phy_config->pre_emphasis);
231
+ hdmi_writeb(hdmi, HDMI_PHY_DRIVER, phy_config->vlev_ctr);
206232
207233 hdmi_writeb(hdmi, HDMI_PHY_SYS_CTL, 0x15);
208234 hdmi_writeb(hdmi, HDMI_PHY_SYS_CTL, 0x14);
....@@ -389,6 +415,12 @@
389415 {
390416 int value;
391417
418
+ if (hdmi->plat_data->dev_type == RK3036_HDMI) {
419
+ value = BIT(20) | BIT(21);
420
+ value |= mode->flags & DRM_MODE_FLAG_PHSYNC ? BIT(4) : 0;
421
+ value |= mode->flags & DRM_MODE_FLAG_PVSYNC ? BIT(5) : 0;
422
+ hdmi_writeb(hdmi, 0x148, value);
423
+ }
392424 /* Set detail external video timing polarity and interlace mode */
393425 value = v_EXTERANL_VIDEO(1);
394426 value |= mode->flags & DRM_MODE_FLAG_PHSYNC ?
....@@ -823,6 +855,41 @@
823855 return adap;
824856 }
825857
858
+static struct inno_hdmi_phy_config rk3036_hdmi_phy_config[] = {
859
+ /* pixelclk pre-emp vlev */
860
+ { 74250000, 0x3f, 0xbb },
861
+ { 165000000, 0x6f, 0xbb },
862
+ { ~0UL, 0x00, 0x00 }
863
+};
864
+
865
+static struct inno_hdmi_phy_config rk3128_hdmi_phy_config[] = {
866
+ /* pixelclk pre-emp vlev */
867
+ { 74250000, 0x3f, 0xaa },
868
+ { 165000000, 0x5f, 0xaa },
869
+ { ~0UL, 0x00, 0x00 }
870
+};
871
+
872
+static const struct inno_hdmi_plat_data rk3036_hdmi_drv_data = {
873
+ .dev_type = RK3036_HDMI,
874
+ .phy_config = rk3036_hdmi_phy_config,
875
+};
876
+
877
+static const struct inno_hdmi_plat_data rk3128_hdmi_drv_data = {
878
+ .dev_type = RK3128_HDMI,
879
+ .phy_config = rk3128_hdmi_phy_config,
880
+};
881
+
882
+static const struct of_device_id inno_hdmi_dt_ids[] = {
883
+ { .compatible = "rockchip,rk3036-inno-hdmi",
884
+ .data = &rk3036_hdmi_drv_data,
885
+ },
886
+ { .compatible = "rockchip,rk3128-inno-hdmi",
887
+ .data = &rk3128_hdmi_drv_data,
888
+ },
889
+ {},
890
+};
891
+MODULE_DEVICE_TABLE(of, inno_hdmi_dt_ids);
892
+
826893 static int inno_hdmi_bind(struct device *dev, struct device *master,
827894 void *data)
828895 {
....@@ -839,11 +906,22 @@
839906
840907 hdmi->dev = dev;
841908 hdmi->drm_dev = drm;
909
+ hdmi->plat_data = device_get_match_data(hdmi->dev);
842910
843911 iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
844912 hdmi->regs = devm_ioremap_resource(dev, iores);
845913 if (IS_ERR(hdmi->regs))
846914 return PTR_ERR(hdmi->regs);
915
+
916
+ irq = platform_get_irq(pdev, 0);
917
+ if (irq < 0)
918
+ return irq;
919
+
920
+ hdmi->aclk = devm_clk_get(hdmi->dev, "aclk");
921
+ if (IS_ERR(hdmi->aclk)) {
922
+ dev_err(hdmi->dev, "Unable to get HDMI aclk clk\n");
923
+ return PTR_ERR(hdmi->aclk);
924
+ }
847925
848926 hdmi->pclk = devm_clk_get(hdmi->dev, "pclk");
849927 if (IS_ERR(hdmi->pclk)) {
....@@ -851,17 +929,17 @@
851929 return PTR_ERR(hdmi->pclk);
852930 }
853931
854
- ret = clk_prepare_enable(hdmi->pclk);
932
+ ret = clk_prepare_enable(hdmi->aclk);
855933 if (ret) {
856934 DRM_DEV_ERROR(hdmi->dev,
857
- "Cannot enable HDMI pclk clock: %d\n", ret);
935
+ "Cannot enable HDMI aclk clock: %d\n", ret);
858936 return ret;
859937 }
860938
861
- irq = platform_get_irq(pdev, 0);
862
- if (irq < 0) {
863
- ret = irq;
864
- goto err_disable_clk;
939
+ ret = clk_prepare_enable(hdmi->pclk);
940
+ if (ret) {
941
+ dev_err(hdmi->dev, "Cannot enable HDMI pclk clock: %d\n", ret);
942
+ goto err_disable_aclk;
865943 }
866944
867945 inno_hdmi_reset(hdmi);
....@@ -870,7 +948,7 @@
870948 if (IS_ERR(hdmi->ddc)) {
871949 ret = PTR_ERR(hdmi->ddc);
872950 hdmi->ddc = NULL;
873
- goto err_disable_clk;
951
+ goto err_disable_pclk;
874952 }
875953
876954 /*
....@@ -894,17 +972,23 @@
894972 ret = devm_request_threaded_irq(dev, irq, inno_hdmi_hardirq,
895973 inno_hdmi_irq, IRQF_SHARED,
896974 dev_name(dev), hdmi);
897
- if (ret < 0)
975
+ if (ret) {
976
+ dev_err(hdmi->dev,
977
+ "failed to request hdmi irq: %d\n", ret);
898978 goto err_cleanup_hdmi;
979
+ }
899980
900981 return 0;
982
+
901983 err_cleanup_hdmi:
902984 hdmi->connector.funcs->destroy(&hdmi->connector);
903985 hdmi->encoder.funcs->destroy(&hdmi->encoder);
904986 err_put_adapter:
905987 i2c_put_adapter(hdmi->ddc);
906
-err_disable_clk:
988
+err_disable_pclk:
907989 clk_disable_unprepare(hdmi->pclk);
990
+err_disable_aclk:
991
+ clk_disable_unprepare(hdmi->aclk);
908992 return ret;
909993 }
910994
....@@ -918,6 +1002,7 @@
9181002
9191003 i2c_put_adapter(hdmi->ddc);
9201004 clk_disable_unprepare(hdmi->pclk);
1005
+ clk_disable_unprepare(hdmi->aclk);
9211006 }
9221007
9231008 static const struct component_ops inno_hdmi_ops = {
....@@ -936,13 +1021,6 @@
9361021
9371022 return 0;
9381023 }
939
-
940
-static const struct of_device_id inno_hdmi_dt_ids[] = {
941
- { .compatible = "rockchip,rk3036-inno-hdmi",
942
- },
943
- {},
944
-};
945
-MODULE_DEVICE_TABLE(of, inno_hdmi_dt_ids);
9461024
9471025 struct platform_driver inno_hdmi_driver = {
9481026 .probe = inno_hdmi_probe,