hc
2023-12-11 6778948f9de86c3cfaf36725a7c87dcff9ba247f
kernel/drivers/video/rockchip/mpp/mpp_vdpu2.c
....@@ -69,6 +69,9 @@
6969 #define VDPU2_DEC_CLOCK_GATE_EN BIT(4)
7070 #define VDPU2_DEC_START BIT(0)
7171
72
+#define VDPU2_REG_SOFT_RESET 0x0e8
73
+#define VDPU2_REG_SOFT_RESET_INDEX (58)
74
+
7275 #define VDPU2_REG_DIR_MV_BASE 0x0f8
7376 #define VDPU2_REG_DIR_MV_BASE_INDEX (62)
7477
....@@ -224,8 +227,11 @@
224227 offset = task->reg[idx] >> 10 << 4;
225228 }
226229 mem_region = mpp_task_attach_fd(&task->mpp_task, fd);
227
- if (IS_ERR(mem_region))
230
+ if (IS_ERR(mem_region)) {
231
+ mpp_err("reg[%3d]: %08x fd %d attach failed\n",
232
+ idx, task->reg[idx], fd);
228233 return -EFAULT;
234
+ }
229235
230236 iova = mem_region->iova;
231237 mpp_debug(DEBUG_IOMMU, "DMV[%3d]: %3d => %pad + offset %10d\n",
....@@ -340,6 +346,7 @@
340346 u32 i;
341347 u32 reg_en;
342348 struct vdpu_task *task = to_vdpu_task(mpp_task);
349
+ u32 timing_en = mpp->srv->timing_en;
343350
344351 mpp_debug_enter();
345352
....@@ -354,16 +361,32 @@
354361
355362 mpp_write_req(mpp, task->reg, s, e, reg_en);
356363 }
364
+
365
+ /* flush tlb before starting hardware */
366
+ mpp_iommu_flush_tlb(mpp->iommu_info);
367
+
357368 /* init current task */
358369 mpp->cur_task = mpp_task;
370
+
371
+ mpp_task_run_begin(mpp_task, timing_en, MPP_WORK_TIMEOUT_DELAY);
372
+
359373 /* Flush the registers */
360374 wmb();
361375 mpp_write(mpp, VDPU2_REG_DEC_EN,
362376 task->reg[reg_en] | VDPU2_DEC_START);
363377
378
+ mpp_task_run_end(mpp_task, timing_en);
379
+
364380 mpp_debug_leave();
365381
366382 return 0;
383
+}
384
+
385
+static int vdpu_px30_run(struct mpp_dev *mpp,
386
+ struct mpp_task *mpp_task)
387
+{
388
+ mpp_iommu_flush_tlb(mpp->iommu_info);
389
+ return vdpu_run(mpp, mpp_task);
367390 }
368391
369392 static int vdpu_finish(struct mpp_dev *mpp,
....@@ -456,6 +479,10 @@
456479 dec->procfs = NULL;
457480 return -EIO;
458481 }
482
+
483
+ /* for common mpp_dev options */
484
+ mpp_procfs_create_common(dec->procfs, mpp);
485
+
459486 mpp_procfs_create_u32("aclk", 0644,
460487 dec->procfs, &dec->aclk_info.debug_rate_hz);
461488 mpp_procfs_create_u32("session_buffers", 0644,
....@@ -596,21 +623,39 @@
596623 return IRQ_HANDLED;
597624 }
598625
626
+static int vdpu_soft_reset(struct mpp_dev *mpp)
627
+{
628
+ u32 val;
629
+ u32 ret;
630
+
631
+ mpp_write(mpp, VDPU2_REG_SOFT_RESET, 1);
632
+ ret = readl_relaxed_poll_timeout(mpp->reg_base + VDPU2_REG_SOFT_RESET,
633
+ val, !val, 0, 5);
634
+ return ret;
635
+}
636
+
599637 static int vdpu_reset(struct mpp_dev *mpp)
600638 {
601639 struct vdpu_dev *dec = to_vdpu_dev(mpp);
640
+ u32 ret = 0;
602641
603642 mpp_write(mpp, VDPU2_REG_DEC_EN, 0);
604643 mpp_write(mpp, VDPU2_REG_DEC_INT, 0);
605
- if (dec->rst_a && dec->rst_h) {
644
+
645
+ /* soft reset first */
646
+ ret = vdpu_soft_reset(mpp);
647
+ if (ret && dec->rst_a && dec->rst_h) {
606648 /* Don't skip this or iommu won't work after reset */
607
- rockchip_pmu_idle_request(mpp->dev, true);
649
+ mpp_err("soft reset failed, use cru reset!\n");
650
+ mpp_debug(DEBUG_RESET, "reset in\n");
651
+ mpp_pmu_idle_request(mpp, true);
608652 mpp_safe_reset(dec->rst_a);
609653 mpp_safe_reset(dec->rst_h);
610654 udelay(5);
611655 mpp_safe_unreset(dec->rst_a);
612656 mpp_safe_unreset(dec->rst_h);
613
- rockchip_pmu_idle_request(mpp->dev, false);
657
+ mpp_pmu_idle_request(mpp, false);
658
+ mpp_debug(DEBUG_RESET, "reset out\n");
614659 }
615660
616661 return 0;
....@@ -645,6 +690,16 @@
645690 .free_task = vdpu_free_task,
646691 };
647692
693
+static struct mpp_dev_ops vdpu_px30_dev_ops = {
694
+ .alloc_task = vdpu_alloc_task,
695
+ .run = vdpu_px30_run,
696
+ .irq = vdpu_irq,
697
+ .isr = vdpu_isr,
698
+ .finish = vdpu_finish,
699
+ .result = vdpu_result,
700
+ .free_task = vdpu_free_task,
701
+};
702
+
648703 static const struct mpp_dev_var vdpu_v2_data = {
649704 .device_type = MPP_DEVICE_VDPU2,
650705 .hw_info = &vdpu_v2_hw_info,
....@@ -658,7 +713,7 @@
658713 .hw_info = &vdpu_v2_hw_info,
659714 .trans_info = vdpu_v2_trans,
660715 .hw_ops = &vdpu_px30_hw_ops,
661
- .dev_ops = &vdpu_v2_dev_ops,
716
+ .dev_ops = &vdpu_px30_dev_ops,
662717 };
663718
664719 static const struct of_device_id mpp_vdpu2_dt_match[] = {
....@@ -687,15 +742,16 @@
687742 dec = devm_kzalloc(dev, sizeof(struct vdpu_dev), GFP_KERNEL);
688743 if (!dec)
689744 return -ENOMEM;
690
- platform_set_drvdata(pdev, dec);
691
-
692745 mpp = &dec->mpp;
746
+ platform_set_drvdata(pdev, mpp);
693747
694748 if (pdev->dev.of_node) {
695749 match = of_match_node(mpp_vdpu2_dt_match,
696750 pdev->dev.of_node);
697751 if (match)
698752 mpp->var = (struct mpp_dev_var *)match->data;
753
+
754
+ mpp->core_id = of_alias_get_id(pdev->dev.of_node, "vdpu");
699755 }
700756
701757 ret = mpp_dev_probe(mpp, pdev);
....@@ -731,37 +787,19 @@
731787 static int vdpu_remove(struct platform_device *pdev)
732788 {
733789 struct device *dev = &pdev->dev;
734
- struct vdpu_dev *dec = platform_get_drvdata(pdev);
790
+ struct mpp_dev *mpp = dev_get_drvdata(dev);
735791
736792 dev_info(dev, "remove device\n");
737
- mpp_dev_remove(&dec->mpp);
738
- vdpu_procfs_remove(&dec->mpp);
793
+ mpp_dev_remove(mpp);
794
+ vdpu_procfs_remove(mpp);
739795
740796 return 0;
741
-}
742
-
743
-static void vdpu_shutdown(struct platform_device *pdev)
744
-{
745
- int ret;
746
- int val;
747
- struct device *dev = &pdev->dev;
748
- struct vdpu_dev *dec = platform_get_drvdata(pdev);
749
- struct mpp_dev *mpp = &dec->mpp;
750
-
751
- dev_info(dev, "shutdown device\n");
752
-
753
- atomic_inc(&mpp->srv->shutdown_request);
754
- ret = readx_poll_timeout(atomic_read,
755
- &mpp->task_count,
756
- val, val == 0, 20000, 200000);
757
- if (ret == -ETIMEDOUT)
758
- dev_err(dev, "wait total running time out\n");
759797 }
760798
761799 struct platform_driver rockchip_vdpu2_driver = {
762800 .probe = vdpu_probe,
763801 .remove = vdpu_remove,
764
- .shutdown = vdpu_shutdown,
802
+ .shutdown = mpp_dev_shutdown,
765803 .driver = {
766804 .name = VDPU2_DRIVER_NAME,
767805 .of_match_table = of_match_ptr(mpp_vdpu2_dt_match),