hc
2024-01-03 2f7c68cb55ecb7331f2381deb497c27155f32faf
kernel/drivers/media/dvb-frontends/bcm3510.c
....@@ -649,6 +649,7 @@
649649 deb_info("firmware chunk, addr: 0x%04x, len: 0x%04x, total length: 0x%04zx\n",addr,len,fw->size);
650650 if ((ret = bcm3510_write_ram(st,addr,&b[i+4],len)) < 0) {
651651 err("firmware download failed: %d\n",ret);
652
+ release_firmware(fw);
652653 return ret;
653654 }
654655 i += 4 + len;
....@@ -773,7 +774,7 @@
773774 deb_info("attempting to download firmware\n");
774775 if ((ret = bcm3510_init_cold(st)) < 0)
775776 return ret;
776
- /* fall-through */
777
+ fallthrough;
777778 case JDEC_EEPROM_LOAD_WAIT:
778779 deb_info("firmware is loaded\n");
779780 bcm3510_check_firmware_version(st);
....@@ -834,7 +835,7 @@
834835 kfree(state);
835836 return NULL;
836837 }
837
-EXPORT_SYMBOL(bcm3510_attach);
838
+EXPORT_SYMBOL_GPL(bcm3510_attach);
838839
839840 static const struct dvb_frontend_ops bcm3510_ops = {
840841 .delsys = { SYS_ATSC, SYS_DVBC_ANNEX_B },