hc
2023-12-08 01573e231f18eb2d99162747186f59511f56b64d
kernel/net/decnet/dn_dev.c
....@@ -160,8 +160,8 @@
160160 static int min_priority[1];
161161 static int max_priority[] = { 127 }; /* From DECnet spec */
162162
163
-static int dn_forwarding_proc(struct ctl_table *, int,
164
- void __user *, size_t *, loff_t *);
163
+static int dn_forwarding_proc(struct ctl_table *, int, void *, size_t *,
164
+ loff_t *);
165165 static struct dn_dev_sysctl_table {
166166 struct ctl_table_header *sysctl_header;
167167 struct ctl_table dn_dev_vars[5];
....@@ -245,8 +245,7 @@
245245 }
246246
247247 static int dn_forwarding_proc(struct ctl_table *table, int write,
248
- void __user *buffer,
249
- size_t *lenp, loff_t *ppos)
248
+ void *buffer, size_t *lenp, loff_t *ppos)
250249 {
251250 #ifdef CONFIG_DECNET_ROUTER
252251 struct net_device *dev = table->extra1;
....@@ -463,7 +462,9 @@
463462 switch (cmd) {
464463 case SIOCGIFADDR:
465464 *((__le16 *)sdn->sdn_nodeaddr) = ifa->ifa_local;
466
- goto rarok;
465
+ if (copy_to_user(arg, ifr, DN_IFREQ_SIZE))
466
+ ret = -EFAULT;
467
+ break;
467468
468469 case SIOCSIFADDR:
469470 if (!ifa) {
....@@ -486,10 +487,6 @@
486487 rtnl_unlock();
487488
488489 return ret;
489
-rarok:
490
- if (copy_to_user(arg, ifr, DN_IFREQ_SIZE))
491
- ret = -EFAULT;
492
- goto done;
493490 }
494491
495492 struct net_device *dn_dev_get_default(void)
....@@ -583,8 +580,8 @@
583580 if (!net_eq(net, &init_net))
584581 goto errout;
585582
586
- err = nlmsg_parse(nlh, sizeof(*ifm), tb, IFA_MAX, dn_ifa_policy,
587
- extack);
583
+ err = nlmsg_parse_deprecated(nlh, sizeof(*ifm), tb, IFA_MAX,
584
+ dn_ifa_policy, extack);
588585 if (err < 0)
589586 goto errout;
590587
....@@ -629,8 +626,8 @@
629626 if (!net_eq(net, &init_net))
630627 return -EINVAL;
631628
632
- err = nlmsg_parse(nlh, sizeof(*ifm), tb, IFA_MAX, dn_ifa_policy,
633
- extack);
629
+ err = nlmsg_parse_deprecated(nlh, sizeof(*ifm), tb, IFA_MAX,
630
+ dn_ifa_policy, extack);
634631 if (err < 0)
635632 return err;
636633
....@@ -1363,7 +1360,7 @@
13631360
13641361 seq_printf(seq, "%-8s %1s %04u %04u %04lu %04lu"
13651362 " %04hu %03d %02x %-10s %-7s %-7s\n",
1366
- dev->name ? dev->name : "???",
1363
+ dev->name,
13671364 dn_type2asc(dn_db->parms.mode),
13681365 0, 0,
13691366 dn_db->t3, dn_db->parms.t3,