hc
2024-12-19 9370bb92b2d16684ee45cf24e879c93c509162da
kernel/security/apparmor/ipc.c
....@@ -1,3 +1,4 @@
1
+// SPDX-License-Identifier: GPL-2.0-only
12 /*
23 * AppArmor security module
34 *
....@@ -5,11 +6,6 @@
56 *
67 * Copyright (C) 1998-2008 Novell/SUSE
78 * Copyright 2009-2017 Canonical Ltd.
8
- *
9
- * This program is free software; you can redistribute it and/or
10
- * modify it under the terms of the GNU General Public License as
11
- * published by the Free Software Foundation, version 2 of the
12
- * License.
139 */
1410
1511 #include <linux/gfp.h>
....@@ -24,25 +20,23 @@
2420
2521 /**
2622 * audit_ptrace_mask - convert mask to permission string
27
- * @buffer: buffer to write string to (NOT NULL)
2823 * @mask: permission mask to convert
24
+ *
25
+ * Returns: pointer to static string
2926 */
30
-static void audit_ptrace_mask(struct audit_buffer *ab, u32 mask)
27
+static const char *audit_ptrace_mask(u32 mask)
3128 {
3229 switch (mask) {
3330 case MAY_READ:
34
- audit_log_string(ab, "read");
35
- break;
31
+ return "read";
3632 case MAY_WRITE:
37
- audit_log_string(ab, "trace");
38
- break;
33
+ return "trace";
3934 case AA_MAY_BE_READ:
40
- audit_log_string(ab, "readby");
41
- break;
35
+ return "readby";
4236 case AA_MAY_BE_TRACED:
43
- audit_log_string(ab, "tracedby");
44
- break;
37
+ return "tracedby";
4538 }
39
+ return "";
4640 }
4741
4842 /* call back to audit ptrace fields */
....@@ -51,12 +45,12 @@
5145 struct common_audit_data *sa = va;
5246
5347 if (aad(sa)->request & AA_PTRACE_PERM_MASK) {
54
- audit_log_format(ab, " requested_mask=");
55
- audit_ptrace_mask(ab, aad(sa)->request);
48
+ audit_log_format(ab, " requested_mask=\"%s\"",
49
+ audit_ptrace_mask(aad(sa)->request));
5650
5751 if (aad(sa)->denied & AA_PTRACE_PERM_MASK) {
58
- audit_log_format(ab, " denied_mask=");
59
- audit_ptrace_mask(ab, aad(sa)->denied);
52
+ audit_log_format(ab, " denied_mask=\"%s\"",
53
+ audit_ptrace_mask(aad(sa)->denied));
6054 }
6155 }
6256 audit_log_format(ab, " peer=");
....@@ -146,16 +140,18 @@
146140 }
147141
148142 /**
149
- * audit_file_mask - convert mask to permission string
150
- * @buffer: buffer to write string to (NOT NULL)
143
+ * audit_signal_mask - convert mask to permission string
151144 * @mask: permission mask to convert
145
+ *
146
+ * Returns: pointer to static string
152147 */
153
-static void audit_signal_mask(struct audit_buffer *ab, u32 mask)
148
+static const char *audit_signal_mask(u32 mask)
154149 {
155150 if (mask & MAY_READ)
156
- audit_log_string(ab, "receive");
151
+ return "receive";
157152 if (mask & MAY_WRITE)
158
- audit_log_string(ab, "send");
153
+ return "send";
154
+ return "";
159155 }
160156
161157 /**
....@@ -168,11 +164,11 @@
168164 struct common_audit_data *sa = va;
169165
170166 if (aad(sa)->request & AA_SIGNAL_PERM_MASK) {
171
- audit_log_format(ab, " requested_mask=");
172
- audit_signal_mask(ab, aad(sa)->request);
167
+ audit_log_format(ab, " requested_mask=\"%s\"",
168
+ audit_signal_mask(aad(sa)->request));
173169 if (aad(sa)->denied & AA_SIGNAL_PERM_MASK) {
174
- audit_log_format(ab, " denied_mask=");
175
- audit_signal_mask(ab, aad(sa)->denied);
170
+ audit_log_format(ab, " denied_mask=\"%s\"",
171
+ audit_signal_mask(aad(sa)->denied));
176172 }
177173 }
178174 if (aad(sa)->signal == SIGUNKNOWN)