hc
2024-12-19 9370bb92b2d16684ee45cf24e879c93c509162da
kernel/kernel/fork.c
....@@ -1,3 +1,4 @@
1
+// SPDX-License-Identifier: GPL-2.0-only
12 /*
23 * linux/kernel/fork.c
34 *
....@@ -39,7 +40,6 @@
3940 #include <linux/binfmts.h>
4041 #include <linux/mman.h>
4142 #include <linux/mmu_notifier.h>
42
-#include <linux/hmm.h>
4343 #include <linux/fs.h>
4444 #include <linux/mm.h>
4545 #include <linux/vmacache.h>
....@@ -79,7 +79,6 @@
7979 #include <linux/blkdev.h>
8080 #include <linux/fs_struct.h>
8181 #include <linux/magic.h>
82
-#include <linux/sched/mm.h>
8382 #include <linux/perf_event.h>
8483 #include <linux/posix-timers.h>
8584 #include <linux/user-return-notifier.h>
....@@ -93,10 +92,12 @@
9392 #include <linux/kcov.h>
9493 #include <linux/livepatch.h>
9594 #include <linux/thread_info.h>
96
-#include <linux/cpufreq_times.h>
95
+#include <linux/stackleak.h>
96
+#include <linux/kasan.h>
9797 #include <linux/scs.h>
98
+#include <linux/io_uring.h>
99
+#include <linux/cpufreq_times.h>
98100
99
-#include <asm/pgtable.h>
100101 #include <asm/pgalloc.h>
101102 #include <linux/uaccess.h>
102103 #include <asm/mmu_context.h>
....@@ -108,6 +109,8 @@
108109 #define CREATE_TRACE_POINTS
109110 #include <trace/events/task.h>
110111
112
+#undef CREATE_TRACE_POINTS
113
+#include <trace/hooks/sched.h>
111114 /*
112115 * Minimum number of threads to boot the kernel
113116 */
....@@ -118,17 +121,29 @@
118121 */
119122 #define MAX_THREADS FUTEX_TID_MASK
120123
124
+EXPORT_TRACEPOINT_SYMBOL_GPL(task_newtask);
125
+
121126 /*
122127 * Protected counters by write_lock_irq(&tasklist_lock)
123128 */
124129 unsigned long total_forks; /* Handle normal Linux uptimes. */
125130 int nr_threads; /* The idle threads do not count.. */
126131
127
-int max_threads; /* tunable limit on nr_threads */
132
+static int max_threads; /* tunable limit on nr_threads */
133
+
134
+#define NAMED_ARRAY_INDEX(x) [x] = __stringify(x)
135
+
136
+static const char * const resident_page_types[] = {
137
+ NAMED_ARRAY_INDEX(MM_FILEPAGES),
138
+ NAMED_ARRAY_INDEX(MM_ANONPAGES),
139
+ NAMED_ARRAY_INDEX(MM_SWAPENTS),
140
+ NAMED_ARRAY_INDEX(MM_SHMEMPAGES),
141
+};
128142
129143 DEFINE_PER_CPU(unsigned long, process_counts) = 0;
130144
131145 __cacheline_aligned DEFINE_RWLOCK(tasklist_lock); /* outer */
146
+EXPORT_SYMBOL_GPL(tasklist_lock);
132147
133148 #ifdef CONFIG_PROVE_RCU
134149 int lockdep_tasklist_lock_is_held(void)
....@@ -216,6 +231,9 @@
216231 if (!s)
217232 continue;
218233
234
+ /* Mark stack accessible for KASAN. */
235
+ kasan_unpoison_range(s->addr, THREAD_SIZE);
236
+
219237 /* Clear stale pointers from reused stack. */
220238 memset(s->addr, 0, THREAD_SIZE);
221239
....@@ -224,9 +242,14 @@
224242 return s->addr;
225243 }
226244
245
+ /*
246
+ * Allocated stacks are cached and later reused by new threads,
247
+ * so memcg accounting is performed manually on assigning/releasing
248
+ * stacks to tasks. Drop __GFP_ACCOUNT.
249
+ */
227250 stack = __vmalloc_node_range(THREAD_SIZE, THREAD_ALIGN,
228251 VMALLOC_START, VMALLOC_END,
229
- THREADINFO_GFP,
252
+ THREADINFO_GFP & ~__GFP_ACCOUNT,
230253 PAGE_KERNEL,
231254 0, node, __builtin_return_address(0));
232255
....@@ -245,7 +268,7 @@
245268 THREAD_SIZE_ORDER);
246269
247270 if (likely(page)) {
248
- tsk->stack = page_address(page);
271
+ tsk->stack = kasan_reset_tag(page_address(page));
249272 return tsk->stack;
250273 }
251274 return NULL;
....@@ -255,8 +278,13 @@
255278 static inline void free_thread_stack(struct task_struct *tsk)
256279 {
257280 #ifdef CONFIG_VMAP_STACK
258
- if (task_stack_vm_area(tsk)) {
281
+ struct vm_struct *vm = task_stack_vm_area(tsk);
282
+
283
+ if (vm) {
259284 int i;
285
+
286
+ for (i = 0; i < THREAD_SIZE / PAGE_SIZE; i++)
287
+ memcg_kmem_uncharge_page(vm->pages[i], 0);
260288
261289 for (i = 0; i < NR_CACHED_STACKS; i++) {
262290 if (this_cpu_cmpxchg(cached_stacks[i],
....@@ -281,6 +309,7 @@
281309 {
282310 unsigned long *stack;
283311 stack = kmem_cache_alloc_node(thread_stack_cache, THREADINFO_GFP, node);
312
+ stack = kasan_reset_tag(stack);
284313 tsk->stack = stack;
285314 return stack;
286315 }
....@@ -333,8 +362,15 @@
333362 struct vm_area_struct *new = kmem_cache_alloc(vm_area_cachep, GFP_KERNEL);
334363
335364 if (new) {
336
- *new = *orig;
337
- INIT_LIST_HEAD(&new->anon_vma_chain);
365
+ ASSERT_EXCLUSIVE_WRITER(orig->vm_flags);
366
+ ASSERT_EXCLUSIVE_WRITER(orig->vm_file);
367
+ /*
368
+ * orig->shared.rb may be modified concurrently, but the clone
369
+ * will be reinitialized.
370
+ */
371
+ *new = data_race(*orig);
372
+ INIT_VMA(new);
373
+ new->vm_next = new->vm_prev = NULL;
338374 }
339375 return new;
340376 }
....@@ -349,6 +385,22 @@
349385 void *stack = task_stack_page(tsk);
350386 struct vm_struct *vm = task_stack_vm_area(tsk);
351387
388
+
389
+ /* All stack pages are in the same node. */
390
+ if (vm)
391
+ mod_lruvec_page_state(vm->pages[0], NR_KERNEL_STACK_KB,
392
+ account * (THREAD_SIZE / 1024));
393
+ else
394
+ mod_lruvec_slab_state(stack, NR_KERNEL_STACK_KB,
395
+ account * (THREAD_SIZE / 1024));
396
+}
397
+
398
+static int memcg_charge_kernel_stack(struct task_struct *tsk)
399
+{
400
+#ifdef CONFIG_VMAP_STACK
401
+ struct vm_struct *vm = task_stack_vm_area(tsk);
402
+ int ret;
403
+
352404 BUILD_BUG_ON(IS_ENABLED(CONFIG_VMAP_STACK) && PAGE_SIZE % 1024 != 0);
353405
354406 if (vm) {
....@@ -357,27 +409,19 @@
357409 BUG_ON(vm->nr_pages != THREAD_SIZE / PAGE_SIZE);
358410
359411 for (i = 0; i < THREAD_SIZE / PAGE_SIZE; i++) {
360
- mod_zone_page_state(page_zone(vm->pages[i]),
361
- NR_KERNEL_STACK_KB,
362
- PAGE_SIZE / 1024 * account);
412
+ /*
413
+ * If memcg_kmem_charge_page() fails, page->mem_cgroup
414
+ * pointer is NULL, and memcg_kmem_uncharge_page() in
415
+ * free_thread_stack() will ignore this page.
416
+ */
417
+ ret = memcg_kmem_charge_page(vm->pages[i], GFP_KERNEL,
418
+ 0);
419
+ if (ret)
420
+ return ret;
363421 }
364
-
365
- /* All stack pages belong to the same memcg. */
366
- mod_memcg_page_state(vm->pages[0], MEMCG_KERNEL_STACK_KB,
367
- account * (THREAD_SIZE / 1024));
368
- } else {
369
- /*
370
- * All stack pages are in the same zone and belong to the
371
- * same memcg.
372
- */
373
- struct page *first_page = virt_to_page(stack);
374
-
375
- mod_zone_page_state(page_zone(first_page), NR_KERNEL_STACK_KB,
376
- THREAD_SIZE / 1024 * account);
377
-
378
- mod_memcg_page_state(first_page, MEMCG_KERNEL_STACK_KB,
379
- account * (THREAD_SIZE / 1024));
380422 }
423
+#endif
424
+ return 0;
381425 }
382426
383427 static void release_task_stack(struct task_struct *tsk)
....@@ -396,16 +440,21 @@
396440 #ifdef CONFIG_THREAD_INFO_IN_TASK
397441 void put_task_stack(struct task_struct *tsk)
398442 {
399
- if (atomic_dec_and_test(&tsk->stack_refcount))
443
+ if (refcount_dec_and_test(&tsk->stack_refcount))
400444 release_task_stack(tsk);
401445 }
446
+EXPORT_SYMBOL_GPL(put_task_stack);
402447 #endif
403448
404449 void free_task(struct task_struct *tsk)
405450 {
451
+#ifdef CONFIG_SECCOMP
452
+ WARN_ON_ONCE(tsk->seccomp.filter);
453
+#endif
406454 cpufreq_task_times_exit(tsk);
407455 scs_release(tsk);
408456
457
+ trace_android_vh_free_task(tsk);
409458 #ifndef CONFIG_THREAD_INFO_IN_TASK
410459 /*
411460 * The task is finally done with both the stack and thread_info,
....@@ -417,11 +466,10 @@
417466 * If the task had a separate stack allocation, it should be gone
418467 * by now.
419468 */
420
- WARN_ON_ONCE(atomic_read(&tsk->stack_refcount) != 0);
469
+ WARN_ON_ONCE(refcount_read(&tsk->stack_refcount) != 0);
421470 #endif
422471 rt_mutex_debug_task_free(tsk);
423472 ftrace_graph_exit_task(tsk);
424
- put_seccomp_filter(tsk);
425473 arch_release_task_struct(tsk);
426474 if (tsk->flags & PF_KTHREAD)
427475 free_kthread_struct(tsk);
....@@ -433,14 +481,14 @@
433481 static __latent_entropy int dup_mmap(struct mm_struct *mm,
434482 struct mm_struct *oldmm)
435483 {
436
- struct vm_area_struct *mpnt, *tmp, *prev, **pprev;
484
+ struct vm_area_struct *mpnt, *tmp, *prev, **pprev, *last = NULL;
437485 struct rb_node **rb_link, *rb_parent;
438486 int retval;
439487 unsigned long charge;
440488 LIST_HEAD(uf);
441489
442490 uprobe_start_dup_mmap();
443
- if (down_write_killable(&oldmm->mmap_sem)) {
491
+ if (mmap_write_lock_killable(oldmm)) {
444492 retval = -EINTR;
445493 goto fail_uprobe_end;
446494 }
....@@ -449,7 +497,7 @@
449497 /*
450498 * Not linked in yet - no deadlock potential:
451499 */
452
- down_write_nested(&mm->mmap_sem, SINGLE_DEPTH_NESTING);
500
+ mmap_write_lock_nested(mm, SINGLE_DEPTH_NESTING);
453501
454502 /* No ordering required: file already has been exposed. */
455503 RCU_INIT_POINTER(mm->exe_file, get_mm_exe_file(oldmm));
....@@ -504,14 +552,15 @@
504552 if (retval)
505553 goto fail_nomem_anon_vma_fork;
506554 if (tmp->vm_flags & VM_WIPEONFORK) {
507
- /* VM_WIPEONFORK gets a clean slate in the child. */
555
+ /*
556
+ * VM_WIPEONFORK gets a clean slate in the child.
557
+ * Don't prepare anon_vma until fault since we don't
558
+ * copy page for current vma.
559
+ */
508560 tmp->anon_vma = NULL;
509
- if (anon_vma_prepare(tmp))
510
- goto fail_nomem_anon_vma_fork;
511561 } else if (anon_vma_fork(tmp, mpnt))
512562 goto fail_nomem_anon_vma_fork;
513563 tmp->vm_flags &= ~(VM_LOCKED | VM_LOCKONFAULT);
514
- tmp->vm_next = tmp->vm_prev = NULL;
515564 file = tmp->vm_file;
516565 if (file) {
517566 struct inode *inode = file_inode(file);
....@@ -519,10 +568,10 @@
519568
520569 get_file(file);
521570 if (tmp->vm_flags & VM_DENYWRITE)
522
- atomic_dec(&inode->i_writecount);
571
+ put_write_access(inode);
523572 i_mmap_lock_write(mapping);
524573 if (tmp->vm_flags & VM_SHARED)
525
- atomic_inc(&mapping->i_mmap_writable);
574
+ mapping_allow_writable(mapping);
526575 flush_dcache_mmap_lock(mapping);
527576 /* insert tmp into the share list, just after mpnt */
528577 vma_interval_tree_insert_after(tmp, mpnt,
....@@ -552,8 +601,18 @@
552601 rb_parent = &tmp->vm_rb;
553602
554603 mm->map_count++;
555
- if (!(tmp->vm_flags & VM_WIPEONFORK))
556
- retval = copy_page_range(mm, oldmm, mpnt);
604
+ if (!(tmp->vm_flags & VM_WIPEONFORK)) {
605
+ if (IS_ENABLED(CONFIG_SPECULATIVE_PAGE_FAULT)) {
606
+ /*
607
+ * Mark this VMA as changing to prevent the
608
+ * speculative page fault hanlder to process
609
+ * it until the TLB are flushed below.
610
+ */
611
+ last = mpnt;
612
+ vm_write_begin(mpnt);
613
+ }
614
+ retval = copy_page_range(tmp, mpnt);
615
+ }
557616
558617 if (tmp->vm_ops && tmp->vm_ops->open)
559618 tmp->vm_ops->open(tmp);
....@@ -564,9 +623,25 @@
564623 /* a new mm has just been created */
565624 retval = arch_dup_mmap(oldmm, mm);
566625 out:
567
- up_write(&mm->mmap_sem);
626
+ mmap_write_unlock(mm);
568627 flush_tlb_mm(oldmm);
569
- up_write(&oldmm->mmap_sem);
628
+
629
+ if (IS_ENABLED(CONFIG_SPECULATIVE_PAGE_FAULT)) {
630
+ /*
631
+ * Since the TLB has been flush, we can safely unmark the
632
+ * copied VMAs and allows the speculative page fault handler to
633
+ * process them again.
634
+ * Walk back the VMA list from the last marked VMA.
635
+ */
636
+ for (; last; last = last->vm_prev) {
637
+ if (last->vm_flags & VM_DONTCOPY)
638
+ continue;
639
+ if (!(last->vm_flags & VM_WIPEONFORK))
640
+ vm_write_end(last);
641
+ }
642
+ }
643
+
644
+ mmap_write_unlock(oldmm);
570645 dup_userfaultfd_complete(&uf);
571646 fail_uprobe_end:
572647 uprobe_end_dup_mmap();
....@@ -596,9 +671,9 @@
596671 #else
597672 static int dup_mmap(struct mm_struct *mm, struct mm_struct *oldmm)
598673 {
599
- down_write(&oldmm->mmap_sem);
674
+ mmap_write_lock(oldmm);
600675 RCU_INIT_POINTER(mm->exe_file, get_mm_exe_file(oldmm));
601
- up_write(&oldmm->mmap_sem);
676
+ mmap_write_unlock(oldmm);
602677 return 0;
603678 }
604679 #define mm_alloc_pgd(mm) (0)
....@@ -609,12 +684,15 @@
609684 {
610685 int i;
611686
687
+ BUILD_BUG_ON_MSG(ARRAY_SIZE(resident_page_types) != NR_MM_COUNTERS,
688
+ "Please make sure 'struct resident_page_types[]' is updated as well");
689
+
612690 for (i = 0; i < NR_MM_COUNTERS; i++) {
613691 long x = atomic_long_read(&mm->rss_stat.count[i]);
614692
615693 if (unlikely(x))
616
- printk(KERN_ALERT "BUG: Bad rss-counter state "
617
- "mm:%p idx:%d val:%ld\n", mm, i, x);
694
+ pr_alert("BUG: Bad rss-counter state mm:%p type:%s val:%ld\n",
695
+ mm, resident_page_types[i], x);
618696 }
619697
620698 if (mm_pgtables_bytes(mm))
....@@ -641,8 +719,7 @@
641719 WARN_ON_ONCE(mm == current->active_mm);
642720 mm_free_pgd(mm);
643721 destroy_context(mm);
644
- hmm_mm_destroy(mm);
645
- mmu_notifier_mm_destroy(mm);
722
+ mmu_notifier_subscriptions_destroy(mm);
646723 check_mm(mm);
647724 put_user_ns(mm->user_ns);
648725 free_mm(mm);
....@@ -680,16 +757,17 @@
680757
681758 static inline void put_signal_struct(struct signal_struct *sig)
682759 {
683
- if (atomic_dec_and_test(&sig->sigcnt))
760
+ if (refcount_dec_and_test(&sig->sigcnt))
684761 free_signal_struct(sig);
685762 }
686763
687764 void __put_task_struct(struct task_struct *tsk)
688765 {
689766 WARN_ON(!tsk->exit_state);
690
- WARN_ON(atomic_read(&tsk->usage));
767
+ WARN_ON(refcount_read(&tsk->usage));
691768 WARN_ON(tsk == current);
692769
770
+ io_uring_free(tsk);
693771 cgroup_free(tsk);
694772 task_numa_free(tsk, true);
695773 security_task_free(tsk);
....@@ -702,6 +780,14 @@
702780 }
703781 EXPORT_SYMBOL_GPL(__put_task_struct);
704782
783
+void __put_task_struct_rcu_cb(struct rcu_head *rhp)
784
+{
785
+ struct task_struct *task = container_of(rhp, struct task_struct, rcu);
786
+
787
+ __put_task_struct(task);
788
+}
789
+EXPORT_SYMBOL_GPL(__put_task_struct_rcu_cb);
790
+
705791 void __init __weak arch_task_cache_init(void) { }
706792
707793 /*
....@@ -710,15 +796,16 @@
710796 static void set_max_threads(unsigned int max_threads_suggested)
711797 {
712798 u64 threads;
799
+ unsigned long nr_pages = totalram_pages();
713800
714801 /*
715802 * The number of threads shall be limited such that the thread
716803 * structures may only consume a small part of the available memory.
717804 */
718
- if (fls64(totalram_pages) + fls64(PAGE_SIZE) > 64)
805
+ if (fls64(nr_pages) + fls64(PAGE_SIZE) > 64)
719806 threads = MAX_THREADS;
720807 else
721
- threads = div64_u64((u64) totalram_pages * (u64) PAGE_SIZE,
808
+ threads = div64_u64((u64) nr_pages * (u64) PAGE_SIZE,
722809 (u64) THREAD_SIZE * 8UL);
723810
724811 if (threads > max_threads_suggested)
....@@ -732,6 +819,7 @@
732819 int arch_task_struct_size __read_mostly;
733820 #endif
734821
822
+#ifndef CONFIG_ARCH_TASK_STRUCT_ALLOCATOR
735823 static void task_struct_whitelist(unsigned long *offset, unsigned long *size)
736824 {
737825 /* Fetch thread_struct whitelist for the architecture. */
....@@ -746,6 +834,7 @@
746834 else
747835 *offset += offsetof(struct task_struct, thread);
748836 }
837
+#endif /* CONFIG_ARCH_TASK_STRUCT_ALLOCATOR */
749838
750839 void __init fork_init(void)
751840 {
....@@ -787,6 +876,7 @@
787876 scs_init();
788877
789878 lockdep_init_task(&init_task);
879
+ uprobes_init();
790880 }
791881
792882 int __weak arch_dup_task_struct(struct task_struct *dst,
....@@ -808,7 +898,7 @@
808898 {
809899 struct task_struct *tsk;
810900 unsigned long *stack;
811
- struct vm_struct *stack_vm_area;
901
+ struct vm_struct *stack_vm_area __maybe_unused;
812902 int err;
813903
814904 if (node == NUMA_NO_NODE)
....@@ -820,6 +910,9 @@
820910 stack = alloc_thread_stack_node(tsk, node);
821911 if (!stack)
822912 goto free_tsk;
913
+
914
+ if (memcg_charge_kernel_stack(tsk))
915
+ goto free_stack;
823916
824917 stack_vm_area = task_stack_vm_area(tsk);
825918
....@@ -835,7 +928,7 @@
835928 tsk->stack_vm_area = stack_vm_area;
836929 #endif
837930 #ifdef CONFIG_THREAD_INFO_IN_TASK
838
- atomic_set(&tsk->stack_refcount, 1);
931
+ refcount_set(&tsk->stack_refcount, 1);
839932 #endif
840933
841934 if (err)
....@@ -863,18 +956,23 @@
863956 #ifdef CONFIG_STACKPROTECTOR
864957 tsk->stack_canary = get_random_canary();
865958 #endif
959
+ if (orig->cpus_ptr == &orig->cpus_mask)
960
+ tsk->cpus_ptr = &tsk->cpus_mask;
866961
867962 /*
868
- * One for us, one for whoever does the "release_task()" (usually
869
- * parent)
963
+ * One for the user space visible state that goes away when reaped.
964
+ * One for the scheduler.
870965 */
871
- atomic_set(&tsk->usage, 2);
966
+ refcount_set(&tsk->rcu_users, 2);
967
+ /* One for the rcu users */
968
+ refcount_set(&tsk->usage, 1);
872969 #ifdef CONFIG_BLK_DEV_IO_TRACE
873970 tsk->btrace_seq = 0;
874971 #endif
875972 tsk->splice_pipe = NULL;
876973 tsk->task_frag.page = NULL;
877974 tsk->wake_q.next = NULL;
975
+ tsk->pf_io_worker = NULL;
878976
879977 account_kernel_stack(tsk, 1);
880978
....@@ -892,6 +990,11 @@
892990 #ifdef CONFIG_MEMCG
893991 tsk->active_memcg = NULL;
894992 #endif
993
+
994
+ android_init_vendor_data(tsk, 1);
995
+ android_init_oem_data(tsk, 1);
996
+
997
+ trace_android_vh_dup_task_struct(tsk, orig);
895998 return tsk;
896999
8971000 free_stack:
....@@ -941,6 +1044,13 @@
9411044 #endif
9421045 }
9431046
1047
+static void mm_init_pasid(struct mm_struct *mm)
1048
+{
1049
+#ifdef CONFIG_IOMMU_SUPPORT
1050
+ mm->pasid = INIT_PASID;
1051
+#endif
1052
+}
1053
+
9441054 static void mm_init_uprobes_state(struct mm_struct *mm)
9451055 {
9461056 #ifdef CONFIG_UPROBES
....@@ -954,24 +1064,30 @@
9541064 mm->mmap = NULL;
9551065 mm->mm_rb = RB_ROOT;
9561066 mm->vmacache_seqnum = 0;
1067
+#ifdef CONFIG_SPECULATIVE_PAGE_FAULT
1068
+ rwlock_init(&mm->mm_rb_lock);
1069
+#endif
9571070 atomic_set(&mm->mm_users, 1);
9581071 atomic_set(&mm->mm_count, 1);
959
- init_rwsem(&mm->mmap_sem);
1072
+ seqcount_init(&mm->write_protect_seq);
1073
+ mmap_init_lock(mm);
9601074 INIT_LIST_HEAD(&mm->mmlist);
9611075 mm->core_state = NULL;
9621076 mm_pgtables_bytes_init(mm);
9631077 mm->map_count = 0;
9641078 mm->locked_vm = 0;
965
- mm->pinned_vm = 0;
1079
+ atomic_set(&mm->has_pinned, 0);
1080
+ atomic64_set(&mm->pinned_vm, 0);
9661081 memset(&mm->rss_stat, 0, sizeof(mm->rss_stat));
9671082 spin_lock_init(&mm->page_table_lock);
9681083 spin_lock_init(&mm->arg_lock);
9691084 mm_init_cpumask(mm);
9701085 mm_init_aio(mm);
9711086 mm_init_owner(mm, p);
1087
+ mm_init_pasid(mm);
9721088 RCU_INIT_POINTER(mm->exe_file, NULL);
973
- mmu_notifier_mm_init(mm);
974
- hmm_mm_init(mm);
1089
+ if (!mmu_notifier_subscriptions_init(mm))
1090
+ goto fail_nopgd;
9751091 init_tlb_flush_pending(mm);
9761092 #if defined(CONFIG_TRANSPARENT_HUGEPAGE) && !USE_SPLIT_PMD_PTLOCKS
9771093 mm->pmd_huge_pte = NULL;
....@@ -1046,8 +1162,10 @@
10461162 {
10471163 might_sleep();
10481164
1049
- if (atomic_dec_and_test(&mm->mm_users))
1165
+ if (atomic_dec_and_test(&mm->mm_users)) {
1166
+ trace_android_vh_mmput(NULL);
10501167 __mmput(mm);
1168
+ }
10511169 }
10521170 EXPORT_SYMBOL_GPL(mmput);
10531171
....@@ -1067,6 +1185,7 @@
10671185 schedule_work(&mm->async_put_work);
10681186 }
10691187 }
1188
+EXPORT_SYMBOL_GPL(mmput_async);
10701189 #endif
10711190
10721191 /**
....@@ -1171,7 +1290,7 @@
11711290 struct mm_struct *mm;
11721291 int err;
11731292
1174
- err = mutex_lock_killable(&task->signal->cred_guard_mutex);
1293
+ err = down_read_killable(&task->signal->exec_update_lock);
11751294 if (err)
11761295 return ERR_PTR(err);
11771296
....@@ -1181,7 +1300,7 @@
11811300 mmput(mm);
11821301 mm = ERR_PTR(-EACCES);
11831302 }
1184
- mutex_unlock(&task->signal->cred_guard_mutex);
1303
+ up_read(&task->signal->exec_update_lock);
11851304
11861305 return mm;
11871306 }
....@@ -1279,13 +1398,20 @@
12791398 mm_release(tsk, mm);
12801399 }
12811400
1282
-/*
1283
- * Allocate a new mm structure and copy contents from the
1284
- * mm structure of the passed in task structure.
1401
+/**
1402
+ * dup_mm() - duplicates an existing mm structure
1403
+ * @tsk: the task_struct with which the new mm will be associated.
1404
+ * @oldmm: the mm to duplicate.
1405
+ *
1406
+ * Allocates a new mm structure and duplicates the provided @oldmm structure
1407
+ * content into it.
1408
+ *
1409
+ * Return: the duplicated mm or NULL on failure.
12851410 */
1286
-static struct mm_struct *dup_mm(struct task_struct *tsk)
1411
+static struct mm_struct *dup_mm(struct task_struct *tsk,
1412
+ struct mm_struct *oldmm)
12871413 {
1288
- struct mm_struct *mm, *oldmm = current->mm;
1414
+ struct mm_struct *mm;
12891415 int err;
12901416
12911417 mm = allocate_mm();
....@@ -1353,7 +1479,7 @@
13531479 }
13541480
13551481 retval = -ENOMEM;
1356
- mm = dup_mm(tsk);
1482
+ mm = dup_mm(tsk, current->mm);
13571483 if (!mm)
13581484 goto fail_nomem;
13591485
....@@ -1403,7 +1529,7 @@
14031529 goto out;
14041530 }
14051531
1406
- newf = dup_fd(oldf, &error);
1532
+ newf = dup_fd(oldf, NR_OPEN_MAX, &error);
14071533 if (!newf)
14081534 goto out;
14091535
....@@ -1444,24 +1570,29 @@
14441570 struct sighand_struct *sig;
14451571
14461572 if (clone_flags & CLONE_SIGHAND) {
1447
- atomic_inc(&current->sighand->count);
1573
+ refcount_inc(&current->sighand->count);
14481574 return 0;
14491575 }
14501576 sig = kmem_cache_alloc(sighand_cachep, GFP_KERNEL);
1451
- rcu_assign_pointer(tsk->sighand, sig);
1577
+ RCU_INIT_POINTER(tsk->sighand, sig);
14521578 if (!sig)
14531579 return -ENOMEM;
14541580
1455
- atomic_set(&sig->count, 1);
1581
+ refcount_set(&sig->count, 1);
14561582 spin_lock_irq(&current->sighand->siglock);
14571583 memcpy(sig->action, current->sighand->action, sizeof(sig->action));
14581584 spin_unlock_irq(&current->sighand->siglock);
1585
+
1586
+ /* Reset all signal handler not set to SIG_IGN to SIG_DFL. */
1587
+ if (clone_flags & CLONE_CLEAR_SIGHAND)
1588
+ flush_signal_handlers(tsk, 0);
1589
+
14591590 return 0;
14601591 }
14611592
14621593 void __cleanup_sighand(struct sighand_struct *sighand)
14631594 {
1464
- if (atomic_dec_and_test(&sighand->count)) {
1595
+ if (refcount_dec_and_test(&sighand->count)) {
14651596 signalfd_cleanup(sighand);
14661597 /*
14671598 * sighand_cachep is SLAB_TYPESAFE_BY_RCU so we can free it
....@@ -1471,28 +1602,17 @@
14711602 }
14721603 }
14731604
1474
-#ifdef CONFIG_POSIX_TIMERS
14751605 /*
14761606 * Initialize POSIX timer handling for a thread group.
14771607 */
14781608 static void posix_cpu_timers_init_group(struct signal_struct *sig)
14791609 {
1610
+ struct posix_cputimers *pct = &sig->posix_cputimers;
14801611 unsigned long cpu_limit;
14811612
14821613 cpu_limit = READ_ONCE(sig->rlim[RLIMIT_CPU].rlim_cur);
1483
- if (cpu_limit != RLIM_INFINITY) {
1484
- sig->cputime_expires.prof_exp = cpu_limit * NSEC_PER_SEC;
1485
- sig->cputimer.running = true;
1486
- }
1487
-
1488
- /* The timer lists. */
1489
- INIT_LIST_HEAD(&sig->cpu_timers[0]);
1490
- INIT_LIST_HEAD(&sig->cpu_timers[1]);
1491
- INIT_LIST_HEAD(&sig->cpu_timers[2]);
1614
+ posix_cputimers_group_init(pct, cpu_limit);
14921615 }
1493
-#else
1494
-static inline void posix_cpu_timers_init_group(struct signal_struct *sig) { }
1495
-#endif
14961616
14971617 static int copy_signal(unsigned long clone_flags, struct task_struct *tsk)
14981618 {
....@@ -1508,7 +1628,7 @@
15081628
15091629 sig->nr_threads = 1;
15101630 atomic_set(&sig->live, 1);
1511
- atomic_set(&sig->sigcnt, 1);
1631
+ refcount_set(&sig->sigcnt, 1);
15121632
15131633 /* list_add(thread_node, thread_head) without INIT_LIST_HEAD() */
15141634 sig->thread_head = (struct list_head)LIST_HEAD_INIT(tsk->thread_node);
....@@ -1540,6 +1660,7 @@
15401660 sig->oom_score_adj_min = current->signal->oom_score_adj_min;
15411661
15421662 mutex_init(&sig->cred_guard_mutex);
1663
+ init_rwsem(&sig->exec_update_lock);
15431664
15441665 return 0;
15451666 }
....@@ -1594,23 +1715,6 @@
15941715 #endif
15951716 }
15961717
1597
-#ifdef CONFIG_POSIX_TIMERS
1598
-/*
1599
- * Initialize POSIX timer handling for a single task.
1600
- */
1601
-static void posix_cpu_timers_init(struct task_struct *tsk)
1602
-{
1603
- tsk->cputime_expires.prof_exp = 0;
1604
- tsk->cputime_expires.virt_exp = 0;
1605
- tsk->cputime_expires.sched_exp = 0;
1606
- INIT_LIST_HEAD(&tsk->cpu_timers[0]);
1607
- INIT_LIST_HEAD(&tsk->cpu_timers[1]);
1608
- INIT_LIST_HEAD(&tsk->cpu_timers[2]);
1609
-}
1610
-#else
1611
-static inline void posix_cpu_timers_init(struct task_struct *tsk) { }
1612
-#endif
1613
-
16141718 static inline void init_task_pid_links(struct task_struct *task)
16151719 {
16161720 enum pid_type type;
....@@ -1642,7 +1746,125 @@
16421746 INIT_LIST_HEAD(&p->rcu_tasks_holdout_list);
16431747 p->rcu_tasks_idle_cpu = -1;
16441748 #endif /* #ifdef CONFIG_TASKS_RCU */
1749
+#ifdef CONFIG_TASKS_TRACE_RCU
1750
+ p->trc_reader_nesting = 0;
1751
+ p->trc_reader_special.s = 0;
1752
+ INIT_LIST_HEAD(&p->trc_holdout_list);
1753
+#endif /* #ifdef CONFIG_TASKS_TRACE_RCU */
16451754 }
1755
+
1756
+struct pid *pidfd_pid(const struct file *file)
1757
+{
1758
+ if (file->f_op == &pidfd_fops)
1759
+ return file->private_data;
1760
+
1761
+ return ERR_PTR(-EBADF);
1762
+}
1763
+
1764
+static int pidfd_release(struct inode *inode, struct file *file)
1765
+{
1766
+ struct pid *pid = file->private_data;
1767
+
1768
+ file->private_data = NULL;
1769
+ put_pid(pid);
1770
+ return 0;
1771
+}
1772
+
1773
+#ifdef CONFIG_PROC_FS
1774
+/**
1775
+ * pidfd_show_fdinfo - print information about a pidfd
1776
+ * @m: proc fdinfo file
1777
+ * @f: file referencing a pidfd
1778
+ *
1779
+ * Pid:
1780
+ * This function will print the pid that a given pidfd refers to in the
1781
+ * pid namespace of the procfs instance.
1782
+ * If the pid namespace of the process is not a descendant of the pid
1783
+ * namespace of the procfs instance 0 will be shown as its pid. This is
1784
+ * similar to calling getppid() on a process whose parent is outside of
1785
+ * its pid namespace.
1786
+ *
1787
+ * NSpid:
1788
+ * If pid namespaces are supported then this function will also print
1789
+ * the pid of a given pidfd refers to for all descendant pid namespaces
1790
+ * starting from the current pid namespace of the instance, i.e. the
1791
+ * Pid field and the first entry in the NSpid field will be identical.
1792
+ * If the pid namespace of the process is not a descendant of the pid
1793
+ * namespace of the procfs instance 0 will be shown as its first NSpid
1794
+ * entry and no others will be shown.
1795
+ * Note that this differs from the Pid and NSpid fields in
1796
+ * /proc/<pid>/status where Pid and NSpid are always shown relative to
1797
+ * the pid namespace of the procfs instance. The difference becomes
1798
+ * obvious when sending around a pidfd between pid namespaces from a
1799
+ * different branch of the tree, i.e. where no ancestoral relation is
1800
+ * present between the pid namespaces:
1801
+ * - create two new pid namespaces ns1 and ns2 in the initial pid
1802
+ * namespace (also take care to create new mount namespaces in the
1803
+ * new pid namespace and mount procfs)
1804
+ * - create a process with a pidfd in ns1
1805
+ * - send pidfd from ns1 to ns2
1806
+ * - read /proc/self/fdinfo/<pidfd> and observe that both Pid and NSpid
1807
+ * have exactly one entry, which is 0
1808
+ */
1809
+static void pidfd_show_fdinfo(struct seq_file *m, struct file *f)
1810
+{
1811
+ struct pid *pid = f->private_data;
1812
+ struct pid_namespace *ns;
1813
+ pid_t nr = -1;
1814
+
1815
+ if (likely(pid_has_task(pid, PIDTYPE_PID))) {
1816
+ ns = proc_pid_ns(file_inode(m->file)->i_sb);
1817
+ nr = pid_nr_ns(pid, ns);
1818
+ }
1819
+
1820
+ seq_put_decimal_ll(m, "Pid:\t", nr);
1821
+
1822
+#ifdef CONFIG_PID_NS
1823
+ seq_put_decimal_ll(m, "\nNSpid:\t", nr);
1824
+ if (nr > 0) {
1825
+ int i;
1826
+
1827
+ /* If nr is non-zero it means that 'pid' is valid and that
1828
+ * ns, i.e. the pid namespace associated with the procfs
1829
+ * instance, is in the pid namespace hierarchy of pid.
1830
+ * Start at one below the already printed level.
1831
+ */
1832
+ for (i = ns->level + 1; i <= pid->level; i++)
1833
+ seq_put_decimal_ll(m, "\t", pid->numbers[i].nr);
1834
+ }
1835
+#endif
1836
+ seq_putc(m, '\n');
1837
+}
1838
+#endif
1839
+
1840
+/*
1841
+ * Poll support for process exit notification.
1842
+ */
1843
+static __poll_t pidfd_poll(struct file *file, struct poll_table_struct *pts)
1844
+{
1845
+ struct pid *pid = file->private_data;
1846
+ __poll_t poll_flags = 0;
1847
+
1848
+ poll_wait(file, &pid->wait_pidfd, pts);
1849
+
1850
+ /*
1851
+ * Inform pollers only when the whole thread group exits.
1852
+ * If the thread group leader exits before all other threads in the
1853
+ * group, then poll(2) should block, similar to the wait(2) family.
1854
+ */
1855
+ if (thread_group_exited(pid))
1856
+ poll_flags = EPOLLIN | EPOLLRDNORM;
1857
+
1858
+ return poll_flags;
1859
+}
1860
+
1861
+const struct file_operations pidfd_fops = {
1862
+ .release = pidfd_release,
1863
+ .poll = pidfd_poll,
1864
+#ifdef CONFIG_PROC_FS
1865
+ .show_fdinfo = pidfd_show_fdinfo,
1866
+#endif
1867
+};
16461868
16471869 static void __delayed_free_task(struct rcu_head *rhp)
16481870 {
....@@ -1657,84 +1879,6 @@
16571879 call_rcu(&tsk->rcu, __delayed_free_task);
16581880 else
16591881 free_task(tsk);
1660
-}
1661
-
1662
-static int pidfd_release(struct inode *inode, struct file *file)
1663
-{
1664
- struct pid *pid = file->private_data;
1665
-
1666
- file->private_data = NULL;
1667
- put_pid(pid);
1668
- return 0;
1669
-}
1670
-
1671
-#ifdef CONFIG_PROC_FS
1672
-static void pidfd_show_fdinfo(struct seq_file *m, struct file *f)
1673
-{
1674
- struct pid_namespace *ns = proc_pid_ns(file_inode(m->file));
1675
- struct pid *pid = f->private_data;
1676
-
1677
- seq_put_decimal_ull(m, "Pid:\t", pid_nr_ns(pid, ns));
1678
- seq_putc(m, '\n');
1679
-}
1680
-#endif
1681
-
1682
-/*
1683
- * Poll support for process exit notification.
1684
- */
1685
-static __poll_t pidfd_poll(struct file *file, struct poll_table_struct *pts)
1686
-{
1687
- struct task_struct *task;
1688
- struct pid *pid = file->private_data;
1689
- __poll_t poll_flags = 0;
1690
-
1691
- poll_wait(file, &pid->wait_pidfd, pts);
1692
-
1693
- rcu_read_lock();
1694
- task = pid_task(pid, PIDTYPE_PID);
1695
- /*
1696
- * Inform pollers only when the whole thread group exits.
1697
- * If the thread group leader exits before all other threads in the
1698
- * group, then poll(2) should block, similar to the wait(2) family.
1699
- */
1700
- if (!task || (task->exit_state && thread_group_empty(task)))
1701
- poll_flags = EPOLLIN | EPOLLRDNORM;
1702
- rcu_read_unlock();
1703
-
1704
- return poll_flags;
1705
-}
1706
-
1707
-const struct file_operations pidfd_fops = {
1708
- .release = pidfd_release,
1709
- .poll = pidfd_poll,
1710
-#ifdef CONFIG_PROC_FS
1711
- .show_fdinfo = pidfd_show_fdinfo,
1712
-#endif
1713
-};
1714
-
1715
-/**
1716
- * pidfd_create() - Create a new pid file descriptor.
1717
- *
1718
- * @pid: struct pid that the pidfd will reference
1719
- *
1720
- * This creates a new pid file descriptor with the O_CLOEXEC flag set.
1721
- *
1722
- * Note, that this function can only be called after the fd table has
1723
- * been unshared to avoid leaking the pidfd to the new process.
1724
- *
1725
- * Return: On success, a cloexec pidfd is returned.
1726
- * On error, a negative errno number will be returned.
1727
- */
1728
-static int pidfd_create(struct pid *pid)
1729
-{
1730
- int fd;
1731
-
1732
- fd = anon_inode_getfd("[pidfd]", &pidfd_fops, get_pid(pid),
1733
- O_RDWR | O_CLOEXEC);
1734
- if (fd < 0)
1735
- put_pid(pid);
1736
-
1737
- return fd;
17381882 }
17391883
17401884 static void copy_oom_score_adj(u64 clone_flags, struct task_struct *tsk)
....@@ -1765,19 +1909,17 @@
17651909 * flags). The actual kick-off is left to the caller.
17661910 */
17671911 static __latent_entropy struct task_struct *copy_process(
1768
- unsigned long clone_flags,
1769
- unsigned long stack_start,
1770
- unsigned long stack_size,
1771
- int __user *parent_tidptr,
1772
- int __user *child_tidptr,
17731912 struct pid *pid,
17741913 int trace,
1775
- unsigned long tls,
1776
- int node)
1914
+ int node,
1915
+ struct kernel_clone_args *args)
17771916 {
17781917 int pidfd = -1, retval;
17791918 struct task_struct *p;
17801919 struct multiprocess_signals delayed;
1920
+ struct file *pidfile = NULL;
1921
+ u64 clone_flags = args->flags;
1922
+ struct nsproxy *nsp = current->nsproxy;
17811923
17821924 /*
17831925 * Don't allow sharing the root directory with processes in a different
....@@ -1820,21 +1962,26 @@
18201962 */
18211963 if (clone_flags & CLONE_THREAD) {
18221964 if ((clone_flags & (CLONE_NEWUSER | CLONE_NEWPID)) ||
1823
- (task_active_pid_ns(current) !=
1824
- current->nsproxy->pid_ns_for_children))
1965
+ (task_active_pid_ns(current) != nsp->pid_ns_for_children))
1966
+ return ERR_PTR(-EINVAL);
1967
+ }
1968
+
1969
+ /*
1970
+ * If the new process will be in a different time namespace
1971
+ * do not allow it to share VM or a thread group with the forking task.
1972
+ */
1973
+ if (clone_flags & (CLONE_THREAD | CLONE_VM)) {
1974
+ if (nsp->time_ns != nsp->time_ns_for_children)
18251975 return ERR_PTR(-EINVAL);
18261976 }
18271977
18281978 if (clone_flags & CLONE_PIDFD) {
18291979 /*
1830
- * - CLONE_PARENT_SETTID is useless for pidfds and also
1831
- * parent_tidptr is used to return pidfds.
18321980 * - CLONE_DETACHED is blocked so that we can potentially
18331981 * reuse it later for CLONE_PIDFD.
18341982 * - CLONE_THREAD is blocked until someone really needs it.
18351983 */
1836
- if (clone_flags &
1837
- (CLONE_DETACHED | CLONE_PARENT_SETTID | CLONE_THREAD))
1984
+ if (clone_flags & (CLONE_DETACHED | CLONE_THREAD))
18381985 return ERR_PTR(-EINVAL);
18391986 }
18401987
....@@ -1853,13 +2000,21 @@
18532000 recalc_sigpending();
18542001 spin_unlock_irq(&current->sighand->siglock);
18552002 retval = -ERESTARTNOINTR;
1856
- if (signal_pending(current))
2003
+ if (task_sigpending(current))
18572004 goto fork_out;
18582005
18592006 retval = -ENOMEM;
18602007 p = dup_task_struct(current, node);
18612008 if (!p)
18622009 goto fork_out;
2010
+ if (args->io_thread) {
2011
+ /*
2012
+ * Mark us an IO worker, and block any signal that isn't
2013
+ * fatal or STOP
2014
+ */
2015
+ p->flags |= PF_IO_WORKER;
2016
+ siginitsetinv(&p->blocked, sigmask(SIGKILL)|sigmask(SIGSTOP));
2017
+ }
18632018
18642019 cpufreq_task_times_init(p);
18652020
....@@ -1869,18 +2024,18 @@
18692024 * p->set_child_tid which is (ab)used as a kthread's data pointer for
18702025 * kernel threads (PF_KTHREAD).
18712026 */
1872
- p->set_child_tid = (clone_flags & CLONE_CHILD_SETTID) ? child_tidptr : NULL;
2027
+ p->set_child_tid = (clone_flags & CLONE_CHILD_SETTID) ? args->child_tid : NULL;
18732028 /*
18742029 * Clear TID on mm_release()?
18752030 */
1876
- p->clear_child_tid = (clone_flags & CLONE_CHILD_CLEARTID) ? child_tidptr : NULL;
2031
+ p->clear_child_tid = (clone_flags & CLONE_CHILD_CLEARTID) ? args->child_tid : NULL;
18772032
18782033 ftrace_graph_init_task(p);
18792034
18802035 rt_mutex_init_task(p);
18812036
2037
+ lockdep_assert_irqs_enabled();
18822038 #ifdef CONFIG_PROVE_LOCKING
1883
- DEBUG_LOCKS_WARN_ON(!p->hardirqs_enabled);
18842039 DEBUG_LOCKS_WARN_ON(!p->softirqs_enabled);
18852040 #endif
18862041 retval = -EAGAIN;
....@@ -1902,7 +2057,7 @@
19022057 * to stop root fork bombs.
19032058 */
19042059 retval = -EAGAIN;
1905
- if (nr_threads >= max_threads)
2060
+ if (data_race(nr_threads >= max_threads))
19062061 goto bad_fork_cleanup_count;
19072062
19082063 delayacct_tsk_init(p); /* Must remain after dup_task_struct() */
....@@ -1928,6 +2083,10 @@
19282083 p->vtime.state = VTIME_INACTIVE;
19292084 #endif
19302085
2086
+#ifdef CONFIG_IO_URING
2087
+ p->io_uring = NULL;
2088
+#endif
2089
+
19312090 #if defined(SPLIT_RSS_COUNTING)
19322091 memset(&p->rss_stat, 0, sizeof(p->rss_stat));
19332092 #endif
....@@ -1941,7 +2100,7 @@
19412100 task_io_accounting_init(&p->ioac);
19422101 acct_clear_integrals(p);
19432102
1944
- posix_cpu_timers_init(p);
2103
+ posix_cputimers_init(&p->posix_cputimers);
19452104
19462105 p->io_context = NULL;
19472106 audit_set_context(p, NULL);
....@@ -1957,30 +2116,19 @@
19572116 #ifdef CONFIG_CPUSETS
19582117 p->cpuset_mem_spread_rotor = NUMA_NO_NODE;
19592118 p->cpuset_slab_spread_rotor = NUMA_NO_NODE;
1960
- seqcount_init(&p->mems_allowed_seq);
2119
+ seqcount_spinlock_init(&p->mems_allowed_seq, &p->alloc_lock);
19612120 #endif
19622121 #ifdef CONFIG_TRACE_IRQFLAGS
1963
- p->irq_events = 0;
1964
- p->hardirqs_enabled = 0;
1965
- p->hardirq_enable_ip = 0;
1966
- p->hardirq_enable_event = 0;
1967
- p->hardirq_disable_ip = _THIS_IP_;
1968
- p->hardirq_disable_event = 0;
1969
- p->softirqs_enabled = 1;
1970
- p->softirq_enable_ip = _THIS_IP_;
1971
- p->softirq_enable_event = 0;
1972
- p->softirq_disable_ip = 0;
1973
- p->softirq_disable_event = 0;
1974
- p->hardirq_context = 0;
1975
- p->softirq_context = 0;
2122
+ memset(&p->irqtrace, 0, sizeof(p->irqtrace));
2123
+ p->irqtrace.hardirq_disable_ip = _THIS_IP_;
2124
+ p->irqtrace.softirq_enable_ip = _THIS_IP_;
2125
+ p->softirqs_enabled = 1;
2126
+ p->softirq_context = 0;
19762127 #endif
19772128
19782129 p->pagefault_disabled = 0;
19792130
19802131 #ifdef CONFIG_LOCKDEP
1981
- p->lockdep_depth = 0; /* no locks held yet */
1982
- p->curr_chain_key = 0;
1983
- p->lockdep_recursion = 0;
19842132 lockdep_init_task(p);
19852133 #endif
19862134
....@@ -2032,12 +2180,15 @@
20322180 retval = copy_io(clone_flags, p);
20332181 if (retval)
20342182 goto bad_fork_cleanup_namespaces;
2035
- retval = copy_thread_tls(clone_flags, stack_start, stack_size, p, tls);
2183
+ retval = copy_thread(clone_flags, args->stack, args->stack_size, p, args->tls);
20362184 if (retval)
20372185 goto bad_fork_cleanup_io;
20382186
2187
+ stackleak_task_init(p);
2188
+
20392189 if (pid != &init_struct_pid) {
2040
- pid = alloc_pid(p->nsproxy->pid_ns_for_children);
2190
+ pid = alloc_pid(p->nsproxy->pid_ns_for_children, args->set_tid,
2191
+ args->set_tid_size);
20412192 if (IS_ERR(pid)) {
20422193 retval = PTR_ERR(pid);
20432194 goto bad_fork_cleanup_thread;
....@@ -2050,12 +2201,22 @@
20502201 * if the fd table isn't shared).
20512202 */
20522203 if (clone_flags & CLONE_PIDFD) {
2053
- retval = pidfd_create(pid);
2204
+ retval = get_unused_fd_flags(O_RDWR | O_CLOEXEC);
20542205 if (retval < 0)
20552206 goto bad_fork_free_pid;
20562207
20572208 pidfd = retval;
2058
- retval = put_user(pidfd, parent_tidptr);
2209
+
2210
+ pidfile = anon_inode_getfile("[pidfd]", &pidfd_fops, pid,
2211
+ O_RDWR | O_CLOEXEC);
2212
+ if (IS_ERR(pidfile)) {
2213
+ put_unused_fd(pidfd);
2214
+ retval = PTR_ERR(pidfile);
2215
+ goto bad_fork_free_pid;
2216
+ }
2217
+ get_pid(pid); /* held by pidfile now */
2218
+
2219
+ retval = put_user(pidfd, args->pidfd);
20592220 if (retval)
20602221 goto bad_fork_put_pidfd;
20612222 }
....@@ -2080,7 +2241,7 @@
20802241 #ifdef TIF_SYSCALL_EMU
20812242 clear_tsk_thread_flag(p, TIF_SYSCALL_EMU);
20822243 #endif
2083
- clear_all_latency_tracing(p);
2244
+ clear_tsk_latency_tracing(p);
20842245
20852246 /* ok, now we should be set up.. */
20862247 p->pid = pid_nr(pid);
....@@ -2099,17 +2260,28 @@
20992260 p->pdeath_signal = 0;
21002261 INIT_LIST_HEAD(&p->thread_group);
21012262 p->task_works = NULL;
2263
+ clear_posix_cputimers_work(p);
21022264
2103
- cgroup_threadgroup_change_begin(current);
21042265 /*
21052266 * Ensure that the cgroup subsystem policies allow the new process to be
2106
- * forked. It should be noted the the new process's css_set can be changed
2267
+ * forked. It should be noted that the new process's css_set can be changed
21072268 * between here and cgroup_post_fork() if an organisation operation is in
21082269 * progress.
21092270 */
2110
- retval = cgroup_can_fork(p);
2271
+ retval = cgroup_can_fork(p, args);
21112272 if (retval)
2112
- goto bad_fork_cgroup_threadgroup_change_end;
2273
+ goto bad_fork_put_pidfd;
2274
+
2275
+ /*
2276
+ * Now that the cgroups are pinned, re-clone the parent cgroup and put
2277
+ * the new task on the correct runqueue. All this *before* the task
2278
+ * becomes visible.
2279
+ *
2280
+ * This isn't part of ->can_fork() because while the re-cloning is
2281
+ * cgroup specific, it unconditionally needs to place the task on a
2282
+ * runqueue.
2283
+ */
2284
+ sched_cgroup_fork(p, args);
21132285
21142286 /*
21152287 * From this point on we must avoid any synchronous user-space
....@@ -2120,7 +2292,7 @@
21202292 */
21212293
21222294 p->start_time = ktime_get_ns();
2123
- p->real_start_time = ktime_get_boot_ns();
2295
+ p->start_boottime = ktime_get_boottime_ns();
21242296
21252297 /*
21262298 * Make it visible to the rest of the system, but dont wake it up yet.
....@@ -2139,18 +2311,12 @@
21392311 } else {
21402312 p->real_parent = current;
21412313 p->parent_exec_id = current->self_exec_id;
2142
- p->exit_signal = (clone_flags & CSIGNAL);
2314
+ p->exit_signal = args->exit_signal;
21432315 }
21442316
21452317 klp_copy_process(p);
21462318
21472319 spin_lock(&current->sighand->siglock);
2148
-
2149
- /*
2150
- * Copy seccomp details explicitly here, in case they were changed
2151
- * before holding sighand lock.
2152
- */
2153
- copy_seccomp(p);
21542320
21552321 rseq_fork(p, clone_flags);
21562322
....@@ -2166,6 +2332,13 @@
21662332 goto bad_fork_cancel_cgroup;
21672333 }
21682334
2335
+ /* No more failure paths after this point. */
2336
+
2337
+ /*
2338
+ * Copy seccomp details explicitly here, in case they were changed
2339
+ * before holding sighand lock.
2340
+ */
2341
+ copy_seccomp(p);
21692342
21702343 init_task_pid_links(p);
21712344 if (likely(p->pid)) {
....@@ -2199,7 +2372,7 @@
21992372 } else {
22002373 current->signal->nr_threads++;
22012374 atomic_inc(&current->signal->live);
2202
- atomic_inc(&current->signal->sigcnt);
2375
+ refcount_inc(&current->signal->sigcnt);
22032376 task_join_group_stop(p);
22042377 list_add_tail_rcu(&p->thread_group,
22052378 &p->group_leader->thread_group);
....@@ -2215,9 +2388,12 @@
22152388 syscall_tracepoint_update(p);
22162389 write_unlock_irq(&tasklist_lock);
22172390
2391
+ if (pidfile)
2392
+ fd_install(pidfd, pidfile);
2393
+
22182394 proc_fork_connector(p);
2219
- cgroup_post_fork(p);
2220
- cgroup_threadgroup_change_end(current);
2395
+ sched_post_fork(p);
2396
+ cgroup_post_fork(p, args);
22212397 perf_event_fork(p);
22222398
22232399 trace_task_newtask(p, clone_flags);
....@@ -2230,12 +2406,12 @@
22302406 bad_fork_cancel_cgroup:
22312407 spin_unlock(&current->sighand->siglock);
22322408 write_unlock_irq(&tasklist_lock);
2233
- cgroup_cancel_fork(p);
2234
-bad_fork_cgroup_threadgroup_change_end:
2235
- cgroup_threadgroup_change_end(current);
2409
+ cgroup_cancel_fork(p, args);
22362410 bad_fork_put_pidfd:
2237
- if (clone_flags & CLONE_PIDFD)
2238
- ksys_close(pidfd);
2411
+ if (clone_flags & CLONE_PIDFD) {
2412
+ fput(pidfile);
2413
+ put_unused_fd(pidfd);
2414
+ }
22392415 bad_fork_free_pid:
22402416 if (pid != &init_struct_pid)
22412417 free_pid(pid);
....@@ -2299,11 +2475,14 @@
22992475 }
23002476 }
23012477
2302
-struct task_struct *fork_idle(int cpu)
2478
+struct task_struct * __init fork_idle(int cpu)
23032479 {
23042480 struct task_struct *task;
2305
- task = copy_process(CLONE_VM, 0, 0, NULL, NULL, &init_struct_pid, 0, 0,
2306
- cpu_to_node(cpu));
2481
+ struct kernel_clone_args args = {
2482
+ .flags = CLONE_VM,
2483
+ };
2484
+
2485
+ task = copy_process(&init_struct_pid, 0, cpu_to_node(cpu), &args);
23072486 if (!IS_ERR(task)) {
23082487 init_idle_pids(task);
23092488 init_idle(task, cpu);
....@@ -2313,23 +2492,57 @@
23132492 }
23142493
23152494 /*
2495
+ * This is like kernel_clone(), but shaved down and tailored to just
2496
+ * creating io_uring workers. It returns a created task, or an error pointer.
2497
+ * The returned task is inactive, and the caller must fire it up through
2498
+ * wake_up_new_task(p). All signals are blocked in the created task.
2499
+ */
2500
+struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node)
2501
+{
2502
+ unsigned long flags = CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|
2503
+ CLONE_IO;
2504
+ struct kernel_clone_args args = {
2505
+ .flags = ((lower_32_bits(flags) | CLONE_VM |
2506
+ CLONE_UNTRACED) & ~CSIGNAL),
2507
+ .exit_signal = (lower_32_bits(flags) & CSIGNAL),
2508
+ .stack = (unsigned long)fn,
2509
+ .stack_size = (unsigned long)arg,
2510
+ .io_thread = 1,
2511
+ };
2512
+
2513
+ return copy_process(NULL, 0, node, &args);
2514
+}
2515
+
2516
+/*
23162517 * Ok, this is the main fork-routine.
23172518 *
23182519 * It copies the process, and if successful kick-starts
23192520 * it and waits for it to finish using the VM if required.
2521
+ *
2522
+ * args->exit_signal is expected to be checked for sanity by the caller.
23202523 */
2321
-long _do_fork(unsigned long clone_flags,
2322
- unsigned long stack_start,
2323
- unsigned long stack_size,
2324
- int __user *parent_tidptr,
2325
- int __user *child_tidptr,
2326
- unsigned long tls)
2524
+pid_t kernel_clone(struct kernel_clone_args *args)
23272525 {
2526
+ u64 clone_flags = args->flags;
23282527 struct completion vfork;
23292528 struct pid *pid;
23302529 struct task_struct *p;
23312530 int trace = 0;
2332
- long nr;
2531
+ pid_t nr;
2532
+
2533
+ /*
2534
+ * For legacy clone() calls, CLONE_PIDFD uses the parent_tid argument
2535
+ * to return the pidfd. Hence, CLONE_PIDFD and CLONE_PARENT_SETTID are
2536
+ * mutually exclusive. With clone3() CLONE_PIDFD has grown a separate
2537
+ * field in struct clone_args and it still doesn't make sense to have
2538
+ * them both point at the same memory location. Performing this check
2539
+ * here has the advantage that we don't need to have a separate helper
2540
+ * to check for legacy clone().
2541
+ */
2542
+ if ((args->flags & CLONE_PIDFD) &&
2543
+ (args->flags & CLONE_PARENT_SETTID) &&
2544
+ (args->pidfd == args->parent_tid))
2545
+ return -EINVAL;
23332546
23342547 /*
23352548 * Determine whether and which event to report to ptracer. When
....@@ -2340,7 +2553,7 @@
23402553 if (!(clone_flags & CLONE_UNTRACED)) {
23412554 if (clone_flags & CLONE_VFORK)
23422555 trace = PTRACE_EVENT_VFORK;
2343
- else if ((clone_flags & CSIGNAL) != SIGCHLD)
2556
+ else if (args->exit_signal != SIGCHLD)
23442557 trace = PTRACE_EVENT_CLONE;
23452558 else
23462559 trace = PTRACE_EVENT_FORK;
....@@ -2349,8 +2562,7 @@
23492562 trace = 0;
23502563 }
23512564
2352
- p = copy_process(clone_flags, stack_start, stack_size, parent_tidptr,
2353
- child_tidptr, NULL, trace, tls, NUMA_NO_NODE);
2565
+ p = copy_process(NULL, trace, NUMA_NO_NODE, args);
23542566 add_latent_entropy();
23552567
23562568 if (IS_ERR(p))
....@@ -2368,7 +2580,7 @@
23682580 nr = pid_vnr(pid);
23692581
23702582 if (clone_flags & CLONE_PARENT_SETTID)
2371
- put_user(nr, parent_tidptr);
2583
+ put_user(nr, args->parent_tid);
23722584
23732585 if (clone_flags & CLONE_VFORK) {
23742586 p->vfork_done = &vfork;
....@@ -2391,34 +2603,31 @@
23912603 return nr;
23922604 }
23932605
2394
-#ifndef CONFIG_HAVE_COPY_THREAD_TLS
2395
-/* For compatibility with architectures that call do_fork directly rather than
2396
- * using the syscall entry points below. */
2397
-long do_fork(unsigned long clone_flags,
2398
- unsigned long stack_start,
2399
- unsigned long stack_size,
2400
- int __user *parent_tidptr,
2401
- int __user *child_tidptr)
2402
-{
2403
- return _do_fork(clone_flags, stack_start, stack_size,
2404
- parent_tidptr, child_tidptr, 0);
2405
-}
2406
-#endif
2407
-
24082606 /*
24092607 * Create a kernel thread.
24102608 */
24112609 pid_t kernel_thread(int (*fn)(void *), void *arg, unsigned long flags)
24122610 {
2413
- return _do_fork(flags|CLONE_VM|CLONE_UNTRACED, (unsigned long)fn,
2414
- (unsigned long)arg, NULL, NULL, 0);
2611
+ struct kernel_clone_args args = {
2612
+ .flags = ((lower_32_bits(flags) | CLONE_VM |
2613
+ CLONE_UNTRACED) & ~CSIGNAL),
2614
+ .exit_signal = (lower_32_bits(flags) & CSIGNAL),
2615
+ .stack = (unsigned long)fn,
2616
+ .stack_size = (unsigned long)arg,
2617
+ };
2618
+
2619
+ return kernel_clone(&args);
24152620 }
24162621
24172622 #ifdef __ARCH_WANT_SYS_FORK
24182623 SYSCALL_DEFINE0(fork)
24192624 {
24202625 #ifdef CONFIG_MMU
2421
- return _do_fork(SIGCHLD, 0, 0, NULL, NULL, 0);
2626
+ struct kernel_clone_args args = {
2627
+ .exit_signal = SIGCHLD,
2628
+ };
2629
+
2630
+ return kernel_clone(&args);
24222631 #else
24232632 /* can not support in nommu mode */
24242633 return -EINVAL;
....@@ -2429,8 +2638,12 @@
24292638 #ifdef __ARCH_WANT_SYS_VFORK
24302639 SYSCALL_DEFINE0(vfork)
24312640 {
2432
- return _do_fork(CLONE_VFORK | CLONE_VM | SIGCHLD, 0,
2433
- 0, NULL, NULL, 0);
2641
+ struct kernel_clone_args args = {
2642
+ .flags = CLONE_VFORK | CLONE_VM,
2643
+ .exit_signal = SIGCHLD,
2644
+ };
2645
+
2646
+ return kernel_clone(&args);
24342647 }
24352648 #endif
24362649
....@@ -2458,7 +2671,175 @@
24582671 unsigned long, tls)
24592672 #endif
24602673 {
2461
- return _do_fork(clone_flags, newsp, 0, parent_tidptr, child_tidptr, tls);
2674
+ struct kernel_clone_args args = {
2675
+ .flags = (lower_32_bits(clone_flags) & ~CSIGNAL),
2676
+ .pidfd = parent_tidptr,
2677
+ .child_tid = child_tidptr,
2678
+ .parent_tid = parent_tidptr,
2679
+ .exit_signal = (lower_32_bits(clone_flags) & CSIGNAL),
2680
+ .stack = newsp,
2681
+ .tls = tls,
2682
+ };
2683
+
2684
+ return kernel_clone(&args);
2685
+}
2686
+#endif
2687
+
2688
+#ifdef __ARCH_WANT_SYS_CLONE3
2689
+
2690
+noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
2691
+ struct clone_args __user *uargs,
2692
+ size_t usize)
2693
+{
2694
+ int err;
2695
+ struct clone_args args;
2696
+ pid_t *kset_tid = kargs->set_tid;
2697
+
2698
+ BUILD_BUG_ON(offsetofend(struct clone_args, tls) !=
2699
+ CLONE_ARGS_SIZE_VER0);
2700
+ BUILD_BUG_ON(offsetofend(struct clone_args, set_tid_size) !=
2701
+ CLONE_ARGS_SIZE_VER1);
2702
+ BUILD_BUG_ON(offsetofend(struct clone_args, cgroup) !=
2703
+ CLONE_ARGS_SIZE_VER2);
2704
+ BUILD_BUG_ON(sizeof(struct clone_args) != CLONE_ARGS_SIZE_VER2);
2705
+
2706
+ if (unlikely(usize > PAGE_SIZE))
2707
+ return -E2BIG;
2708
+ if (unlikely(usize < CLONE_ARGS_SIZE_VER0))
2709
+ return -EINVAL;
2710
+
2711
+ err = copy_struct_from_user(&args, sizeof(args), uargs, usize);
2712
+ if (err)
2713
+ return err;
2714
+
2715
+ if (unlikely(args.set_tid_size > MAX_PID_NS_LEVEL))
2716
+ return -EINVAL;
2717
+
2718
+ if (unlikely(!args.set_tid && args.set_tid_size > 0))
2719
+ return -EINVAL;
2720
+
2721
+ if (unlikely(args.set_tid && args.set_tid_size == 0))
2722
+ return -EINVAL;
2723
+
2724
+ /*
2725
+ * Verify that higher 32bits of exit_signal are unset and that
2726
+ * it is a valid signal
2727
+ */
2728
+ if (unlikely((args.exit_signal & ~((u64)CSIGNAL)) ||
2729
+ !valid_signal(args.exit_signal)))
2730
+ return -EINVAL;
2731
+
2732
+ if ((args.flags & CLONE_INTO_CGROUP) &&
2733
+ (args.cgroup > INT_MAX || usize < CLONE_ARGS_SIZE_VER2))
2734
+ return -EINVAL;
2735
+
2736
+ *kargs = (struct kernel_clone_args){
2737
+ .flags = args.flags,
2738
+ .pidfd = u64_to_user_ptr(args.pidfd),
2739
+ .child_tid = u64_to_user_ptr(args.child_tid),
2740
+ .parent_tid = u64_to_user_ptr(args.parent_tid),
2741
+ .exit_signal = args.exit_signal,
2742
+ .stack = args.stack,
2743
+ .stack_size = args.stack_size,
2744
+ .tls = args.tls,
2745
+ .set_tid_size = args.set_tid_size,
2746
+ .cgroup = args.cgroup,
2747
+ };
2748
+
2749
+ if (args.set_tid &&
2750
+ copy_from_user(kset_tid, u64_to_user_ptr(args.set_tid),
2751
+ (kargs->set_tid_size * sizeof(pid_t))))
2752
+ return -EFAULT;
2753
+
2754
+ kargs->set_tid = kset_tid;
2755
+
2756
+ return 0;
2757
+}
2758
+
2759
+/**
2760
+ * clone3_stack_valid - check and prepare stack
2761
+ * @kargs: kernel clone args
2762
+ *
2763
+ * Verify that the stack arguments userspace gave us are sane.
2764
+ * In addition, set the stack direction for userspace since it's easy for us to
2765
+ * determine.
2766
+ */
2767
+static inline bool clone3_stack_valid(struct kernel_clone_args *kargs)
2768
+{
2769
+ if (kargs->stack == 0) {
2770
+ if (kargs->stack_size > 0)
2771
+ return false;
2772
+ } else {
2773
+ if (kargs->stack_size == 0)
2774
+ return false;
2775
+
2776
+ if (!access_ok((void __user *)kargs->stack, kargs->stack_size))
2777
+ return false;
2778
+
2779
+#if !defined(CONFIG_STACK_GROWSUP) && !defined(CONFIG_IA64)
2780
+ kargs->stack += kargs->stack_size;
2781
+#endif
2782
+ }
2783
+
2784
+ return true;
2785
+}
2786
+
2787
+static bool clone3_args_valid(struct kernel_clone_args *kargs)
2788
+{
2789
+ /* Verify that no unknown flags are passed along. */
2790
+ if (kargs->flags &
2791
+ ~(CLONE_LEGACY_FLAGS | CLONE_CLEAR_SIGHAND | CLONE_INTO_CGROUP))
2792
+ return false;
2793
+
2794
+ /*
2795
+ * - make the CLONE_DETACHED bit reuseable for clone3
2796
+ * - make the CSIGNAL bits reuseable for clone3
2797
+ */
2798
+ if (kargs->flags & (CLONE_DETACHED | (CSIGNAL & (~CLONE_NEWTIME))))
2799
+ return false;
2800
+
2801
+ if ((kargs->flags & (CLONE_SIGHAND | CLONE_CLEAR_SIGHAND)) ==
2802
+ (CLONE_SIGHAND | CLONE_CLEAR_SIGHAND))
2803
+ return false;
2804
+
2805
+ if ((kargs->flags & (CLONE_THREAD | CLONE_PARENT)) &&
2806
+ kargs->exit_signal)
2807
+ return false;
2808
+
2809
+ if (!clone3_stack_valid(kargs))
2810
+ return false;
2811
+
2812
+ return true;
2813
+}
2814
+
2815
+/**
2816
+ * clone3 - create a new process with specific properties
2817
+ * @uargs: argument structure
2818
+ * @size: size of @uargs
2819
+ *
2820
+ * clone3() is the extensible successor to clone()/clone2().
2821
+ * It takes a struct as argument that is versioned by its size.
2822
+ *
2823
+ * Return: On success, a positive PID for the child process.
2824
+ * On error, a negative errno number.
2825
+ */
2826
+SYSCALL_DEFINE2(clone3, struct clone_args __user *, uargs, size_t, size)
2827
+{
2828
+ int err;
2829
+
2830
+ struct kernel_clone_args kargs;
2831
+ pid_t set_tid[MAX_PID_NS_LEVEL];
2832
+
2833
+ kargs.set_tid = set_tid;
2834
+
2835
+ err = copy_clone_args_from_user(&kargs, uargs, size);
2836
+ if (err)
2837
+ return err;
2838
+
2839
+ if (!clone3_args_valid(&kargs))
2840
+ return -EINVAL;
2841
+
2842
+ return kernel_clone(&kargs);
24622843 }
24632844 #endif
24642845
....@@ -2506,10 +2887,27 @@
25062887 init_waitqueue_head(&sighand->signalfd_wqh);
25072888 }
25082889
2509
-void __init proc_caches_init(void)
2890
+void __init mm_cache_init(void)
25102891 {
25112892 unsigned int mm_size;
25122893
2894
+ /*
2895
+ * The mm_cpumask is located at the end of mm_struct, and is
2896
+ * dynamically sized based on the maximum CPU number this system
2897
+ * can have, taking hotplug into account (nr_cpu_ids).
2898
+ */
2899
+ mm_size = sizeof(struct mm_struct) + cpumask_size();
2900
+
2901
+ mm_cachep = kmem_cache_create_usercopy("mm_struct",
2902
+ mm_size, ARCH_MIN_MMSTRUCT_ALIGN,
2903
+ SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT,
2904
+ offsetof(struct mm_struct, saved_auxv),
2905
+ sizeof_field(struct mm_struct, saved_auxv),
2906
+ NULL);
2907
+}
2908
+
2909
+void __init proc_caches_init(void)
2910
+{
25132911 sighand_cachep = kmem_cache_create("sighand_cache",
25142912 sizeof(struct sighand_struct), 0,
25152913 SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_TYPESAFE_BY_RCU|
....@@ -2527,19 +2925,6 @@
25272925 SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT,
25282926 NULL);
25292927
2530
- /*
2531
- * The mm_cpumask is located at the end of mm_struct, and is
2532
- * dynamically sized based on the maximum CPU number this system
2533
- * can have, taking hotplug into account (nr_cpu_ids).
2534
- */
2535
- mm_size = sizeof(struct mm_struct) + cpumask_size();
2536
-
2537
- mm_cachep = kmem_cache_create_usercopy("mm_struct",
2538
- mm_size, ARCH_MIN_MMSTRUCT_ALIGN,
2539
- SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT,
2540
- offsetof(struct mm_struct, saved_auxv),
2541
- sizeof_field(struct mm_struct, saved_auxv),
2542
- NULL);
25432928 vm_area_cachep = KMEM_CACHE(vm_area_struct, SLAB_PANIC|SLAB_ACCOUNT);
25442929 mmap_init();
25452930 nsproxy_cache_init();
....@@ -2553,7 +2938,8 @@
25532938 if (unshare_flags & ~(CLONE_THREAD|CLONE_FS|CLONE_NEWNS|CLONE_SIGHAND|
25542939 CLONE_VM|CLONE_FILES|CLONE_SYSVSEM|
25552940 CLONE_NEWUTS|CLONE_NEWIPC|CLONE_NEWNET|
2556
- CLONE_NEWUSER|CLONE_NEWPID|CLONE_NEWCGROUP))
2941
+ CLONE_NEWUSER|CLONE_NEWPID|CLONE_NEWCGROUP|
2942
+ CLONE_NEWTIME))
25572943 return -EINVAL;
25582944 /*
25592945 * Not implemented, but pretend it works if there is nothing
....@@ -2566,7 +2952,7 @@
25662952 return -EINVAL;
25672953 }
25682954 if (unshare_flags & (CLONE_SIGHAND | CLONE_VM)) {
2569
- if (atomic_read(&current->sighand->count) > 1)
2955
+ if (refcount_read(&current->sighand->count) > 1)
25702956 return -EINVAL;
25712957 }
25722958 if (unshare_flags & CLONE_VM) {
....@@ -2601,14 +2987,15 @@
26012987 /*
26022988 * Unshare file descriptor table if it is being shared
26032989 */
2604
-static int unshare_fd(unsigned long unshare_flags, struct files_struct **new_fdp)
2990
+int unshare_fd(unsigned long unshare_flags, unsigned int max_fds,
2991
+ struct files_struct **new_fdp)
26052992 {
26062993 struct files_struct *fd = current->files;
26072994 int error = 0;
26082995
26092996 if ((unshare_flags & CLONE_FILES) &&
26102997 (fd && atomic_read(&fd->count) > 1)) {
2611
- *new_fdp = dup_fd(fd, &error);
2998
+ *new_fdp = dup_fd(fd, max_fds, &error);
26122999 if (!*new_fdp)
26133000 return error;
26143001 }
....@@ -2619,7 +3006,7 @@
26193006 /*
26203007 * unshare allows a process to 'unshare' part of the process
26213008 * context which was originally shared using clone. copy_*
2622
- * functions used by do_fork() cannot be used here directly
3009
+ * functions used by kernel_clone() cannot be used here directly
26233010 * because they modify an inactive task_struct that is being
26243011 * constructed. Here we are modifying the current, active,
26253012 * task_struct.
....@@ -2668,7 +3055,7 @@
26683055 err = unshare_fs(unshare_flags, &new_fs);
26693056 if (err)
26703057 goto bad_unshare_out;
2671
- err = unshare_fd(unshare_flags, &new_fd);
3058
+ err = unshare_fd(unshare_flags, NR_OPEN_MAX, &new_fd);
26723059 if (err)
26733060 goto bad_unshare_cleanup_fs;
26743061 err = unshare_userns(unshare_flags, &new_cred);
....@@ -2757,7 +3144,7 @@
27573144 struct files_struct *copy = NULL;
27583145 int error;
27593146
2760
- error = unshare_fd(CLONE_FILES, &copy);
3147
+ error = unshare_fd(CLONE_FILES, NR_OPEN_MAX, &copy);
27613148 if (error || !copy) {
27623149 *displaced = NULL;
27633150 return error;
....@@ -2770,7 +3157,7 @@
27703157 }
27713158
27723159 int sysctl_max_threads(struct ctl_table *table, int write,
2773
- void __user *buffer, size_t *lenp, loff_t *ppos)
3160
+ void *buffer, size_t *lenp, loff_t *ppos)
27743161 {
27753162 struct ctl_table t;
27763163 int ret;