hc
2024-12-19 9370bb92b2d16684ee45cf24e879c93c509162da
kernel/fs/orangefs/orangefs-debugfs.c
....@@ -194,14 +194,9 @@
194194 */
195195 static void orangefs_kernel_debug_init(void)
196196 {
197
- int rc = -ENOMEM;
198
- char *k_buffer = NULL;
197
+ static char k_buffer[ORANGEFS_MAX_DEBUG_STRING_LEN] = { };
199198
200199 gossip_debug(GOSSIP_DEBUGFS_DEBUG, "%s: start\n", __func__);
201
-
202
- k_buffer = kzalloc(ORANGEFS_MAX_DEBUG_STRING_LEN, GFP_KERNEL);
203
- if (!k_buffer)
204
- goto out;
205200
206201 if (strlen(kernel_debug_string) + 1 < ORANGEFS_MAX_DEBUG_STRING_LEN) {
207202 strcpy(k_buffer, kernel_debug_string);
....@@ -213,15 +208,14 @@
213208
214209 debugfs_create_file(ORANGEFS_KMOD_DEBUG_FILE, 0444, debug_dir, k_buffer,
215210 &kernel_debug_fops);
216
-
217
-out:
218
- gossip_debug(GOSSIP_DEBUGFS_DEBUG, "%s: rc:%d:\n", __func__, rc);
219211 }
220212
221213
222214 void orangefs_debugfs_cleanup(void)
223215 {
224216 debugfs_remove_recursive(debug_dir);
217
+ kfree(debug_help_string);
218
+ debug_help_string = NULL;
225219 }
226220
227221 /* open ORANGEFS_KMOD_DEBUG_HELP_FILE */
....@@ -297,17 +291,12 @@
297291 /*
298292 * initialize the client-debug file.
299293 */
300
-static int orangefs_client_debug_init(void)
294
+static void orangefs_client_debug_init(void)
301295 {
302296
303
- int rc = -ENOMEM;
304
- char *c_buffer = NULL;
297
+ static char c_buffer[ORANGEFS_MAX_DEBUG_STRING_LEN] = { };
305298
306299 gossip_debug(GOSSIP_DEBUGFS_DEBUG, "%s: start\n", __func__);
307
-
308
- c_buffer = kzalloc(ORANGEFS_MAX_DEBUG_STRING_LEN, GFP_KERNEL);
309
- if (!c_buffer)
310
- goto out;
311300
312301 if (strlen(client_debug_string) + 1 < ORANGEFS_MAX_DEBUG_STRING_LEN) {
313302 strcpy(c_buffer, client_debug_string);
....@@ -322,13 +311,6 @@
322311 debug_dir,
323312 c_buffer,
324313 &kernel_debug_fops);
325
-
326
- rc = 0;
327
-
328
-out:
329
-
330
- gossip_debug(GOSSIP_DEBUGFS_DEBUG, "%s: rc:%d:\n", __func__, rc);
331
- return rc;
332314 }
333315
334316 /* open ORANGEFS_KMOD_DEBUG_FILE or ORANGEFS_CLIENT_DEBUG_FILE.*/
....@@ -671,6 +653,7 @@
671653 memset(debug_help_string, 0, DEBUG_HELP_STRING_SIZE);
672654 strlcat(debug_help_string, new, string_size);
673655 mutex_unlock(&orangefs_help_file_lock);
656
+ kfree(new);
674657 }
675658
676659 rc = 0;