forked from ~ljy/RK356X_SDK_RELEASE

hc
2024-12-19 9370bb92b2d16684ee45cf24e879c93c509162da
kernel/drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c
....@@ -438,7 +438,6 @@
438438
439439 void xgbe_debugfs_init(struct xgbe_prv_data *pdata)
440440 {
441
- struct dentry *pfile;
442441 char *buf;
443442
444443 /* Set defaults */
....@@ -451,88 +450,48 @@
451450 return;
452451
453452 pdata->xgbe_debugfs = debugfs_create_dir(buf, NULL);
454
- if (!pdata->xgbe_debugfs) {
455
- netdev_err(pdata->netdev, "debugfs_create_dir failed\n");
456
- kfree(buf);
457
- return;
458
- }
459453
460
- pfile = debugfs_create_file("xgmac_register", 0600,
461
- pdata->xgbe_debugfs, pdata,
462
- &xgmac_reg_addr_fops);
463
- if (!pfile)
464
- netdev_err(pdata->netdev, "debugfs_create_file failed\n");
454
+ debugfs_create_file("xgmac_register", 0600, pdata->xgbe_debugfs, pdata,
455
+ &xgmac_reg_addr_fops);
465456
466
- pfile = debugfs_create_file("xgmac_register_value", 0600,
467
- pdata->xgbe_debugfs, pdata,
468
- &xgmac_reg_value_fops);
469
- if (!pfile)
470
- netdev_err(pdata->netdev, "debugfs_create_file failed\n");
457
+ debugfs_create_file("xgmac_register_value", 0600, pdata->xgbe_debugfs,
458
+ pdata, &xgmac_reg_value_fops);
471459
472
- pfile = debugfs_create_file("xpcs_mmd", 0600,
473
- pdata->xgbe_debugfs, pdata,
474
- &xpcs_mmd_fops);
475
- if (!pfile)
476
- netdev_err(pdata->netdev, "debugfs_create_file failed\n");
460
+ debugfs_create_file("xpcs_mmd", 0600, pdata->xgbe_debugfs, pdata,
461
+ &xpcs_mmd_fops);
477462
478
- pfile = debugfs_create_file("xpcs_register", 0600,
479
- pdata->xgbe_debugfs, pdata,
480
- &xpcs_reg_addr_fops);
481
- if (!pfile)
482
- netdev_err(pdata->netdev, "debugfs_create_file failed\n");
463
+ debugfs_create_file("xpcs_register", 0600, pdata->xgbe_debugfs, pdata,
464
+ &xpcs_reg_addr_fops);
483465
484
- pfile = debugfs_create_file("xpcs_register_value", 0600,
485
- pdata->xgbe_debugfs, pdata,
486
- &xpcs_reg_value_fops);
487
- if (!pfile)
488
- netdev_err(pdata->netdev, "debugfs_create_file failed\n");
466
+ debugfs_create_file("xpcs_register_value", 0600, pdata->xgbe_debugfs,
467
+ pdata, &xpcs_reg_value_fops);
489468
490469 if (pdata->xprop_regs) {
491
- pfile = debugfs_create_file("xprop_register", 0600,
492
- pdata->xgbe_debugfs, pdata,
493
- &xprop_reg_addr_fops);
494
- if (!pfile)
495
- netdev_err(pdata->netdev,
496
- "debugfs_create_file failed\n");
470
+ debugfs_create_file("xprop_register", 0600, pdata->xgbe_debugfs,
471
+ pdata, &xprop_reg_addr_fops);
497472
498
- pfile = debugfs_create_file("xprop_register_value", 0600,
499
- pdata->xgbe_debugfs, pdata,
500
- &xprop_reg_value_fops);
501
- if (!pfile)
502
- netdev_err(pdata->netdev,
503
- "debugfs_create_file failed\n");
473
+ debugfs_create_file("xprop_register_value", 0600,
474
+ pdata->xgbe_debugfs, pdata,
475
+ &xprop_reg_value_fops);
504476 }
505477
506478 if (pdata->xi2c_regs) {
507
- pfile = debugfs_create_file("xi2c_register", 0600,
508
- pdata->xgbe_debugfs, pdata,
509
- &xi2c_reg_addr_fops);
510
- if (!pfile)
511
- netdev_err(pdata->netdev,
512
- "debugfs_create_file failed\n");
479
+ debugfs_create_file("xi2c_register", 0600, pdata->xgbe_debugfs,
480
+ pdata, &xi2c_reg_addr_fops);
513481
514
- pfile = debugfs_create_file("xi2c_register_value", 0600,
515
- pdata->xgbe_debugfs, pdata,
516
- &xi2c_reg_value_fops);
517
- if (!pfile)
518
- netdev_err(pdata->netdev,
519
- "debugfs_create_file failed\n");
482
+ debugfs_create_file("xi2c_register_value", 0600,
483
+ pdata->xgbe_debugfs, pdata,
484
+ &xi2c_reg_value_fops);
520485 }
521486
522487 if (pdata->vdata->an_cdr_workaround) {
523
- pfile = debugfs_create_bool("an_cdr_workaround", 0600,
524
- pdata->xgbe_debugfs,
525
- &pdata->debugfs_an_cdr_workaround);
526
- if (!pfile)
527
- netdev_err(pdata->netdev,
528
- "debugfs_create_bool failed\n");
488
+ debugfs_create_bool("an_cdr_workaround", 0600,
489
+ pdata->xgbe_debugfs,
490
+ &pdata->debugfs_an_cdr_workaround);
529491
530
- pfile = debugfs_create_bool("an_cdr_track_early", 0600,
531
- pdata->xgbe_debugfs,
532
- &pdata->debugfs_an_cdr_track_early);
533
- if (!pfile)
534
- netdev_err(pdata->netdev,
535
- "debugfs_create_bool failed\n");
492
+ debugfs_create_bool("an_cdr_track_early", 0600,
493
+ pdata->xgbe_debugfs,
494
+ &pdata->debugfs_an_cdr_track_early);
536495 }
537496
538497 kfree(buf);
....@@ -546,7 +505,6 @@
546505
547506 void xgbe_debugfs_rename(struct xgbe_prv_data *pdata)
548507 {
549
- struct dentry *pfile;
550508 char *buf;
551509
552510 if (!pdata->xgbe_debugfs)
....@@ -559,11 +517,8 @@
559517 if (!strcmp(pdata->xgbe_debugfs->d_name.name, buf))
560518 goto out;
561519
562
- pfile = debugfs_rename(pdata->xgbe_debugfs->d_parent,
563
- pdata->xgbe_debugfs,
564
- pdata->xgbe_debugfs->d_parent, buf);
565
- if (!pfile)
566
- netdev_err(pdata->netdev, "debugfs_rename failed\n");
520
+ debugfs_rename(pdata->xgbe_debugfs->d_parent, pdata->xgbe_debugfs,
521
+ pdata->xgbe_debugfs->d_parent, buf);
567522
568523 out:
569524 kfree(buf);