.. | .. |
---|
634 | 634 | u32 config_data, const char *message) |
---|
635 | 635 | { |
---|
636 | 636 | u8 i; |
---|
637 | | - int ret = HCMD_SUCCESS; |
---|
| 637 | + int ret; |
---|
638 | 638 | |
---|
639 | 639 | for (i = 0; i < 4; i++) { |
---|
640 | 640 | ret = load_8051_config(ppd->dd, field_id, i, config_data); |
---|
.. | .. |
---|
668 | 668 | |
---|
669 | 669 | /* active optical cables only */ |
---|
670 | 670 | switch ((cache[QSFP_MOD_TECH_OFFS] & 0xF0) >> 4) { |
---|
671 | | - case 0x0 ... 0x9: /* fallthrough */ |
---|
672 | | - case 0xC: /* fallthrough */ |
---|
| 671 | + case 0x0 ... 0x9: fallthrough; |
---|
| 672 | + case 0xC: fallthrough; |
---|
673 | 673 | case 0xE: |
---|
674 | 674 | /* active AOC */ |
---|
675 | 675 | power_class = get_qsfp_power_class(cache[QSFP_MOD_PWR_OFFS]); |
---|
.. | .. |
---|
899 | 899 | |
---|
900 | 900 | *ptr_tuning_method = OPA_PASSIVE_TUNING; |
---|
901 | 901 | break; |
---|
902 | | - case 0x0 ... 0x9: /* fallthrough */ |
---|
903 | | - case 0xC: /* fallthrough */ |
---|
| 902 | + case 0x0 ... 0x9: fallthrough; |
---|
| 903 | + case 0xC: fallthrough; |
---|
904 | 904 | case 0xE: |
---|
905 | 905 | ret = tune_active_qsfp(ppd, ptr_tx_preset, ptr_rx_preset, |
---|
906 | 906 | ptr_total_atten); |
---|
.. | .. |
---|
909 | 909 | |
---|
910 | 910 | *ptr_tuning_method = OPA_ACTIVE_TUNING; |
---|
911 | 911 | break; |
---|
912 | | - case 0xD: /* fallthrough */ |
---|
| 912 | + case 0xD: fallthrough; |
---|
913 | 913 | case 0xF: |
---|
914 | 914 | default: |
---|
915 | 915 | dd_dev_warn(ppd->dd, "%s: Unknown/unsupported cable\n", |
---|