write in 30M

hc

2024-02-20 ea08eeccae9297f7aabd2ef7f0c2517ac4549acc

 kernel/mm/hwpoison-inject.c
..
..
@@ -1,3 +1,4 @@
1
+// SPDX-License-Identifier: GPL-2.0-only
1
2
 /* Inject a hwpoison memory failure on a arbitrary pfn */
2
3
 #include <linux/module.h>
3
4
 #include <linux/debugfs.h>
..
..
@@ -25,11 +26,6 @@
25
26
 
26
27
 	p = pfn_to_page(pfn);
27
28
 	hpage = compound_head(p);
28
-	/*
29
-	 * This implies unable to support free buddy pages.
30
-	 */
31
-	if (!get_hwpoison_page(p))
32
-		return 0;
33
29
 
34
30
 	if (!hwpoison_filter_enable)
35
31
 		goto inject;
..
..
@@ -39,23 +35,20 @@
39
35
 	 * This implies unable to support non-LRU pages.
40
36
 	 */
41
37
 	if (!PageLRU(hpage) && !PageHuge(p))
42
-		goto put_out;
38
+		return 0;
43
39
 
44
40
 	/*
45
-	 * do a racy check with elevated page count, to make sure PG_hwpoison
46
-	 * will only be set for the targeted owner (or on a free page).
41
+	 * do a racy check to make sure PG_hwpoison will only be set for
42
+	 * the targeted owner (or on a free page).
47
43
 	 * memory_failure() will redo the check reliably inside page lock.
48
44
 	 */
49
45
 	err = hwpoison_filter(hpage);
50
46
 	if (err)
51
-		goto put_out;
47
+		return 0;
52
48
 
53
49
 inject:
54
50
 	pr_info("Injecting memory failure at pfn %#lx\n", pfn);
55
-	return memory_failure(pfn, MF_COUNT_INCREASED);
56
-put_out:
57
-	put_hwpoison_page(p);
58
-	return 0;
51
+	return memory_failure(pfn, 0);
59
52
 }
60
53
 
61
54
 static int hwpoison_unpoison(void *data, u64 val)
..
..
@@ -66,8 +59,8 @@
66
59
 	return unpoison_memory(val);
67
60
 }
68
61
 
69
-DEFINE_SIMPLE_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n");
70
-DEFINE_SIMPLE_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n");
62
+DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n");
63
+DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n");
71
64
 
72
65
 static void pfn_inject_exit(void)
73
66
 {
..
..
@@ -76,63 +69,40 @@
76
69
 
77
70
 static int pfn_inject_init(void)
78
71
 {
79
-	struct dentry *dentry;
80
-
81
72
 	hwpoison_dir = debugfs_create_dir("hwpoison", NULL);
82
-	if (hwpoison_dir == NULL)
83
-		return -ENOMEM;
84
73
 
85
74
 	/*
86
75
 	 * Note that the below poison/unpoison interfaces do not involve
87
76
 	 * hardware status change, hence do not require hardware support.
88
77
 	 * They are mainly for testing hwpoison in software level.
89
78
 	 */
90
-	dentry = debugfs_create_file("corrupt-pfn", 0200, hwpoison_dir,
91
-					  NULL, &hwpoison_fops);
92
-	if (!dentry)
93
-		goto fail;
79
+	debugfs_create_file("corrupt-pfn", 0200, hwpoison_dir, NULL,
80
+			    &hwpoison_fops);
94
81
 
95
-	dentry = debugfs_create_file("unpoison-pfn", 0200, hwpoison_dir,
96
-				     NULL, &unpoison_fops);
97
-	if (!dentry)
98
-		goto fail;
82
+	debugfs_create_file("unpoison-pfn", 0200, hwpoison_dir, NULL,
83
+			    &unpoison_fops);
99
84
 
100
-	dentry = debugfs_create_u32("corrupt-filter-enable", 0600,
101
-				    hwpoison_dir, &hwpoison_filter_enable);
102
-	if (!dentry)
103
-		goto fail;
85
+	debugfs_create_u32("corrupt-filter-enable", 0600, hwpoison_dir,
86
+			   &hwpoison_filter_enable);
104
87
 
105
-	dentry = debugfs_create_u32("corrupt-filter-dev-major", 0600,
106
-				    hwpoison_dir, &hwpoison_filter_dev_major);
107
-	if (!dentry)
108
-		goto fail;
88
+	debugfs_create_u32("corrupt-filter-dev-major", 0600, hwpoison_dir,
89
+			   &hwpoison_filter_dev_major);
109
90
 
110
-	dentry = debugfs_create_u32("corrupt-filter-dev-minor", 0600,
111
-				    hwpoison_dir, &hwpoison_filter_dev_minor);
112
-	if (!dentry)
113
-		goto fail;
91
+	debugfs_create_u32("corrupt-filter-dev-minor", 0600, hwpoison_dir,
92
+			   &hwpoison_filter_dev_minor);
114
93
 
115
-	dentry = debugfs_create_u64("corrupt-filter-flags-mask", 0600,
116
-				    hwpoison_dir, &hwpoison_filter_flags_mask);
117
-	if (!dentry)
118
-		goto fail;
94
+	debugfs_create_u64("corrupt-filter-flags-mask", 0600, hwpoison_dir,
95
+			   &hwpoison_filter_flags_mask);
119
96
 
120
-	dentry = debugfs_create_u64("corrupt-filter-flags-value", 0600,
121
-				    hwpoison_dir, &hwpoison_filter_flags_value);
122
-	if (!dentry)
123
-		goto fail;
97
+	debugfs_create_u64("corrupt-filter-flags-value", 0600, hwpoison_dir,
98
+			   &hwpoison_filter_flags_value);
124
99
 
125
100
 #ifdef CONFIG_MEMCG
126
-	dentry = debugfs_create_u64("corrupt-filter-memcg", 0600,
127
-				    hwpoison_dir, &hwpoison_filter_memcg);
128
-	if (!dentry)
129
-		goto fail;
101
+	debugfs_create_u64("corrupt-filter-memcg", 0600, hwpoison_dir,
102
+			   &hwpoison_filter_memcg);
130
103
 #endif
131
104
 
132
105
 	return 0;
133
-fail:
134
-	pfn_inject_exit();
135
-	return -ENOMEM;
136
106
 }
137
107
 
138
108
 module_init(pfn_inject_init);