| .. | .. |
|---|
| 1 | +// SPDX-License-Identifier: GPL-2.0-or-later |
|---|
| 1 | 2 | /* |
|---|
| 2 | 3 | * Copyright 2015 IBM Corp. |
|---|
| 3 | 4 | * |
|---|
| 4 | 5 | * Joel Stanley <joel@jms.id.au> |
|---|
| 5 | | - * |
|---|
| 6 | | - * This program is free software; you can redistribute it and/or |
|---|
| 7 | | - * modify it under the terms of the GNU General Public License |
|---|
| 8 | | - * as published by the Free Software Foundation; either version |
|---|
| 9 | | - * 2 of the License, or (at your option) any later version. |
|---|
| 10 | 6 | */ |
|---|
| 11 | 7 | |
|---|
| 12 | 8 | #include <asm/div64.h> |
|---|
| .. | .. |
|---|
| 56 | 52 | */ |
|---|
| 57 | 53 | struct aspeed_gpio { |
|---|
| 58 | 54 | struct gpio_chip chip; |
|---|
| 59 | | - spinlock_t lock; |
|---|
| 55 | + struct irq_chip irqc; |
|---|
| 56 | + raw_spinlock_t lock; |
|---|
| 60 | 57 | void __iomem *base; |
|---|
| 61 | 58 | int irq; |
|---|
| 62 | 59 | const struct aspeed_gpio_config *config; |
|---|
| .. | .. |
|---|
| 416 | 413 | unsigned long flags; |
|---|
| 417 | 414 | bool copro; |
|---|
| 418 | 415 | |
|---|
| 419 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 416 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 420 | 417 | copro = aspeed_gpio_copro_request(gpio, offset); |
|---|
| 421 | 418 | |
|---|
| 422 | 419 | __aspeed_gpio_set(gc, offset, val); |
|---|
| 423 | 420 | |
|---|
| 424 | 421 | if (copro) |
|---|
| 425 | 422 | aspeed_gpio_copro_release(gpio, offset); |
|---|
| 426 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 423 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 427 | 424 | } |
|---|
| 428 | 425 | |
|---|
| 429 | 426 | static int aspeed_gpio_dir_in(struct gpio_chip *gc, unsigned int offset) |
|---|
| .. | .. |
|---|
| 438 | 435 | if (!have_input(gpio, offset)) |
|---|
| 439 | 436 | return -ENOTSUPP; |
|---|
| 440 | 437 | |
|---|
| 441 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 438 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 442 | 439 | |
|---|
| 443 | 440 | reg = ioread32(addr); |
|---|
| 444 | 441 | reg &= ~GPIO_BIT(offset); |
|---|
| .. | .. |
|---|
| 448 | 445 | if (copro) |
|---|
| 449 | 446 | aspeed_gpio_copro_release(gpio, offset); |
|---|
| 450 | 447 | |
|---|
| 451 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 448 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 452 | 449 | |
|---|
| 453 | 450 | return 0; |
|---|
| 454 | 451 | } |
|---|
| .. | .. |
|---|
| 466 | 463 | if (!have_output(gpio, offset)) |
|---|
| 467 | 464 | return -ENOTSUPP; |
|---|
| 468 | 465 | |
|---|
| 469 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 466 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 470 | 467 | |
|---|
| 471 | 468 | reg = ioread32(addr); |
|---|
| 472 | 469 | reg |= GPIO_BIT(offset); |
|---|
| .. | .. |
|---|
| 477 | 474 | |
|---|
| 478 | 475 | if (copro) |
|---|
| 479 | 476 | aspeed_gpio_copro_release(gpio, offset); |
|---|
| 480 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 477 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 481 | 478 | |
|---|
| 482 | 479 | return 0; |
|---|
| 483 | 480 | } |
|---|
| .. | .. |
|---|
| 490 | 487 | u32 val; |
|---|
| 491 | 488 | |
|---|
| 492 | 489 | if (!have_input(gpio, offset)) |
|---|
| 493 | | - return 0; |
|---|
| 490 | + return GPIO_LINE_DIRECTION_OUT; |
|---|
| 494 | 491 | |
|---|
| 495 | 492 | if (!have_output(gpio, offset)) |
|---|
| 496 | | - return 1; |
|---|
| 493 | + return GPIO_LINE_DIRECTION_IN; |
|---|
| 497 | 494 | |
|---|
| 498 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 495 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 499 | 496 | |
|---|
| 500 | 497 | val = ioread32(bank_reg(gpio, bank, reg_dir)) & GPIO_BIT(offset); |
|---|
| 501 | 498 | |
|---|
| 502 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 499 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 503 | 500 | |
|---|
| 504 | | - return !val; |
|---|
| 505 | | - |
|---|
| 501 | + return val ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN; |
|---|
| 506 | 502 | } |
|---|
| 507 | 503 | |
|---|
| 508 | 504 | static inline int irqd_to_aspeed_gpio_data(struct irq_data *d, |
|---|
| .. | .. |
|---|
| 543 | 539 | |
|---|
| 544 | 540 | status_addr = bank_reg(gpio, bank, reg_irq_status); |
|---|
| 545 | 541 | |
|---|
| 546 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 542 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 547 | 543 | copro = aspeed_gpio_copro_request(gpio, offset); |
|---|
| 548 | 544 | |
|---|
| 549 | 545 | iowrite32(bit, status_addr); |
|---|
| 550 | 546 | |
|---|
| 551 | 547 | if (copro) |
|---|
| 552 | 548 | aspeed_gpio_copro_release(gpio, offset); |
|---|
| 553 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 549 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 554 | 550 | } |
|---|
| 555 | 551 | |
|---|
| 556 | 552 | static void aspeed_gpio_irq_set_mask(struct irq_data *d, bool set) |
|---|
| .. | .. |
|---|
| 569 | 565 | |
|---|
| 570 | 566 | addr = bank_reg(gpio, bank, reg_irq_enable); |
|---|
| 571 | 567 | |
|---|
| 572 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 568 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 573 | 569 | copro = aspeed_gpio_copro_request(gpio, offset); |
|---|
| 574 | 570 | |
|---|
| 575 | 571 | reg = ioread32(addr); |
|---|
| .. | .. |
|---|
| 581 | 577 | |
|---|
| 582 | 578 | if (copro) |
|---|
| 583 | 579 | aspeed_gpio_copro_release(gpio, offset); |
|---|
| 584 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 580 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 585 | 581 | } |
|---|
| 586 | 582 | |
|---|
| 587 | 583 | static void aspeed_gpio_irq_mask(struct irq_data *d) |
|---|
| .. | .. |
|---|
| 615 | 611 | switch (type & IRQ_TYPE_SENSE_MASK) { |
|---|
| 616 | 612 | case IRQ_TYPE_EDGE_BOTH: |
|---|
| 617 | 613 | type2 |= bit; |
|---|
| 618 | | - /* fall through */ |
|---|
| 614 | + fallthrough; |
|---|
| 619 | 615 | case IRQ_TYPE_EDGE_RISING: |
|---|
| 620 | 616 | type0 |= bit; |
|---|
| 621 | | - /* fall through */ |
|---|
| 617 | + fallthrough; |
|---|
| 622 | 618 | case IRQ_TYPE_EDGE_FALLING: |
|---|
| 623 | 619 | handler = handle_edge_irq; |
|---|
| 624 | 620 | break; |
|---|
| 625 | 621 | case IRQ_TYPE_LEVEL_HIGH: |
|---|
| 626 | 622 | type0 |= bit; |
|---|
| 627 | | - /* fall through */ |
|---|
| 623 | + fallthrough; |
|---|
| 628 | 624 | case IRQ_TYPE_LEVEL_LOW: |
|---|
| 629 | 625 | type1 |= bit; |
|---|
| 630 | 626 | handler = handle_level_irq; |
|---|
| .. | .. |
|---|
| 633 | 629 | return -EINVAL; |
|---|
| 634 | 630 | } |
|---|
| 635 | 631 | |
|---|
| 636 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 632 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 637 | 633 | copro = aspeed_gpio_copro_request(gpio, offset); |
|---|
| 638 | 634 | |
|---|
| 639 | 635 | addr = bank_reg(gpio, bank, reg_irq_type0); |
|---|
| .. | .. |
|---|
| 653 | 649 | |
|---|
| 654 | 650 | if (copro) |
|---|
| 655 | 651 | aspeed_gpio_copro_release(gpio, offset); |
|---|
| 656 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 652 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 657 | 653 | |
|---|
| 658 | 654 | irq_set_handler_locked(d, handler); |
|---|
| 659 | 655 | |
|---|
| .. | .. |
|---|
| 665 | 661 | struct gpio_chip *gc = irq_desc_get_handler_data(desc); |
|---|
| 666 | 662 | struct irq_chip *ic = irq_desc_get_chip(desc); |
|---|
| 667 | 663 | struct aspeed_gpio *data = gpiochip_get_data(gc); |
|---|
| 668 | | - unsigned int i, p, girq; |
|---|
| 664 | + unsigned int i, p, girq, banks; |
|---|
| 669 | 665 | unsigned long reg; |
|---|
| 666 | + struct aspeed_gpio *gpio = gpiochip_get_data(gc); |
|---|
| 670 | 667 | |
|---|
| 671 | 668 | chained_irq_enter(ic, desc); |
|---|
| 672 | 669 | |
|---|
| 673 | | - for (i = 0; i < ARRAY_SIZE(aspeed_gpio_banks); i++) { |
|---|
| 670 | + banks = DIV_ROUND_UP(gpio->chip.ngpio, 32); |
|---|
| 671 | + for (i = 0; i < banks; i++) { |
|---|
| 674 | 672 | const struct aspeed_gpio_bank *bank = &aspeed_gpio_banks[i]; |
|---|
| 675 | 673 | |
|---|
| 676 | 674 | reg = ioread32(bank_reg(data, bank, reg_irq_status)); |
|---|
| .. | .. |
|---|
| 685 | 683 | chained_irq_exit(ic, desc); |
|---|
| 686 | 684 | } |
|---|
| 687 | 685 | |
|---|
| 688 | | -static struct irq_chip aspeed_gpio_irqchip = { |
|---|
| 689 | | - .name = "aspeed-gpio", |
|---|
| 690 | | - .irq_ack = aspeed_gpio_irq_ack, |
|---|
| 691 | | - .irq_mask = aspeed_gpio_irq_mask, |
|---|
| 692 | | - .irq_unmask = aspeed_gpio_irq_unmask, |
|---|
| 693 | | - .irq_set_type = aspeed_gpio_set_type, |
|---|
| 694 | | -}; |
|---|
| 695 | | - |
|---|
| 696 | | -static void set_irq_valid_mask(struct aspeed_gpio *gpio) |
|---|
| 686 | +static void aspeed_init_irq_valid_mask(struct gpio_chip *gc, |
|---|
| 687 | + unsigned long *valid_mask, |
|---|
| 688 | + unsigned int ngpios) |
|---|
| 697 | 689 | { |
|---|
| 690 | + struct aspeed_gpio *gpio = gpiochip_get_data(gc); |
|---|
| 698 | 691 | const struct aspeed_bank_props *props = gpio->config->props; |
|---|
| 699 | 692 | |
|---|
| 700 | 693 | while (!is_bank_props_sentinel(props)) { |
|---|
| .. | .. |
|---|
| 705 | 698 | for_each_clear_bit(offset, &input, 32) { |
|---|
| 706 | 699 | unsigned int i = props->bank * 32 + offset; |
|---|
| 707 | 700 | |
|---|
| 708 | | - if (i >= gpio->config->nr_gpios) |
|---|
| 701 | + if (i >= gpio->chip.ngpio) |
|---|
| 709 | 702 | break; |
|---|
| 710 | 703 | |
|---|
| 711 | | - clear_bit(i, gpio->chip.irq.valid_mask); |
|---|
| 704 | + clear_bit(i, valid_mask); |
|---|
| 712 | 705 | } |
|---|
| 713 | 706 | |
|---|
| 714 | 707 | props++; |
|---|
| 715 | 708 | } |
|---|
| 716 | | -} |
|---|
| 717 | | - |
|---|
| 718 | | -static int aspeed_gpio_setup_irqs(struct aspeed_gpio *gpio, |
|---|
| 719 | | - struct platform_device *pdev) |
|---|
| 720 | | -{ |
|---|
| 721 | | - int rc; |
|---|
| 722 | | - |
|---|
| 723 | | - rc = platform_get_irq(pdev, 0); |
|---|
| 724 | | - if (rc < 0) |
|---|
| 725 | | - return rc; |
|---|
| 726 | | - |
|---|
| 727 | | - gpio->irq = rc; |
|---|
| 728 | | - |
|---|
| 729 | | - set_irq_valid_mask(gpio); |
|---|
| 730 | | - |
|---|
| 731 | | - rc = gpiochip_irqchip_add(&gpio->chip, &aspeed_gpio_irqchip, |
|---|
| 732 | | - 0, handle_bad_irq, IRQ_TYPE_NONE); |
|---|
| 733 | | - if (rc) { |
|---|
| 734 | | - dev_info(&pdev->dev, "Could not add irqchip\n"); |
|---|
| 735 | | - return rc; |
|---|
| 736 | | - } |
|---|
| 737 | | - |
|---|
| 738 | | - gpiochip_set_chained_irqchip(&gpio->chip, &aspeed_gpio_irqchip, |
|---|
| 739 | | - gpio->irq, aspeed_gpio_irq_handler); |
|---|
| 740 | | - |
|---|
| 741 | | - return 0; |
|---|
| 742 | 709 | } |
|---|
| 743 | 710 | |
|---|
| 744 | 711 | static int aspeed_gpio_reset_tolerance(struct gpio_chip *chip, |
|---|
| .. | .. |
|---|
| 752 | 719 | |
|---|
| 753 | 720 | treg = bank_reg(gpio, to_bank(offset), reg_tolerance); |
|---|
| 754 | 721 | |
|---|
| 755 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 722 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 756 | 723 | copro = aspeed_gpio_copro_request(gpio, offset); |
|---|
| 757 | 724 | |
|---|
| 758 | 725 | val = readl(treg); |
|---|
| .. | .. |
|---|
| 766 | 733 | |
|---|
| 767 | 734 | if (copro) |
|---|
| 768 | 735 | aspeed_gpio_copro_release(gpio, offset); |
|---|
| 769 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 736 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 770 | 737 | |
|---|
| 771 | 738 | return 0; |
|---|
| 772 | 739 | } |
|---|
| .. | .. |
|---|
| 892 | 859 | return rc; |
|---|
| 893 | 860 | } |
|---|
| 894 | 861 | |
|---|
| 895 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 862 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 896 | 863 | |
|---|
| 897 | 864 | if (timer_allocation_registered(gpio, offset)) { |
|---|
| 898 | 865 | rc = unregister_allocated_timer(gpio, offset); |
|---|
| .. | .. |
|---|
| 952 | 919 | configure_timer(gpio, offset, i); |
|---|
| 953 | 920 | |
|---|
| 954 | 921 | out: |
|---|
| 955 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 922 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 956 | 923 | |
|---|
| 957 | 924 | return rc; |
|---|
| 958 | 925 | } |
|---|
| .. | .. |
|---|
| 963 | 930 | unsigned long flags; |
|---|
| 964 | 931 | int rc; |
|---|
| 965 | 932 | |
|---|
| 966 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 933 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 967 | 934 | |
|---|
| 968 | 935 | rc = unregister_allocated_timer(gpio, offset); |
|---|
| 969 | 936 | if (!rc) |
|---|
| 970 | 937 | configure_timer(gpio, offset, 0); |
|---|
| 971 | 938 | |
|---|
| 972 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 939 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 973 | 940 | |
|---|
| 974 | 941 | return rc; |
|---|
| 975 | 942 | } |
|---|
| .. | .. |
|---|
| 999 | 966 | else if (param == PIN_CONFIG_BIAS_DISABLE || |
|---|
| 1000 | 967 | param == PIN_CONFIG_BIAS_PULL_DOWN || |
|---|
| 1001 | 968 | param == PIN_CONFIG_DRIVE_STRENGTH) |
|---|
| 1002 | | - return pinctrl_gpio_set_config(offset, config); |
|---|
| 969 | + return pinctrl_gpio_set_config(chip->base + offset, config); |
|---|
| 1003 | 970 | else if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN || |
|---|
| 1004 | 971 | param == PIN_CONFIG_DRIVE_OPEN_SOURCE) |
|---|
| 1005 | 972 | /* Return -ENOTSUPP to trigger emulation, as per datasheet */ |
|---|
| .. | .. |
|---|
| 1011 | 978 | } |
|---|
| 1012 | 979 | |
|---|
| 1013 | 980 | /** |
|---|
| 1014 | | - * aspeed_gpio_copro_set_ops - Sets the callbacks used for handhsaking with |
|---|
| 981 | + * aspeed_gpio_copro_set_ops - Sets the callbacks used for handshaking with |
|---|
| 1015 | 982 | * the coprocessor for shared GPIO banks |
|---|
| 1016 | 983 | * @ops: The callbacks |
|---|
| 1017 | 984 | * @data: Pointer passed back to the callbacks |
|---|
| .. | .. |
|---|
| 1044 | 1011 | unsigned long flags; |
|---|
| 1045 | 1012 | |
|---|
| 1046 | 1013 | if (!gpio->cf_copro_bankmap) |
|---|
| 1047 | | - gpio->cf_copro_bankmap = kzalloc(gpio->config->nr_gpios >> 3, GFP_KERNEL); |
|---|
| 1014 | + gpio->cf_copro_bankmap = kzalloc(gpio->chip.ngpio >> 3, GFP_KERNEL); |
|---|
| 1048 | 1015 | if (!gpio->cf_copro_bankmap) |
|---|
| 1049 | 1016 | return -ENOMEM; |
|---|
| 1050 | | - if (offset < 0 || offset > gpio->config->nr_gpios) |
|---|
| 1017 | + if (offset < 0 || offset > gpio->chip.ngpio) |
|---|
| 1051 | 1018 | return -EINVAL; |
|---|
| 1052 | 1019 | bindex = offset >> 3; |
|---|
| 1053 | 1020 | |
|---|
| 1054 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 1021 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 1055 | 1022 | |
|---|
| 1056 | 1023 | /* Sanity check, this shouldn't happen */ |
|---|
| 1057 | 1024 | if (gpio->cf_copro_bankmap[bindex] == 0xff) { |
|---|
| .. | .. |
|---|
| 1072 | 1039 | if (bit) |
|---|
| 1073 | 1040 | *bit = GPIO_OFFSET(offset); |
|---|
| 1074 | 1041 | bail: |
|---|
| 1075 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 1042 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 1076 | 1043 | return rc; |
|---|
| 1077 | 1044 | } |
|---|
| 1078 | 1045 | EXPORT_SYMBOL_GPL(aspeed_gpio_copro_grab_gpio); |
|---|
| .. | .. |
|---|
| 1092 | 1059 | if (!gpio->cf_copro_bankmap) |
|---|
| 1093 | 1060 | return -ENXIO; |
|---|
| 1094 | 1061 | |
|---|
| 1095 | | - if (offset < 0 || offset > gpio->config->nr_gpios) |
|---|
| 1062 | + if (offset < 0 || offset > gpio->chip.ngpio) |
|---|
| 1096 | 1063 | return -EINVAL; |
|---|
| 1097 | 1064 | bindex = offset >> 3; |
|---|
| 1098 | 1065 | |
|---|
| 1099 | | - spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 1066 | + raw_spin_lock_irqsave(&gpio->lock, flags); |
|---|
| 1100 | 1067 | |
|---|
| 1101 | 1068 | /* Sanity check, this shouldn't happen */ |
|---|
| 1102 | 1069 | if (gpio->cf_copro_bankmap[bindex] == 0) { |
|---|
| .. | .. |
|---|
| 1110 | 1077 | aspeed_gpio_change_cmd_source(gpio, bank, bindex, |
|---|
| 1111 | 1078 | GPIO_CMDSRC_ARM); |
|---|
| 1112 | 1079 | bail: |
|---|
| 1113 | | - spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 1080 | + raw_spin_unlock_irqrestore(&gpio->lock, flags); |
|---|
| 1114 | 1081 | return rc; |
|---|
| 1115 | 1082 | } |
|---|
| 1116 | 1083 | EXPORT_SYMBOL_GPL(aspeed_gpio_copro_release_gpio); |
|---|
| .. | .. |
|---|
| 1145 | 1112 | /* 232 for simplicity, actual number is 228 (4-GPIO hole in GPIOAB) */ |
|---|
| 1146 | 1113 | { .nr_gpios = 232, .props = ast2500_bank_props, }; |
|---|
| 1147 | 1114 | |
|---|
| 1115 | +static const struct aspeed_bank_props ast2600_bank_props[] = { |
|---|
| 1116 | + /* input output */ |
|---|
| 1117 | + {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */ |
|---|
| 1118 | + {5, 0xffffffff, 0xffffff00}, /* U/V/W/X */ |
|---|
| 1119 | + {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */ |
|---|
| 1120 | + { }, |
|---|
| 1121 | +}; |
|---|
| 1122 | + |
|---|
| 1123 | +static const struct aspeed_gpio_config ast2600_config = |
|---|
| 1124 | + /* |
|---|
| 1125 | + * ast2600 has two controllers one with 208 GPIOs and one with 36 GPIOs. |
|---|
| 1126 | + * We expect ngpio being set in the device tree and this is a fallback |
|---|
| 1127 | + * option. |
|---|
| 1128 | + */ |
|---|
| 1129 | + { .nr_gpios = 208, .props = ast2600_bank_props, }; |
|---|
| 1130 | + |
|---|
| 1148 | 1131 | static const struct of_device_id aspeed_gpio_of_table[] = { |
|---|
| 1149 | 1132 | { .compatible = "aspeed,ast2400-gpio", .data = &ast2400_config, }, |
|---|
| 1150 | 1133 | { .compatible = "aspeed,ast2500-gpio", .data = &ast2500_config, }, |
|---|
| 1134 | + { .compatible = "aspeed,ast2600-gpio", .data = &ast2600_config, }, |
|---|
| 1151 | 1135 | {} |
|---|
| 1152 | 1136 | }; |
|---|
| 1153 | 1137 | MODULE_DEVICE_TABLE(of, aspeed_gpio_of_table); |
|---|
| .. | .. |
|---|
| 1156 | 1140 | { |
|---|
| 1157 | 1141 | const struct of_device_id *gpio_id; |
|---|
| 1158 | 1142 | struct aspeed_gpio *gpio; |
|---|
| 1159 | | - struct resource *res; |
|---|
| 1160 | | - int rc, i, banks; |
|---|
| 1143 | + int rc, i, banks, err; |
|---|
| 1144 | + u32 ngpio; |
|---|
| 1161 | 1145 | |
|---|
| 1162 | 1146 | gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL); |
|---|
| 1163 | 1147 | if (!gpio) |
|---|
| 1164 | 1148 | return -ENOMEM; |
|---|
| 1165 | 1149 | |
|---|
| 1166 | | - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
|---|
| 1167 | | - gpio->base = devm_ioremap_resource(&pdev->dev, res); |
|---|
| 1150 | + gpio->base = devm_platform_ioremap_resource(pdev, 0); |
|---|
| 1168 | 1151 | if (IS_ERR(gpio->base)) |
|---|
| 1169 | 1152 | return PTR_ERR(gpio->base); |
|---|
| 1170 | 1153 | |
|---|
| 1171 | | - spin_lock_init(&gpio->lock); |
|---|
| 1154 | + raw_spin_lock_init(&gpio->lock); |
|---|
| 1172 | 1155 | |
|---|
| 1173 | 1156 | gpio_id = of_match_node(aspeed_gpio_of_table, pdev->dev.of_node); |
|---|
| 1174 | 1157 | if (!gpio_id) |
|---|
| .. | .. |
|---|
| 1184 | 1167 | gpio->config = gpio_id->data; |
|---|
| 1185 | 1168 | |
|---|
| 1186 | 1169 | gpio->chip.parent = &pdev->dev; |
|---|
| 1187 | | - gpio->chip.ngpio = gpio->config->nr_gpios; |
|---|
| 1188 | | - gpio->chip.parent = &pdev->dev; |
|---|
| 1170 | + err = of_property_read_u32(pdev->dev.of_node, "ngpios", &ngpio); |
|---|
| 1171 | + gpio->chip.ngpio = (u16) ngpio; |
|---|
| 1172 | + if (err) |
|---|
| 1173 | + gpio->chip.ngpio = gpio->config->nr_gpios; |
|---|
| 1189 | 1174 | gpio->chip.direction_input = aspeed_gpio_dir_in; |
|---|
| 1190 | 1175 | gpio->chip.direction_output = aspeed_gpio_dir_out; |
|---|
| 1191 | 1176 | gpio->chip.get_direction = aspeed_gpio_get_direction; |
|---|
| .. | .. |
|---|
| 1196 | 1181 | gpio->chip.set_config = aspeed_gpio_set_config; |
|---|
| 1197 | 1182 | gpio->chip.label = dev_name(&pdev->dev); |
|---|
| 1198 | 1183 | gpio->chip.base = -1; |
|---|
| 1199 | | - gpio->chip.irq.need_valid_mask = true; |
|---|
| 1200 | 1184 | |
|---|
| 1201 | 1185 | /* Allocate a cache of the output registers */ |
|---|
| 1202 | | - banks = DIV_ROUND_UP(gpio->config->nr_gpios, 32); |
|---|
| 1186 | + banks = DIV_ROUND_UP(gpio->chip.ngpio, 32); |
|---|
| 1203 | 1187 | gpio->dcache = devm_kcalloc(&pdev->dev, |
|---|
| 1204 | 1188 | banks, sizeof(u32), GFP_KERNEL); |
|---|
| 1205 | 1189 | if (!gpio->dcache) |
|---|
| .. | .. |
|---|
| 1219 | 1203 | aspeed_gpio_change_cmd_source(gpio, bank, 3, GPIO_CMDSRC_ARM); |
|---|
| 1220 | 1204 | } |
|---|
| 1221 | 1205 | |
|---|
| 1222 | | - rc = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio); |
|---|
| 1223 | | - if (rc < 0) |
|---|
| 1224 | | - return rc; |
|---|
| 1206 | + /* Optionally set up an irqchip if there is an IRQ */ |
|---|
| 1207 | + rc = platform_get_irq(pdev, 0); |
|---|
| 1208 | + if (rc > 0) { |
|---|
| 1209 | + struct gpio_irq_chip *girq; |
|---|
| 1210 | + |
|---|
| 1211 | + gpio->irq = rc; |
|---|
| 1212 | + girq = &gpio->chip.irq; |
|---|
| 1213 | + girq->chip = &gpio->irqc; |
|---|
| 1214 | + girq->chip->name = dev_name(&pdev->dev); |
|---|
| 1215 | + girq->chip->irq_ack = aspeed_gpio_irq_ack; |
|---|
| 1216 | + girq->chip->irq_mask = aspeed_gpio_irq_mask; |
|---|
| 1217 | + girq->chip->irq_unmask = aspeed_gpio_irq_unmask; |
|---|
| 1218 | + girq->chip->irq_set_type = aspeed_gpio_set_type; |
|---|
| 1219 | + girq->parent_handler = aspeed_gpio_irq_handler; |
|---|
| 1220 | + girq->num_parents = 1; |
|---|
| 1221 | + girq->parents = devm_kcalloc(&pdev->dev, 1, |
|---|
| 1222 | + sizeof(*girq->parents), |
|---|
| 1223 | + GFP_KERNEL); |
|---|
| 1224 | + if (!girq->parents) |
|---|
| 1225 | + return -ENOMEM; |
|---|
| 1226 | + girq->parents[0] = gpio->irq; |
|---|
| 1227 | + girq->default_type = IRQ_TYPE_NONE; |
|---|
| 1228 | + girq->handler = handle_bad_irq; |
|---|
| 1229 | + girq->init_valid_mask = aspeed_init_irq_valid_mask; |
|---|
| 1230 | + } |
|---|
| 1225 | 1231 | |
|---|
| 1226 | 1232 | gpio->offset_timer = |
|---|
| 1227 | 1233 | devm_kzalloc(&pdev->dev, gpio->chip.ngpio, GFP_KERNEL); |
|---|
| 1228 | 1234 | if (!gpio->offset_timer) |
|---|
| 1229 | 1235 | return -ENOMEM; |
|---|
| 1230 | 1236 | |
|---|
| 1231 | | - return aspeed_gpio_setup_irqs(gpio, pdev); |
|---|
| 1237 | + rc = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio); |
|---|
| 1238 | + if (rc < 0) |
|---|
| 1239 | + return rc; |
|---|
| 1240 | + |
|---|
| 1241 | + return 0; |
|---|
| 1232 | 1242 | } |
|---|
| 1233 | 1243 | |
|---|
| 1234 | 1244 | static struct platform_driver aspeed_gpio_driver = { |
|---|