debug lk

hc

2024-02-20 e636c8d336489bf3eed5878299e6cc045bbad077

 kernel/drivers/usb/host/max3421-hcd.c
..
..
@@ -11,9 +11,9 @@
11
11
  *
12
12
  * Based on:
13
13
  *	o MAX3421E datasheet
14
- *		http://datasheets.maximintegrated.com/en/ds/MAX3421E.pdf
14
+ *		https://datasheets.maximintegrated.com/en/ds/MAX3421E.pdf
15
15
  *	o MAX3421E Programming Guide
16
- *		http://www.hdl.co.jp/ftpdata/utl-001/AN3785.pdf
16
+ *		https://www.hdl.co.jp/ftpdata/utl-001/AN3785.pdf
17
17
  *	o gadget/dummy_hcd.c
18
18
  *		For USB HCD implementation.
19
19
  *	o Arduino MAX3421 driver
..
..
@@ -311,7 +311,7 @@
311
311
 };
312
312
 
313
313
 /*
314
- * See http://www.beyondlogic.org/usbnutshell/usb4.shtml#Control for a
314
+ * See https://www.beyondlogic.org/usbnutshell/usb4.shtml#Control for a
315
315
  * reasonable overview of how control transfers use the the IN/OUT
316
316
  * tokens.
317
317
  */
..
..
@@ -895,7 +895,7 @@
895
895
 			spi_wr8(hcd, MAX3421_REG_HCTL,
896
896
 				BIT(sndtog + MAX3421_HCTL_SNDTOG0_BIT));
897
897
 		}
898
-		/* FALL THROUGH */
898
+		fallthrough;
899
899
 	case MAX3421_HRSL_BADBC:	/* bad byte count */
900
900
 	case MAX3421_HRSL_PIDERR:	/* received PID is corrupted */
901
901
 	case MAX3421_HRSL_PKTERR:	/* packet error (stuff, EOP) */
..
..
@@ -1695,7 +1695,7 @@
1695
1695
 			dev_dbg(hcd->self.controller, "power-off\n");
1696
1696
 			max3421_gpout_set_value(hcd, pdata->vbus_gpout,
1697
1697
 						!pdata->vbus_active_level);
1698
-			/* FALLS THROUGH */
1698
+			fallthrough;
1699
1699
 		default:
1700
1700
 			max3421_hcd->port_status &= ~(1 << value);
1701
1701
 		}
..
..
@@ -1748,7 +1748,7 @@
1748
1748
 			break;
1749
1749
 		case USB_PORT_FEAT_RESET:
1750
1750
 			max3421_reset_port(hcd);
1751
-			/* FALLS THROUGH */
1751
+			fallthrough;
1752
1752
 		default:
1753
1753
 			if ((max3421_hcd->port_status & USB_PORT_STAT_POWER)
1754
1754
 			    != 0)
..
..
@@ -1780,21 +1780,6 @@
1780
1780
 	return -1;
1781
1781
 }
1782
1782
 
1783
-/*
1784
- * The SPI driver already takes care of DMA-mapping/unmapping, so no
1785
- * reason to do it twice.
1786
- */
1787
-static int
1788
-max3421_map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags)
1789
-{
1790
-	return 0;
1791
-}
1792
-
1793
-static void
1794
-max3421_unmap_urb_for_dma(struct usb_hcd *hcd, struct urb *urb)
1795
-{
1796
-}
1797
-
1798
1783
 static const struct hc_driver max3421_hcd_desc = {
1799
1784
 	.description =		"max3421",
1800
1785
 	.product_desc =		DRIVER_DESC,
..
..
@@ -1806,8 +1791,6 @@
1806
1791
 	.get_frame_number =	max3421_get_frame_number,
1807
1792
 	.urb_enqueue =		max3421_urb_enqueue,
1808
1793
 	.urb_dequeue =		max3421_urb_dequeue,
1809
-	.map_urb_for_dma =	max3421_map_urb_for_dma,
1810
-	.unmap_urb_for_dma =	max3421_unmap_urb_for_dma,
1811
1794
 	.endpoint_disable =	max3421_endpoint_disable,
1812
1795
 	.hub_status_data =	max3421_hub_status_data,
1813
1796
 	.hub_control =		max3421_hub_control,