hc
2023-12-11 d2ccde1c8e90d38cee87a1b0309ad2827f3fd30d
kernel/drivers/usb/gadget/udc/udc-xilinx.c
....@@ -1078,7 +1078,7 @@
10781078 unsigned long flags;
10791079
10801080 if (!ep->desc) {
1081
- dev_dbg(udc->dev, "%s:queing request to disabled %s\n",
1081
+ dev_dbg(udc->dev, "%s: queuing request to disabled %s\n",
10821082 __func__, ep->name);
10831083 return -ESHUTDOWN;
10841084 }
....@@ -1399,7 +1399,6 @@
13991399 /**
14001400 * xudc_stop - stops the device.
14011401 * @gadget: pointer to the usb gadget structure
1402
- * @driver: pointer to usb gadget driver structure
14031402 *
14041403 * Return: zero always
14051404 */
....@@ -1739,6 +1738,7 @@
17391738 * Process setup packet and delegate to gadget layer.
17401739 */
17411740 static void xudc_handle_setup(struct xusb_udc *udc)
1741
+ __must_hold(&udc->lock)
17421742 {
17431743 struct xusb_ep *ep0 = &udc->ep[0];
17441744 struct usb_ctrlrequest setup;
....@@ -1960,7 +1960,7 @@
19601960 if (intrstatus & (XUSB_STATUS_EP0_BUFF1_COMP_MASK << epnum))
19611961 ep->buffer0ready = 0;
19621962 if (intrstatus & (XUSB_STATUS_EP0_BUFF2_COMP_MASK << epnum))
1963
- ep->buffer1ready = 0;
1963
+ ep->buffer1ready = false;
19641964
19651965 if (list_empty(&ep->queue))
19661966 return;
....@@ -2080,10 +2080,8 @@
20802080 return PTR_ERR(udc->addr);
20812081
20822082 irq = platform_get_irq(pdev, 0);
2083
- if (irq < 0) {
2084
- dev_err(&pdev->dev, "unable to get irq\n");
2083
+ if (irq < 0)
20852084 return irq;
2086
- }
20872085 ret = devm_request_irq(&pdev->dev, irq, xudc_irq, 0,
20882086 dev_name(&pdev->dev), udc);
20892087 if (ret < 0) {
....@@ -2105,9 +2103,9 @@
21052103 /* Check for IP endianness */
21062104 udc->write_fn = xudc_write32_be;
21072105 udc->read_fn = xudc_read32_be;
2108
- udc->write_fn(udc->addr, XUSB_TESTMODE_OFFSET, TEST_J);
2106
+ udc->write_fn(udc->addr, XUSB_TESTMODE_OFFSET, USB_TEST_J);
21092107 if ((udc->read_fn(udc->addr + XUSB_TESTMODE_OFFSET))
2110
- != TEST_J) {
2108
+ != USB_TEST_J) {
21112109 udc->write_fn = xudc_write32;
21122110 udc->read_fn = xudc_read32;
21132111 }