.. | .. |
---|
1078 | 1078 | unsigned long flags; |
---|
1079 | 1079 | |
---|
1080 | 1080 | if (!ep->desc) { |
---|
1081 | | - dev_dbg(udc->dev, "%s:queing request to disabled %s\n", |
---|
| 1081 | + dev_dbg(udc->dev, "%s: queuing request to disabled %s\n", |
---|
1082 | 1082 | __func__, ep->name); |
---|
1083 | 1083 | return -ESHUTDOWN; |
---|
1084 | 1084 | } |
---|
.. | .. |
---|
1399 | 1399 | /** |
---|
1400 | 1400 | * xudc_stop - stops the device. |
---|
1401 | 1401 | * @gadget: pointer to the usb gadget structure |
---|
1402 | | - * @driver: pointer to usb gadget driver structure |
---|
1403 | 1402 | * |
---|
1404 | 1403 | * Return: zero always |
---|
1405 | 1404 | */ |
---|
.. | .. |
---|
1739 | 1738 | * Process setup packet and delegate to gadget layer. |
---|
1740 | 1739 | */ |
---|
1741 | 1740 | static void xudc_handle_setup(struct xusb_udc *udc) |
---|
| 1741 | + __must_hold(&udc->lock) |
---|
1742 | 1742 | { |
---|
1743 | 1743 | struct xusb_ep *ep0 = &udc->ep[0]; |
---|
1744 | 1744 | struct usb_ctrlrequest setup; |
---|
.. | .. |
---|
1960 | 1960 | if (intrstatus & (XUSB_STATUS_EP0_BUFF1_COMP_MASK << epnum)) |
---|
1961 | 1961 | ep->buffer0ready = 0; |
---|
1962 | 1962 | if (intrstatus & (XUSB_STATUS_EP0_BUFF2_COMP_MASK << epnum)) |
---|
1963 | | - ep->buffer1ready = 0; |
---|
| 1963 | + ep->buffer1ready = false; |
---|
1964 | 1964 | |
---|
1965 | 1965 | if (list_empty(&ep->queue)) |
---|
1966 | 1966 | return; |
---|
.. | .. |
---|
2080 | 2080 | return PTR_ERR(udc->addr); |
---|
2081 | 2081 | |
---|
2082 | 2082 | irq = platform_get_irq(pdev, 0); |
---|
2083 | | - if (irq < 0) { |
---|
2084 | | - dev_err(&pdev->dev, "unable to get irq\n"); |
---|
| 2083 | + if (irq < 0) |
---|
2085 | 2084 | return irq; |
---|
2086 | | - } |
---|
2087 | 2085 | ret = devm_request_irq(&pdev->dev, irq, xudc_irq, 0, |
---|
2088 | 2086 | dev_name(&pdev->dev), udc); |
---|
2089 | 2087 | if (ret < 0) { |
---|
.. | .. |
---|
2105 | 2103 | /* Check for IP endianness */ |
---|
2106 | 2104 | udc->write_fn = xudc_write32_be; |
---|
2107 | 2105 | udc->read_fn = xudc_read32_be; |
---|
2108 | | - udc->write_fn(udc->addr, XUSB_TESTMODE_OFFSET, TEST_J); |
---|
| 2106 | + udc->write_fn(udc->addr, XUSB_TESTMODE_OFFSET, USB_TEST_J); |
---|
2109 | 2107 | if ((udc->read_fn(udc->addr + XUSB_TESTMODE_OFFSET)) |
---|
2110 | | - != TEST_J) { |
---|
| 2108 | + != USB_TEST_J) { |
---|
2111 | 2109 | udc->write_fn = xudc_write32; |
---|
2112 | 2110 | udc->read_fn = xudc_read32; |
---|
2113 | 2111 | } |
---|