hc
2024-05-14 bedbef8ad3e75a304af6361af235302bcc61d06b
kernel/drivers/watchdog/st_lpc_wdt.c
....@@ -142,13 +142,18 @@
142142 .ops = &st_wdog_ops,
143143 };
144144
145
+static void st_clk_disable_unprepare(void *data)
146
+{
147
+ clk_disable_unprepare(data);
148
+}
149
+
145150 static int st_wdog_probe(struct platform_device *pdev)
146151 {
152
+ struct device *dev = &pdev->dev;
147153 const struct of_device_id *match;
148
- struct device_node *np = pdev->dev.of_node;
154
+ struct device_node *np = dev->of_node;
149155 struct st_wdog *st_wdog;
150156 struct regmap *regmap;
151
- struct resource *res;
152157 struct clk *clk;
153158 void __iomem *base;
154159 uint32_t mode;
....@@ -156,7 +161,7 @@
156161
157162 ret = of_property_read_u32(np, "st,lpc-mode", &mode);
158163 if (ret) {
159
- dev_err(&pdev->dev, "An LPC mode must be provided\n");
164
+ dev_err(dev, "An LPC mode must be provided\n");
160165 return -EINVAL;
161166 }
162167
....@@ -164,35 +169,34 @@
164169 if (mode != ST_LPC_MODE_WDT)
165170 return -ENODEV;
166171
167
- st_wdog = devm_kzalloc(&pdev->dev, sizeof(*st_wdog), GFP_KERNEL);
172
+ st_wdog = devm_kzalloc(dev, sizeof(*st_wdog), GFP_KERNEL);
168173 if (!st_wdog)
169174 return -ENOMEM;
170175
171
- match = of_match_device(st_wdog_match, &pdev->dev);
176
+ match = of_match_device(st_wdog_match, dev);
172177 if (!match) {
173
- dev_err(&pdev->dev, "Couldn't match device\n");
178
+ dev_err(dev, "Couldn't match device\n");
174179 return -ENODEV;
175180 }
176181 st_wdog->syscfg = (struct st_wdog_syscfg *)match->data;
177182
178
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
179
- base = devm_ioremap_resource(&pdev->dev, res);
183
+ base = devm_platform_ioremap_resource(pdev, 0);
180184 if (IS_ERR(base))
181185 return PTR_ERR(base);
182186
183187 regmap = syscon_regmap_lookup_by_phandle(np, "st,syscfg");
184188 if (IS_ERR(regmap)) {
185
- dev_err(&pdev->dev, "No syscfg phandle specified\n");
189
+ dev_err(dev, "No syscfg phandle specified\n");
186190 return PTR_ERR(regmap);
187191 }
188192
189
- clk = devm_clk_get(&pdev->dev, NULL);
193
+ clk = devm_clk_get(dev, NULL);
190194 if (IS_ERR(clk)) {
191
- dev_err(&pdev->dev, "Unable to request clock\n");
195
+ dev_err(dev, "Unable to request clock\n");
192196 return PTR_ERR(clk);
193197 }
194198
195
- st_wdog->dev = &pdev->dev;
199
+ st_wdog->dev = dev;
196200 st_wdog->base = base;
197201 st_wdog->clk = clk;
198202 st_wdog->regmap = regmap;
....@@ -200,39 +204,36 @@
200204 st_wdog->clkrate = clk_get_rate(st_wdog->clk);
201205
202206 if (!st_wdog->clkrate) {
203
- dev_err(&pdev->dev, "Unable to fetch clock rate\n");
207
+ dev_err(dev, "Unable to fetch clock rate\n");
204208 return -EINVAL;
205209 }
206210 st_wdog_dev.max_timeout = 0xFFFFFFFF / st_wdog->clkrate;
207
- st_wdog_dev.parent = &pdev->dev;
211
+ st_wdog_dev.parent = dev;
208212
209213 ret = clk_prepare_enable(clk);
210214 if (ret) {
211
- dev_err(&pdev->dev, "Unable to enable clock\n");
215
+ dev_err(dev, "Unable to enable clock\n");
212216 return ret;
213217 }
218
+ ret = devm_add_action_or_reset(dev, st_clk_disable_unprepare, clk);
219
+ if (ret)
220
+ return ret;
214221
215222 watchdog_set_drvdata(&st_wdog_dev, st_wdog);
216223 watchdog_set_nowayout(&st_wdog_dev, WATCHDOG_NOWAYOUT);
217224
218225 /* Init Watchdog timeout with value in DT */
219
- ret = watchdog_init_timeout(&st_wdog_dev, 0, &pdev->dev);
220
- if (ret) {
221
- dev_err(&pdev->dev, "Unable to initialise watchdog timeout\n");
222
- clk_disable_unprepare(clk);
226
+ ret = watchdog_init_timeout(&st_wdog_dev, 0, dev);
227
+ if (ret)
223228 return ret;
224
- }
225229
226
- ret = watchdog_register_device(&st_wdog_dev);
227
- if (ret) {
228
- dev_err(&pdev->dev, "Unable to register watchdog\n");
229
- clk_disable_unprepare(clk);
230
+ ret = devm_watchdog_register_device(dev, &st_wdog_dev);
231
+ if (ret)
230232 return ret;
231
- }
232233
233234 st_wdog_setup(st_wdog, true);
234235
235
- dev_info(&pdev->dev, "LPC Watchdog driver registered, reset type is %s",
236
+ dev_info(dev, "LPC Watchdog driver registered, reset type is %s",
236237 st_wdog->warm_reset ? "warm" : "cold");
237238
238239 return ret;
....@@ -243,8 +244,6 @@
243244 struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev);
244245
245246 st_wdog_setup(st_wdog, false);
246
- watchdog_unregister_device(&st_wdog_dev);
247
- clk_disable_unprepare(st_wdog->clk);
248247
249248 return 0;
250249 }