hc
2024-05-14 bedbef8ad3e75a304af6361af235302bcc61d06b
kernel/drivers/media/i2c/adv7511-v4l2.c
....@@ -470,7 +470,7 @@
470470 reg->val = adv7511_cec_read(sd, reg->reg & 0xff);
471471 break;
472472 }
473
- /* fall through */
473
+ fallthrough;
474474 default:
475475 v4l2_info(sd, "Register %03llx not supported\n", reg->reg);
476476 adv7511_inv_register(sd);
....@@ -492,7 +492,7 @@
492492 adv7511_cec_write(sd, reg->reg & 0xff, reg->val & 0xff);
493493 break;
494494 }
495
- /* fall through */
495
+ fallthrough;
496496 default:
497497 v4l2_info(sd, "Register %03llx not supported\n", reg->reg);
498498 adv7511_inv_register(sd);
....@@ -555,7 +555,7 @@
555555 buffer[3] = 0;
556556 buffer[3] = hdmi_infoframe_checksum(buffer, len + 4);
557557
558
- if (hdmi_infoframe_unpack(&frame, buffer, sizeof(buffer)) < 0) {
558
+ if (hdmi_infoframe_unpack(&frame, buffer, len + 4) < 0) {
559559 v4l2_err(sd, "%s: unpack of %s infoframe failed\n", __func__, cri->desc);
560560 return;
561561 }
....@@ -1872,11 +1872,11 @@
18721872 goto err_entity;
18731873 }
18741874
1875
- state->i2c_edid = i2c_new_dummy(client->adapter,
1875
+ state->i2c_edid = i2c_new_dummy_device(client->adapter,
18761876 state->i2c_edid_addr >> 1);
1877
- if (state->i2c_edid == NULL) {
1877
+ if (IS_ERR(state->i2c_edid)) {
18781878 v4l2_err(sd, "failed to register edid i2c client\n");
1879
- err = -ENOMEM;
1879
+ err = PTR_ERR(state->i2c_edid);
18801880 goto err_entity;
18811881 }
18821882
....@@ -1889,11 +1889,11 @@
18891889 }
18901890
18911891 if (state->pdata.cec_clk) {
1892
- state->i2c_cec = i2c_new_dummy(client->adapter,
1892
+ state->i2c_cec = i2c_new_dummy_device(client->adapter,
18931893 state->i2c_cec_addr >> 1);
1894
- if (state->i2c_cec == NULL) {
1894
+ if (IS_ERR(state->i2c_cec)) {
18951895 v4l2_err(sd, "failed to register cec i2c client\n");
1896
- err = -ENOMEM;
1896
+ err = PTR_ERR(state->i2c_cec);
18971897 goto err_unreg_edid;
18981898 }
18991899 adv7511_wr(sd, 0xe2, 0x00); /* power up cec section */
....@@ -1901,10 +1901,10 @@
19011901 adv7511_wr(sd, 0xe2, 0x01); /* power down cec section */
19021902 }
19031903
1904
- state->i2c_pktmem = i2c_new_dummy(client->adapter, state->i2c_pktmem_addr >> 1);
1905
- if (state->i2c_pktmem == NULL) {
1904
+ state->i2c_pktmem = i2c_new_dummy_device(client->adapter, state->i2c_pktmem_addr >> 1);
1905
+ if (IS_ERR(state->i2c_pktmem)) {
19061906 v4l2_err(sd, "failed to register pktmem i2c client\n");
1907
- err = -ENOMEM;
1907
+ err = PTR_ERR(state->i2c_pktmem);
19081908 goto err_unreg_cec;
19091909 }
19101910
....@@ -1940,8 +1940,7 @@
19401940 err_unreg_pktmem:
19411941 i2c_unregister_device(state->i2c_pktmem);
19421942 err_unreg_cec:
1943
- if (state->i2c_cec)
1944
- i2c_unregister_device(state->i2c_cec);
1943
+ i2c_unregister_device(state->i2c_cec);
19451944 err_unreg_edid:
19461945 i2c_unregister_device(state->i2c_edid);
19471946 err_entity:
....@@ -1967,8 +1966,7 @@
19671966 adv7511_init_setup(sd);
19681967 cancel_delayed_work_sync(&state->edid_handler);
19691968 i2c_unregister_device(state->i2c_edid);
1970
- if (state->i2c_cec)
1971
- i2c_unregister_device(state->i2c_cec);
1969
+ i2c_unregister_device(state->i2c_cec);
19721970 i2c_unregister_device(state->i2c_pktmem);
19731971 destroy_workqueue(state->work_queue);
19741972 v4l2_device_unregister_subdev(sd);
....@@ -1980,14 +1978,14 @@
19801978 /* ----------------------------------------------------------------------- */
19811979
19821980 static const struct i2c_device_id adv7511_id[] = {
1983
- { "adv7511", 0 },
1981
+ { "adv7511-v4l2", 0 },
19841982 { }
19851983 };
19861984 MODULE_DEVICE_TABLE(i2c, adv7511_id);
19871985
19881986 static struct i2c_driver adv7511_driver = {
19891987 .driver = {
1990
- .name = "adv7511",
1988
+ .name = "adv7511-v4l2",
19911989 },
19921990 .probe = adv7511_probe,
19931991 .remove = adv7511_remove,