hc
2023-12-09 b22da3d8526a935aa31e086e63f60ff3246cb61c
kernel/kernel/fork.c
....@@ -1,3 +1,4 @@
1
+// SPDX-License-Identifier: GPL-2.0-only
12 /*
23 * linux/kernel/fork.c
34 *
....@@ -39,7 +40,6 @@
3940 #include <linux/binfmts.h>
4041 #include <linux/mman.h>
4142 #include <linux/mmu_notifier.h>
42
-#include <linux/hmm.h>
4343 #include <linux/fs.h>
4444 #include <linux/mm.h>
4545 #include <linux/kprobes.h>
....@@ -80,7 +80,6 @@
8080 #include <linux/blkdev.h>
8181 #include <linux/fs_struct.h>
8282 #include <linux/magic.h>
83
-#include <linux/sched/mm.h>
8483 #include <linux/perf_event.h>
8584 #include <linux/posix-timers.h>
8685 #include <linux/user-return-notifier.h>
....@@ -94,10 +93,12 @@
9493 #include <linux/kcov.h>
9594 #include <linux/livepatch.h>
9695 #include <linux/thread_info.h>
97
-#include <linux/cpufreq_times.h>
96
+#include <linux/stackleak.h>
97
+#include <linux/kasan.h>
9898 #include <linux/scs.h>
99
+#include <linux/io_uring.h>
100
+#include <linux/cpufreq_times.h>
99101
100
-#include <asm/pgtable.h>
101102 #include <asm/pgalloc.h>
102103 #include <linux/uaccess.h>
103104 #include <asm/mmu_context.h>
....@@ -109,6 +110,8 @@
109110 #define CREATE_TRACE_POINTS
110111 #include <trace/events/task.h>
111112
113
+#undef CREATE_TRACE_POINTS
114
+#include <trace/hooks/sched.h>
112115 /*
113116 * Minimum number of threads to boot the kernel
114117 */
....@@ -119,17 +122,29 @@
119122 */
120123 #define MAX_THREADS FUTEX_TID_MASK
121124
125
+EXPORT_TRACEPOINT_SYMBOL_GPL(task_newtask);
126
+
122127 /*
123128 * Protected counters by write_lock_irq(&tasklist_lock)
124129 */
125130 unsigned long total_forks; /* Handle normal Linux uptimes. */
126131 int nr_threads; /* The idle threads do not count.. */
127132
128
-int max_threads; /* tunable limit on nr_threads */
133
+static int max_threads; /* tunable limit on nr_threads */
134
+
135
+#define NAMED_ARRAY_INDEX(x) [x] = __stringify(x)
136
+
137
+static const char * const resident_page_types[] = {
138
+ NAMED_ARRAY_INDEX(MM_FILEPAGES),
139
+ NAMED_ARRAY_INDEX(MM_ANONPAGES),
140
+ NAMED_ARRAY_INDEX(MM_SWAPENTS),
141
+ NAMED_ARRAY_INDEX(MM_SHMEMPAGES),
142
+};
129143
130144 DEFINE_PER_CPU(unsigned long, process_counts) = 0;
131145
132146 __cacheline_aligned DEFINE_RWLOCK(tasklist_lock); /* outer */
147
+EXPORT_SYMBOL_GPL(tasklist_lock);
133148
134149 #ifdef CONFIG_PROVE_RCU
135150 int lockdep_tasklist_lock_is_held(void)
....@@ -217,6 +232,9 @@
217232 if (!s)
218233 continue;
219234
235
+ /* Mark stack accessible for KASAN. */
236
+ kasan_unpoison_range(s->addr, THREAD_SIZE);
237
+
220238 /* Clear stale pointers from reused stack. */
221239 memset(s->addr, 0, THREAD_SIZE);
222240
....@@ -225,9 +243,14 @@
225243 return s->addr;
226244 }
227245
246
+ /*
247
+ * Allocated stacks are cached and later reused by new threads,
248
+ * so memcg accounting is performed manually on assigning/releasing
249
+ * stacks to tasks. Drop __GFP_ACCOUNT.
250
+ */
228251 stack = __vmalloc_node_range(THREAD_SIZE, THREAD_ALIGN,
229252 VMALLOC_START, VMALLOC_END,
230
- THREADINFO_GFP,
253
+ THREADINFO_GFP & ~__GFP_ACCOUNT,
231254 PAGE_KERNEL,
232255 0, node, __builtin_return_address(0));
233256
....@@ -246,7 +269,7 @@
246269 THREAD_SIZE_ORDER);
247270
248271 if (likely(page)) {
249
- tsk->stack = page_address(page);
272
+ tsk->stack = kasan_reset_tag(page_address(page));
250273 return tsk->stack;
251274 }
252275 return NULL;
....@@ -256,8 +279,13 @@
256279 static inline void free_thread_stack(struct task_struct *tsk)
257280 {
258281 #ifdef CONFIG_VMAP_STACK
259
- if (task_stack_vm_area(tsk)) {
282
+ struct vm_struct *vm = task_stack_vm_area(tsk);
283
+
284
+ if (vm) {
260285 int i;
286
+
287
+ for (i = 0; i < THREAD_SIZE / PAGE_SIZE; i++)
288
+ memcg_kmem_uncharge_page(vm->pages[i], 0);
261289
262290 for (i = 0; i < NR_CACHED_STACKS; i++) {
263291 if (this_cpu_cmpxchg(cached_stacks[i],
....@@ -267,7 +295,7 @@
267295 return;
268296 }
269297
270
- vfree_atomic(tsk->stack);
298
+ vfree(tsk->stack);
271299 return;
272300 }
273301 #endif
....@@ -282,6 +310,7 @@
282310 {
283311 unsigned long *stack;
284312 stack = kmem_cache_alloc_node(thread_stack_cache, THREADINFO_GFP, node);
313
+ stack = kasan_reset_tag(stack);
285314 tsk->stack = stack;
286315 return stack;
287316 }
....@@ -334,8 +363,15 @@
334363 struct vm_area_struct *new = kmem_cache_alloc(vm_area_cachep, GFP_KERNEL);
335364
336365 if (new) {
337
- *new = *orig;
338
- INIT_LIST_HEAD(&new->anon_vma_chain);
366
+ ASSERT_EXCLUSIVE_WRITER(orig->vm_flags);
367
+ ASSERT_EXCLUSIVE_WRITER(orig->vm_file);
368
+ /*
369
+ * orig->shared.rb may be modified concurrently, but the clone
370
+ * will be reinitialized.
371
+ */
372
+ *new = data_race(*orig);
373
+ INIT_VMA(new);
374
+ new->vm_next = new->vm_prev = NULL;
339375 }
340376 return new;
341377 }
....@@ -350,6 +386,22 @@
350386 void *stack = task_stack_page(tsk);
351387 struct vm_struct *vm = task_stack_vm_area(tsk);
352388
389
+
390
+ /* All stack pages are in the same node. */
391
+ if (vm)
392
+ mod_lruvec_page_state(vm->pages[0], NR_KERNEL_STACK_KB,
393
+ account * (THREAD_SIZE / 1024));
394
+ else
395
+ mod_lruvec_slab_state(stack, NR_KERNEL_STACK_KB,
396
+ account * (THREAD_SIZE / 1024));
397
+}
398
+
399
+static int memcg_charge_kernel_stack(struct task_struct *tsk)
400
+{
401
+#ifdef CONFIG_VMAP_STACK
402
+ struct vm_struct *vm = task_stack_vm_area(tsk);
403
+ int ret;
404
+
353405 BUILD_BUG_ON(IS_ENABLED(CONFIG_VMAP_STACK) && PAGE_SIZE % 1024 != 0);
354406
355407 if (vm) {
....@@ -358,27 +410,19 @@
358410 BUG_ON(vm->nr_pages != THREAD_SIZE / PAGE_SIZE);
359411
360412 for (i = 0; i < THREAD_SIZE / PAGE_SIZE; i++) {
361
- mod_zone_page_state(page_zone(vm->pages[i]),
362
- NR_KERNEL_STACK_KB,
363
- PAGE_SIZE / 1024 * account);
413
+ /*
414
+ * If memcg_kmem_charge_page() fails, page->mem_cgroup
415
+ * pointer is NULL, and memcg_kmem_uncharge_page() in
416
+ * free_thread_stack() will ignore this page.
417
+ */
418
+ ret = memcg_kmem_charge_page(vm->pages[i], GFP_KERNEL,
419
+ 0);
420
+ if (ret)
421
+ return ret;
364422 }
365
-
366
- /* All stack pages belong to the same memcg. */
367
- mod_memcg_page_state(vm->pages[0], MEMCG_KERNEL_STACK_KB,
368
- account * (THREAD_SIZE / 1024));
369
- } else {
370
- /*
371
- * All stack pages are in the same zone and belong to the
372
- * same memcg.
373
- */
374
- struct page *first_page = virt_to_page(stack);
375
-
376
- mod_zone_page_state(page_zone(first_page), NR_KERNEL_STACK_KB,
377
- THREAD_SIZE / 1024 * account);
378
-
379
- mod_memcg_page_state(first_page, MEMCG_KERNEL_STACK_KB,
380
- account * (THREAD_SIZE / 1024));
381423 }
424
+#endif
425
+ return 0;
382426 }
383427
384428 static void release_task_stack(struct task_struct *tsk)
....@@ -397,9 +441,10 @@
397441 #ifdef CONFIG_THREAD_INFO_IN_TASK
398442 void put_task_stack(struct task_struct *tsk)
399443 {
400
- if (atomic_dec_and_test(&tsk->stack_refcount))
444
+ if (refcount_dec_and_test(&tsk->stack_refcount))
401445 release_task_stack(tsk);
402446 }
447
+EXPORT_SYMBOL_GPL(put_task_stack);
403448 #endif
404449
405450 void free_task(struct task_struct *tsk)
....@@ -407,6 +452,7 @@
407452 cpufreq_task_times_exit(tsk);
408453 scs_release(tsk);
409454
455
+ trace_android_vh_free_task(tsk);
410456 #ifndef CONFIG_THREAD_INFO_IN_TASK
411457 /*
412458 * The task is finally done with both the stack and thread_info,
....@@ -418,11 +464,10 @@
418464 * If the task had a separate stack allocation, it should be gone
419465 * by now.
420466 */
421
- WARN_ON_ONCE(atomic_read(&tsk->stack_refcount) != 0);
467
+ WARN_ON_ONCE(refcount_read(&tsk->stack_refcount) != 0);
422468 #endif
423469 rt_mutex_debug_task_free(tsk);
424470 ftrace_graph_exit_task(tsk);
425
- put_seccomp_filter(tsk);
426471 arch_release_task_struct(tsk);
427472 if (tsk->flags & PF_KTHREAD)
428473 free_kthread_struct(tsk);
....@@ -434,14 +479,14 @@
434479 static __latent_entropy int dup_mmap(struct mm_struct *mm,
435480 struct mm_struct *oldmm)
436481 {
437
- struct vm_area_struct *mpnt, *tmp, *prev, **pprev;
482
+ struct vm_area_struct *mpnt, *tmp, *prev, **pprev, *last = NULL;
438483 struct rb_node **rb_link, *rb_parent;
439484 int retval;
440485 unsigned long charge;
441486 LIST_HEAD(uf);
442487
443488 uprobe_start_dup_mmap();
444
- if (down_write_killable(&oldmm->mmap_sem)) {
489
+ if (mmap_write_lock_killable(oldmm)) {
445490 retval = -EINTR;
446491 goto fail_uprobe_end;
447492 }
....@@ -450,7 +495,7 @@
450495 /*
451496 * Not linked in yet - no deadlock potential:
452497 */
453
- down_write_nested(&mm->mmap_sem, SINGLE_DEPTH_NESTING);
498
+ mmap_write_lock_nested(mm, SINGLE_DEPTH_NESTING);
454499
455500 /* No ordering required: file already has been exposed. */
456501 RCU_INIT_POINTER(mm->exe_file, get_mm_exe_file(oldmm));
....@@ -505,14 +550,15 @@
505550 if (retval)
506551 goto fail_nomem_anon_vma_fork;
507552 if (tmp->vm_flags & VM_WIPEONFORK) {
508
- /* VM_WIPEONFORK gets a clean slate in the child. */
553
+ /*
554
+ * VM_WIPEONFORK gets a clean slate in the child.
555
+ * Don't prepare anon_vma until fault since we don't
556
+ * copy page for current vma.
557
+ */
509558 tmp->anon_vma = NULL;
510
- if (anon_vma_prepare(tmp))
511
- goto fail_nomem_anon_vma_fork;
512559 } else if (anon_vma_fork(tmp, mpnt))
513560 goto fail_nomem_anon_vma_fork;
514561 tmp->vm_flags &= ~(VM_LOCKED | VM_LOCKONFAULT);
515
- tmp->vm_next = tmp->vm_prev = NULL;
516562 file = tmp->vm_file;
517563 if (file) {
518564 struct inode *inode = file_inode(file);
....@@ -520,10 +566,10 @@
520566
521567 get_file(file);
522568 if (tmp->vm_flags & VM_DENYWRITE)
523
- atomic_dec(&inode->i_writecount);
569
+ put_write_access(inode);
524570 i_mmap_lock_write(mapping);
525571 if (tmp->vm_flags & VM_SHARED)
526
- atomic_inc(&mapping->i_mmap_writable);
572
+ mapping_allow_writable(mapping);
527573 flush_dcache_mmap_lock(mapping);
528574 /* insert tmp into the share list, just after mpnt */
529575 vma_interval_tree_insert_after(tmp, mpnt,
....@@ -553,8 +599,18 @@
553599 rb_parent = &tmp->vm_rb;
554600
555601 mm->map_count++;
556
- if (!(tmp->vm_flags & VM_WIPEONFORK))
557
- retval = copy_page_range(mm, oldmm, mpnt);
602
+ if (!(tmp->vm_flags & VM_WIPEONFORK)) {
603
+ if (IS_ENABLED(CONFIG_SPECULATIVE_PAGE_FAULT)) {
604
+ /*
605
+ * Mark this VMA as changing to prevent the
606
+ * speculative page fault hanlder to process
607
+ * it until the TLB are flushed below.
608
+ */
609
+ last = mpnt;
610
+ vm_write_begin(mpnt);
611
+ }
612
+ retval = copy_page_range(tmp, mpnt);
613
+ }
558614
559615 if (tmp->vm_ops && tmp->vm_ops->open)
560616 tmp->vm_ops->open(tmp);
....@@ -565,9 +621,25 @@
565621 /* a new mm has just been created */
566622 retval = arch_dup_mmap(oldmm, mm);
567623 out:
568
- up_write(&mm->mmap_sem);
624
+ mmap_write_unlock(mm);
569625 flush_tlb_mm(oldmm);
570
- up_write(&oldmm->mmap_sem);
626
+
627
+ if (IS_ENABLED(CONFIG_SPECULATIVE_PAGE_FAULT)) {
628
+ /*
629
+ * Since the TLB has been flush, we can safely unmark the
630
+ * copied VMAs and allows the speculative page fault handler to
631
+ * process them again.
632
+ * Walk back the VMA list from the last marked VMA.
633
+ */
634
+ for (; last; last = last->vm_prev) {
635
+ if (last->vm_flags & VM_DONTCOPY)
636
+ continue;
637
+ if (!(last->vm_flags & VM_WIPEONFORK))
638
+ vm_write_end(last);
639
+ }
640
+ }
641
+
642
+ mmap_write_unlock(oldmm);
571643 dup_userfaultfd_complete(&uf);
572644 fail_uprobe_end:
573645 uprobe_end_dup_mmap();
....@@ -597,9 +669,9 @@
597669 #else
598670 static int dup_mmap(struct mm_struct *mm, struct mm_struct *oldmm)
599671 {
600
- down_write(&oldmm->mmap_sem);
672
+ mmap_write_lock(oldmm);
601673 RCU_INIT_POINTER(mm->exe_file, get_mm_exe_file(oldmm));
602
- up_write(&oldmm->mmap_sem);
674
+ mmap_write_unlock(oldmm);
603675 return 0;
604676 }
605677 #define mm_alloc_pgd(mm) (0)
....@@ -610,12 +682,15 @@
610682 {
611683 int i;
612684
685
+ BUILD_BUG_ON_MSG(ARRAY_SIZE(resident_page_types) != NR_MM_COUNTERS,
686
+ "Please make sure 'struct resident_page_types[]' is updated as well");
687
+
613688 for (i = 0; i < NR_MM_COUNTERS; i++) {
614689 long x = atomic_long_read(&mm->rss_stat.count[i]);
615690
616691 if (unlikely(x))
617
- printk(KERN_ALERT "BUG: Bad rss-counter state "
618
- "mm:%p idx:%d val:%ld\n", mm, i, x);
692
+ pr_alert("BUG: Bad rss-counter state mm:%p type:%s val:%ld\n",
693
+ mm, resident_page_types[i], x);
619694 }
620695
621696 if (mm_pgtables_bytes(mm))
....@@ -642,15 +717,14 @@
642717 WARN_ON_ONCE(mm == current->active_mm);
643718 mm_free_pgd(mm);
644719 destroy_context(mm);
645
- hmm_mm_destroy(mm);
646
- mmu_notifier_mm_destroy(mm);
720
+ mmu_notifier_subscriptions_destroy(mm);
647721 check_mm(mm);
648722 put_user_ns(mm->user_ns);
649723 free_mm(mm);
650724 }
651725 EXPORT_SYMBOL_GPL(__mmdrop);
652726
653
-#ifdef CONFIG_PREEMPT_RT_BASE
727
+#ifdef CONFIG_PREEMPT_RT
654728 /*
655729 * RCU callback for delayed mm drop. Not strictly rcu, but we don't
656730 * want another facility to make this work.
....@@ -694,16 +768,14 @@
694768
695769 static inline void put_signal_struct(struct signal_struct *sig)
696770 {
697
- if (atomic_dec_and_test(&sig->sigcnt))
771
+ if (refcount_dec_and_test(&sig->sigcnt))
698772 free_signal_struct(sig);
699773 }
700
-#ifdef CONFIG_PREEMPT_RT_BASE
701
-static
702
-#endif
774
+
703775 void __put_task_struct(struct task_struct *tsk)
704776 {
705777 WARN_ON(!tsk->exit_state);
706
- WARN_ON(atomic_read(&tsk->usage));
778
+ WARN_ON(refcount_read(&tsk->usage));
707779 WARN_ON(tsk == current);
708780
709781 /*
....@@ -715,6 +787,7 @@
715787 /* Task is done with its stack. */
716788 put_task_stack(tsk);
717789
790
+ io_uring_free(tsk);
718791 cgroup_free(tsk);
719792 task_numa_free(tsk, true);
720793 security_task_free(tsk);
....@@ -725,18 +798,7 @@
725798 if (!profile_handoff_task(tsk))
726799 free_task(tsk);
727800 }
728
-#ifndef CONFIG_PREEMPT_RT_BASE
729801 EXPORT_SYMBOL_GPL(__put_task_struct);
730
-#else
731
-void __put_task_struct_cb(struct rcu_head *rhp)
732
-{
733
- struct task_struct *tsk = container_of(rhp, struct task_struct, put_rcu);
734
-
735
- __put_task_struct(tsk);
736
-
737
-}
738
-EXPORT_SYMBOL_GPL(__put_task_struct_cb);
739
-#endif
740802
741803 void __init __weak arch_task_cache_init(void) { }
742804
....@@ -746,15 +808,16 @@
746808 static void set_max_threads(unsigned int max_threads_suggested)
747809 {
748810 u64 threads;
811
+ unsigned long nr_pages = totalram_pages();
749812
750813 /*
751814 * The number of threads shall be limited such that the thread
752815 * structures may only consume a small part of the available memory.
753816 */
754
- if (fls64(totalram_pages) + fls64(PAGE_SIZE) > 64)
817
+ if (fls64(nr_pages) + fls64(PAGE_SIZE) > 64)
755818 threads = MAX_THREADS;
756819 else
757
- threads = div64_u64((u64) totalram_pages * (u64) PAGE_SIZE,
820
+ threads = div64_u64((u64) nr_pages * (u64) PAGE_SIZE,
758821 (u64) THREAD_SIZE * 8UL);
759822
760823 if (threads > max_threads_suggested)
....@@ -768,6 +831,7 @@
768831 int arch_task_struct_size __read_mostly;
769832 #endif
770833
834
+#ifndef CONFIG_ARCH_TASK_STRUCT_ALLOCATOR
771835 static void task_struct_whitelist(unsigned long *offset, unsigned long *size)
772836 {
773837 /* Fetch thread_struct whitelist for the architecture. */
....@@ -782,6 +846,7 @@
782846 else
783847 *offset += offsetof(struct task_struct, thread);
784848 }
849
+#endif /* CONFIG_ARCH_TASK_STRUCT_ALLOCATOR */
785850
786851 void __init fork_init(void)
787852 {
....@@ -823,6 +888,7 @@
823888 scs_init();
824889
825890 lockdep_init_task(&init_task);
891
+ uprobes_init();
826892 }
827893
828894 int __weak arch_dup_task_struct(struct task_struct *dst,
....@@ -844,7 +910,7 @@
844910 {
845911 struct task_struct *tsk;
846912 unsigned long *stack;
847
- struct vm_struct *stack_vm_area;
913
+ struct vm_struct *stack_vm_area __maybe_unused;
848914 int err;
849915
850916 if (node == NUMA_NO_NODE)
....@@ -856,6 +922,9 @@
856922 stack = alloc_thread_stack_node(tsk, node);
857923 if (!stack)
858924 goto free_tsk;
925
+
926
+ if (memcg_charge_kernel_stack(tsk))
927
+ goto free_stack;
859928
860929 stack_vm_area = task_stack_vm_area(tsk);
861930
....@@ -871,7 +940,7 @@
871940 tsk->stack_vm_area = stack_vm_area;
872941 #endif
873942 #ifdef CONFIG_THREAD_INFO_IN_TASK
874
- atomic_set(&tsk->stack_refcount, 1);
943
+ refcount_set(&tsk->stack_refcount, 1);
875944 #endif
876945
877946 if (err)
....@@ -903,10 +972,12 @@
903972 tsk->cpus_ptr = &tsk->cpus_mask;
904973
905974 /*
906
- * One for us, one for whoever does the "release_task()" (usually
907
- * parent)
975
+ * One for the user space visible state that goes away when reaped.
976
+ * One for the scheduler.
908977 */
909
- atomic_set(&tsk->usage, 2);
978
+ refcount_set(&tsk->rcu_users, 2);
979
+ /* One for the rcu users */
980
+ refcount_set(&tsk->usage, 1);
910981 #ifdef CONFIG_BLK_DEV_IO_TRACE
911982 tsk->btrace_seq = 0;
912983 #endif
....@@ -914,10 +985,12 @@
914985 tsk->task_frag.page = NULL;
915986 tsk->wake_q.next = NULL;
916987 tsk->wake_q_sleeper.next = NULL;
988
+ tsk->pf_io_worker = NULL;
917989
918990 account_kernel_stack(tsk, 1);
919991
920992 kcov_task_init(tsk);
993
+ kmap_local_fork(tsk);
921994
922995 #ifdef CONFIG_FAULT_INJECTION
923996 tsk->fail_nth = 0;
....@@ -931,6 +1004,11 @@
9311004 #ifdef CONFIG_MEMCG
9321005 tsk->active_memcg = NULL;
9331006 #endif
1007
+
1008
+ android_init_vendor_data(tsk, 1);
1009
+ android_init_oem_data(tsk, 1);
1010
+
1011
+ trace_android_vh_dup_task_struct(tsk, orig);
9341012 return tsk;
9351013
9361014 free_stack:
....@@ -980,6 +1058,13 @@
9801058 #endif
9811059 }
9821060
1061
+static void mm_init_pasid(struct mm_struct *mm)
1062
+{
1063
+#ifdef CONFIG_IOMMU_SUPPORT
1064
+ mm->pasid = INIT_PASID;
1065
+#endif
1066
+}
1067
+
9831068 static void mm_init_uprobes_state(struct mm_struct *mm)
9841069 {
9851070 #ifdef CONFIG_UPROBES
....@@ -993,24 +1078,30 @@
9931078 mm->mmap = NULL;
9941079 mm->mm_rb = RB_ROOT;
9951080 mm->vmacache_seqnum = 0;
1081
+#ifdef CONFIG_SPECULATIVE_PAGE_FAULT
1082
+ rwlock_init(&mm->mm_rb_lock);
1083
+#endif
9961084 atomic_set(&mm->mm_users, 1);
9971085 atomic_set(&mm->mm_count, 1);
998
- init_rwsem(&mm->mmap_sem);
1086
+ seqcount_init(&mm->write_protect_seq);
1087
+ mmap_init_lock(mm);
9991088 INIT_LIST_HEAD(&mm->mmlist);
10001089 mm->core_state = NULL;
10011090 mm_pgtables_bytes_init(mm);
10021091 mm->map_count = 0;
10031092 mm->locked_vm = 0;
1004
- mm->pinned_vm = 0;
1093
+ atomic_set(&mm->has_pinned, 0);
1094
+ atomic64_set(&mm->pinned_vm, 0);
10051095 memset(&mm->rss_stat, 0, sizeof(mm->rss_stat));
10061096 spin_lock_init(&mm->page_table_lock);
10071097 spin_lock_init(&mm->arg_lock);
10081098 mm_init_cpumask(mm);
10091099 mm_init_aio(mm);
10101100 mm_init_owner(mm, p);
1101
+ mm_init_pasid(mm);
10111102 RCU_INIT_POINTER(mm->exe_file, NULL);
1012
- mmu_notifier_mm_init(mm);
1013
- hmm_mm_init(mm);
1103
+ if (!mmu_notifier_subscriptions_init(mm))
1104
+ goto fail_nopgd;
10141105 init_tlb_flush_pending(mm);
10151106 #if defined(CONFIG_TRANSPARENT_HUGEPAGE) && !USE_SPLIT_PMD_PTLOCKS
10161107 mm->pmd_huge_pte = NULL;
....@@ -1085,8 +1176,10 @@
10851176 {
10861177 might_sleep();
10871178
1088
- if (atomic_dec_and_test(&mm->mm_users))
1179
+ if (atomic_dec_and_test(&mm->mm_users)) {
1180
+ trace_android_vh_mmput(NULL);
10891181 __mmput(mm);
1182
+ }
10901183 }
10911184 EXPORT_SYMBOL_GPL(mmput);
10921185
....@@ -1106,6 +1199,7 @@
11061199 schedule_work(&mm->async_put_work);
11071200 }
11081201 }
1202
+EXPORT_SYMBOL_GPL(mmput_async);
11091203 #endif
11101204
11111205 /**
....@@ -1210,7 +1304,7 @@
12101304 struct mm_struct *mm;
12111305 int err;
12121306
1213
- err = mutex_lock_killable(&task->signal->cred_guard_mutex);
1307
+ err = down_read_killable(&task->signal->exec_update_lock);
12141308 if (err)
12151309 return ERR_PTR(err);
12161310
....@@ -1220,7 +1314,7 @@
12201314 mmput(mm);
12211315 mm = ERR_PTR(-EACCES);
12221316 }
1223
- mutex_unlock(&task->signal->cred_guard_mutex);
1317
+ up_read(&task->signal->exec_update_lock);
12241318
12251319 return mm;
12261320 }
....@@ -1318,13 +1412,20 @@
13181412 mm_release(tsk, mm);
13191413 }
13201414
1321
-/*
1322
- * Allocate a new mm structure and copy contents from the
1323
- * mm structure of the passed in task structure.
1415
+/**
1416
+ * dup_mm() - duplicates an existing mm structure
1417
+ * @tsk: the task_struct with which the new mm will be associated.
1418
+ * @oldmm: the mm to duplicate.
1419
+ *
1420
+ * Allocates a new mm structure and duplicates the provided @oldmm structure
1421
+ * content into it.
1422
+ *
1423
+ * Return: the duplicated mm or NULL on failure.
13241424 */
1325
-static struct mm_struct *dup_mm(struct task_struct *tsk)
1425
+static struct mm_struct *dup_mm(struct task_struct *tsk,
1426
+ struct mm_struct *oldmm)
13261427 {
1327
- struct mm_struct *mm, *oldmm = current->mm;
1428
+ struct mm_struct *mm;
13281429 int err;
13291430
13301431 mm = allocate_mm();
....@@ -1392,7 +1493,7 @@
13921493 }
13931494
13941495 retval = -ENOMEM;
1395
- mm = dup_mm(tsk);
1496
+ mm = dup_mm(tsk, current->mm);
13961497 if (!mm)
13971498 goto fail_nomem;
13981499
....@@ -1442,7 +1543,7 @@
14421543 goto out;
14431544 }
14441545
1445
- newf = dup_fd(oldf, &error);
1546
+ newf = dup_fd(oldf, NR_OPEN_MAX, &error);
14461547 if (!newf)
14471548 goto out;
14481549
....@@ -1483,24 +1584,29 @@
14831584 struct sighand_struct *sig;
14841585
14851586 if (clone_flags & CLONE_SIGHAND) {
1486
- atomic_inc(&current->sighand->count);
1587
+ refcount_inc(&current->sighand->count);
14871588 return 0;
14881589 }
14891590 sig = kmem_cache_alloc(sighand_cachep, GFP_KERNEL);
1490
- rcu_assign_pointer(tsk->sighand, sig);
1591
+ RCU_INIT_POINTER(tsk->sighand, sig);
14911592 if (!sig)
14921593 return -ENOMEM;
14931594
1494
- atomic_set(&sig->count, 1);
1595
+ refcount_set(&sig->count, 1);
14951596 spin_lock_irq(&current->sighand->siglock);
14961597 memcpy(sig->action, current->sighand->action, sizeof(sig->action));
14971598 spin_unlock_irq(&current->sighand->siglock);
1599
+
1600
+ /* Reset all signal handler not set to SIG_IGN to SIG_DFL. */
1601
+ if (clone_flags & CLONE_CLEAR_SIGHAND)
1602
+ flush_signal_handlers(tsk, 0);
1603
+
14981604 return 0;
14991605 }
15001606
15011607 void __cleanup_sighand(struct sighand_struct *sighand)
15021608 {
1503
- if (atomic_dec_and_test(&sighand->count)) {
1609
+ if (refcount_dec_and_test(&sighand->count)) {
15041610 signalfd_cleanup(sighand);
15051611 /*
15061612 * sighand_cachep is SLAB_TYPESAFE_BY_RCU so we can free it
....@@ -1510,28 +1616,17 @@
15101616 }
15111617 }
15121618
1513
-#ifdef CONFIG_POSIX_TIMERS
15141619 /*
15151620 * Initialize POSIX timer handling for a thread group.
15161621 */
15171622 static void posix_cpu_timers_init_group(struct signal_struct *sig)
15181623 {
1624
+ struct posix_cputimers *pct = &sig->posix_cputimers;
15191625 unsigned long cpu_limit;
15201626
15211627 cpu_limit = READ_ONCE(sig->rlim[RLIMIT_CPU].rlim_cur);
1522
- if (cpu_limit != RLIM_INFINITY) {
1523
- sig->cputime_expires.prof_exp = cpu_limit * NSEC_PER_SEC;
1524
- sig->cputimer.running = true;
1525
- }
1526
-
1527
- /* The timer lists. */
1528
- INIT_LIST_HEAD(&sig->cpu_timers[0]);
1529
- INIT_LIST_HEAD(&sig->cpu_timers[1]);
1530
- INIT_LIST_HEAD(&sig->cpu_timers[2]);
1628
+ posix_cputimers_group_init(pct, cpu_limit);
15311629 }
1532
-#else
1533
-static inline void posix_cpu_timers_init_group(struct signal_struct *sig) { }
1534
-#endif
15351630
15361631 static int copy_signal(unsigned long clone_flags, struct task_struct *tsk)
15371632 {
....@@ -1547,7 +1642,7 @@
15471642
15481643 sig->nr_threads = 1;
15491644 atomic_set(&sig->live, 1);
1550
- atomic_set(&sig->sigcnt, 1);
1645
+ refcount_set(&sig->sigcnt, 1);
15511646
15521647 /* list_add(thread_node, thread_head) without INIT_LIST_HEAD() */
15531648 sig->thread_head = (struct list_head)LIST_HEAD_INIT(tsk->thread_node);
....@@ -1579,6 +1674,7 @@
15791674 sig->oom_score_adj_min = current->signal->oom_score_adj_min;
15801675
15811676 mutex_init(&sig->cred_guard_mutex);
1677
+ init_rwsem(&sig->exec_update_lock);
15821678
15831679 return 0;
15841680 }
....@@ -1633,26 +1729,6 @@
16331729 #endif
16341730 }
16351731
1636
-#ifdef CONFIG_POSIX_TIMERS
1637
-/*
1638
- * Initialize POSIX timer handling for a single task.
1639
- */
1640
-static void posix_cpu_timers_init(struct task_struct *tsk)
1641
-{
1642
-#ifdef CONFIG_PREEMPT_RT_BASE
1643
- tsk->posix_timer_list = NULL;
1644
-#endif
1645
- tsk->cputime_expires.prof_exp = 0;
1646
- tsk->cputime_expires.virt_exp = 0;
1647
- tsk->cputime_expires.sched_exp = 0;
1648
- INIT_LIST_HEAD(&tsk->cpu_timers[0]);
1649
- INIT_LIST_HEAD(&tsk->cpu_timers[1]);
1650
- INIT_LIST_HEAD(&tsk->cpu_timers[2]);
1651
-}
1652
-#else
1653
-static inline void posix_cpu_timers_init(struct task_struct *tsk) { }
1654
-#endif
1655
-
16561732 static inline void init_task_pid_links(struct task_struct *task)
16571733 {
16581734 enum pid_type type;
....@@ -1684,7 +1760,125 @@
16841760 INIT_LIST_HEAD(&p->rcu_tasks_holdout_list);
16851761 p->rcu_tasks_idle_cpu = -1;
16861762 #endif /* #ifdef CONFIG_TASKS_RCU */
1763
+#ifdef CONFIG_TASKS_TRACE_RCU
1764
+ p->trc_reader_nesting = 0;
1765
+ p->trc_reader_special.s = 0;
1766
+ INIT_LIST_HEAD(&p->trc_holdout_list);
1767
+#endif /* #ifdef CONFIG_TASKS_TRACE_RCU */
16871768 }
1769
+
1770
+struct pid *pidfd_pid(const struct file *file)
1771
+{
1772
+ if (file->f_op == &pidfd_fops)
1773
+ return file->private_data;
1774
+
1775
+ return ERR_PTR(-EBADF);
1776
+}
1777
+
1778
+static int pidfd_release(struct inode *inode, struct file *file)
1779
+{
1780
+ struct pid *pid = file->private_data;
1781
+
1782
+ file->private_data = NULL;
1783
+ put_pid(pid);
1784
+ return 0;
1785
+}
1786
+
1787
+#ifdef CONFIG_PROC_FS
1788
+/**
1789
+ * pidfd_show_fdinfo - print information about a pidfd
1790
+ * @m: proc fdinfo file
1791
+ * @f: file referencing a pidfd
1792
+ *
1793
+ * Pid:
1794
+ * This function will print the pid that a given pidfd refers to in the
1795
+ * pid namespace of the procfs instance.
1796
+ * If the pid namespace of the process is not a descendant of the pid
1797
+ * namespace of the procfs instance 0 will be shown as its pid. This is
1798
+ * similar to calling getppid() on a process whose parent is outside of
1799
+ * its pid namespace.
1800
+ *
1801
+ * NSpid:
1802
+ * If pid namespaces are supported then this function will also print
1803
+ * the pid of a given pidfd refers to for all descendant pid namespaces
1804
+ * starting from the current pid namespace of the instance, i.e. the
1805
+ * Pid field and the first entry in the NSpid field will be identical.
1806
+ * If the pid namespace of the process is not a descendant of the pid
1807
+ * namespace of the procfs instance 0 will be shown as its first NSpid
1808
+ * entry and no others will be shown.
1809
+ * Note that this differs from the Pid and NSpid fields in
1810
+ * /proc/<pid>/status where Pid and NSpid are always shown relative to
1811
+ * the pid namespace of the procfs instance. The difference becomes
1812
+ * obvious when sending around a pidfd between pid namespaces from a
1813
+ * different branch of the tree, i.e. where no ancestoral relation is
1814
+ * present between the pid namespaces:
1815
+ * - create two new pid namespaces ns1 and ns2 in the initial pid
1816
+ * namespace (also take care to create new mount namespaces in the
1817
+ * new pid namespace and mount procfs)
1818
+ * - create a process with a pidfd in ns1
1819
+ * - send pidfd from ns1 to ns2
1820
+ * - read /proc/self/fdinfo/<pidfd> and observe that both Pid and NSpid
1821
+ * have exactly one entry, which is 0
1822
+ */
1823
+static void pidfd_show_fdinfo(struct seq_file *m, struct file *f)
1824
+{
1825
+ struct pid *pid = f->private_data;
1826
+ struct pid_namespace *ns;
1827
+ pid_t nr = -1;
1828
+
1829
+ if (likely(pid_has_task(pid, PIDTYPE_PID))) {
1830
+ ns = proc_pid_ns(file_inode(m->file)->i_sb);
1831
+ nr = pid_nr_ns(pid, ns);
1832
+ }
1833
+
1834
+ seq_put_decimal_ll(m, "Pid:\t", nr);
1835
+
1836
+#ifdef CONFIG_PID_NS
1837
+ seq_put_decimal_ll(m, "\nNSpid:\t", nr);
1838
+ if (nr > 0) {
1839
+ int i;
1840
+
1841
+ /* If nr is non-zero it means that 'pid' is valid and that
1842
+ * ns, i.e. the pid namespace associated with the procfs
1843
+ * instance, is in the pid namespace hierarchy of pid.
1844
+ * Start at one below the already printed level.
1845
+ */
1846
+ for (i = ns->level + 1; i <= pid->level; i++)
1847
+ seq_put_decimal_ll(m, "\t", pid->numbers[i].nr);
1848
+ }
1849
+#endif
1850
+ seq_putc(m, '\n');
1851
+}
1852
+#endif
1853
+
1854
+/*
1855
+ * Poll support for process exit notification.
1856
+ */
1857
+static __poll_t pidfd_poll(struct file *file, struct poll_table_struct *pts)
1858
+{
1859
+ struct pid *pid = file->private_data;
1860
+ __poll_t poll_flags = 0;
1861
+
1862
+ poll_wait(file, &pid->wait_pidfd, pts);
1863
+
1864
+ /*
1865
+ * Inform pollers only when the whole thread group exits.
1866
+ * If the thread group leader exits before all other threads in the
1867
+ * group, then poll(2) should block, similar to the wait(2) family.
1868
+ */
1869
+ if (thread_group_exited(pid))
1870
+ poll_flags = EPOLLIN | EPOLLRDNORM;
1871
+
1872
+ return poll_flags;
1873
+}
1874
+
1875
+const struct file_operations pidfd_fops = {
1876
+ .release = pidfd_release,
1877
+ .poll = pidfd_poll,
1878
+#ifdef CONFIG_PROC_FS
1879
+ .show_fdinfo = pidfd_show_fdinfo,
1880
+#endif
1881
+};
16881882
16891883 static void __delayed_free_task(struct rcu_head *rhp)
16901884 {
....@@ -1699,84 +1893,6 @@
16991893 call_rcu(&tsk->rcu, __delayed_free_task);
17001894 else
17011895 free_task(tsk);
1702
-}
1703
-
1704
-static int pidfd_release(struct inode *inode, struct file *file)
1705
-{
1706
- struct pid *pid = file->private_data;
1707
-
1708
- file->private_data = NULL;
1709
- put_pid(pid);
1710
- return 0;
1711
-}
1712
-
1713
-#ifdef CONFIG_PROC_FS
1714
-static void pidfd_show_fdinfo(struct seq_file *m, struct file *f)
1715
-{
1716
- struct pid_namespace *ns = proc_pid_ns(file_inode(m->file));
1717
- struct pid *pid = f->private_data;
1718
-
1719
- seq_put_decimal_ull(m, "Pid:\t", pid_nr_ns(pid, ns));
1720
- seq_putc(m, '\n');
1721
-}
1722
-#endif
1723
-
1724
-/*
1725
- * Poll support for process exit notification.
1726
- */
1727
-static __poll_t pidfd_poll(struct file *file, struct poll_table_struct *pts)
1728
-{
1729
- struct task_struct *task;
1730
- struct pid *pid = file->private_data;
1731
- __poll_t poll_flags = 0;
1732
-
1733
- poll_wait(file, &pid->wait_pidfd, pts);
1734
-
1735
- rcu_read_lock();
1736
- task = pid_task(pid, PIDTYPE_PID);
1737
- /*
1738
- * Inform pollers only when the whole thread group exits.
1739
- * If the thread group leader exits before all other threads in the
1740
- * group, then poll(2) should block, similar to the wait(2) family.
1741
- */
1742
- if (!task || (task->exit_state && thread_group_empty(task)))
1743
- poll_flags = EPOLLIN | EPOLLRDNORM;
1744
- rcu_read_unlock();
1745
-
1746
- return poll_flags;
1747
-}
1748
-
1749
-const struct file_operations pidfd_fops = {
1750
- .release = pidfd_release,
1751
- .poll = pidfd_poll,
1752
-#ifdef CONFIG_PROC_FS
1753
- .show_fdinfo = pidfd_show_fdinfo,
1754
-#endif
1755
-};
1756
-
1757
-/**
1758
- * pidfd_create() - Create a new pid file descriptor.
1759
- *
1760
- * @pid: struct pid that the pidfd will reference
1761
- *
1762
- * This creates a new pid file descriptor with the O_CLOEXEC flag set.
1763
- *
1764
- * Note, that this function can only be called after the fd table has
1765
- * been unshared to avoid leaking the pidfd to the new process.
1766
- *
1767
- * Return: On success, a cloexec pidfd is returned.
1768
- * On error, a negative errno number will be returned.
1769
- */
1770
-static int pidfd_create(struct pid *pid)
1771
-{
1772
- int fd;
1773
-
1774
- fd = anon_inode_getfd("[pidfd]", &pidfd_fops, get_pid(pid),
1775
- O_RDWR | O_CLOEXEC);
1776
- if (fd < 0)
1777
- put_pid(pid);
1778
-
1779
- return fd;
17801896 }
17811897
17821898 static void copy_oom_score_adj(u64 clone_flags, struct task_struct *tsk)
....@@ -1807,19 +1923,17 @@
18071923 * flags). The actual kick-off is left to the caller.
18081924 */
18091925 static __latent_entropy struct task_struct *copy_process(
1810
- unsigned long clone_flags,
1811
- unsigned long stack_start,
1812
- unsigned long stack_size,
1813
- int __user *parent_tidptr,
1814
- int __user *child_tidptr,
18151926 struct pid *pid,
18161927 int trace,
1817
- unsigned long tls,
1818
- int node)
1928
+ int node,
1929
+ struct kernel_clone_args *args)
18191930 {
18201931 int pidfd = -1, retval;
18211932 struct task_struct *p;
18221933 struct multiprocess_signals delayed;
1934
+ struct file *pidfile = NULL;
1935
+ u64 clone_flags = args->flags;
1936
+ struct nsproxy *nsp = current->nsproxy;
18231937
18241938 /*
18251939 * Don't allow sharing the root directory with processes in a different
....@@ -1862,21 +1976,26 @@
18621976 */
18631977 if (clone_flags & CLONE_THREAD) {
18641978 if ((clone_flags & (CLONE_NEWUSER | CLONE_NEWPID)) ||
1865
- (task_active_pid_ns(current) !=
1866
- current->nsproxy->pid_ns_for_children))
1979
+ (task_active_pid_ns(current) != nsp->pid_ns_for_children))
1980
+ return ERR_PTR(-EINVAL);
1981
+ }
1982
+
1983
+ /*
1984
+ * If the new process will be in a different time namespace
1985
+ * do not allow it to share VM or a thread group with the forking task.
1986
+ */
1987
+ if (clone_flags & (CLONE_THREAD | CLONE_VM)) {
1988
+ if (nsp->time_ns != nsp->time_ns_for_children)
18671989 return ERR_PTR(-EINVAL);
18681990 }
18691991
18701992 if (clone_flags & CLONE_PIDFD) {
18711993 /*
1872
- * - CLONE_PARENT_SETTID is useless for pidfds and also
1873
- * parent_tidptr is used to return pidfds.
18741994 * - CLONE_DETACHED is blocked so that we can potentially
18751995 * reuse it later for CLONE_PIDFD.
18761996 * - CLONE_THREAD is blocked until someone really needs it.
18771997 */
1878
- if (clone_flags &
1879
- (CLONE_DETACHED | CLONE_PARENT_SETTID | CLONE_THREAD))
1998
+ if (clone_flags & (CLONE_DETACHED | CLONE_THREAD))
18801999 return ERR_PTR(-EINVAL);
18812000 }
18822001
....@@ -1895,13 +2014,21 @@
18952014 recalc_sigpending();
18962015 spin_unlock_irq(&current->sighand->siglock);
18972016 retval = -ERESTARTNOINTR;
1898
- if (signal_pending(current))
2017
+ if (task_sigpending(current))
18992018 goto fork_out;
19002019
19012020 retval = -ENOMEM;
19022021 p = dup_task_struct(current, node);
19032022 if (!p)
19042023 goto fork_out;
2024
+ if (args->io_thread) {
2025
+ /*
2026
+ * Mark us an IO worker, and block any signal that isn't
2027
+ * fatal or STOP
2028
+ */
2029
+ p->flags |= PF_IO_WORKER;
2030
+ siginitsetinv(&p->blocked, sigmask(SIGKILL)|sigmask(SIGSTOP));
2031
+ }
19052032
19062033 cpufreq_task_times_init(p);
19072034
....@@ -1911,18 +2038,18 @@
19112038 * p->set_child_tid which is (ab)used as a kthread's data pointer for
19122039 * kernel threads (PF_KTHREAD).
19132040 */
1914
- p->set_child_tid = (clone_flags & CLONE_CHILD_SETTID) ? child_tidptr : NULL;
2041
+ p->set_child_tid = (clone_flags & CLONE_CHILD_SETTID) ? args->child_tid : NULL;
19152042 /*
19162043 * Clear TID on mm_release()?
19172044 */
1918
- p->clear_child_tid = (clone_flags & CLONE_CHILD_CLEARTID) ? child_tidptr : NULL;
2045
+ p->clear_child_tid = (clone_flags & CLONE_CHILD_CLEARTID) ? args->child_tid : NULL;
19192046
19202047 ftrace_graph_init_task(p);
19212048
19222049 rt_mutex_init_task(p);
19232050
2051
+ lockdep_assert_irqs_enabled();
19242052 #ifdef CONFIG_PROVE_LOCKING
1925
- DEBUG_LOCKS_WARN_ON(!p->hardirqs_enabled);
19262053 DEBUG_LOCKS_WARN_ON(!p->softirqs_enabled);
19272054 #endif
19282055 retval = -EAGAIN;
....@@ -1944,7 +2071,7 @@
19442071 * to stop root fork bombs.
19452072 */
19462073 retval = -EAGAIN;
1947
- if (nr_threads >= max_threads)
2074
+ if (data_race(nr_threads >= max_threads))
19482075 goto bad_fork_cleanup_count;
19492076
19502077 delayacct_tsk_init(p); /* Must remain after dup_task_struct() */
....@@ -1971,6 +2098,10 @@
19712098 p->vtime.state = VTIME_INACTIVE;
19722099 #endif
19732100
2101
+#ifdef CONFIG_IO_URING
2102
+ p->io_uring = NULL;
2103
+#endif
2104
+
19742105 #if defined(SPLIT_RSS_COUNTING)
19752106 memset(&p->rss_stat, 0, sizeof(p->rss_stat));
19762107 #endif
....@@ -1984,7 +2115,7 @@
19842115 task_io_accounting_init(&p->ioac);
19852116 acct_clear_integrals(p);
19862117
1987
- posix_cpu_timers_init(p);
2118
+ posix_cputimers_init(&p->posix_cputimers);
19882119
19892120 p->io_context = NULL;
19902121 audit_set_context(p, NULL);
....@@ -2000,30 +2131,19 @@
20002131 #ifdef CONFIG_CPUSETS
20012132 p->cpuset_mem_spread_rotor = NUMA_NO_NODE;
20022133 p->cpuset_slab_spread_rotor = NUMA_NO_NODE;
2003
- seqcount_init(&p->mems_allowed_seq);
2134
+ seqcount_spinlock_init(&p->mems_allowed_seq, &p->alloc_lock);
20042135 #endif
20052136 #ifdef CONFIG_TRACE_IRQFLAGS
2006
- p->irq_events = 0;
2007
- p->hardirqs_enabled = 0;
2008
- p->hardirq_enable_ip = 0;
2009
- p->hardirq_enable_event = 0;
2010
- p->hardirq_disable_ip = _THIS_IP_;
2011
- p->hardirq_disable_event = 0;
2012
- p->softirqs_enabled = 1;
2013
- p->softirq_enable_ip = _THIS_IP_;
2014
- p->softirq_enable_event = 0;
2015
- p->softirq_disable_ip = 0;
2016
- p->softirq_disable_event = 0;
2017
- p->hardirq_context = 0;
2018
- p->softirq_context = 0;
2137
+ memset(&p->irqtrace, 0, sizeof(p->irqtrace));
2138
+ p->irqtrace.hardirq_disable_ip = _THIS_IP_;
2139
+ p->irqtrace.softirq_enable_ip = _THIS_IP_;
2140
+ p->softirqs_enabled = 1;
2141
+ p->softirq_context = 0;
20192142 #endif
20202143
20212144 p->pagefault_disabled = 0;
20222145
20232146 #ifdef CONFIG_LOCKDEP
2024
- p->lockdep_depth = 0; /* no locks held yet */
2025
- p->curr_chain_key = 0;
2026
- p->lockdep_recursion = 0;
20272147 lockdep_init_task(p);
20282148 #endif
20292149
....@@ -2075,12 +2195,15 @@
20752195 retval = copy_io(clone_flags, p);
20762196 if (retval)
20772197 goto bad_fork_cleanup_namespaces;
2078
- retval = copy_thread_tls(clone_flags, stack_start, stack_size, p, tls);
2198
+ retval = copy_thread(clone_flags, args->stack, args->stack_size, p, args->tls);
20792199 if (retval)
20802200 goto bad_fork_cleanup_io;
20812201
2202
+ stackleak_task_init(p);
2203
+
20822204 if (pid != &init_struct_pid) {
2083
- pid = alloc_pid(p->nsproxy->pid_ns_for_children);
2205
+ pid = alloc_pid(p->nsproxy->pid_ns_for_children, args->set_tid,
2206
+ args->set_tid_size);
20842207 if (IS_ERR(pid)) {
20852208 retval = PTR_ERR(pid);
20862209 goto bad_fork_cleanup_thread;
....@@ -2093,12 +2216,22 @@
20932216 * if the fd table isn't shared).
20942217 */
20952218 if (clone_flags & CLONE_PIDFD) {
2096
- retval = pidfd_create(pid);
2219
+ retval = get_unused_fd_flags(O_RDWR | O_CLOEXEC);
20972220 if (retval < 0)
20982221 goto bad_fork_free_pid;
20992222
21002223 pidfd = retval;
2101
- retval = put_user(pidfd, parent_tidptr);
2224
+
2225
+ pidfile = anon_inode_getfile("[pidfd]", &pidfd_fops, pid,
2226
+ O_RDWR | O_CLOEXEC);
2227
+ if (IS_ERR(pidfile)) {
2228
+ put_unused_fd(pidfd);
2229
+ retval = PTR_ERR(pidfile);
2230
+ goto bad_fork_free_pid;
2231
+ }
2232
+ get_pid(pid); /* held by pidfile now */
2233
+
2234
+ retval = put_user(pidfd, args->pidfd);
21022235 if (retval)
21032236 goto bad_fork_put_pidfd;
21042237 }
....@@ -2123,7 +2256,7 @@
21232256 #ifdef TIF_SYSCALL_EMU
21242257 clear_tsk_thread_flag(p, TIF_SYSCALL_EMU);
21252258 #endif
2126
- clear_all_latency_tracing(p);
2259
+ clear_tsk_latency_tracing(p);
21272260
21282261 /* ok, now we should be set up.. */
21292262 p->pid = pid_nr(pid);
....@@ -2142,17 +2275,28 @@
21422275 p->pdeath_signal = 0;
21432276 INIT_LIST_HEAD(&p->thread_group);
21442277 p->task_works = NULL;
2278
+ clear_posix_cputimers_work(p);
21452279
2146
- cgroup_threadgroup_change_begin(current);
21472280 /*
21482281 * Ensure that the cgroup subsystem policies allow the new process to be
2149
- * forked. It should be noted the the new process's css_set can be changed
2282
+ * forked. It should be noted that the new process's css_set can be changed
21502283 * between here and cgroup_post_fork() if an organisation operation is in
21512284 * progress.
21522285 */
2153
- retval = cgroup_can_fork(p);
2286
+ retval = cgroup_can_fork(p, args);
21542287 if (retval)
2155
- goto bad_fork_cgroup_threadgroup_change_end;
2288
+ goto bad_fork_put_pidfd;
2289
+
2290
+ /*
2291
+ * Now that the cgroups are pinned, re-clone the parent cgroup and put
2292
+ * the new task on the correct runqueue. All this *before* the task
2293
+ * becomes visible.
2294
+ *
2295
+ * This isn't part of ->can_fork() because while the re-cloning is
2296
+ * cgroup specific, it unconditionally needs to place the task on a
2297
+ * runqueue.
2298
+ */
2299
+ sched_cgroup_fork(p, args);
21562300
21572301 /*
21582302 * From this point on we must avoid any synchronous user-space
....@@ -2163,7 +2307,7 @@
21632307 */
21642308
21652309 p->start_time = ktime_get_ns();
2166
- p->real_start_time = ktime_get_boot_ns();
2310
+ p->start_boottime = ktime_get_boottime_ns();
21672311
21682312 /*
21692313 * Make it visible to the rest of the system, but dont wake it up yet.
....@@ -2182,7 +2326,7 @@
21822326 } else {
21832327 p->real_parent = current;
21842328 p->parent_exec_id = current->self_exec_id;
2185
- p->exit_signal = (clone_flags & CSIGNAL);
2329
+ p->exit_signal = args->exit_signal;
21862330 }
21872331
21882332 klp_copy_process(p);
....@@ -2208,7 +2352,6 @@
22082352 retval = -EINTR;
22092353 goto bad_fork_cancel_cgroup;
22102354 }
2211
-
22122355
22132356 init_task_pid_links(p);
22142357 if (likely(p->pid)) {
....@@ -2242,7 +2385,7 @@
22422385 } else {
22432386 current->signal->nr_threads++;
22442387 atomic_inc(&current->signal->live);
2245
- atomic_inc(&current->signal->sigcnt);
2388
+ refcount_inc(&current->signal->sigcnt);
22462389 task_join_group_stop(p);
22472390 list_add_tail_rcu(&p->thread_group,
22482391 &p->group_leader->thread_group);
....@@ -2258,9 +2401,12 @@
22582401 syscall_tracepoint_update(p);
22592402 write_unlock_irq(&tasklist_lock);
22602403
2404
+ if (pidfile)
2405
+ fd_install(pidfd, pidfile);
2406
+
22612407 proc_fork_connector(p);
2262
- cgroup_post_fork(p);
2263
- cgroup_threadgroup_change_end(current);
2408
+ sched_post_fork(p);
2409
+ cgroup_post_fork(p, args);
22642410 perf_event_fork(p);
22652411
22662412 trace_task_newtask(p, clone_flags);
....@@ -2273,12 +2419,12 @@
22732419 bad_fork_cancel_cgroup:
22742420 spin_unlock(&current->sighand->siglock);
22752421 write_unlock_irq(&tasklist_lock);
2276
- cgroup_cancel_fork(p);
2277
-bad_fork_cgroup_threadgroup_change_end:
2278
- cgroup_threadgroup_change_end(current);
2422
+ cgroup_cancel_fork(p, args);
22792423 bad_fork_put_pidfd:
2280
- if (clone_flags & CLONE_PIDFD)
2281
- ksys_close(pidfd);
2424
+ if (clone_flags & CLONE_PIDFD) {
2425
+ fput(pidfile);
2426
+ put_unused_fd(pidfd);
2427
+ }
22822428 bad_fork_free_pid:
22832429 if (pid != &init_struct_pid)
22842430 free_pid(pid);
....@@ -2342,11 +2488,14 @@
23422488 }
23432489 }
23442490
2345
-struct task_struct *fork_idle(int cpu)
2491
+struct task_struct * __init fork_idle(int cpu)
23462492 {
23472493 struct task_struct *task;
2348
- task = copy_process(CLONE_VM, 0, 0, NULL, NULL, &init_struct_pid, 0, 0,
2349
- cpu_to_node(cpu));
2494
+ struct kernel_clone_args args = {
2495
+ .flags = CLONE_VM,
2496
+ };
2497
+
2498
+ task = copy_process(&init_struct_pid, 0, cpu_to_node(cpu), &args);
23502499 if (!IS_ERR(task)) {
23512500 init_idle_pids(task);
23522501 init_idle(task, cpu);
....@@ -2355,24 +2504,63 @@
23552504 return task;
23562505 }
23572506
2507
+struct mm_struct *copy_init_mm(void)
2508
+{
2509
+ return dup_mm(NULL, &init_mm);
2510
+}
2511
+
2512
+/*
2513
+ * This is like kernel_clone(), but shaved down and tailored to just
2514
+ * creating io_uring workers. It returns a created task, or an error pointer.
2515
+ * The returned task is inactive, and the caller must fire it up through
2516
+ * wake_up_new_task(p). All signals are blocked in the created task.
2517
+ */
2518
+struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node)
2519
+{
2520
+ unsigned long flags = CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|
2521
+ CLONE_IO;
2522
+ struct kernel_clone_args args = {
2523
+ .flags = ((lower_32_bits(flags) | CLONE_VM |
2524
+ CLONE_UNTRACED) & ~CSIGNAL),
2525
+ .exit_signal = (lower_32_bits(flags) & CSIGNAL),
2526
+ .stack = (unsigned long)fn,
2527
+ .stack_size = (unsigned long)arg,
2528
+ .io_thread = 1,
2529
+ };
2530
+
2531
+ return copy_process(NULL, 0, node, &args);
2532
+}
2533
+
23582534 /*
23592535 * Ok, this is the main fork-routine.
23602536 *
23612537 * It copies the process, and if successful kick-starts
23622538 * it and waits for it to finish using the VM if required.
2539
+ *
2540
+ * args->exit_signal is expected to be checked for sanity by the caller.
23632541 */
2364
-long _do_fork(unsigned long clone_flags,
2365
- unsigned long stack_start,
2366
- unsigned long stack_size,
2367
- int __user *parent_tidptr,
2368
- int __user *child_tidptr,
2369
- unsigned long tls)
2542
+pid_t kernel_clone(struct kernel_clone_args *args)
23702543 {
2544
+ u64 clone_flags = args->flags;
23712545 struct completion vfork;
23722546 struct pid *pid;
23732547 struct task_struct *p;
23742548 int trace = 0;
2375
- long nr;
2549
+ pid_t nr;
2550
+
2551
+ /*
2552
+ * For legacy clone() calls, CLONE_PIDFD uses the parent_tid argument
2553
+ * to return the pidfd. Hence, CLONE_PIDFD and CLONE_PARENT_SETTID are
2554
+ * mutually exclusive. With clone3() CLONE_PIDFD has grown a separate
2555
+ * field in struct clone_args and it still doesn't make sense to have
2556
+ * them both point at the same memory location. Performing this check
2557
+ * here has the advantage that we don't need to have a separate helper
2558
+ * to check for legacy clone().
2559
+ */
2560
+ if ((args->flags & CLONE_PIDFD) &&
2561
+ (args->flags & CLONE_PARENT_SETTID) &&
2562
+ (args->pidfd == args->parent_tid))
2563
+ return -EINVAL;
23762564
23772565 /*
23782566 * Determine whether and which event to report to ptracer. When
....@@ -2383,7 +2571,7 @@
23832571 if (!(clone_flags & CLONE_UNTRACED)) {
23842572 if (clone_flags & CLONE_VFORK)
23852573 trace = PTRACE_EVENT_VFORK;
2386
- else if ((clone_flags & CSIGNAL) != SIGCHLD)
2574
+ else if (args->exit_signal != SIGCHLD)
23872575 trace = PTRACE_EVENT_CLONE;
23882576 else
23892577 trace = PTRACE_EVENT_FORK;
....@@ -2392,8 +2580,7 @@
23922580 trace = 0;
23932581 }
23942582
2395
- p = copy_process(clone_flags, stack_start, stack_size, parent_tidptr,
2396
- child_tidptr, NULL, trace, tls, NUMA_NO_NODE);
2583
+ p = copy_process(NULL, trace, NUMA_NO_NODE, args);
23972584 add_latent_entropy();
23982585
23992586 if (IS_ERR(p))
....@@ -2411,7 +2598,7 @@
24112598 nr = pid_vnr(pid);
24122599
24132600 if (clone_flags & CLONE_PARENT_SETTID)
2414
- put_user(nr, parent_tidptr);
2601
+ put_user(nr, args->parent_tid);
24152602
24162603 if (clone_flags & CLONE_VFORK) {
24172604 p->vfork_done = &vfork;
....@@ -2434,34 +2621,31 @@
24342621 return nr;
24352622 }
24362623
2437
-#ifndef CONFIG_HAVE_COPY_THREAD_TLS
2438
-/* For compatibility with architectures that call do_fork directly rather than
2439
- * using the syscall entry points below. */
2440
-long do_fork(unsigned long clone_flags,
2441
- unsigned long stack_start,
2442
- unsigned long stack_size,
2443
- int __user *parent_tidptr,
2444
- int __user *child_tidptr)
2445
-{
2446
- return _do_fork(clone_flags, stack_start, stack_size,
2447
- parent_tidptr, child_tidptr, 0);
2448
-}
2449
-#endif
2450
-
24512624 /*
24522625 * Create a kernel thread.
24532626 */
24542627 pid_t kernel_thread(int (*fn)(void *), void *arg, unsigned long flags)
24552628 {
2456
- return _do_fork(flags|CLONE_VM|CLONE_UNTRACED, (unsigned long)fn,
2457
- (unsigned long)arg, NULL, NULL, 0);
2629
+ struct kernel_clone_args args = {
2630
+ .flags = ((lower_32_bits(flags) | CLONE_VM |
2631
+ CLONE_UNTRACED) & ~CSIGNAL),
2632
+ .exit_signal = (lower_32_bits(flags) & CSIGNAL),
2633
+ .stack = (unsigned long)fn,
2634
+ .stack_size = (unsigned long)arg,
2635
+ };
2636
+
2637
+ return kernel_clone(&args);
24582638 }
24592639
24602640 #ifdef __ARCH_WANT_SYS_FORK
24612641 SYSCALL_DEFINE0(fork)
24622642 {
24632643 #ifdef CONFIG_MMU
2464
- return _do_fork(SIGCHLD, 0, 0, NULL, NULL, 0);
2644
+ struct kernel_clone_args args = {
2645
+ .exit_signal = SIGCHLD,
2646
+ };
2647
+
2648
+ return kernel_clone(&args);
24652649 #else
24662650 /* can not support in nommu mode */
24672651 return -EINVAL;
....@@ -2472,8 +2656,12 @@
24722656 #ifdef __ARCH_WANT_SYS_VFORK
24732657 SYSCALL_DEFINE0(vfork)
24742658 {
2475
- return _do_fork(CLONE_VFORK | CLONE_VM | SIGCHLD, 0,
2476
- 0, NULL, NULL, 0);
2659
+ struct kernel_clone_args args = {
2660
+ .flags = CLONE_VFORK | CLONE_VM,
2661
+ .exit_signal = SIGCHLD,
2662
+ };
2663
+
2664
+ return kernel_clone(&args);
24772665 }
24782666 #endif
24792667
....@@ -2501,7 +2689,175 @@
25012689 unsigned long, tls)
25022690 #endif
25032691 {
2504
- return _do_fork(clone_flags, newsp, 0, parent_tidptr, child_tidptr, tls);
2692
+ struct kernel_clone_args args = {
2693
+ .flags = (lower_32_bits(clone_flags) & ~CSIGNAL),
2694
+ .pidfd = parent_tidptr,
2695
+ .child_tid = child_tidptr,
2696
+ .parent_tid = parent_tidptr,
2697
+ .exit_signal = (lower_32_bits(clone_flags) & CSIGNAL),
2698
+ .stack = newsp,
2699
+ .tls = tls,
2700
+ };
2701
+
2702
+ return kernel_clone(&args);
2703
+}
2704
+#endif
2705
+
2706
+#ifdef __ARCH_WANT_SYS_CLONE3
2707
+
2708
+noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
2709
+ struct clone_args __user *uargs,
2710
+ size_t usize)
2711
+{
2712
+ int err;
2713
+ struct clone_args args;
2714
+ pid_t *kset_tid = kargs->set_tid;
2715
+
2716
+ BUILD_BUG_ON(offsetofend(struct clone_args, tls) !=
2717
+ CLONE_ARGS_SIZE_VER0);
2718
+ BUILD_BUG_ON(offsetofend(struct clone_args, set_tid_size) !=
2719
+ CLONE_ARGS_SIZE_VER1);
2720
+ BUILD_BUG_ON(offsetofend(struct clone_args, cgroup) !=
2721
+ CLONE_ARGS_SIZE_VER2);
2722
+ BUILD_BUG_ON(sizeof(struct clone_args) != CLONE_ARGS_SIZE_VER2);
2723
+
2724
+ if (unlikely(usize > PAGE_SIZE))
2725
+ return -E2BIG;
2726
+ if (unlikely(usize < CLONE_ARGS_SIZE_VER0))
2727
+ return -EINVAL;
2728
+
2729
+ err = copy_struct_from_user(&args, sizeof(args), uargs, usize);
2730
+ if (err)
2731
+ return err;
2732
+
2733
+ if (unlikely(args.set_tid_size > MAX_PID_NS_LEVEL))
2734
+ return -EINVAL;
2735
+
2736
+ if (unlikely(!args.set_tid && args.set_tid_size > 0))
2737
+ return -EINVAL;
2738
+
2739
+ if (unlikely(args.set_tid && args.set_tid_size == 0))
2740
+ return -EINVAL;
2741
+
2742
+ /*
2743
+ * Verify that higher 32bits of exit_signal are unset and that
2744
+ * it is a valid signal
2745
+ */
2746
+ if (unlikely((args.exit_signal & ~((u64)CSIGNAL)) ||
2747
+ !valid_signal(args.exit_signal)))
2748
+ return -EINVAL;
2749
+
2750
+ if ((args.flags & CLONE_INTO_CGROUP) &&
2751
+ (args.cgroup > INT_MAX || usize < CLONE_ARGS_SIZE_VER2))
2752
+ return -EINVAL;
2753
+
2754
+ *kargs = (struct kernel_clone_args){
2755
+ .flags = args.flags,
2756
+ .pidfd = u64_to_user_ptr(args.pidfd),
2757
+ .child_tid = u64_to_user_ptr(args.child_tid),
2758
+ .parent_tid = u64_to_user_ptr(args.parent_tid),
2759
+ .exit_signal = args.exit_signal,
2760
+ .stack = args.stack,
2761
+ .stack_size = args.stack_size,
2762
+ .tls = args.tls,
2763
+ .set_tid_size = args.set_tid_size,
2764
+ .cgroup = args.cgroup,
2765
+ };
2766
+
2767
+ if (args.set_tid &&
2768
+ copy_from_user(kset_tid, u64_to_user_ptr(args.set_tid),
2769
+ (kargs->set_tid_size * sizeof(pid_t))))
2770
+ return -EFAULT;
2771
+
2772
+ kargs->set_tid = kset_tid;
2773
+
2774
+ return 0;
2775
+}
2776
+
2777
+/**
2778
+ * clone3_stack_valid - check and prepare stack
2779
+ * @kargs: kernel clone args
2780
+ *
2781
+ * Verify that the stack arguments userspace gave us are sane.
2782
+ * In addition, set the stack direction for userspace since it's easy for us to
2783
+ * determine.
2784
+ */
2785
+static inline bool clone3_stack_valid(struct kernel_clone_args *kargs)
2786
+{
2787
+ if (kargs->stack == 0) {
2788
+ if (kargs->stack_size > 0)
2789
+ return false;
2790
+ } else {
2791
+ if (kargs->stack_size == 0)
2792
+ return false;
2793
+
2794
+ if (!access_ok((void __user *)kargs->stack, kargs->stack_size))
2795
+ return false;
2796
+
2797
+#if !defined(CONFIG_STACK_GROWSUP) && !defined(CONFIG_IA64)
2798
+ kargs->stack += kargs->stack_size;
2799
+#endif
2800
+ }
2801
+
2802
+ return true;
2803
+}
2804
+
2805
+static bool clone3_args_valid(struct kernel_clone_args *kargs)
2806
+{
2807
+ /* Verify that no unknown flags are passed along. */
2808
+ if (kargs->flags &
2809
+ ~(CLONE_LEGACY_FLAGS | CLONE_CLEAR_SIGHAND | CLONE_INTO_CGROUP))
2810
+ return false;
2811
+
2812
+ /*
2813
+ * - make the CLONE_DETACHED bit reuseable for clone3
2814
+ * - make the CSIGNAL bits reuseable for clone3
2815
+ */
2816
+ if (kargs->flags & (CLONE_DETACHED | CSIGNAL))
2817
+ return false;
2818
+
2819
+ if ((kargs->flags & (CLONE_SIGHAND | CLONE_CLEAR_SIGHAND)) ==
2820
+ (CLONE_SIGHAND | CLONE_CLEAR_SIGHAND))
2821
+ return false;
2822
+
2823
+ if ((kargs->flags & (CLONE_THREAD | CLONE_PARENT)) &&
2824
+ kargs->exit_signal)
2825
+ return false;
2826
+
2827
+ if (!clone3_stack_valid(kargs))
2828
+ return false;
2829
+
2830
+ return true;
2831
+}
2832
+
2833
+/**
2834
+ * clone3 - create a new process with specific properties
2835
+ * @uargs: argument structure
2836
+ * @size: size of @uargs
2837
+ *
2838
+ * clone3() is the extensible successor to clone()/clone2().
2839
+ * It takes a struct as argument that is versioned by its size.
2840
+ *
2841
+ * Return: On success, a positive PID for the child process.
2842
+ * On error, a negative errno number.
2843
+ */
2844
+SYSCALL_DEFINE2(clone3, struct clone_args __user *, uargs, size_t, size)
2845
+{
2846
+ int err;
2847
+
2848
+ struct kernel_clone_args kargs;
2849
+ pid_t set_tid[MAX_PID_NS_LEVEL];
2850
+
2851
+ kargs.set_tid = set_tid;
2852
+
2853
+ err = copy_clone_args_from_user(&kargs, uargs, size);
2854
+ if (err)
2855
+ return err;
2856
+
2857
+ if (!clone3_args_valid(&kargs))
2858
+ return -EINVAL;
2859
+
2860
+ return kernel_clone(&kargs);
25052861 }
25062862 #endif
25072863
....@@ -2596,7 +2952,8 @@
25962952 if (unshare_flags & ~(CLONE_THREAD|CLONE_FS|CLONE_NEWNS|CLONE_SIGHAND|
25972953 CLONE_VM|CLONE_FILES|CLONE_SYSVSEM|
25982954 CLONE_NEWUTS|CLONE_NEWIPC|CLONE_NEWNET|
2599
- CLONE_NEWUSER|CLONE_NEWPID|CLONE_NEWCGROUP))
2955
+ CLONE_NEWUSER|CLONE_NEWPID|CLONE_NEWCGROUP|
2956
+ CLONE_NEWTIME))
26002957 return -EINVAL;
26012958 /*
26022959 * Not implemented, but pretend it works if there is nothing
....@@ -2609,7 +2966,7 @@
26092966 return -EINVAL;
26102967 }
26112968 if (unshare_flags & (CLONE_SIGHAND | CLONE_VM)) {
2612
- if (atomic_read(&current->sighand->count) > 1)
2969
+ if (refcount_read(&current->sighand->count) > 1)
26132970 return -EINVAL;
26142971 }
26152972 if (unshare_flags & CLONE_VM) {
....@@ -2644,14 +3001,15 @@
26443001 /*
26453002 * Unshare file descriptor table if it is being shared
26463003 */
2647
-static int unshare_fd(unsigned long unshare_flags, struct files_struct **new_fdp)
3004
+int unshare_fd(unsigned long unshare_flags, unsigned int max_fds,
3005
+ struct files_struct **new_fdp)
26483006 {
26493007 struct files_struct *fd = current->files;
26503008 int error = 0;
26513009
26523010 if ((unshare_flags & CLONE_FILES) &&
26533011 (fd && atomic_read(&fd->count) > 1)) {
2654
- *new_fdp = dup_fd(fd, &error);
3012
+ *new_fdp = dup_fd(fd, max_fds, &error);
26553013 if (!*new_fdp)
26563014 return error;
26573015 }
....@@ -2662,7 +3020,7 @@
26623020 /*
26633021 * unshare allows a process to 'unshare' part of the process
26643022 * context which was originally shared using clone. copy_*
2665
- * functions used by do_fork() cannot be used here directly
3023
+ * functions used by kernel_clone() cannot be used here directly
26663024 * because they modify an inactive task_struct that is being
26673025 * constructed. Here we are modifying the current, active,
26683026 * task_struct.
....@@ -2711,7 +3069,7 @@
27113069 err = unshare_fs(unshare_flags, &new_fs);
27123070 if (err)
27133071 goto bad_unshare_out;
2714
- err = unshare_fd(unshare_flags, &new_fd);
3072
+ err = unshare_fd(unshare_flags, NR_OPEN_MAX, &new_fd);
27153073 if (err)
27163074 goto bad_unshare_cleanup_fs;
27173075 err = unshare_userns(unshare_flags, &new_cred);
....@@ -2800,7 +3158,7 @@
28003158 struct files_struct *copy = NULL;
28013159 int error;
28023160
2803
- error = unshare_fd(CLONE_FILES, &copy);
3161
+ error = unshare_fd(CLONE_FILES, NR_OPEN_MAX, &copy);
28043162 if (error || !copy) {
28053163 *displaced = NULL;
28063164 return error;
....@@ -2813,7 +3171,7 @@
28133171 }
28143172
28153173 int sysctl_max_threads(struct ctl_table *table, int write,
2816
- void __user *buffer, size_t *lenp, loff_t *ppos)
3174
+ void *buffer, size_t *lenp, loff_t *ppos)
28173175 {
28183176 struct ctl_table t;
28193177 int ret;