.. | .. |
---|
| 1 | +// SPDX-License-Identifier: GPL-2.0-or-later |
---|
1 | 2 | /* |
---|
2 | 3 | * Marvell 88E6xxx Switch Global 2 Registers support |
---|
3 | 4 | * |
---|
.. | .. |
---|
5 | 6 | * |
---|
6 | 7 | * Copyright (c) 2016-2017 Savoir-faire Linux Inc. |
---|
7 | 8 | * Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
---|
8 | | - * |
---|
9 | | - * This program is free software; you can redistribute it and/or modify |
---|
10 | | - * it under the terms of the GNU General Public License as published by |
---|
11 | | - * the Free Software Foundation; either version 2 of the License, or |
---|
12 | | - * (at your option) any later version. |
---|
13 | 9 | */ |
---|
14 | 10 | |
---|
15 | 11 | #include <linux/bitfield.h> |
---|
.. | .. |
---|
30 | 26 | return mv88e6xxx_write(chip, chip->info->global2_addr, reg, val); |
---|
31 | 27 | } |
---|
32 | 28 | |
---|
33 | | -int mv88e6xxx_g2_update(struct mv88e6xxx_chip *chip, int reg, u16 update) |
---|
| 29 | +int mv88e6xxx_g2_wait_bit(struct mv88e6xxx_chip *chip, int reg, int |
---|
| 30 | + bit, int val) |
---|
34 | 31 | { |
---|
35 | | - return mv88e6xxx_update(chip, chip->info->global2_addr, reg, update); |
---|
36 | | -} |
---|
37 | | - |
---|
38 | | -int mv88e6xxx_g2_wait(struct mv88e6xxx_chip *chip, int reg, u16 mask) |
---|
39 | | -{ |
---|
40 | | - return mv88e6xxx_wait(chip, chip->info->global2_addr, reg, mask); |
---|
| 32 | + return mv88e6xxx_wait_bit(chip, chip->info->global2_addr, reg, |
---|
| 33 | + bit, val); |
---|
41 | 34 | } |
---|
42 | 35 | |
---|
43 | 36 | /* Offset 0x00: Interrupt Source Register */ |
---|
.. | .. |
---|
127 | 120 | * but bit 4 is reserved on older chips, so it is safe to use. |
---|
128 | 121 | */ |
---|
129 | 122 | |
---|
130 | | - return mv88e6xxx_g2_update(chip, MV88E6XXX_G2_DEVICE_MAPPING, val); |
---|
| 123 | + return mv88e6xxx_g2_write(chip, MV88E6XXX_G2_DEVICE_MAPPING, |
---|
| 124 | + MV88E6XXX_G2_DEVICE_MAPPING_UPDATE | val); |
---|
131 | 125 | } |
---|
132 | 126 | |
---|
133 | 127 | /* Offset 0x07: Trunk Mask Table register */ |
---|
.. | .. |
---|
140 | 134 | if (hash) |
---|
141 | 135 | val |= MV88E6XXX_G2_TRUNK_MASK_HASH; |
---|
142 | 136 | |
---|
143 | | - return mv88e6xxx_g2_update(chip, MV88E6XXX_G2_TRUNK_MASK, val); |
---|
| 137 | + return mv88e6xxx_g2_write(chip, MV88E6XXX_G2_TRUNK_MASK, |
---|
| 138 | + MV88E6XXX_G2_TRUNK_MASK_UPDATE | val); |
---|
144 | 139 | } |
---|
145 | 140 | |
---|
146 | 141 | /* Offset 0x08: Trunk Mapping Table register */ |
---|
.. | .. |
---|
151 | 146 | const u16 port_mask = BIT(mv88e6xxx_num_ports(chip)) - 1; |
---|
152 | 147 | u16 val = (id << 11) | (map & port_mask); |
---|
153 | 148 | |
---|
154 | | - return mv88e6xxx_g2_update(chip, MV88E6XXX_G2_TRUNK_MAPPING, val); |
---|
| 149 | + return mv88e6xxx_g2_write(chip, MV88E6XXX_G2_TRUNK_MAPPING, |
---|
| 150 | + MV88E6XXX_G2_TRUNK_MAPPING_UPDATE | val); |
---|
155 | 151 | } |
---|
156 | 152 | |
---|
157 | 153 | int mv88e6xxx_g2_trunk_clear(struct mv88e6xxx_chip *chip) |
---|
.. | .. |
---|
182 | 178 | |
---|
183 | 179 | static int mv88e6xxx_g2_irl_wait(struct mv88e6xxx_chip *chip) |
---|
184 | 180 | { |
---|
185 | | - return mv88e6xxx_g2_wait(chip, MV88E6XXX_G2_IRL_CMD, |
---|
186 | | - MV88E6XXX_G2_IRL_CMD_BUSY); |
---|
| 181 | + int bit = __bf_shf(MV88E6XXX_G2_IRL_CMD_BUSY); |
---|
| 182 | + |
---|
| 183 | + return mv88e6xxx_g2_wait_bit(chip, MV88E6XXX_G2_IRL_CMD, bit, 0); |
---|
187 | 184 | } |
---|
188 | 185 | |
---|
189 | 186 | static int mv88e6xxx_g2_irl_op(struct mv88e6xxx_chip *chip, u16 op, int port, |
---|
.. | .. |
---|
218 | 215 | |
---|
219 | 216 | static int mv88e6xxx_g2_pvt_op_wait(struct mv88e6xxx_chip *chip) |
---|
220 | 217 | { |
---|
221 | | - return mv88e6xxx_g2_wait(chip, MV88E6XXX_G2_PVT_ADDR, |
---|
222 | | - MV88E6XXX_G2_PVT_ADDR_BUSY); |
---|
| 218 | + int bit = __bf_shf(MV88E6XXX_G2_PVT_ADDR_BUSY); |
---|
| 219 | + |
---|
| 220 | + return mv88e6xxx_g2_wait_bit(chip, MV88E6XXX_G2_PVT_ADDR, bit, 0); |
---|
223 | 221 | } |
---|
224 | 222 | |
---|
225 | 223 | static int mv88e6xxx_g2_pvt_op(struct mv88e6xxx_chip *chip, int src_dev, |
---|
.. | .. |
---|
265 | 263 | { |
---|
266 | 264 | u16 val = (pointer << 8) | data; |
---|
267 | 265 | |
---|
268 | | - return mv88e6xxx_g2_update(chip, MV88E6XXX_G2_SWITCH_MAC, val); |
---|
| 266 | + return mv88e6xxx_g2_write(chip, MV88E6XXX_G2_SWITCH_MAC, |
---|
| 267 | + MV88E6XXX_G2_SWITCH_MAC_UPDATE | val); |
---|
269 | 268 | } |
---|
270 | 269 | |
---|
271 | 270 | int mv88e6xxx_g2_set_switch_mac(struct mv88e6xxx_chip *chip, u8 *addr) |
---|
.. | .. |
---|
281 | 280 | return err; |
---|
282 | 281 | } |
---|
283 | 282 | |
---|
| 283 | +/* Offset 0x0E: ATU Statistics */ |
---|
| 284 | + |
---|
| 285 | +int mv88e6xxx_g2_atu_stats_set(struct mv88e6xxx_chip *chip, u16 kind, u16 bin) |
---|
| 286 | +{ |
---|
| 287 | + return mv88e6xxx_g2_write(chip, MV88E6XXX_G2_ATU_STATS, |
---|
| 288 | + kind | bin); |
---|
| 289 | +} |
---|
| 290 | + |
---|
| 291 | +int mv88e6xxx_g2_atu_stats_get(struct mv88e6xxx_chip *chip, u16 *stats) |
---|
| 292 | +{ |
---|
| 293 | + return mv88e6xxx_g2_read(chip, MV88E6XXX_G2_ATU_STATS, stats); |
---|
| 294 | +} |
---|
| 295 | + |
---|
284 | 296 | /* Offset 0x0F: Priority Override Table */ |
---|
285 | 297 | |
---|
286 | 298 | static int mv88e6xxx_g2_pot_write(struct mv88e6xxx_chip *chip, int pointer, |
---|
.. | .. |
---|
288 | 300 | { |
---|
289 | 301 | u16 val = (pointer << 8) | (data & 0x7); |
---|
290 | 302 | |
---|
291 | | - return mv88e6xxx_g2_update(chip, MV88E6XXX_G2_PRIO_OVERRIDE, val); |
---|
| 303 | + return mv88e6xxx_g2_write(chip, MV88E6XXX_G2_PRIO_OVERRIDE, |
---|
| 304 | + MV88E6XXX_G2_PRIO_OVERRIDE_UPDATE | val); |
---|
292 | 305 | } |
---|
293 | 306 | |
---|
294 | 307 | int mv88e6xxx_g2_pot_clear(struct mv88e6xxx_chip *chip) |
---|
.. | .. |
---|
312 | 325 | |
---|
313 | 326 | static int mv88e6xxx_g2_eeprom_wait(struct mv88e6xxx_chip *chip) |
---|
314 | 327 | { |
---|
315 | | - return mv88e6xxx_g2_wait(chip, MV88E6XXX_G2_EEPROM_CMD, |
---|
316 | | - MV88E6XXX_G2_EEPROM_CMD_BUSY | |
---|
317 | | - MV88E6XXX_G2_EEPROM_CMD_RUNNING); |
---|
| 328 | + int bit = __bf_shf(MV88E6XXX_G2_EEPROM_CMD_BUSY); |
---|
| 329 | + int err; |
---|
| 330 | + |
---|
| 331 | + err = mv88e6xxx_g2_wait_bit(chip, MV88E6XXX_G2_EEPROM_CMD, bit, 0); |
---|
| 332 | + if (err) |
---|
| 333 | + return err; |
---|
| 334 | + |
---|
| 335 | + bit = __bf_shf(MV88E6XXX_G2_EEPROM_CMD_RUNNING); |
---|
| 336 | + |
---|
| 337 | + return mv88e6xxx_g2_wait_bit(chip, MV88E6XXX_G2_EEPROM_CMD, bit, 0); |
---|
318 | 338 | } |
---|
319 | 339 | |
---|
320 | 340 | static int mv88e6xxx_g2_eeprom_cmd(struct mv88e6xxx_chip *chip, u16 cmd) |
---|
.. | .. |
---|
576 | 596 | |
---|
577 | 597 | static int mv88e6xxx_g2_smi_phy_wait(struct mv88e6xxx_chip *chip) |
---|
578 | 598 | { |
---|
579 | | - return mv88e6xxx_g2_wait(chip, MV88E6XXX_G2_SMI_PHY_CMD, |
---|
580 | | - MV88E6XXX_G2_SMI_PHY_CMD_BUSY); |
---|
| 599 | + int bit = __bf_shf(MV88E6XXX_G2_SMI_PHY_CMD_BUSY); |
---|
| 600 | + |
---|
| 601 | + return mv88e6xxx_g2_wait_bit(chip, MV88E6XXX_G2_SMI_PHY_CMD, bit, 0); |
---|
581 | 602 | } |
---|
582 | 603 | |
---|
583 | 604 | static int mv88e6xxx_g2_smi_phy_cmd(struct mv88e6xxx_chip *chip, u16 cmd) |
---|
.. | .. |
---|
816 | 837 | .irq_free = mv88e6097_watchdog_free, |
---|
817 | 838 | }; |
---|
818 | 839 | |
---|
| 840 | +static void mv88e6250_watchdog_free(struct mv88e6xxx_chip *chip) |
---|
| 841 | +{ |
---|
| 842 | + u16 reg; |
---|
| 843 | + |
---|
| 844 | + mv88e6xxx_g2_read(chip, MV88E6250_G2_WDOG_CTL, ®); |
---|
| 845 | + |
---|
| 846 | + reg &= ~(MV88E6250_G2_WDOG_CTL_EGRESS_ENABLE | |
---|
| 847 | + MV88E6250_G2_WDOG_CTL_QC_ENABLE); |
---|
| 848 | + |
---|
| 849 | + mv88e6xxx_g2_write(chip, MV88E6250_G2_WDOG_CTL, reg); |
---|
| 850 | +} |
---|
| 851 | + |
---|
| 852 | +static int mv88e6250_watchdog_setup(struct mv88e6xxx_chip *chip) |
---|
| 853 | +{ |
---|
| 854 | + return mv88e6xxx_g2_write(chip, MV88E6250_G2_WDOG_CTL, |
---|
| 855 | + MV88E6250_G2_WDOG_CTL_EGRESS_ENABLE | |
---|
| 856 | + MV88E6250_G2_WDOG_CTL_QC_ENABLE | |
---|
| 857 | + MV88E6250_G2_WDOG_CTL_SWRESET); |
---|
| 858 | +} |
---|
| 859 | + |
---|
| 860 | +const struct mv88e6xxx_irq_ops mv88e6250_watchdog_ops = { |
---|
| 861 | + .irq_action = mv88e6097_watchdog_action, |
---|
| 862 | + .irq_setup = mv88e6250_watchdog_setup, |
---|
| 863 | + .irq_free = mv88e6250_watchdog_free, |
---|
| 864 | +}; |
---|
| 865 | + |
---|
819 | 866 | static int mv88e6390_watchdog_setup(struct mv88e6xxx_chip *chip) |
---|
820 | 867 | { |
---|
821 | | - return mv88e6xxx_g2_update(chip, MV88E6390_G2_WDOG_CTL, |
---|
822 | | - MV88E6390_G2_WDOG_CTL_PTR_INT_ENABLE | |
---|
823 | | - MV88E6390_G2_WDOG_CTL_CUT_THROUGH | |
---|
824 | | - MV88E6390_G2_WDOG_CTL_QUEUE_CONTROLLER | |
---|
825 | | - MV88E6390_G2_WDOG_CTL_EGRESS | |
---|
826 | | - MV88E6390_G2_WDOG_CTL_FORCE_IRQ); |
---|
| 868 | + return mv88e6xxx_g2_write(chip, MV88E6390_G2_WDOG_CTL, |
---|
| 869 | + MV88E6390_G2_WDOG_CTL_UPDATE | |
---|
| 870 | + MV88E6390_G2_WDOG_CTL_PTR_INT_ENABLE | |
---|
| 871 | + MV88E6390_G2_WDOG_CTL_CUT_THROUGH | |
---|
| 872 | + MV88E6390_G2_WDOG_CTL_QUEUE_CONTROLLER | |
---|
| 873 | + MV88E6390_G2_WDOG_CTL_EGRESS | |
---|
| 874 | + MV88E6390_G2_WDOG_CTL_FORCE_IRQ); |
---|
827 | 875 | } |
---|
828 | 876 | |
---|
829 | 877 | static int mv88e6390_watchdog_action(struct mv88e6xxx_chip *chip, int irq) |
---|
830 | 878 | { |
---|
831 | | - int err; |
---|
832 | 879 | u16 reg; |
---|
833 | 880 | |
---|
834 | 881 | mv88e6xxx_g2_write(chip, MV88E6390_G2_WDOG_CTL, |
---|
835 | 882 | MV88E6390_G2_WDOG_CTL_PTR_EVENT); |
---|
836 | | - err = mv88e6xxx_g2_read(chip, MV88E6390_G2_WDOG_CTL, ®); |
---|
| 883 | + mv88e6xxx_g2_read(chip, MV88E6390_G2_WDOG_CTL, ®); |
---|
837 | 884 | |
---|
838 | 885 | dev_info(chip->dev, "Watchdog event: 0x%04x", |
---|
839 | 886 | reg & MV88E6390_G2_WDOG_CTL_DATA_MASK); |
---|
840 | 887 | |
---|
841 | 888 | mv88e6xxx_g2_write(chip, MV88E6390_G2_WDOG_CTL, |
---|
842 | 889 | MV88E6390_G2_WDOG_CTL_PTR_HISTORY); |
---|
843 | | - err = mv88e6xxx_g2_read(chip, MV88E6390_G2_WDOG_CTL, ®); |
---|
| 890 | + mv88e6xxx_g2_read(chip, MV88E6390_G2_WDOG_CTL, ®); |
---|
844 | 891 | |
---|
845 | 892 | dev_info(chip->dev, "Watchdog history: 0x%04x", |
---|
846 | 893 | reg & MV88E6390_G2_WDOG_CTL_DATA_MASK); |
---|
.. | .. |
---|
856 | 903 | |
---|
857 | 904 | static void mv88e6390_watchdog_free(struct mv88e6xxx_chip *chip) |
---|
858 | 905 | { |
---|
859 | | - mv88e6xxx_g2_update(chip, MV88E6390_G2_WDOG_CTL, |
---|
860 | | - MV88E6390_G2_WDOG_CTL_PTR_INT_ENABLE); |
---|
| 906 | + mv88e6xxx_g2_write(chip, MV88E6390_G2_WDOG_CTL, |
---|
| 907 | + MV88E6390_G2_WDOG_CTL_UPDATE | |
---|
| 908 | + MV88E6390_G2_WDOG_CTL_PTR_INT_ENABLE); |
---|
861 | 909 | } |
---|
862 | 910 | |
---|
863 | 911 | const struct mv88e6xxx_irq_ops mv88e6390_watchdog_ops = { |
---|
.. | .. |
---|
871 | 919 | struct mv88e6xxx_chip *chip = dev_id; |
---|
872 | 920 | irqreturn_t ret = IRQ_NONE; |
---|
873 | 921 | |
---|
874 | | - mutex_lock(&chip->reg_lock); |
---|
| 922 | + mv88e6xxx_reg_lock(chip); |
---|
875 | 923 | if (chip->info->ops->watchdog_ops->irq_action) |
---|
876 | 924 | ret = chip->info->ops->watchdog_ops->irq_action(chip, irq); |
---|
877 | | - mutex_unlock(&chip->reg_lock); |
---|
| 925 | + mv88e6xxx_reg_unlock(chip); |
---|
878 | 926 | |
---|
879 | 927 | return ret; |
---|
880 | 928 | } |
---|
881 | 929 | |
---|
882 | 930 | static void mv88e6xxx_g2_watchdog_free(struct mv88e6xxx_chip *chip) |
---|
883 | 931 | { |
---|
884 | | - mutex_lock(&chip->reg_lock); |
---|
| 932 | + mv88e6xxx_reg_lock(chip); |
---|
885 | 933 | if (chip->info->ops->watchdog_ops->irq_free) |
---|
886 | 934 | chip->info->ops->watchdog_ops->irq_free(chip); |
---|
887 | | - mutex_unlock(&chip->reg_lock); |
---|
| 935 | + mv88e6xxx_reg_unlock(chip); |
---|
888 | 936 | |
---|
889 | 937 | free_irq(chip->watchdog_irq, chip); |
---|
890 | 938 | irq_dispose_mapping(chip->watchdog_irq); |
---|
.. | .. |
---|
899 | 947 | if (chip->watchdog_irq < 0) |
---|
900 | 948 | return chip->watchdog_irq; |
---|
901 | 949 | |
---|
| 950 | + snprintf(chip->watchdog_irq_name, sizeof(chip->watchdog_irq_name), |
---|
| 951 | + "mv88e6xxx-%s-watchdog", dev_name(chip->dev)); |
---|
| 952 | + |
---|
902 | 953 | err = request_threaded_irq(chip->watchdog_irq, NULL, |
---|
903 | 954 | mv88e6xxx_g2_watchdog_thread_fn, |
---|
904 | 955 | IRQF_ONESHOT | IRQF_TRIGGER_FALLING, |
---|
905 | | - "mv88e6xxx-watchdog", chip); |
---|
| 956 | + chip->watchdog_irq_name, chip); |
---|
906 | 957 | if (err) |
---|
907 | 958 | return err; |
---|
908 | 959 | |
---|
909 | | - mutex_lock(&chip->reg_lock); |
---|
| 960 | + mv88e6xxx_reg_lock(chip); |
---|
910 | 961 | if (chip->info->ops->watchdog_ops->irq_setup) |
---|
911 | 962 | err = chip->info->ops->watchdog_ops->irq_setup(chip); |
---|
912 | | - mutex_unlock(&chip->reg_lock); |
---|
| 963 | + mv88e6xxx_reg_unlock(chip); |
---|
913 | 964 | |
---|
914 | 965 | return err; |
---|
915 | 966 | } |
---|
.. | .. |
---|
964 | 1015 | int err; |
---|
965 | 1016 | u16 reg; |
---|
966 | 1017 | |
---|
967 | | - mutex_lock(&chip->reg_lock); |
---|
| 1018 | + mv88e6xxx_reg_lock(chip); |
---|
968 | 1019 | err = mv88e6xxx_g2_int_source(chip, ®); |
---|
969 | | - mutex_unlock(&chip->reg_lock); |
---|
| 1020 | + mv88e6xxx_reg_unlock(chip); |
---|
970 | 1021 | if (err) |
---|
971 | 1022 | goto out; |
---|
972 | 1023 | |
---|
.. | .. |
---|
985 | 1036 | { |
---|
986 | 1037 | struct mv88e6xxx_chip *chip = irq_data_get_irq_chip_data(d); |
---|
987 | 1038 | |
---|
988 | | - mutex_lock(&chip->reg_lock); |
---|
| 1039 | + mv88e6xxx_reg_lock(chip); |
---|
989 | 1040 | } |
---|
990 | 1041 | |
---|
991 | 1042 | static void mv88e6xxx_g2_irq_bus_sync_unlock(struct irq_data *d) |
---|
.. | .. |
---|
997 | 1048 | if (err) |
---|
998 | 1049 | dev_err(chip->dev, "failed to mask interrupts\n"); |
---|
999 | 1050 | |
---|
1000 | | - mutex_unlock(&chip->reg_lock); |
---|
| 1051 | + mv88e6xxx_reg_unlock(chip); |
---|
1001 | 1052 | } |
---|
1002 | 1053 | |
---|
1003 | 1054 | static const struct irq_chip mv88e6xxx_g2_irq_chip = { |
---|
.. | .. |
---|
1047 | 1098 | { |
---|
1048 | 1099 | int err, irq, virq; |
---|
1049 | 1100 | |
---|
| 1101 | + chip->g2_irq.masked = ~0; |
---|
| 1102 | + mv88e6xxx_reg_lock(chip); |
---|
| 1103 | + err = mv88e6xxx_g2_int_mask(chip, ~chip->g2_irq.masked); |
---|
| 1104 | + mv88e6xxx_reg_unlock(chip); |
---|
| 1105 | + if (err) |
---|
| 1106 | + return err; |
---|
| 1107 | + |
---|
1050 | 1108 | chip->g2_irq.domain = irq_domain_add_simple( |
---|
1051 | 1109 | chip->dev->of_node, 16, 0, &mv88e6xxx_g2_irq_domain_ops, chip); |
---|
1052 | 1110 | if (!chip->g2_irq.domain) |
---|
.. | .. |
---|
1056 | 1114 | irq_create_mapping(chip->g2_irq.domain, irq); |
---|
1057 | 1115 | |
---|
1058 | 1116 | chip->g2_irq.chip = mv88e6xxx_g2_irq_chip; |
---|
1059 | | - chip->g2_irq.masked = ~0; |
---|
1060 | 1117 | |
---|
1061 | 1118 | chip->device_irq = irq_find_mapping(chip->g1_irq.domain, |
---|
1062 | 1119 | MV88E6XXX_G1_STS_IRQ_DEVICE); |
---|
.. | .. |
---|
1065 | 1122 | goto out; |
---|
1066 | 1123 | } |
---|
1067 | 1124 | |
---|
| 1125 | + snprintf(chip->device_irq_name, sizeof(chip->device_irq_name), |
---|
| 1126 | + "mv88e6xxx-%s-g2", dev_name(chip->dev)); |
---|
| 1127 | + |
---|
1068 | 1128 | err = request_threaded_irq(chip->device_irq, NULL, |
---|
1069 | 1129 | mv88e6xxx_g2_irq_thread_fn, |
---|
1070 | | - IRQF_ONESHOT, "mv88e6xxx-g2", chip); |
---|
| 1130 | + IRQF_ONESHOT, chip->device_irq_name, chip); |
---|
1071 | 1131 | if (err) |
---|
1072 | 1132 | goto out; |
---|
1073 | 1133 | |
---|