.. | .. |
---|
108 | 108 | u32 *buffer_32 = (u32 *)buf; |
---|
109 | 109 | size_t i = 0; |
---|
110 | 110 | |
---|
111 | | - if (count <= 0) |
---|
| 111 | + if (!count) |
---|
112 | 112 | return -EINVAL; |
---|
113 | 113 | |
---|
114 | 114 | /* Write out the complete 32-bit chunks */ |
---|
.. | .. |
---|
177 | 177 | { |
---|
178 | 178 | struct alt_pr_priv *priv; |
---|
179 | 179 | struct fpga_manager *mgr; |
---|
180 | | - int ret; |
---|
181 | 180 | u32 val; |
---|
182 | 181 | |
---|
183 | 182 | priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); |
---|
.. | .. |
---|
192 | 191 | (val & ALT_PR_CSR_STATUS_MSK) >> ALT_PR_CSR_STATUS_SFT, |
---|
193 | 192 | (int)(val & ALT_PR_CSR_PR_START)); |
---|
194 | 193 | |
---|
195 | | - mgr = fpga_mgr_create(dev, dev_name(dev), &alt_pr_ops, priv); |
---|
| 194 | + mgr = devm_fpga_mgr_create(dev, dev_name(dev), &alt_pr_ops, priv); |
---|
196 | 195 | if (!mgr) |
---|
197 | 196 | return -ENOMEM; |
---|
198 | 197 | |
---|
199 | 198 | dev_set_drvdata(dev, mgr); |
---|
200 | 199 | |
---|
201 | | - ret = fpga_mgr_register(mgr); |
---|
202 | | - if (ret) |
---|
203 | | - fpga_mgr_free(mgr); |
---|
204 | | - |
---|
205 | | - return ret; |
---|
| 200 | + return fpga_mgr_register(mgr); |
---|
206 | 201 | } |
---|
207 | 202 | EXPORT_SYMBOL_GPL(alt_pr_register); |
---|
208 | 203 | |
---|
209 | | -int alt_pr_unregister(struct device *dev) |
---|
| 204 | +void alt_pr_unregister(struct device *dev) |
---|
210 | 205 | { |
---|
211 | 206 | struct fpga_manager *mgr = dev_get_drvdata(dev); |
---|
212 | 207 | |
---|
213 | 208 | dev_dbg(dev, "%s\n", __func__); |
---|
214 | 209 | |
---|
215 | 210 | fpga_mgr_unregister(mgr); |
---|
216 | | - |
---|
217 | | - return 0; |
---|
218 | 211 | } |
---|
219 | 212 | EXPORT_SYMBOL_GPL(alt_pr_unregister); |
---|
220 | 213 | |
---|