hc
2023-12-09 b22da3d8526a935aa31e086e63f60ff3246cb61c
kernel/drivers/fpga/altera-pr-ip-core.c
....@@ -108,7 +108,7 @@
108108 u32 *buffer_32 = (u32 *)buf;
109109 size_t i = 0;
110110
111
- if (count <= 0)
111
+ if (!count)
112112 return -EINVAL;
113113
114114 /* Write out the complete 32-bit chunks */
....@@ -177,7 +177,6 @@
177177 {
178178 struct alt_pr_priv *priv;
179179 struct fpga_manager *mgr;
180
- int ret;
181180 u32 val;
182181
183182 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
....@@ -192,29 +191,23 @@
192191 (val & ALT_PR_CSR_STATUS_MSK) >> ALT_PR_CSR_STATUS_SFT,
193192 (int)(val & ALT_PR_CSR_PR_START));
194193
195
- mgr = fpga_mgr_create(dev, dev_name(dev), &alt_pr_ops, priv);
194
+ mgr = devm_fpga_mgr_create(dev, dev_name(dev), &alt_pr_ops, priv);
196195 if (!mgr)
197196 return -ENOMEM;
198197
199198 dev_set_drvdata(dev, mgr);
200199
201
- ret = fpga_mgr_register(mgr);
202
- if (ret)
203
- fpga_mgr_free(mgr);
204
-
205
- return ret;
200
+ return fpga_mgr_register(mgr);
206201 }
207202 EXPORT_SYMBOL_GPL(alt_pr_register);
208203
209
-int alt_pr_unregister(struct device *dev)
204
+void alt_pr_unregister(struct device *dev)
210205 {
211206 struct fpga_manager *mgr = dev_get_drvdata(dev);
212207
213208 dev_dbg(dev, "%s\n", __func__);
214209
215210 fpga_mgr_unregister(mgr);
216
-
217
- return 0;
218211 }
219212 EXPORT_SYMBOL_GPL(alt_pr_unregister);
220213