hc
2023-12-09 b22da3d8526a935aa31e086e63f60ff3246cb61c
kernel/drivers/char/ipmi/ipmi_smic_sm.c
....@@ -21,6 +21,8 @@
2121 * 2001 Hewlett-Packard Company
2222 */
2323
24
+#define DEBUG /* So dev_dbg() is always available. */
25
+
2426 #include <linux/kernel.h> /* For printk. */
2527 #include <linux/string.h>
2628 #include <linux/module.h>
....@@ -126,14 +128,17 @@
126128 if (size > MAX_SMIC_WRITE_SIZE)
127129 return IPMI_REQ_LEN_EXCEEDED_ERR;
128130
129
- if ((smic->state != SMIC_IDLE) && (smic->state != SMIC_HOSED))
131
+ if ((smic->state != SMIC_IDLE) && (smic->state != SMIC_HOSED)) {
132
+ dev_warn(smic->io->dev,
133
+ "SMIC in invalid state %d\n", smic->state);
130134 return IPMI_NOT_IN_MY_STATE_ERR;
135
+ }
131136
132137 if (smic_debug & SMIC_DEBUG_MSG) {
133
- printk(KERN_DEBUG "start_smic_transaction -");
138
+ dev_dbg(smic->io->dev, "%s -", __func__);
134139 for (i = 0; i < size; i++)
135
- printk(" %02x", (unsigned char) data[i]);
136
- printk("\n");
140
+ pr_cont(" %02x", data[i]);
141
+ pr_cont("\n");
137142 }
138143 smic->error_retries = 0;
139144 memcpy(smic->write_data, data, size);
....@@ -152,10 +157,10 @@
152157 int i;
153158
154159 if (smic_debug & SMIC_DEBUG_MSG) {
155
- printk(KERN_DEBUG "smic_get result -");
160
+ dev_dbg(smic->io->dev, "smic_get result -");
156161 for (i = 0; i < smic->read_pos; i++)
157
- printk(" %02x", smic->read_data[i]);
158
- printk("\n");
162
+ pr_cont(" %02x", smic->read_data[i]);
163
+ pr_cont("\n");
159164 }
160165 if (length < smic->read_pos) {
161166 smic->read_pos = length;
....@@ -212,8 +217,7 @@
212217 (smic->error_retries)++;
213218 if (smic->error_retries > SMIC_MAX_ERROR_RETRIES) {
214219 if (smic_debug & SMIC_DEBUG_ENABLE)
215
- printk(KERN_WARNING
216
- "ipmi_smic_drv: smic hosed: %s\n", reason);
220
+ pr_warn("ipmi_smic_drv: smic hosed: %s\n", reason);
217221 smic->state = SMIC_HOSED;
218222 } else {
219223 smic->write_count = smic->orig_write_count;
....@@ -325,10 +329,9 @@
325329 }
326330 if (smic->state != SMIC_IDLE) {
327331 if (smic_debug & SMIC_DEBUG_STATES)
328
- printk(KERN_DEBUG
329
- "smic_event - smic->smic_timeout = %ld,"
330
- " time = %ld\n",
331
- smic->smic_timeout, time);
332
+ dev_dbg(smic->io->dev,
333
+ "%s - smic->smic_timeout = %ld, time = %ld\n",
334
+ __func__, smic->smic_timeout, time);
332335 /*
333336 * FIXME: smic_event is sometimes called with time >
334337 * SMIC_RETRY_TIMEOUT
....@@ -347,10 +350,9 @@
347350
348351 status = read_smic_status(smic);
349352 if (smic_debug & SMIC_DEBUG_STATES)
350
- printk(KERN_DEBUG
351
- "smic_event - state = %d, flags = 0x%02x,"
352
- " status = 0x%02x\n",
353
- smic->state, flags, status);
353
+ dev_dbg(smic->io->dev,
354
+ "%s - state = %d, flags = 0x%02x, status = 0x%02x\n",
355
+ __func__, smic->state, flags, status);
354356
355357 switch (smic->state) {
356358 case SMIC_IDLE:
....@@ -440,8 +442,9 @@
440442 data = read_smic_data(smic);
441443 if (data != 0) {
442444 if (smic_debug & SMIC_DEBUG_ENABLE)
443
- printk(KERN_DEBUG
444
- "SMIC_WRITE_END: data = %02x\n", data);
445
+ dev_dbg(smic->io->dev,
446
+ "SMIC_WRITE_END: data = %02x\n",
447
+ data);
445448 start_error_recovery(smic,
446449 "state = SMIC_WRITE_END, "
447450 "data != SUCCESS");
....@@ -520,8 +523,9 @@
520523 /* data register holds an error code */
521524 if (data != 0) {
522525 if (smic_debug & SMIC_DEBUG_ENABLE)
523
- printk(KERN_DEBUG
524
- "SMIC_READ_END: data = %02x\n", data);
526
+ dev_dbg(smic->io->dev,
527
+ "SMIC_READ_END: data = %02x\n",
528
+ data);
525529 start_error_recovery(smic,
526530 "state = SMIC_READ_END, "
527531 "data != SUCCESS");
....@@ -537,7 +541,8 @@
537541
538542 default:
539543 if (smic_debug & SMIC_DEBUG_ENABLE) {
540
- printk(KERN_DEBUG "smic->state = %d\n", smic->state);
544
+ dev_dbg(smic->io->dev,
545
+ "smic->state = %d\n", smic->state);
541546 start_error_recovery(smic, "state = UNKNOWN");
542547 return SI_SM_CALL_WITH_DELAY;
543548 }