hc
2023-12-09 b22da3d8526a935aa31e086e63f60ff3246cb61c
kernel/drivers/char/ipmi/ipmi_kcs_sm.c
....@@ -17,6 +17,8 @@
1717 * that document.
1818 */
1919
20
+#define DEBUG /* So dev_dbg() is always available. */
21
+
2022 #include <linux/kernel.h> /* For printk. */
2123 #include <linux/module.h>
2224 #include <linux/moduleparam.h>
....@@ -187,8 +189,8 @@
187189 (kcs->error_retries)++;
188190 if (kcs->error_retries > MAX_ERROR_RETRIES) {
189191 if (kcs_debug & KCS_DEBUG_ENABLE)
190
- printk(KERN_DEBUG "ipmi_kcs_sm: kcs hosed: %s\n",
191
- reason);
192
+ dev_dbg(kcs->io->dev, "ipmi_kcs_sm: kcs hosed: %s\n",
193
+ reason);
192194 kcs->state = KCS_HOSED;
193195 } else {
194196 kcs->error0_timeout = jiffies + ERROR0_OBF_WAIT_JIFFIES;
....@@ -268,14 +270,16 @@
268270 if (size > MAX_KCS_WRITE_SIZE)
269271 return IPMI_REQ_LEN_EXCEEDED_ERR;
270272
271
- if ((kcs->state != KCS_IDLE) && (kcs->state != KCS_HOSED))
273
+ if ((kcs->state != KCS_IDLE) && (kcs->state != KCS_HOSED)) {
274
+ dev_warn(kcs->io->dev, "KCS in invalid state %d\n", kcs->state);
272275 return IPMI_NOT_IN_MY_STATE_ERR;
276
+ }
273277
274278 if (kcs_debug & KCS_DEBUG_MSG) {
275
- printk(KERN_DEBUG "start_kcs_transaction -");
279
+ dev_dbg(kcs->io->dev, "%s -", __func__);
276280 for (i = 0; i < size; i++)
277
- printk(" %02x", (unsigned char) (data [i]));
278
- printk("\n");
281
+ pr_cont(" %02x", data[i]);
282
+ pr_cont("\n");
279283 }
280284 kcs->error_retries = 0;
281285 memcpy(kcs->write_data, data, size);
....@@ -331,7 +335,8 @@
331335 status = read_status(kcs);
332336
333337 if (kcs_debug & KCS_DEBUG_STATES)
334
- printk(KERN_DEBUG "KCS: State = %d, %x\n", kcs->state, status);
338
+ dev_dbg(kcs->io->dev,
339
+ "KCS: State = %d, %x\n", kcs->state, status);
335340
336341 /* All states wait for ibf, so just do it here. */
337342 if (!check_ibf(kcs, status, time))