hc
2024-10-12 a5969cabbb4660eab42b6ef0412cbbd1200cf14d
kernel/drivers/i2c/busses/i2c-mv64xxx.c
....@@ -251,7 +251,7 @@
251251 MV64XXX_I2C_STATE_WAITING_FOR_ADDR_2_ACK;
252252 break;
253253 }
254
- /* FALLTHRU */
254
+ fallthrough;
255255 case MV64XXX_I2C_STATUS_MAST_WR_ADDR_2_ACK: /* 0xd0 */
256256 case MV64XXX_I2C_STATUS_MAST_WR_ACK: /* 0x28 */
257257 if ((drv_data->bytes_left == 0)
....@@ -282,14 +282,14 @@
282282 MV64XXX_I2C_STATE_WAITING_FOR_ADDR_2_ACK;
283283 break;
284284 }
285
- /* FALLTHRU */
285
+ fallthrough;
286286 case MV64XXX_I2C_STATUS_MAST_RD_ADDR_2_ACK: /* 0xe0 */
287287 if (drv_data->bytes_left == 0) {
288288 drv_data->action = MV64XXX_I2C_ACTION_SEND_STOP;
289289 drv_data->state = MV64XXX_I2C_STATE_IDLE;
290290 break;
291291 }
292
- /* FALLTHRU */
292
+ fallthrough;
293293 case MV64XXX_I2C_STATUS_MAST_RD_DATA_ACK: /* 0x50 */
294294 if (status != MV64XXX_I2C_STATUS_MAST_RD_DATA_ACK)
295295 drv_data->action = MV64XXX_I2C_ACTION_CONTINUE;
....@@ -417,8 +417,7 @@
417417 "mv64xxx_i2c_do_action: Invalid action: %d\n",
418418 drv_data->action);
419419 drv_data->rc = -EIO;
420
-
421
- /* FALLTHRU */
420
+ fallthrough;
422421 case MV64XXX_I2C_ACTION_SEND_STOP:
423422 drv_data->cntl_bits &= ~MV64XXX_I2C_REG_CONTROL_INTEN;
424423 writel(drv_data->cntl_bits | MV64XXX_I2C_REG_CONTROL_STOP,
....@@ -497,11 +496,10 @@
497496 mv64xxx_i2c_intr(int irq, void *dev_id)
498497 {
499498 struct mv64xxx_i2c_data *drv_data = dev_id;
500
- unsigned long flags;
501499 u32 status;
502500 irqreturn_t rc = IRQ_NONE;
503501
504
- spin_lock_irqsave(&drv_data->lock, flags);
502
+ spin_lock(&drv_data->lock);
505503
506504 if (drv_data->offload_enabled)
507505 rc = mv64xxx_i2c_intr_offload(drv_data);
....@@ -518,7 +516,7 @@
518516
519517 rc = IRQ_HANDLED;
520518 }
521
- spin_unlock_irqrestore(&drv_data->lock, flags);
519
+ spin_unlock(&drv_data->lock);
522520
523521 return rc;
524522 }
....@@ -810,7 +808,7 @@
810808 tclk = clk_get_rate(drv_data->clk);
811809
812810 if (of_property_read_u32(np, "clock-frequency", &bus_freq))
813
- bus_freq = 100000; /* 100kHz by default */
811
+ bus_freq = I2C_MAX_STANDARD_MODE_FREQ; /* 100kHz by default */
814812
815813 if (of_device_is_compatible(np, "allwinner,sun4i-a10-i2c") ||
816814 of_device_is_compatible(np, "allwinner,sun6i-a31-i2c"))
....@@ -846,14 +844,14 @@
846844 if (of_device_is_compatible(np, "marvell,mv78230-i2c")) {
847845 drv_data->offload_enabled = true;
848846 /* The delay is only needed in standard mode (100kHz) */
849
- if (bus_freq <= 100000)
847
+ if (bus_freq <= I2C_MAX_STANDARD_MODE_FREQ)
850848 drv_data->errata_delay = true;
851849 }
852850
853851 if (of_device_is_compatible(np, "marvell,mv78230-a0-i2c")) {
854852 drv_data->offload_enabled = false;
855853 /* The delay is only needed in standard mode (100kHz) */
856
- if (bus_freq <= 100000)
854
+ if (bus_freq <= I2C_MAX_STANDARD_MODE_FREQ)
857855 drv_data->errata_delay = true;
858856 }
859857
....@@ -877,7 +875,6 @@
877875 {
878876 struct mv64xxx_i2c_data *drv_data;
879877 struct mv64xxx_i2c_pdata *pdata = dev_get_platdata(&pd->dev);
880
- struct resource *r;
881878 int rc;
882879
883880 if ((!pdata && !pd->dev.of_node))
....@@ -888,8 +885,7 @@
888885 if (!drv_data)
889886 return -ENOMEM;
890887
891
- r = platform_get_resource(pd, IORESOURCE_MEM, 0);
892
- drv_data->reg_base = devm_ioremap_resource(&pd->dev, r);
888
+ drv_data->reg_base = devm_platform_ioremap_resource(pd, 0);
893889 if (IS_ERR(drv_data->reg_base))
894890 return PTR_ERR(drv_data->reg_base);
895891
....@@ -901,14 +897,13 @@
901897
902898 /* Not all platforms have clocks */
903899 drv_data->clk = devm_clk_get(&pd->dev, NULL);
904
- if (IS_ERR(drv_data->clk) && PTR_ERR(drv_data->clk) == -EPROBE_DEFER)
900
+ if (PTR_ERR(drv_data->clk) == -EPROBE_DEFER)
905901 return -EPROBE_DEFER;
906902 if (!IS_ERR(drv_data->clk))
907903 clk_prepare_enable(drv_data->clk);
908904
909905 drv_data->reg_clk = devm_clk_get(&pd->dev, "reg");
910
- if (IS_ERR(drv_data->reg_clk) &&
911
- PTR_ERR(drv_data->reg_clk) == -EPROBE_DEFER)
906
+ if (PTR_ERR(drv_data->reg_clk) == -EPROBE_DEFER)
912907 return -EPROBE_DEFER;
913908 if (!IS_ERR(drv_data->reg_clk))
914909 clk_prepare_enable(drv_data->reg_clk);