| .. | .. |
|---|
| 1 | +// SPDX-License-Identifier: GPL-2.0-or-later |
|---|
| 1 | 2 | /* Server address list management |
|---|
| 2 | 3 | * |
|---|
| 3 | 4 | * Copyright (C) 2017 Red Hat, Inc. All Rights Reserved. |
|---|
| 4 | 5 | * Written by David Howells (dhowells@redhat.com) |
|---|
| 5 | | - * |
|---|
| 6 | | - * This program is free software; you can redistribute it and/or |
|---|
| 7 | | - * modify it under the terms of the GNU General Public Licence |
|---|
| 8 | | - * as published by the Free Software Foundation; either version |
|---|
| 9 | | - * 2 of the Licence, or (at your option) any later version. |
|---|
| 10 | 6 | */ |
|---|
| 11 | 7 | |
|---|
| 12 | 8 | #include <linux/slab.h> |
|---|
| .. | .. |
|---|
| 17 | 13 | #include "internal.h" |
|---|
| 18 | 14 | #include "afs_fs.h" |
|---|
| 19 | 15 | |
|---|
| 20 | | -//#define AFS_MAX_ADDRESSES |
|---|
| 21 | | -// ((unsigned int)((PAGE_SIZE - sizeof(struct afs_addr_list)) / |
|---|
| 22 | | -// sizeof(struct sockaddr_rxrpc))) |
|---|
| 23 | | -#define AFS_MAX_ADDRESSES ((unsigned int)(sizeof(unsigned long) * 8)) |
|---|
| 24 | | - |
|---|
| 25 | 16 | /* |
|---|
| 26 | 17 | * Release an address list. |
|---|
| 27 | 18 | */ |
|---|
| 28 | 19 | void afs_put_addrlist(struct afs_addr_list *alist) |
|---|
| 29 | 20 | { |
|---|
| 30 | 21 | if (alist && refcount_dec_and_test(&alist->usage)) |
|---|
| 31 | | - call_rcu(&alist->rcu, (rcu_callback_t)kfree); |
|---|
| 22 | + kfree_rcu(alist, rcu); |
|---|
| 32 | 23 | } |
|---|
| 33 | 24 | |
|---|
| 34 | 25 | /* |
|---|
| .. | .. |
|---|
| 43 | 34 | |
|---|
| 44 | 35 | _enter("%u,%u,%u", nr, service, port); |
|---|
| 45 | 36 | |
|---|
| 37 | + if (nr > AFS_MAX_ADDRESSES) |
|---|
| 38 | + nr = AFS_MAX_ADDRESSES; |
|---|
| 39 | + |
|---|
| 46 | 40 | alist = kzalloc(struct_size(alist, addrs, nr), GFP_KERNEL); |
|---|
| 47 | 41 | if (!alist) |
|---|
| 48 | 42 | return NULL; |
|---|
| 49 | 43 | |
|---|
| 50 | 44 | refcount_set(&alist->usage, 1); |
|---|
| 45 | + alist->max_addrs = nr; |
|---|
| 51 | 46 | |
|---|
| 52 | 47 | for (i = 0; i < nr; i++) { |
|---|
| 53 | 48 | struct sockaddr_rxrpc *srx = &alist->addrs[i]; |
|---|
| .. | .. |
|---|
| 65 | 60 | /* |
|---|
| 66 | 61 | * Parse a text string consisting of delimited addresses. |
|---|
| 67 | 62 | */ |
|---|
| 68 | | -struct afs_addr_list *afs_parse_text_addrs(const char *text, size_t len, |
|---|
| 69 | | - char delim, |
|---|
| 70 | | - unsigned short service, |
|---|
| 71 | | - unsigned short port) |
|---|
| 63 | +struct afs_vlserver_list *afs_parse_text_addrs(struct afs_net *net, |
|---|
| 64 | + const char *text, size_t len, |
|---|
| 65 | + char delim, |
|---|
| 66 | + unsigned short service, |
|---|
| 67 | + unsigned short port) |
|---|
| 72 | 68 | { |
|---|
| 69 | + struct afs_vlserver_list *vllist; |
|---|
| 73 | 70 | struct afs_addr_list *alist; |
|---|
| 74 | 71 | const char *p, *end = text + len; |
|---|
| 72 | + const char *problem; |
|---|
| 75 | 73 | unsigned int nr = 0; |
|---|
| 74 | + int ret = -ENOMEM; |
|---|
| 76 | 75 | |
|---|
| 77 | 76 | _enter("%*.*s,%c", (int)len, (int)len, text, delim); |
|---|
| 78 | 77 | |
|---|
| 79 | | - if (!len) |
|---|
| 78 | + if (!len) { |
|---|
| 79 | + _leave(" = -EDESTADDRREQ [empty]"); |
|---|
| 80 | 80 | return ERR_PTR(-EDESTADDRREQ); |
|---|
| 81 | + } |
|---|
| 81 | 82 | |
|---|
| 82 | 83 | if (delim == ':' && (memchr(text, ',', len) || !memchr(text, '.', len))) |
|---|
| 83 | 84 | delim = ','; |
|---|
| .. | .. |
|---|
| 85 | 86 | /* Count the addresses */ |
|---|
| 86 | 87 | p = text; |
|---|
| 87 | 88 | do { |
|---|
| 88 | | - if (!*p) |
|---|
| 89 | | - return ERR_PTR(-EINVAL); |
|---|
| 89 | + if (!*p) { |
|---|
| 90 | + problem = "nul"; |
|---|
| 91 | + goto inval; |
|---|
| 92 | + } |
|---|
| 90 | 93 | if (*p == delim) |
|---|
| 91 | 94 | continue; |
|---|
| 92 | 95 | nr++; |
|---|
| 93 | 96 | if (*p == '[') { |
|---|
| 94 | 97 | p++; |
|---|
| 95 | | - if (p == end) |
|---|
| 96 | | - return ERR_PTR(-EINVAL); |
|---|
| 98 | + if (p == end) { |
|---|
| 99 | + problem = "brace1"; |
|---|
| 100 | + goto inval; |
|---|
| 101 | + } |
|---|
| 97 | 102 | p = memchr(p, ']', end - p); |
|---|
| 98 | | - if (!p) |
|---|
| 99 | | - return ERR_PTR(-EINVAL); |
|---|
| 103 | + if (!p) { |
|---|
| 104 | + problem = "brace2"; |
|---|
| 105 | + goto inval; |
|---|
| 106 | + } |
|---|
| 100 | 107 | p++; |
|---|
| 101 | 108 | if (p >= end) |
|---|
| 102 | 109 | break; |
|---|
| .. | .. |
|---|
| 109 | 116 | } while (p < end); |
|---|
| 110 | 117 | |
|---|
| 111 | 118 | _debug("%u/%u addresses", nr, AFS_MAX_ADDRESSES); |
|---|
| 112 | | - if (nr > AFS_MAX_ADDRESSES) |
|---|
| 113 | | - nr = AFS_MAX_ADDRESSES; |
|---|
| 114 | 119 | |
|---|
| 115 | | - alist = afs_alloc_addrlist(nr, service, port); |
|---|
| 116 | | - if (!alist) |
|---|
| 120 | + vllist = afs_alloc_vlserver_list(1); |
|---|
| 121 | + if (!vllist) |
|---|
| 117 | 122 | return ERR_PTR(-ENOMEM); |
|---|
| 123 | + |
|---|
| 124 | + vllist->nr_servers = 1; |
|---|
| 125 | + vllist->servers[0].server = afs_alloc_vlserver("<dummy>", 7, AFS_VL_PORT); |
|---|
| 126 | + if (!vllist->servers[0].server) |
|---|
| 127 | + goto error_vl; |
|---|
| 128 | + |
|---|
| 129 | + alist = afs_alloc_addrlist(nr, service, AFS_VL_PORT); |
|---|
| 130 | + if (!alist) |
|---|
| 131 | + goto error; |
|---|
| 118 | 132 | |
|---|
| 119 | 133 | /* Extract the addresses */ |
|---|
| 120 | 134 | p = text; |
|---|
| 121 | 135 | do { |
|---|
| 122 | | - struct sockaddr_rxrpc *srx = &alist->addrs[alist->nr_addrs]; |
|---|
| 123 | 136 | const char *q, *stop; |
|---|
| 137 | + unsigned int xport = port; |
|---|
| 138 | + __be32 x[4]; |
|---|
| 139 | + int family; |
|---|
| 124 | 140 | |
|---|
| 125 | 141 | if (*p == delim) { |
|---|
| 126 | 142 | p++; |
|---|
| .. | .. |
|---|
| 136 | 152 | break; |
|---|
| 137 | 153 | } |
|---|
| 138 | 154 | |
|---|
| 139 | | - if (in4_pton(p, q - p, |
|---|
| 140 | | - (u8 *)&srx->transport.sin6.sin6_addr.s6_addr32[3], |
|---|
| 141 | | - -1, &stop)) { |
|---|
| 142 | | - srx->transport.sin6.sin6_addr.s6_addr32[0] = 0; |
|---|
| 143 | | - srx->transport.sin6.sin6_addr.s6_addr32[1] = 0; |
|---|
| 144 | | - srx->transport.sin6.sin6_addr.s6_addr32[2] = htonl(0xffff); |
|---|
| 145 | | - } else if (in6_pton(p, q - p, |
|---|
| 146 | | - srx->transport.sin6.sin6_addr.s6_addr, |
|---|
| 147 | | - -1, &stop)) { |
|---|
| 148 | | - /* Nothing to do */ |
|---|
| 155 | + if (in4_pton(p, q - p, (u8 *)&x[0], -1, &stop)) { |
|---|
| 156 | + family = AF_INET; |
|---|
| 157 | + } else if (in6_pton(p, q - p, (u8 *)x, -1, &stop)) { |
|---|
| 158 | + family = AF_INET6; |
|---|
| 149 | 159 | } else { |
|---|
| 160 | + problem = "family"; |
|---|
| 150 | 161 | goto bad_address; |
|---|
| 151 | 162 | } |
|---|
| 152 | 163 | |
|---|
| 153 | | - if (stop != q) |
|---|
| 154 | | - goto bad_address; |
|---|
| 155 | | - |
|---|
| 156 | 164 | p = q; |
|---|
| 165 | + if (stop != p) { |
|---|
| 166 | + problem = "nostop"; |
|---|
| 167 | + goto bad_address; |
|---|
| 168 | + } |
|---|
| 169 | + |
|---|
| 157 | 170 | if (q < end && *q == ']') |
|---|
| 158 | 171 | p++; |
|---|
| 159 | 172 | |
|---|
| 160 | 173 | if (p < end) { |
|---|
| 161 | 174 | if (*p == '+') { |
|---|
| 162 | 175 | /* Port number specification "+1234" */ |
|---|
| 163 | | - unsigned int xport = 0; |
|---|
| 176 | + xport = 0; |
|---|
| 164 | 177 | p++; |
|---|
| 165 | | - if (p >= end || !isdigit(*p)) |
|---|
| 178 | + if (p >= end || !isdigit(*p)) { |
|---|
| 179 | + problem = "port"; |
|---|
| 166 | 180 | goto bad_address; |
|---|
| 181 | + } |
|---|
| 167 | 182 | do { |
|---|
| 168 | 183 | xport *= 10; |
|---|
| 169 | 184 | xport += *p - '0'; |
|---|
| 170 | | - if (xport > 65535) |
|---|
| 185 | + if (xport > 65535) { |
|---|
| 186 | + problem = "pval"; |
|---|
| 171 | 187 | goto bad_address; |
|---|
| 188 | + } |
|---|
| 172 | 189 | p++; |
|---|
| 173 | 190 | } while (p < end && isdigit(*p)); |
|---|
| 174 | | - srx->transport.sin6.sin6_port = htons(xport); |
|---|
| 175 | 191 | } else if (*p == delim) { |
|---|
| 176 | 192 | p++; |
|---|
| 177 | 193 | } else { |
|---|
| 194 | + problem = "weird"; |
|---|
| 178 | 195 | goto bad_address; |
|---|
| 179 | 196 | } |
|---|
| 180 | 197 | } |
|---|
| 181 | 198 | |
|---|
| 182 | | - alist->nr_addrs++; |
|---|
| 183 | | - } while (p < end && alist->nr_addrs < AFS_MAX_ADDRESSES); |
|---|
| 199 | + if (family == AF_INET) |
|---|
| 200 | + afs_merge_fs_addr4(alist, x[0], xport); |
|---|
| 201 | + else |
|---|
| 202 | + afs_merge_fs_addr6(alist, x, xport); |
|---|
| 184 | 203 | |
|---|
| 204 | + } while (p < end); |
|---|
| 205 | + |
|---|
| 206 | + rcu_assign_pointer(vllist->servers[0].server->addresses, alist); |
|---|
| 185 | 207 | _leave(" = [nr %u]", alist->nr_addrs); |
|---|
| 186 | | - return alist; |
|---|
| 208 | + return vllist; |
|---|
| 187 | 209 | |
|---|
| 188 | | -bad_address: |
|---|
| 189 | | - kfree(alist); |
|---|
| 210 | +inval: |
|---|
| 211 | + _leave(" = -EINVAL [%s %zu %*.*s]", |
|---|
| 212 | + problem, p - text, (int)len, (int)len, text); |
|---|
| 190 | 213 | return ERR_PTR(-EINVAL); |
|---|
| 214 | +bad_address: |
|---|
| 215 | + _leave(" = -EINVAL [%s %zu %*.*s]", |
|---|
| 216 | + problem, p - text, (int)len, (int)len, text); |
|---|
| 217 | + ret = -EINVAL; |
|---|
| 218 | +error: |
|---|
| 219 | + afs_put_addrlist(alist); |
|---|
| 220 | +error_vl: |
|---|
| 221 | + afs_put_vlserverlist(net, vllist); |
|---|
| 222 | + return ERR_PTR(ret); |
|---|
| 191 | 223 | } |
|---|
| 192 | 224 | |
|---|
| 193 | 225 | /* |
|---|
| .. | .. |
|---|
| 206 | 238 | /* |
|---|
| 207 | 239 | * Perform a DNS query for VL servers and build a up an address list. |
|---|
| 208 | 240 | */ |
|---|
| 209 | | -struct afs_addr_list *afs_dns_query(struct afs_cell *cell, time64_t *_expiry) |
|---|
| 241 | +struct afs_vlserver_list *afs_dns_query(struct afs_cell *cell, time64_t *_expiry) |
|---|
| 210 | 242 | { |
|---|
| 211 | | - struct afs_addr_list *alist; |
|---|
| 212 | | - char *vllist = NULL; |
|---|
| 243 | + struct afs_vlserver_list *vllist; |
|---|
| 244 | + char *result = NULL; |
|---|
| 213 | 245 | int ret; |
|---|
| 214 | 246 | |
|---|
| 215 | 247 | _enter("%s", cell->name); |
|---|
| 216 | 248 | |
|---|
| 217 | | - ret = dns_query("afsdb", cell->name, cell->name_len, |
|---|
| 218 | | - "", &vllist, _expiry); |
|---|
| 219 | | - if (ret < 0) |
|---|
| 249 | + ret = dns_query(cell->net->net, "afsdb", cell->name, cell->name_len, |
|---|
| 250 | + "srv=1", &result, _expiry, true); |
|---|
| 251 | + if (ret < 0) { |
|---|
| 252 | + _leave(" = %d [dns]", ret); |
|---|
| 220 | 253 | return ERR_PTR(ret); |
|---|
| 221 | | - |
|---|
| 222 | | - alist = afs_parse_text_addrs(vllist, strlen(vllist), ',', |
|---|
| 223 | | - VL_SERVICE, AFS_VL_PORT); |
|---|
| 224 | | - if (IS_ERR(alist)) { |
|---|
| 225 | | - kfree(vllist); |
|---|
| 226 | | - if (alist != ERR_PTR(-ENOMEM)) |
|---|
| 227 | | - pr_err("Failed to parse DNS data\n"); |
|---|
| 228 | | - return alist; |
|---|
| 229 | 254 | } |
|---|
| 230 | 255 | |
|---|
| 231 | | - kfree(vllist); |
|---|
| 232 | | - return alist; |
|---|
| 256 | + if (*_expiry == 0) |
|---|
| 257 | + *_expiry = ktime_get_real_seconds() + 60; |
|---|
| 258 | + |
|---|
| 259 | + if (ret > 1 && result[0] == 0) |
|---|
| 260 | + vllist = afs_extract_vlserver_list(cell, result, ret); |
|---|
| 261 | + else |
|---|
| 262 | + vllist = afs_parse_text_addrs(cell->net, result, ret, ',', |
|---|
| 263 | + VL_SERVICE, AFS_VL_PORT); |
|---|
| 264 | + kfree(result); |
|---|
| 265 | + if (IS_ERR(vllist) && vllist != ERR_PTR(-ENOMEM)) |
|---|
| 266 | + pr_err("Failed to parse DNS data %ld\n", PTR_ERR(vllist)); |
|---|
| 267 | + |
|---|
| 268 | + return vllist; |
|---|
| 233 | 269 | } |
|---|
| 234 | 270 | |
|---|
| 235 | 271 | /* |
|---|
| .. | .. |
|---|
| 237 | 273 | */ |
|---|
| 238 | 274 | void afs_merge_fs_addr4(struct afs_addr_list *alist, __be32 xdr, u16 port) |
|---|
| 239 | 275 | { |
|---|
| 240 | | - struct sockaddr_in6 *a; |
|---|
| 241 | | - __be16 xport = htons(port); |
|---|
| 276 | + struct sockaddr_rxrpc *srx; |
|---|
| 277 | + u32 addr = ntohl(xdr); |
|---|
| 242 | 278 | int i; |
|---|
| 243 | 279 | |
|---|
| 280 | + if (alist->nr_addrs >= alist->max_addrs) |
|---|
| 281 | + return; |
|---|
| 282 | + |
|---|
| 244 | 283 | for (i = 0; i < alist->nr_ipv4; i++) { |
|---|
| 245 | | - a = &alist->addrs[i].transport.sin6; |
|---|
| 246 | | - if (xdr == a->sin6_addr.s6_addr32[3] && |
|---|
| 247 | | - xport == a->sin6_port) |
|---|
| 284 | + struct sockaddr_in *a = &alist->addrs[i].transport.sin; |
|---|
| 285 | + u32 a_addr = ntohl(a->sin_addr.s_addr); |
|---|
| 286 | + u16 a_port = ntohs(a->sin_port); |
|---|
| 287 | + |
|---|
| 288 | + if (addr == a_addr && port == a_port) |
|---|
| 248 | 289 | return; |
|---|
| 249 | | - if (xdr == a->sin6_addr.s6_addr32[3] && |
|---|
| 250 | | - (u16 __force)xport < (u16 __force)a->sin6_port) |
|---|
| 290 | + if (addr == a_addr && port < a_port) |
|---|
| 251 | 291 | break; |
|---|
| 252 | | - if ((u32 __force)xdr < (u32 __force)a->sin6_addr.s6_addr32[3]) |
|---|
| 292 | + if (addr < a_addr) |
|---|
| 253 | 293 | break; |
|---|
| 254 | 294 | } |
|---|
| 255 | 295 | |
|---|
| .. | .. |
|---|
| 258 | 298 | alist->addrs + i, |
|---|
| 259 | 299 | sizeof(alist->addrs[0]) * (alist->nr_addrs - i)); |
|---|
| 260 | 300 | |
|---|
| 261 | | - a = &alist->addrs[i].transport.sin6; |
|---|
| 262 | | - a->sin6_port = xport; |
|---|
| 263 | | - a->sin6_addr.s6_addr32[0] = 0; |
|---|
| 264 | | - a->sin6_addr.s6_addr32[1] = 0; |
|---|
| 265 | | - a->sin6_addr.s6_addr32[2] = htonl(0xffff); |
|---|
| 266 | | - a->sin6_addr.s6_addr32[3] = xdr; |
|---|
| 301 | + srx = &alist->addrs[i]; |
|---|
| 302 | + srx->srx_family = AF_RXRPC; |
|---|
| 303 | + srx->transport_type = SOCK_DGRAM; |
|---|
| 304 | + srx->transport_len = sizeof(srx->transport.sin); |
|---|
| 305 | + srx->transport.sin.sin_family = AF_INET; |
|---|
| 306 | + srx->transport.sin.sin_port = htons(port); |
|---|
| 307 | + srx->transport.sin.sin_addr.s_addr = xdr; |
|---|
| 267 | 308 | alist->nr_ipv4++; |
|---|
| 268 | 309 | alist->nr_addrs++; |
|---|
| 269 | 310 | } |
|---|
| .. | .. |
|---|
| 273 | 314 | */ |
|---|
| 274 | 315 | void afs_merge_fs_addr6(struct afs_addr_list *alist, __be32 *xdr, u16 port) |
|---|
| 275 | 316 | { |
|---|
| 276 | | - struct sockaddr_in6 *a; |
|---|
| 277 | | - __be16 xport = htons(port); |
|---|
| 317 | + struct sockaddr_rxrpc *srx; |
|---|
| 278 | 318 | int i, diff; |
|---|
| 279 | 319 | |
|---|
| 320 | + if (alist->nr_addrs >= alist->max_addrs) |
|---|
| 321 | + return; |
|---|
| 322 | + |
|---|
| 280 | 323 | for (i = alist->nr_ipv4; i < alist->nr_addrs; i++) { |
|---|
| 281 | | - a = &alist->addrs[i].transport.sin6; |
|---|
| 324 | + struct sockaddr_in6 *a = &alist->addrs[i].transport.sin6; |
|---|
| 325 | + u16 a_port = ntohs(a->sin6_port); |
|---|
| 326 | + |
|---|
| 282 | 327 | diff = memcmp(xdr, &a->sin6_addr, 16); |
|---|
| 283 | | - if (diff == 0 && |
|---|
| 284 | | - xport == a->sin6_port) |
|---|
| 328 | + if (diff == 0 && port == a_port) |
|---|
| 285 | 329 | return; |
|---|
| 286 | | - if (diff == 0 && |
|---|
| 287 | | - (u16 __force)xport < (u16 __force)a->sin6_port) |
|---|
| 330 | + if (diff == 0 && port < a_port) |
|---|
| 288 | 331 | break; |
|---|
| 289 | 332 | if (diff < 0) |
|---|
| 290 | 333 | break; |
|---|
| .. | .. |
|---|
| 295 | 338 | alist->addrs + i, |
|---|
| 296 | 339 | sizeof(alist->addrs[0]) * (alist->nr_addrs - i)); |
|---|
| 297 | 340 | |
|---|
| 298 | | - a = &alist->addrs[i].transport.sin6; |
|---|
| 299 | | - a->sin6_port = xport; |
|---|
| 300 | | - a->sin6_addr.s6_addr32[0] = xdr[0]; |
|---|
| 301 | | - a->sin6_addr.s6_addr32[1] = xdr[1]; |
|---|
| 302 | | - a->sin6_addr.s6_addr32[2] = xdr[2]; |
|---|
| 303 | | - a->sin6_addr.s6_addr32[3] = xdr[3]; |
|---|
| 341 | + srx = &alist->addrs[i]; |
|---|
| 342 | + srx->srx_family = AF_RXRPC; |
|---|
| 343 | + srx->transport_type = SOCK_DGRAM; |
|---|
| 344 | + srx->transport_len = sizeof(srx->transport.sin6); |
|---|
| 345 | + srx->transport.sin6.sin6_family = AF_INET6; |
|---|
| 346 | + srx->transport.sin6.sin6_port = htons(port); |
|---|
| 347 | + memcpy(&srx->transport.sin6.sin6_addr, xdr, 16); |
|---|
| 304 | 348 | alist->nr_addrs++; |
|---|
| 305 | 349 | } |
|---|
| 306 | 350 | |
|---|
| .. | .. |
|---|
| 309 | 353 | */ |
|---|
| 310 | 354 | bool afs_iterate_addresses(struct afs_addr_cursor *ac) |
|---|
| 311 | 355 | { |
|---|
| 312 | | - _enter("%hu+%hd", ac->start, (short)ac->index); |
|---|
| 356 | + unsigned long set, failed; |
|---|
| 357 | + int index; |
|---|
| 313 | 358 | |
|---|
| 314 | 359 | if (!ac->alist) |
|---|
| 315 | 360 | return false; |
|---|
| 316 | 361 | |
|---|
| 317 | | - if (ac->begun) { |
|---|
| 318 | | - ac->index++; |
|---|
| 319 | | - if (ac->index == ac->alist->nr_addrs) |
|---|
| 320 | | - ac->index = 0; |
|---|
| 362 | + set = ac->alist->responded; |
|---|
| 363 | + failed = ac->alist->failed; |
|---|
| 364 | + _enter("%lx-%lx-%lx,%d", set, failed, ac->tried, ac->index); |
|---|
| 321 | 365 | |
|---|
| 322 | | - if (ac->index == ac->start) { |
|---|
| 323 | | - ac->error = -EDESTADDRREQ; |
|---|
| 324 | | - return false; |
|---|
| 325 | | - } |
|---|
| 326 | | - } |
|---|
| 366 | + ac->nr_iterations++; |
|---|
| 327 | 367 | |
|---|
| 328 | | - ac->begun = true; |
|---|
| 368 | + set &= ~(failed | ac->tried); |
|---|
| 369 | + |
|---|
| 370 | + if (!set) |
|---|
| 371 | + return false; |
|---|
| 372 | + |
|---|
| 373 | + index = READ_ONCE(ac->alist->preferred); |
|---|
| 374 | + if (test_bit(index, &set)) |
|---|
| 375 | + goto selected; |
|---|
| 376 | + |
|---|
| 377 | + index = __ffs(set); |
|---|
| 378 | + |
|---|
| 379 | +selected: |
|---|
| 380 | + ac->index = index; |
|---|
| 381 | + set_bit(index, &ac->tried); |
|---|
| 329 | 382 | ac->responded = false; |
|---|
| 330 | | - ac->addr = &ac->alist->addrs[ac->index]; |
|---|
| 331 | 383 | return true; |
|---|
| 332 | 384 | } |
|---|
| 333 | 385 | |
|---|
| .. | .. |
|---|
| 340 | 392 | |
|---|
| 341 | 393 | alist = ac->alist; |
|---|
| 342 | 394 | if (alist) { |
|---|
| 343 | | - if (ac->responded && ac->index != ac->start) |
|---|
| 344 | | - WRITE_ONCE(alist->index, ac->index); |
|---|
| 395 | + if (ac->responded && |
|---|
| 396 | + ac->index != alist->preferred && |
|---|
| 397 | + test_bit(ac->alist->preferred, &ac->tried)) |
|---|
| 398 | + WRITE_ONCE(alist->preferred, ac->index); |
|---|
| 345 | 399 | afs_put_addrlist(alist); |
|---|
| 400 | + ac->alist = NULL; |
|---|
| 346 | 401 | } |
|---|
| 347 | 402 | |
|---|
| 348 | | - ac->addr = NULL; |
|---|
| 349 | | - ac->alist = NULL; |
|---|
| 350 | | - ac->begun = false; |
|---|
| 351 | 403 | return ac->error; |
|---|
| 352 | | -} |
|---|
| 353 | | - |
|---|
| 354 | | -/* |
|---|
| 355 | | - * Set the address cursor for iterating over VL servers. |
|---|
| 356 | | - */ |
|---|
| 357 | | -int afs_set_vl_cursor(struct afs_addr_cursor *ac, struct afs_cell *cell) |
|---|
| 358 | | -{ |
|---|
| 359 | | - struct afs_addr_list *alist; |
|---|
| 360 | | - int ret; |
|---|
| 361 | | - |
|---|
| 362 | | - if (!rcu_access_pointer(cell->vl_addrs)) { |
|---|
| 363 | | - ret = wait_on_bit(&cell->flags, AFS_CELL_FL_NO_LOOKUP_YET, |
|---|
| 364 | | - TASK_INTERRUPTIBLE); |
|---|
| 365 | | - if (ret < 0) |
|---|
| 366 | | - return ret; |
|---|
| 367 | | - |
|---|
| 368 | | - if (!rcu_access_pointer(cell->vl_addrs) && |
|---|
| 369 | | - ktime_get_real_seconds() < cell->dns_expiry) |
|---|
| 370 | | - return cell->error; |
|---|
| 371 | | - } |
|---|
| 372 | | - |
|---|
| 373 | | - read_lock(&cell->vl_addrs_lock); |
|---|
| 374 | | - alist = rcu_dereference_protected(cell->vl_addrs, |
|---|
| 375 | | - lockdep_is_held(&cell->vl_addrs_lock)); |
|---|
| 376 | | - if (alist->nr_addrs > 0) |
|---|
| 377 | | - afs_get_addrlist(alist); |
|---|
| 378 | | - else |
|---|
| 379 | | - alist = NULL; |
|---|
| 380 | | - read_unlock(&cell->vl_addrs_lock); |
|---|
| 381 | | - |
|---|
| 382 | | - if (!alist) |
|---|
| 383 | | - return -EDESTADDRREQ; |
|---|
| 384 | | - |
|---|
| 385 | | - ac->alist = alist; |
|---|
| 386 | | - ac->addr = NULL; |
|---|
| 387 | | - ac->start = READ_ONCE(alist->index); |
|---|
| 388 | | - ac->index = ac->start; |
|---|
| 389 | | - ac->error = 0; |
|---|
| 390 | | - ac->begun = false; |
|---|
| 391 | | - return 0; |
|---|
| 392 | 404 | } |
|---|