| .. | .. |
|---|
| 793 | 793 | struct device_node *np) |
|---|
| 794 | 794 | { |
|---|
| 795 | 795 | struct spear_smi_plat_data *pdata = dev_get_platdata(&pdev->dev); |
|---|
| 796 | | - struct device_node *pp = NULL; |
|---|
| 796 | + struct device_node *pp; |
|---|
| 797 | 797 | const __be32 *addr; |
|---|
| 798 | 798 | u32 val; |
|---|
| 799 | 799 | int len; |
|---|
| .. | .. |
|---|
| 812 | 812 | return -ENOMEM; |
|---|
| 813 | 813 | |
|---|
| 814 | 814 | /* Fill structs for each subnode (flash device) */ |
|---|
| 815 | | - while ((pp = of_get_next_child(np, pp))) { |
|---|
| 816 | | - struct spear_smi_flash_info *flash_info; |
|---|
| 817 | | - |
|---|
| 818 | | - flash_info = &pdata->board_flash_info[i]; |
|---|
| 815 | + for_each_child_of_node(np, pp) { |
|---|
| 819 | 816 | pdata->np[i] = pp; |
|---|
| 820 | 817 | |
|---|
| 821 | 818 | /* Read base-addr and size from DT */ |
|---|
| .. | .. |
|---|
| 969 | 966 | irq = platform_get_irq(pdev, 0); |
|---|
| 970 | 967 | if (irq < 0) { |
|---|
| 971 | 968 | ret = -ENODEV; |
|---|
| 972 | | - dev_err(&pdev->dev, "invalid smi irq\n"); |
|---|
| 973 | 969 | goto err; |
|---|
| 974 | 970 | } |
|---|
| 975 | 971 | |
|---|