enable docker ppp

hc

2023-12-09 95099d4622f8cb224d94e314c7a8e0df60b13f87

 kernel/drivers/media/platform/rockchip/isp/dev.c
..
..
@@ -63,6 +63,14 @@
63
63
 module_param_named(monitor, rkisp_monitor, bool, 0644);
64
64
 MODULE_PARM_DESC(monitor, "rkisp abnormal restart monitor");
65
65
 
66
+bool rkisp_irq_dbg;
67
+module_param_named(irq_dbg, rkisp_irq_dbg, bool, 0644);
68
+MODULE_PARM_DESC(irq_dbg, "rkisp interrupt runtime");
69
+
70
+static bool rkisp_rdbk_auto;
71
+module_param_named(rdbk_auto, rkisp_rdbk_auto, bool, 0644);
72
+MODULE_PARM_DESC(irq_dbg, "rkisp and vicap auto readback mode");
73
+
66
74
 static bool rkisp_clk_dbg;
67
75
 module_param_named(clk_dbg, rkisp_clk_dbg, bool, 0644);
68
76
 MODULE_PARM_DESC(clk_dbg, "rkisp clk set by user");
..
..
@@ -78,6 +86,10 @@
78
86
 static unsigned int rkisp_wait_line;
79
87
 module_param_named(wait_line, rkisp_wait_line, uint, 0644);
80
88
 MODULE_PARM_DESC(wait_line, "rkisp wait line to buf done early");
89
+
90
+static unsigned int rkisp_wrap_line;
91
+module_param_named(wrap_line, rkisp_wrap_line, uint, 0644);
92
+MODULE_PARM_DESC(wrap_line, "rkisp wrap line for mpp");
81
93
 
82
94
 static DEFINE_MUTEX(rkisp_dev_mutex);
83
95
 static LIST_HEAD(rkisp_device_list);
..
..
@@ -126,7 +138,7 @@
126
138
 	p->num_subdevs = 0;
127
139
 	memset(p->subdevs, 0, sizeof(p->subdevs));
128
140
 
129
-	if (!(dev->isp_inp & (INP_CSI | INP_DVP | INP_LVDS)))
141
+	if (!(dev->isp_inp & (INP_CSI | INP_DVP | INP_LVDS | INP_CIF)))
130
142
 		return 0;
131
143
 
132
144
 	while (1) {
..
..
@@ -164,21 +176,35 @@
164
176
 {
165
177
 	struct rkisp_device *dev = container_of(p, struct rkisp_device, pipe);
166
178
 	struct rkisp_hw_dev *hw_dev = dev->hw_dev;
167
-	u32 w = hw_dev->max_in.w ? hw_dev->max_in.w : dev->isp_sdev.in_frm.width;
168
179
 	struct v4l2_subdev *sd;
169
180
 	struct v4l2_ctrl *ctrl;
170
-	u64 data_rate;
171
-	int i;
181
+	u64 data_rate = 0;
182
+	int i, fps;
172
183
 
173
-	if (dev->isp_inp & (INP_RAWRD0 | INP_RAWRD1 | INP_RAWRD2 | INP_CIF)) {
174
-		for (i = 0; i < hw_dev->num_clk_rate_tbl; i++) {
175
-			if (w <= hw_dev->clk_rate_tbl[i].refer_data)
176
-				break;
184
+	hw_dev->isp_size[dev->dev_id].is_on = true;
185
+	if (hw_dev->is_runing) {
186
+		if (dev->isp_ver >= ISP_V30 && !rkisp_clk_dbg)
187
+			hw_dev->is_dvfs = true;
188
+		return 0;
189
+	}
190
+
191
+	if (dev->isp_inp & (INP_RAWRD0 | INP_RAWRD1 | INP_RAWRD2) ||
192
+	    (dev->is_pre_on && hw_dev->dev_num > 1)) {
193
+		if (dev->isp_ver < ISP_V30 || dev->is_pre_on) {
194
+			/* isp with mipi no support dvfs, calculate max data rate */
195
+			for (i = 0; i < hw_dev->dev_num; i++) {
196
+				fps = hw_dev->isp_size[i].fps;
197
+				if (!fps)
198
+					fps = 30;
199
+				data_rate += (fps * hw_dev->isp_size[i].size);
200
+			}
201
+		} else {
202
+			i = dev->dev_id;
203
+			fps = hw_dev->isp_size[i].fps;
204
+			if (!fps)
205
+				fps = 30;
206
+			data_rate = fps * hw_dev->isp_size[i].size;
177
207
 		}
178
-		if (!hw_dev->is_single)
179
-			i++;
180
-		if (i > hw_dev->num_clk_rate_tbl - 1)
181
-			i = hw_dev->num_clk_rate_tbl - 1;
182
208
 		goto end;
183
209
 	}
184
210
 
..
..
@@ -187,11 +213,12 @@
187
213
 		return 0;
188
214
 	}
189
215
 
190
-	/* find the subdev of active sensor */
216
+	/* find the subdev of active sensor or vicap itf */
191
217
 	sd = p->subdevs[0];
192
218
 	for (i = 0; i < p->num_subdevs; i++) {
193
219
 		sd = p->subdevs[i];
194
-		if (sd->entity.function == MEDIA_ENT_F_CAM_SENSOR)
220
+		if (sd->entity.function == MEDIA_ENT_F_CAM_SENSOR ||
221
+		    sd->entity.function == MEDIA_ENT_F_PROC_VIDEO_COMPOSER)
195
222
 			break;
196
223
 	}
197
224
 
..
..
@@ -210,6 +237,7 @@
210
237
 	data_rate = v4l2_ctrl_g_ctrl_int64(ctrl) *
211
238
 		    dev->isp_sdev.in_fmt.bus_width;
212
239
 	data_rate >>= 3;
240
+end:
213
241
 	do_div(data_rate, 1000 * 1000);
214
242
 
215
243
 	/* increase 25% margin */
..
..
@@ -221,10 +249,15 @@
221
249
 			break;
222
250
 	if (i == hw_dev->num_clk_rate_tbl)
223
251
 		i--;
224
-end:
252
+
225
253
 	/* set isp clock rate */
226
254
 	rkisp_set_clk_rate(hw_dev->clks[0], hw_dev->clk_rate_tbl[i].clk_rate * 1000000UL);
227
-	dev_dbg(hw_dev->dev, "set isp clk = %luHz\n", clk_get_rate(hw_dev->clks[0]));
255
+	if (hw_dev->is_unite)
256
+		rkisp_set_clk_rate(hw_dev->clks[5], hw_dev->clk_rate_tbl[i].clk_rate * 1000000UL);
257
+	/* aclk equal to core clk */
258
+	if (dev->isp_ver == ISP_V32)
259
+		rkisp_set_clk_rate(hw_dev->clks[1], hw_dev->clk_rate_tbl[i].clk_rate * 1000000UL);
260
+	dev_info(hw_dev->dev, "set isp clk = %luHz\n", clk_get_rate(hw_dev->clks[0]));
228
261
 
229
262
 	return 0;
230
263
 }
..
..
@@ -259,8 +292,15 @@
259
292
 
260
293
 static int rkisp_pipeline_close(struct rkisp_pipeline *p)
261
294
 {
262
-	atomic_dec(&p->power_cnt);
295
+	struct rkisp_device *dev = container_of(p, struct rkisp_device, pipe);
263
296
 
297
+	if (atomic_dec_return(&p->power_cnt))
298
+		return 0;
299
+
300
+	rkisp_rx_buf_pool_free(dev);
301
+	dev->hw_dev->isp_size[dev->dev_id].is_on = false;
302
+	if (dev->hw_dev->is_runing && (dev->isp_ver >= ISP_V30) && !rkisp_clk_dbg)
303
+		dev->hw_dev->is_dvfs = true;
264
304
 	return 0;
265
305
 }
266
306
 
..
..
@@ -281,17 +321,32 @@
281
321
 		if (dev->vs_irq >= 0)
282
322
 			enable_irq(dev->vs_irq);
283
323
 		rockchip_set_system_status(SYS_STATUS_ISP);
284
-		v4l2_subdev_call(&dev->isp_sdev.sd, video, s_stream, true);
324
+		ret = v4l2_subdev_call(&dev->isp_sdev.sd, video, s_stream, true);
325
+		if (ret < 0)
326
+			goto err;
285
327
 		/* phy -> sensor */
286
328
 		for (i = 0; i < p->num_subdevs; ++i) {
329
+			if ((dev->vicap_in.merge_num > 1) &&
330
+			    (p->subdevs[i]->entity.function == MEDIA_ENT_F_CAM_SENSOR))
331
+				continue;
287
332
 			ret = v4l2_subdev_call(p->subdevs[i], video, s_stream, on);
288
333
 			if (on && ret < 0 && ret != -ENOIOCTLCMD && ret != -ENODEV)
289
334
 				goto err_stream_off;
290
335
 		}
291
336
 	} else {
337
+		if (dev->hw_dev->monitor.is_en) {
338
+			dev->hw_dev->monitor.is_en = 0;
339
+			dev->hw_dev->monitor.state = ISP_STOP;
340
+			if (!completion_done(&dev->hw_dev->monitor.cmpl))
341
+				complete(&dev->hw_dev->monitor.cmpl);
342
+		}
292
343
 		/* sensor -> phy */
293
-		for (i = p->num_subdevs - 1; i >= 0; --i)
344
+		for (i = p->num_subdevs - 1; i >= 0; --i) {
345
+			if ((dev->vicap_in.merge_num > 1) &&
346
+			    (p->subdevs[i]->entity.function == MEDIA_ENT_F_CAM_SENSOR))
347
+				continue;
294
348
 			v4l2_subdev_call(p->subdevs[i], video, s_stream, on);
349
+		}
295
350
 		if (dev->vs_irq >= 0)
296
351
 			disable_irq(dev->vs_irq);
297
352
 		v4l2_subdev_call(&dev->isp_sdev.sd, video, s_stream, false);
..
..
@@ -304,7 +359,9 @@
304
359
 	for (--i; i >= 0; --i)
305
360
 		v4l2_subdev_call(p->subdevs[i], video, s_stream, false);
306
361
 	v4l2_subdev_call(&dev->isp_sdev.sd, video, s_stream, false);
362
+err:
307
363
 	rockchip_clear_system_status(SYS_STATUS_ISP);
364
+	atomic_dec_return(&p->stream_cnt);
308
365
 	return ret;
309
366
 }
310
367
 
..
..
@@ -320,7 +377,7 @@
320
377
 	for (s = 0; s < dev->num_sensors; ++s) {
321
378
 		struct rkisp_sensor_info *sensor = &dev->sensors[s];
322
379
 		u32 type = sensor->sd->entity.function;
323
-		bool en = s ? 0 : MEDIA_LNK_FL_ENABLED;
380
+		bool en = s ? 0 : true;
324
381
 
325
382
 		for (pad = 0; pad < sensor->sd->entity.num_pads; pad++)
326
383
 			if (sensor->sd->entity.pads[pad].flags & MEDIA_PAD_FL_SOURCE)
..
..
@@ -342,8 +399,8 @@
342
399
 			ret = media_create_pad_link(&sensor->sd->entity, pad,
343
400
 				&dev->isp_sdev.sd.entity, RKISP_ISP_PAD_SINK, en);
344
401
 		} else {
345
-			v4l2_subdev_call(sensor->sd, video,
346
-					 g_mbus_config, &sensor->mbus);
402
+			v4l2_subdev_call(sensor->sd, pad,
403
+					 get_mbus_config, 0, &sensor->mbus);
347
404
 			if (sensor->mbus.type == V4L2_MBUS_CCP2) {
348
405
 				/* mipi-phy lvds link -> isp */
349
406
 				dev->isp_inp = INP_LVDS;
..
..
@@ -366,16 +423,27 @@
366
423
 	return ret;
367
424
 }
368
425
 
369
-static int _set_pipeline_default_fmt(struct rkisp_device *dev)
426
+static int _set_pipeline_default_fmt(struct rkisp_device *dev, bool is_init)
370
427
 {
371
428
 	struct v4l2_subdev *isp;
372
429
 	struct v4l2_subdev_format fmt;
373
430
 	struct v4l2_subdev_selection sel;
374
-	u32 width, height, code;
431
+	u32 i, width, height, code;
375
432
 
433
+	memset(&sel, 0, sizeof(sel));
434
+	memset(&fmt, 0, sizeof(fmt));
376
435
 	isp = &dev->isp_sdev.sd;
377
436
 
378
-	fmt = dev->active_sensor->fmt[0];
437
+	if (dev->active_sensor) {
438
+		fmt = dev->active_sensor->fmt[0];
439
+		if (!is_init &&
440
+		    fmt.format.code == dev->isp_sdev.in_frm.code &&
441
+		    fmt.format.width == dev->isp_sdev.in_frm.width &&
442
+		    fmt.format.height == dev->isp_sdev.in_frm.height)
443
+			return 0;
444
+	} else {
445
+		fmt.format = dev->isp_sdev.in_frm;
446
+	}
379
447
 	code = fmt.format.code;
380
448
 	fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;
381
449
 	fmt.pad = RKISP_ISP_PAD_SINK;
..
..
@@ -411,7 +479,7 @@
411
479
 		rkisp_set_stream_def_fmt(dev, RKISP_STREAM_SP,
412
480
 					 width, height, V4L2_PIX_FMT_NV12);
413
481
 	if ((dev->isp_ver == ISP_V20 || dev->isp_ver == ISP_V21) &&
414
-	    dev->isp_inp == INP_CSI) {
482
+	    dev->isp_inp == INP_CSI && dev->active_sensor) {
415
483
 		width = dev->active_sensor->fmt[1].format.width;
416
484
 		height = dev->active_sensor->fmt[1].format.height;
417
485
 		code = dev->active_sensor->fmt[1].format.code;
..
..
@@ -431,12 +499,49 @@
431
499
 			width, height, rkisp_mbus_pixelcode_to_v4l2(code));
432
500
 	}
433
501
 
434
-	if (dev->isp_ver == ISP_V20 && dev->isp_inp == INP_CSI) {
502
+	if (dev->isp_ver == ISP_V20 &&
503
+	    dev->isp_inp == INP_CSI && dev->active_sensor) {
435
504
 		width = dev->active_sensor->fmt[2].format.width;
436
505
 		height = dev->active_sensor->fmt[2].format.height;
437
506
 		code = dev->active_sensor->fmt[2].format.code;
438
507
 		rkisp_set_stream_def_fmt(dev, RKISP_STREAM_DMATX1,
439
508
 			width, height, rkisp_mbus_pixelcode_to_v4l2(code));
509
+	}
510
+
511
+	if (dev->isp_ver == ISP_V30) {
512
+		struct v4l2_pix_format_mplane pixm = {
513
+			.width = width,
514
+			.height = height,
515
+			.pixelformat = rkisp_mbus_pixelcode_to_v4l2(code),
516
+		};
517
+
518
+		for (i = RKISP_STREAM_RAWRD0; i <= RKISP_STREAM_RAWRD2; i++)
519
+			rkisp_dmarx_set_fmt(&dev->dmarx_dev.stream[i], pixm);
520
+		rkisp_set_stream_def_fmt(dev, RKISP_STREAM_FBC,
521
+					 width, height, V4L2_PIX_FMT_FBC0);
522
+#ifdef RKISP_STREAM_BP_EN
523
+		rkisp_set_stream_def_fmt(dev, RKISP_STREAM_BP,
524
+					 width, height, V4L2_PIX_FMT_NV12);
525
+#endif
526
+	}
527
+
528
+	if (dev->isp_ver == ISP_V32 || dev->isp_ver == ISP_V32_L) {
529
+		struct v4l2_pix_format_mplane pixm = {
530
+			.width = width,
531
+			.height = height,
532
+			.pixelformat = rkisp_mbus_pixelcode_to_v4l2(code),
533
+		};
534
+
535
+		rkisp_dmarx_set_fmt(&dev->dmarx_dev.stream[RKISP_STREAM_RAWRD0], pixm);
536
+		rkisp_dmarx_set_fmt(&dev->dmarx_dev.stream[RKISP_STREAM_RAWRD2], pixm);
537
+		if (dev->isp_ver == ISP_V32) {
538
+			rkisp_set_stream_def_fmt(dev, RKISP_STREAM_BP,
539
+						 width, height, V4L2_PIX_FMT_NV12);
540
+			rkisp_set_stream_def_fmt(dev, RKISP_STREAM_MPDS,
541
+						 width / 4, height / 4, V4L2_PIX_FMT_NV12);
542
+			rkisp_set_stream_def_fmt(dev, RKISP_STREAM_BPDS,
543
+						 width / 4, height / 4, V4L2_PIX_FMT_NV12);
544
+		}
440
545
 	}
441
546
 	return 0;
442
547
 }
..
..
@@ -456,13 +561,16 @@
456
561
 	if (ret < 0)
457
562
 		goto unlock;
458
563
 
459
-	ret = rkisp_update_sensor_info(dev);
460
-	if (ret < 0) {
461
-		v4l2_err(&dev->v4l2_dev, "update sensor failed\n");
462
-		goto unlock;
564
+	if (dev->isp_inp) {
565
+		ret = rkisp_update_sensor_info(dev);
566
+		if (ret < 0) {
567
+			v4l2_err(&dev->v4l2_dev, "update sensor failed\n");
568
+			goto unlock;
569
+		}
570
+		dev->is_hw_link = true;
463
571
 	}
464
572
 
465
-	ret = _set_pipeline_default_fmt(dev);
573
+	ret = _set_pipeline_default_fmt(dev, true);
466
574
 	if (ret < 0)
467
575
 		goto unlock;
468
576
 
..
..
@@ -470,6 +578,8 @@
470
578
 
471
579
 unlock:
472
580
 	mutex_unlock(&dev->media_dev.graph_mutex);
581
+	if (!ret && dev->is_thunderboot)
582
+		schedule_work(&dev->cap_dev.fast_work);
473
583
 	return ret;
474
584
 }
475
585
 
..
..
@@ -521,9 +631,28 @@
521
631
 	return 0;
522
632
 }
523
633
 
634
+static void subdev_notifier_unbind(struct v4l2_async_notifier *notifier,
635
+				   struct v4l2_subdev *subdev,
636
+				   struct v4l2_async_subdev *asd)
637
+{
638
+	struct rkisp_device *isp_dev = container_of(notifier, struct rkisp_device, notifier);
639
+	struct rkisp_isp_subdev *isp_sdev = &isp_dev->isp_sdev;
640
+	struct v4l2_subdev *isp_sd = &isp_sdev->sd;
641
+	int i;
642
+
643
+	for (i = 0; i < isp_dev->num_sensors; i++) {
644
+		if (isp_dev->sensors[i].sd == subdev) {
645
+			media_entity_call(&isp_sd->entity, link_setup,
646
+				isp_sd->entity.pads, subdev->entity.pads, 0);
647
+			isp_dev->sensors[i].sd = NULL;
648
+		}
649
+	}
650
+}
651
+
524
652
 static const struct v4l2_async_notifier_operations subdev_notifier_ops = {
525
653
 	.bound = subdev_notifier_bound,
526
654
 	.complete = subdev_notifier_complete,
655
+	.unbind = subdev_notifier_unbind,
527
656
 };
528
657
 
529
658
 static int isp_subdev_notifier(struct rkisp_device *isp_dev)
..
..
@@ -532,14 +661,13 @@
532
661
 	struct device *dev = isp_dev->dev;
533
662
 	int ret;
534
663
 
664
+	v4l2_async_notifier_init(ntf);
665
+
535
666
 	ret = v4l2_async_notifier_parse_fwnode_endpoints(
536
667
 		dev, ntf, sizeof(struct rkisp_async_subdev),
537
668
 		rkisp_fwnode_parse);
538
669
 	if (ret < 0)
539
670
 		return ret;
540
-
541
-	if (!ntf->num_subdevs)
542
-		return -ENODEV;	/* no endpoint */
543
671
 
544
672
 	ntf->ops = &subdev_notifier_ops;
545
673
 
..
..
@@ -588,10 +716,6 @@
588
716
 	if (ret < 0) {
589
717
 		v4l2_err(&dev->v4l2_dev,
590
718
 			 "Failed to register subdev notifier(%d)\n", ret);
591
-		/* maybe use dmarx to input image */
592
-		ret = v4l2_device_register_subdev_nodes(&dev->v4l2_dev);
593
-		if (ret == 0)
594
-			return 0;
595
719
 		goto err_unreg_luma_vdev;
596
720
 	}
597
721
 
..
..
@@ -688,12 +812,8 @@
688
812
 					      sizeof(struct rkisp_thunderboot_resmem_head),
689
813
 					      DMA_BIDIRECTIONAL);
690
814
 	ret = dma_mapping_error(dev, isp_dev->resmem_addr);
691
-
692
815
 	isp_dev->is_thunderboot = true;
693
-	atomic_inc(&isp_dev->hw_dev->tb_ref);
694
-
695
-	dev_info(dev, "Allocated reserved memory, paddr: 0x%x\n",
696
-		(u32)isp_dev->resmem_pa);
816
+	dev_info(dev, "Allocated reserved memory, paddr: 0x%x\n", (u32)isp_dev->resmem_pa);
697
817
 	return ret;
698
818
 }
699
819
 
..
..
@@ -702,41 +822,49 @@
702
822
 	struct device *dev = &pdev->dev;
703
823
 	struct v4l2_device *v4l2_dev;
704
824
 	struct rkisp_device *isp_dev;
705
-	int i, ret;
825
+	int i, ret, mult = 1;
706
826
 
707
-	sprintf(rkisp_version, "v%02x.%02x.%02x",
708
-		RKISP_DRIVER_VERSION >> 16,
709
-		(RKISP_DRIVER_VERSION & 0xff00) >> 8,
710
-		RKISP_DRIVER_VERSION & 0x00ff);
827
+	snprintf(rkisp_version, sizeof(rkisp_version),
828
+		 "v%02x.%02x.%02x",
829
+		 RKISP_DRIVER_VERSION >> 16,
830
+		 (RKISP_DRIVER_VERSION & 0xff00) >> 8,
831
+		 RKISP_DRIVER_VERSION & 0x00ff);
711
832
 
712
833
 	dev_info(dev, "rkisp driver version: %s\n", rkisp_version);
713
834
 
714
835
 	isp_dev = devm_kzalloc(dev, sizeof(*isp_dev), GFP_KERNEL);
715
836
 	if (!isp_dev)
716
837
 		return -ENOMEM;
717
-	isp_dev->sw_base_addr = devm_kzalloc(dev, RKISP_ISP_SW_MAX_SIZE, GFP_KERNEL);
718
-	if (!isp_dev->sw_base_addr)
719
-		return -ENOMEM;
720
838
 
721
839
 	dev_set_drvdata(dev, isp_dev);
722
840
 	isp_dev->dev = dev;
841
+	ret = rkisp_attach_hw(isp_dev);
842
+	if (ret)
843
+		return ret;
844
+
845
+	if (isp_dev->hw_dev->is_unite)
846
+		mult = 2;
847
+	isp_dev->sw_base_addr = devm_kzalloc(dev, RKISP_ISP_SW_MAX_SIZE * mult, GFP_KERNEL);
848
+	if (!isp_dev->sw_base_addr)
849
+		return -ENOMEM;
723
850
 
724
851
 	ret = rkisp_vs_irq_parse(dev);
725
852
 	if (ret)
726
853
 		return ret;
727
854
 
728
-	ret = rkisp_attach_hw(isp_dev);
855
+	snprintf(isp_dev->media_dev.model, sizeof(isp_dev->media_dev.model),
856
+		 "%s%d", DRIVER_NAME, isp_dev->dev_id);
857
+	if (!isp_dev->hw_dev->is_unite)
858
+		strscpy(isp_dev->name, dev_name(dev), sizeof(isp_dev->name));
859
+	else
860
+		snprintf(isp_dev->name, sizeof(isp_dev->name),
861
+			 "%s%d", "rkisp-unite", isp_dev->dev_id);
862
+	strscpy(isp_dev->media_dev.driver_name, isp_dev->name,
863
+		sizeof(isp_dev->media_dev.driver_name));
864
+
865
+	ret = rkisp_get_reserved_mem(isp_dev);
729
866
 	if (ret)
730
867
 		return ret;
731
-
732
-	sprintf(isp_dev->media_dev.model, "%s%d",
733
-		DRIVER_NAME, isp_dev->dev_id);
734
-
735
-	if (isp_dev->hw_dev->is_thunderboot) {
736
-		ret = rkisp_get_reserved_mem(isp_dev);
737
-		if (ret)
738
-			return ret;
739
-	}
740
868
 
741
869
 	mutex_init(&isp_dev->apilock);
742
870
 	mutex_init(&isp_dev->iqlock);
..
..
@@ -755,9 +883,6 @@
755
883
 		}
756
884
 	}
757
885
 
758
-	strscpy(isp_dev->name, dev_name(dev), sizeof(isp_dev->name));
759
-	strscpy(isp_dev->media_dev.driver_name, isp_dev->name,
760
-		sizeof(isp_dev->media_dev.driver_name));
761
886
 	isp_dev->media_dev.dev = dev;
762
887
 	isp_dev->media_dev.ops = &rkisp_media_ops;
763
888
 
..
..
@@ -780,11 +905,13 @@
780
905
 		goto err_unreg_v4l2_dev;
781
906
 	}
782
907
 
908
+	pm_runtime_enable(dev);
783
909
 	/* create & register platefom subdev (from of_node) */
784
910
 	ret = rkisp_register_platform_subdevs(isp_dev);
785
-	if (ret < 0)
911
+	if (ret < 0) {
912
+		v4l2_err(v4l2_dev, "Failed to register platform subdevs:%d\n", ret);
786
913
 		goto err_unreg_media_dev;
787
-
914
+	}
788
915
 	rkisp_wait_line = 0;
789
916
 	of_property_read_u32(dev->of_node, "wait-line", &rkisp_wait_line);
790
917
 
..
..
@@ -793,10 +920,7 @@
793
920
 	mutex_lock(&rkisp_dev_mutex);
794
921
 	list_add_tail(&isp_dev->list, &rkisp_device_list);
795
922
 	mutex_unlock(&rkisp_dev_mutex);
796
-
797
-	pm_runtime_enable(dev);
798
-	if (isp_dev->hw_dev->is_thunderboot && isp_dev->is_thunderboot)
799
-		pm_runtime_get_noresume(isp_dev->hw_dev->dev);
923
+	isp_dev->is_probe_end = true;
800
924
 	return 0;
801
925
 
802
926
 err_unreg_media_dev:
..
..
@@ -810,11 +934,17 @@
810
934
 {
811
935
 	struct rkisp_device *isp_dev = platform_get_drvdata(pdev);
812
936
 
937
+	isp_dev->is_hw_link = false;
938
+	isp_dev->hw_dev->isp[isp_dev->dev_id] = NULL;
939
+
813
940
 	pm_runtime_disable(&pdev->dev);
814
941
 
815
942
 	rkisp_proc_cleanup(isp_dev);
816
943
 	media_device_unregister(&isp_dev->media_dev);
944
+	v4l2_async_notifier_unregister(&isp_dev->notifier);
945
+	v4l2_async_notifier_cleanup(&isp_dev->notifier);
817
946
 	v4l2_device_unregister(&isp_dev->v4l2_dev);
947
+	v4l2_ctrl_handler_free(&isp_dev->ctrl_handler);
818
948
 	rkisp_unregister_luma_vdev(&isp_dev->luma_vdev);
819
949
 	rkisp_unregister_params_vdev(&isp_dev->params_vdev);
820
950
 	rkisp_unregister_stats_vdev(&isp_dev->stats_vdev);
..
..
@@ -843,7 +973,14 @@
843
973
 	struct rkisp_device *isp_dev = dev_get_drvdata(dev);
844
974
 	int ret;
845
975
 
976
+	/* power on to config default format from sensor */
977
+	if (isp_dev->isp_inp & (INP_CSI | INP_DVP | INP_LVDS | INP_CIF) &&
978
+	    rkisp_update_sensor_info(isp_dev) >= 0)
979
+		_set_pipeline_default_fmt(isp_dev, false);
980
+
846
981
 	isp_dev->cap_dev.wait_line = rkisp_wait_line;
982
+	isp_dev->cap_dev.wrap_line = rkisp_wrap_line;
983
+	isp_dev->is_rdbk_auto = rkisp_rdbk_auto;
847
984
 	mutex_lock(&isp_dev->hw_dev->dev_lock);
848
985
 	ret = pm_runtime_get_sync(isp_dev->hw_dev->dev);
849
986
 	mutex_unlock(&isp_dev->hw_dev->dev_lock);
..
..
@@ -888,3 +1025,4 @@
888
1025
 MODULE_AUTHOR("Rockchip Camera/ISP team");
889
1026
 MODULE_DESCRIPTION("Rockchip ISP platform driver");
890
1027
 MODULE_LICENSE("Dual BSD/GPL");
1028
+MODULE_IMPORT_NS(VFS_internal_I_am_really_a_filesystem_and_am_NOT_a_driver);