.. | .. |
---|
22 | 22 | |
---|
23 | 23 | #define DRV_NAME "rockchip-sai" |
---|
24 | 24 | |
---|
| 25 | +#define CLK_SHIFT_RATE_HZ_MAX 1 /* 1 Hz */ |
---|
25 | 26 | #define FW_RATIO_MAX 8 |
---|
26 | 27 | #define FW_RATIO_MIN 1 |
---|
27 | 28 | #define MAXBURST_PER_FIFO 8 |
---|
.. | .. |
---|
496 | 497 | if (sai->is_clk_auto) |
---|
497 | 498 | clk_set_rate(sai->mclk, bclk_rate); |
---|
498 | 499 | mclk_rate = clk_get_rate(sai->mclk); |
---|
499 | | - if (mclk_rate < bclk_rate) { |
---|
500 | | - dev_err(sai->dev, "Mismatch mclk: %u, expected %u at least\n", |
---|
501 | | - mclk_rate, bclk_rate); |
---|
| 500 | + if (mclk_rate < bclk_rate - CLK_SHIFT_RATE_HZ_MAX || |
---|
| 501 | + mclk_rate > bclk_rate + CLK_SHIFT_RATE_HZ_MAX) { |
---|
| 502 | + dev_err(sai->dev, "Mismatch mclk: %u, expected %u (+/- %dHz)\n", |
---|
| 503 | + mclk_rate, bclk_rate, CLK_SHIFT_RATE_HZ_MAX); |
---|
502 | 504 | return -EINVAL; |
---|
503 | 505 | } |
---|
504 | 506 | |
---|
.. | .. |
---|
506 | 508 | |
---|
507 | 509 | regmap_update_bits(sai->regmap, SAI_CKR, SAI_CKR_MDIV_MASK, |
---|
508 | 510 | SAI_CKR_MDIV(div_bclk)); |
---|
| 511 | + } |
---|
| 512 | + |
---|
| 513 | + return 0; |
---|
| 514 | +} |
---|
| 515 | + |
---|
| 516 | +static int rockchip_sai_prepare(struct snd_pcm_substream *substream, |
---|
| 517 | + struct snd_soc_dai *dai) |
---|
| 518 | +{ |
---|
| 519 | + struct rk_sai_dev *sai = snd_soc_dai_get_drvdata(dai); |
---|
| 520 | + |
---|
| 521 | + if (sai->is_master_mode) { |
---|
509 | 522 | /* |
---|
510 | 523 | * Should wait for one BCLK ready after DIV and then ungate |
---|
511 | 524 | * output clk to achieve the clean clk. |
---|
.. | .. |
---|
628 | 641 | .hw_params = rockchip_sai_hw_params, |
---|
629 | 642 | .set_sysclk = rockchip_sai_set_sysclk, |
---|
630 | 643 | .set_fmt = rockchip_sai_set_fmt, |
---|
| 644 | + .prepare = rockchip_sai_prepare, |
---|
631 | 645 | .trigger = rockchip_sai_trigger, |
---|
632 | 646 | .set_tdm_slot = rockchip_sai_set_tdm_slot, |
---|
633 | 647 | }; |
---|
.. | .. |
---|
783 | 797 | if (sai->has_playback) { |
---|
784 | 798 | dai->playback.stream_name = "Playback"; |
---|
785 | 799 | dai->playback.channels_min = 1; |
---|
786 | | - dai->playback.channels_max = 128; |
---|
787 | | - dai->playback.rates = SNDRV_PCM_RATE_8000_192000; |
---|
| 800 | + dai->playback.channels_max = 512; |
---|
| 801 | + dai->playback.rates = SNDRV_PCM_RATE_8000_384000; |
---|
788 | 802 | dai->playback.formats = SNDRV_PCM_FMTBIT_S8 | |
---|
789 | 803 | SNDRV_PCM_FMTBIT_S16_LE | |
---|
790 | 804 | SNDRV_PCM_FMTBIT_S24_LE | |
---|
.. | .. |
---|
799 | 813 | if (sai->has_capture) { |
---|
800 | 814 | dai->capture.stream_name = "Capture"; |
---|
801 | 815 | dai->capture.channels_min = 1; |
---|
802 | | - dai->capture.channels_max = 128; |
---|
803 | | - dai->capture.rates = SNDRV_PCM_RATE_8000_192000; |
---|
| 816 | + dai->capture.channels_max = 512; |
---|
| 817 | + dai->capture.rates = SNDRV_PCM_RATE_8000_384000; |
---|
804 | 818 | dai->capture.formats = SNDRV_PCM_FMTBIT_S8 | |
---|
805 | 819 | SNDRV_PCM_FMTBIT_S16_LE | |
---|
806 | 820 | SNDRV_PCM_FMTBIT_S24_LE | |
---|
.. | .. |
---|
855 | 869 | "From SDO0", "From SDO1", "From SDO2", "From SDO3" }; |
---|
856 | 870 | |
---|
857 | 871 | static const char * const lps_text[] = { "Disable", "Enable" }; |
---|
858 | | -static const char * const sync_out_text[] = { "External", "Internal" }; |
---|
859 | | -static const char * const sync_in_text[] = { "External", "Internal" }; |
---|
| 872 | +static const char * const sync_out_text[] = { "From CRU", "From IO" }; |
---|
| 873 | +static const char * const sync_in_text[] = { "From IO", "From Sync Port" }; |
---|
860 | 874 | |
---|
861 | 875 | static const char * const rpaths_text[] = { |
---|
862 | 876 | "From SDI0", "From SDI1", "From SDI2", "From SDI3" }; |
---|
863 | 877 | |
---|
864 | 878 | static const char * const tpaths_text[] = { |
---|
865 | | - "To SDO0", "To SDO1", "To SDO2", "To SDO3" }; |
---|
| 879 | + "From PATH0", "From PATH1", "From PATH2", "From PATH3" }; |
---|
866 | 880 | |
---|
867 | 881 | /* TXCR */ |
---|
868 | 882 | static SOC_ENUM_SINGLE_DECL(tsft_enum, SAI_TXCR, 22, edge_shift_text); |
---|
.. | .. |
---|
919 | 933 | static SOC_ENUM_SINGLE_DECL(tpath1_enum, SAI_PATH_SEL, 2, tpaths_text); |
---|
920 | 934 | static SOC_ENUM_SINGLE_DECL(tpath0_enum, SAI_PATH_SEL, 0, tpaths_text); |
---|
921 | 935 | |
---|
922 | | -static int rockchip_sai_fpw_get(struct snd_kcontrol *kcontrol, |
---|
923 | | - struct snd_ctl_elem_value *ucontrol) |
---|
| 936 | +static int __maybe_unused rockchip_sai_fpw_get(struct snd_kcontrol *kcontrol, |
---|
| 937 | + struct snd_ctl_elem_value *ucontrol) |
---|
924 | 938 | { |
---|
925 | 939 | struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); |
---|
926 | 940 | struct rk_sai_dev *sai = snd_soc_component_get_drvdata(component); |
---|
.. | .. |
---|
930 | 944 | return 0; |
---|
931 | 945 | } |
---|
932 | 946 | |
---|
933 | | -static int rockchip_sai_fpw_put(struct snd_kcontrol *kcontrol, |
---|
934 | | - struct snd_ctl_elem_value *ucontrol) |
---|
| 947 | +static int __maybe_unused rockchip_sai_fpw_put(struct snd_kcontrol *kcontrol, |
---|
| 948 | + struct snd_ctl_elem_value *ucontrol) |
---|
935 | 949 | { |
---|
936 | 950 | struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); |
---|
937 | 951 | struct rk_sai_dev *sai = snd_soc_component_get_drvdata(component); |
---|
.. | .. |
---|
946 | 960 | return 1; |
---|
947 | 961 | } |
---|
948 | 962 | |
---|
949 | | -static int rockchip_sai_fw_ratio_get(struct snd_kcontrol *kcontrol, |
---|
950 | | - struct snd_ctl_elem_value *ucontrol) |
---|
| 963 | +static int __maybe_unused rockchip_sai_fw_ratio_get(struct snd_kcontrol *kcontrol, |
---|
| 964 | + struct snd_ctl_elem_value *ucontrol) |
---|
951 | 965 | { |
---|
952 | 966 | struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); |
---|
953 | 967 | struct rk_sai_dev *sai = snd_soc_component_get_drvdata(component); |
---|
.. | .. |
---|
957 | 971 | return 0; |
---|
958 | 972 | } |
---|
959 | 973 | |
---|
960 | | -static int rockchip_sai_fw_ratio_put(struct snd_kcontrol *kcontrol, |
---|
961 | | - struct snd_ctl_elem_value *ucontrol) |
---|
| 974 | +static int __maybe_unused rockchip_sai_fw_ratio_put(struct snd_kcontrol *kcontrol, |
---|
| 975 | + struct snd_ctl_elem_value *ucontrol) |
---|
962 | 976 | { |
---|
963 | 977 | struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); |
---|
964 | 978 | struct rk_sai_dev *sai = snd_soc_component_get_drvdata(component); |
---|
.. | .. |
---|
1026 | 1040 | return 1; |
---|
1027 | 1041 | } |
---|
1028 | 1042 | |
---|
1029 | | -static int rockchip_sai_mss_get(struct snd_kcontrol *kcontrol, |
---|
1030 | | - struct snd_ctl_elem_value *ucontrol) |
---|
| 1043 | +static int __maybe_unused rockchip_sai_mss_get(struct snd_kcontrol *kcontrol, |
---|
| 1044 | + struct snd_ctl_elem_value *ucontrol) |
---|
1031 | 1045 | { |
---|
1032 | 1046 | struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); |
---|
1033 | 1047 | struct rk_sai_dev *sai = snd_soc_component_get_drvdata(component); |
---|
.. | .. |
---|
1037 | 1051 | return 0; |
---|
1038 | 1052 | } |
---|
1039 | 1053 | |
---|
1040 | | -static int rockchip_sai_mss_put(struct snd_kcontrol *kcontrol, |
---|
1041 | | - struct snd_ctl_elem_value *ucontrol) |
---|
| 1054 | +static int __maybe_unused rockchip_sai_mss_put(struct snd_kcontrol *kcontrol, |
---|
| 1055 | + struct snd_ctl_elem_value *ucontrol) |
---|
1042 | 1056 | { |
---|
1043 | 1057 | struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); |
---|
1044 | 1058 | struct rk_sai_dev *sai = snd_soc_component_get_drvdata(component); |
---|
.. | .. |
---|
1174 | 1188 | .info = rockchip_sai_wait_time_info, \ |
---|
1175 | 1189 | .get = xhandler_get, .put = xhandler_put } |
---|
1176 | 1190 | |
---|
1177 | | -static DECLARE_TLV_DB_SCALE(fs_shift_tlv, 0, 8192, 0); |
---|
| 1191 | +static __maybe_unused DECLARE_TLV_DB_SCALE(fs_shift_tlv, 0, 8192, 0); |
---|
1178 | 1192 | |
---|
1179 | 1193 | static const struct snd_kcontrol_new rockchip_sai_controls[] = { |
---|
1180 | | - |
---|
| 1194 | +#ifdef CONFIG_SND_SOC_ROCKCHIP_SAI_VERBOSE |
---|
1181 | 1195 | SOC_ENUM("Transmit Edge Shift", tsft_enum), |
---|
1182 | | - SOC_ENUM_EXT("Transmit SDOx Select", tx_lanes_enum, |
---|
1183 | | - rockchip_sai_tx_lanes_get, rockchip_sai_tx_lanes_put), |
---|
1184 | 1196 | SOC_ENUM("Transmit Store Justified Mode", tsjm_enum), |
---|
1185 | 1197 | SOC_ENUM("Transmit First Bit Mode", tfbm_enum), |
---|
1186 | 1198 | SOC_ENUM("Transmit Valid Data Justified", tvdj_enum), |
---|
1187 | 1199 | SOC_ENUM("Transmit Slot Bit Width", tsbw_enum), |
---|
1188 | 1200 | |
---|
1189 | 1201 | SOC_ENUM("Receive Edge Shift", rsft_enum), |
---|
1190 | | - SOC_ENUM_EXT("Receive SDIx Select", rx_lanes_enum, |
---|
1191 | | - rockchip_sai_rx_lanes_get, rockchip_sai_rx_lanes_put), |
---|
1192 | 1202 | SOC_ENUM("Receive Store Justified Mode", rsjm_enum), |
---|
1193 | 1203 | SOC_ENUM("Receive First Bit Mode", rfbm_enum), |
---|
1194 | 1204 | SOC_ENUM("Receive Valid Data Justified", rvdj_enum), |
---|
.. | .. |
---|
1200 | 1210 | SOC_ENUM_EXT("Frame Width Ratio", fw_ratio_enum, |
---|
1201 | 1211 | rockchip_sai_fw_ratio_get, rockchip_sai_fw_ratio_put), |
---|
1202 | 1212 | |
---|
| 1213 | + SOC_ENUM_EXT("Master Slave Mode Select", mss_switch, |
---|
| 1214 | + rockchip_sai_mss_get, rockchip_sai_mss_put), |
---|
| 1215 | + SOC_ENUM("Sclk Polarity", sp_switch), |
---|
| 1216 | + SOC_ENUM("Frame Sync Polarity", fp_switch), |
---|
| 1217 | + |
---|
| 1218 | + SOC_SINGLE_TLV("Transmit Frame Shift Select", SAI_TX_SHIFT, |
---|
| 1219 | + 0, 8192, 0, fs_shift_tlv), |
---|
| 1220 | + SOC_SINGLE_TLV("Receive Frame Shift Select", SAI_RX_SHIFT, |
---|
| 1221 | + 0, 8192, 0, fs_shift_tlv), |
---|
| 1222 | +#endif |
---|
| 1223 | + SOC_ENUM_EXT("Transmit SDOx Select", tx_lanes_enum, |
---|
| 1224 | + rockchip_sai_tx_lanes_get, rockchip_sai_tx_lanes_put), |
---|
| 1225 | + SOC_ENUM_EXT("Receive SDIx Select", rx_lanes_enum, |
---|
| 1226 | + rockchip_sai_rx_lanes_get, rockchip_sai_rx_lanes_put), |
---|
1203 | 1227 | SOC_SINGLE_TLV("Receive Mono Slot Select", SAI_MONO_CR, |
---|
1204 | 1228 | 2, 128, 0, rmss_tlv), |
---|
1205 | 1229 | SOC_ENUM("Receive Mono Switch", rmono_switch), |
---|
1206 | 1230 | SOC_ENUM("Transmit Mono Switch", tmono_switch), |
---|
1207 | | - |
---|
1208 | | - SOC_ENUM_EXT("Master / Slave Mode Select", mss_switch, |
---|
1209 | | - rockchip_sai_mss_get, rockchip_sai_mss_put), |
---|
1210 | | - SOC_ENUM("Sclk Polarity", sp_switch), |
---|
1211 | | - SOC_ENUM("Frame Sync Polarity", fp_switch), |
---|
1212 | 1231 | |
---|
1213 | 1232 | SOC_ENUM("SDI3 Loopback Src Select", lp3_enum), |
---|
1214 | 1233 | SOC_ENUM("SDI2 Loopback Src Select", lp2_enum), |
---|
.. | .. |
---|
1224 | 1243 | SOC_ENUM("Receive PATH2 Source Select", rpath2_enum), |
---|
1225 | 1244 | SOC_ENUM("Receive PATH1 Source Select", rpath1_enum), |
---|
1226 | 1245 | SOC_ENUM("Receive PATH0 Source Select", rpath0_enum), |
---|
1227 | | - SOC_ENUM("Transmit PATH3 Sink Select", tpath3_enum), |
---|
1228 | | - SOC_ENUM("Transmit PATH2 Sink Select", tpath2_enum), |
---|
1229 | | - SOC_ENUM("Transmit PATH1 Sink Select", tpath1_enum), |
---|
1230 | | - SOC_ENUM("Transmit PATH0 Sink Select", tpath0_enum), |
---|
1231 | | - |
---|
1232 | | - SOC_SINGLE_TLV("Transmit Frame Shift Select", SAI_TX_SHIFT, |
---|
1233 | | - 0, 8192, 0, fs_shift_tlv), |
---|
1234 | | - SOC_SINGLE_TLV("Receive Frame Shift Select", SAI_RX_SHIFT, |
---|
1235 | | - 0, 8192, 0, fs_shift_tlv), |
---|
| 1246 | + SOC_ENUM("Transmit SDO3 Source Select", tpath3_enum), |
---|
| 1247 | + SOC_ENUM("Transmit SDO2 Source Select", tpath2_enum), |
---|
| 1248 | + SOC_ENUM("Transmit SDO1 Source Select", tpath1_enum), |
---|
| 1249 | + SOC_ENUM("Transmit SDO0 Source Select", tpath0_enum), |
---|
1236 | 1250 | |
---|
1237 | 1251 | SOC_SINGLE_BOOL_EXT("Clk Auto Switch", 0, |
---|
1238 | 1252 | rockchip_sai_clk_auto_get, |
---|
.. | .. |
---|
1263 | 1277 | dev_warn_ratelimited(sai->dev, "TX FIFO Underrun\n"); |
---|
1264 | 1278 | regmap_update_bits(sai->regmap, SAI_INTCR, |
---|
1265 | 1279 | SAI_INTCR_TXUIC, SAI_INTCR_TXUIC); |
---|
| 1280 | + regmap_update_bits(sai->regmap, SAI_INTCR, |
---|
| 1281 | + SAI_INTCR_TXUIE_MASK, |
---|
| 1282 | + SAI_INTCR_TXUIE(0)); |
---|
1266 | 1283 | substream = sai->substreams[SNDRV_PCM_STREAM_PLAYBACK]; |
---|
1267 | 1284 | if (substream) |
---|
1268 | 1285 | snd_pcm_stop_xrun(substream); |
---|
.. | .. |
---|
1272 | 1289 | dev_warn_ratelimited(sai->dev, "RX FIFO Overrun\n"); |
---|
1273 | 1290 | regmap_update_bits(sai->regmap, SAI_INTCR, |
---|
1274 | 1291 | SAI_INTCR_RXOIC, SAI_INTCR_RXOIC); |
---|
| 1292 | + regmap_update_bits(sai->regmap, SAI_INTCR, |
---|
| 1293 | + SAI_INTCR_RXOIE_MASK, |
---|
| 1294 | + SAI_INTCR_RXOIE(0)); |
---|
1275 | 1295 | substream = sai->substreams[SNDRV_PCM_STREAM_CAPTURE]; |
---|
1276 | 1296 | if (substream) |
---|
1277 | 1297 | snd_pcm_stop_xrun(substream); |
---|
.. | .. |
---|
1386 | 1406 | if (ret) |
---|
1387 | 1407 | return ret; |
---|
1388 | 1408 | |
---|
| 1409 | + ret = rockchip_sai_init_dai(sai, res, &dai); |
---|
| 1410 | + if (ret) |
---|
| 1411 | + return ret; |
---|
| 1412 | + |
---|
| 1413 | + /* |
---|
| 1414 | + * MUST: after pm_runtime_enable step, any register R/W |
---|
| 1415 | + * should be wrapped with pm_runtime_get_sync/put. |
---|
| 1416 | + * |
---|
| 1417 | + * Another approach is to enable the regcache true to |
---|
| 1418 | + * avoid access HW registers. |
---|
| 1419 | + * |
---|
| 1420 | + * Alternatively, performing the registers R/W before |
---|
| 1421 | + * pm_runtime_enable is also a good option. |
---|
| 1422 | + */ |
---|
1389 | 1423 | pm_runtime_enable(&pdev->dev); |
---|
1390 | 1424 | if (!pm_runtime_enabled(&pdev->dev)) { |
---|
1391 | 1425 | ret = rockchip_sai_runtime_resume(&pdev->dev); |
---|
1392 | 1426 | if (ret) |
---|
1393 | 1427 | goto err_runtime_disable; |
---|
1394 | 1428 | } |
---|
1395 | | - |
---|
1396 | | - ret = rockchip_sai_init_dai(sai, res, &dai); |
---|
1397 | | - if (ret) |
---|
1398 | | - goto err_runtime_suspend; |
---|
1399 | 1429 | |
---|
1400 | 1430 | ret = devm_snd_soc_register_component(&pdev->dev, |
---|
1401 | 1431 | &rockchip_sai_component, |
---|
.. | .. |
---|
1432 | 1462 | return 0; |
---|
1433 | 1463 | } |
---|
1434 | 1464 | |
---|
1435 | | -#ifdef CONFIG_PM_SLEEP |
---|
1436 | | -static int rockchip_sai_suspend(struct device *dev) |
---|
1437 | | -{ |
---|
1438 | | - struct rk_sai_dev *sai = dev_get_drvdata(dev); |
---|
1439 | | - |
---|
1440 | | - regcache_mark_dirty(sai->regmap); |
---|
1441 | | - |
---|
1442 | | - return 0; |
---|
1443 | | -} |
---|
1444 | | - |
---|
1445 | | -static int rockchip_sai_resume(struct device *dev) |
---|
1446 | | -{ |
---|
1447 | | - struct rk_sai_dev *sai = dev_get_drvdata(dev); |
---|
1448 | | - int ret = pm_runtime_resume_and_get(dev); |
---|
1449 | | - |
---|
1450 | | - if (ret < 0) |
---|
1451 | | - return ret; |
---|
1452 | | - ret = regcache_sync(sai->regmap); |
---|
1453 | | - pm_runtime_put(dev); |
---|
1454 | | - |
---|
1455 | | - return ret; |
---|
1456 | | -} |
---|
1457 | | -#endif /* CONFIG_PM_SLEEP */ |
---|
1458 | | - |
---|
1459 | 1465 | static const struct dev_pm_ops rockchip_sai_pm_ops = { |
---|
1460 | 1466 | SET_RUNTIME_PM_OPS(rockchip_sai_runtime_suspend, rockchip_sai_runtime_resume, NULL) |
---|
1461 | | - SET_SYSTEM_SLEEP_PM_OPS(rockchip_sai_suspend, rockchip_sai_resume) |
---|
| 1467 | + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) |
---|
1462 | 1468 | }; |
---|
1463 | 1469 | |
---|
1464 | 1470 | static struct platform_driver rockchip_sai_driver = { |
---|