hc
2023-12-11 6778948f9de86c3cfaf36725a7c87dcff9ba247f
kernel/sound/pci/echoaudio/echoaudio_dsp.c
....@@ -635,36 +635,30 @@
635635 Meters is an array [3][16][2] of long. */
636636 static void get_audio_meters(struct echoaudio *chip, long *meters)
637637 {
638
- int i, m, n;
638
+ unsigned int i, m, n;
639639
640
- m = 0;
641
- n = 0;
642
- for (i = 0; i < num_busses_out(chip); i++, m++) {
640
+ for (i = 0 ; i < 96; i++)
641
+ meters[i] = 0;
642
+
643
+ for (m = 0, n = 0, i = 0; i < num_busses_out(chip); i++, m++) {
643644 meters[n++] = chip->comm_page->vu_meter[m];
644645 meters[n++] = chip->comm_page->peak_meter[m];
645646 }
646
- for (; n < 32; n++)
647
- meters[n] = 0;
648647
649648 #ifdef ECHOCARD_ECHO3G
650649 m = E3G_MAX_OUTPUTS; /* Skip unused meters */
651650 #endif
652651
653
- for (i = 0; i < num_busses_in(chip); i++, m++) {
652
+ for (n = 32, i = 0; i < num_busses_in(chip); i++, m++) {
654653 meters[n++] = chip->comm_page->vu_meter[m];
655654 meters[n++] = chip->comm_page->peak_meter[m];
656655 }
657
- for (; n < 64; n++)
658
- meters[n] = 0;
659
-
660656 #ifdef ECHOCARD_HAS_VMIXER
661
- for (i = 0; i < num_pipes_out(chip); i++, m++) {
657
+ for (n = 64, i = 0; i < num_pipes_out(chip); i++, m++) {
662658 meters[n++] = chip->comm_page->vu_meter[m];
663659 meters[n++] = chip->comm_page->peak_meter[m];
664660 }
665661 #endif
666
- for (; n < 96; n++)
667
- meters[n] = 0;
668662 }
669663
670664
....@@ -904,7 +898,7 @@
904898 return 0;
905899 }
906900
907
- dev_warn(chip->card->dev, "pause_transport: No pipes to stop!\n");
901
+ dev_dbg(chip->card->dev, "pause_transport: No pipes to stop!\n");
908902 return 0;
909903 }
910904
....@@ -930,7 +924,7 @@
930924 return 0;
931925 }
932926
933
- dev_warn(chip->card->dev, "stop_transport: No pipes to stop!\n");
927
+ dev_dbg(chip->card->dev, "stop_transport: No pipes to stop!\n");
934928 return 0;
935929 }
936930
....@@ -1058,15 +1052,12 @@
10581052 {
10591053 int i;
10601054 u32 channel_mask;
1061
- char is_cyclic;
10621055
10631056 dev_dbg(chip->card->dev,
10641057 "allocate_pipes: ch=%d int=%d\n", pipe_index, interleave);
10651058
10661059 if (chip->bad_board)
10671060 return -EIO;
1068
-
1069
- is_cyclic = 1; /* This driver uses cyclic buffers only */
10701061
10711062 for (channel_mask = i = 0; i < interleave; i++)
10721063 channel_mask |= 1 << (pipe_index + i);
....@@ -1078,8 +1069,8 @@
10781069
10791070 chip->comm_page->position[pipe_index] = 0;
10801071 chip->pipe_alloc_mask |= channel_mask;
1081
- if (is_cyclic)
1082
- chip->pipe_cyclic_mask |= channel_mask;
1072
+ /* This driver uses cyclic buffers only */
1073
+ chip->pipe_cyclic_mask |= channel_mask;
10831074 pipe->index = pipe_index;
10841075 pipe->interleave = interleave;
10851076 pipe->state = PIPE_STATE_STOPPED;