forked from ~ljy/RK356X_SDK_RELEASE
blame | history | patch | commit | commitdiff
hc
2023-12-11 6778948f9de86c3cfaf36725a7c87dcff9ba247f 
 kernel/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c
....@@ -1,27 +1,5 @@
1
-/******************************************************************************
2
- *
3
- * Copyright(c) 2009-2013  Realtek Corporation.
4
- *
5
- * This program is free software; you can redistribute it and/or modify it
6
- * under the terms of version 2 of the GNU General Public License as
7
- * published by the Free Software Foundation.
8
- *
9
- * This program is distributed in the hope that it will be useful, but WITHOUT
10
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
12
- * more details.
13
- *
14
- * The full GNU General Public License is included in this distribution in the
15
- * file called LICENSE.
16
- *
17
- * Contact Information:
18
- * wlanfae <wlanfae@realtek.com>
19
- * Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
20
- * Hsinchu 300, Taiwan.
21
- *
22
- * Larry Finger <Larry.Finger@lwfinger.net>
23
- *
24
- *****************************************************************************/
1
+// SPDX-License-Identifier: GPL-2.0
2
+/* Copyright(c) 2009-2013  Realtek Corporation.*/
253 
264 #include "../wifi.h"
275 #include "../efuse.h"
....@@ -97,11 +75,10 @@
9775 		struct rtl_tx_desc *entry = &ring->desc[ring->idx];
9876 		struct sk_buff *skb = __skb_dequeue(&ring->queue);
9977 
100
-		pci_unmap_single(rtlpci->pdev,
101
-				 rtlpriv->cfg->ops->get_desc(
102
-				 hw,
103
-				 (u8 *)entry, true, HW_DESC_TXBUFF_ADDR),
104
-				 skb->len, PCI_DMA_TODEVICE);
78
+		dma_unmap_single(&rtlpci->pdev->dev,
79
+				 rtlpriv->cfg->ops->get_desc(hw, (u8 *)entry,
80
+						true, HW_DESC_TXBUFF_ADDR),
81
+				 skb->len, DMA_TO_DEVICE);
10582 		kfree_skb(skb);
10683 		ring->idx = (ring->idx + 1) % ring->entries;
10784 	}
....@@ -162,9 +139,9 @@
162139 			if (content & IMR_CPWM) {
163140 				rtl_write_word(rtlpriv, isr_regaddr, 0x0100);
164141 				rtlhal->fw_ps_state = FW_PS_STATE_RF_ON_88E;
165
-				RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
166
-					 "Receive CPWM INT!!! Set pHalData->FwPSState = %X\n",
167
-					 rtlhal->fw_ps_state);
142
+				rtl_dbg(rtlpriv, COMP_POWER, DBG_LOUD,
143
+					"Receive CPWM INT!!! Set pHalData->FwPSState = %X\n",
144
+					rtlhal->fw_ps_state);
168145 			}
169146 		}
170147 
....@@ -422,8 +399,8 @@
422399 	case HW_VAR_SLOT_TIME:{
423400 		u8 e_aci;
424401 
425
-		RT_TRACE(rtlpriv, COMP_MLME, DBG_LOUD,
426
-			 "HW_VAR_SLOT_TIME %x\n", val[0]);
402
+		rtl_dbg(rtlpriv, COMP_MLME, DBG_LOUD,
403
+			"HW_VAR_SLOT_TIME %x\n", val[0]);
427404 
428405 		rtl_write_byte(rtlpriv, REG_SLOT, val[0]);
429406 
....@@ -467,9 +444,9 @@
467444 
468445 			*val = min_spacing_to_set;
469446 
470
-			RT_TRACE(rtlpriv, COMP_MLME, DBG_LOUD,
471
-				 "Set HW_VAR_AMPDU_MIN_SPACE: %#x\n",
472
-				  mac->min_space_cfg);
447
+			rtl_dbg(rtlpriv, COMP_MLME, DBG_LOUD,
448
+				"Set HW_VAR_AMPDU_MIN_SPACE: %#x\n",
449
+				mac->min_space_cfg);
473450 
474451 			rtl_write_byte(rtlpriv, REG_AMPDU_MIN_SPACE,
475452 				       mac->min_space_cfg);
....@@ -481,9 +458,9 @@
481458 		density_to_set = *val;
482459 		mac->min_space_cfg |= (density_to_set << 3);
483460 
484
-		RT_TRACE(rtlpriv, COMP_MLME, DBG_LOUD,
485
-			 "Set HW_VAR_SHORTGI_DENSITY: %#x\n",
486
-			  mac->min_space_cfg);
461
+		rtl_dbg(rtlpriv, COMP_MLME, DBG_LOUD,
462
+			"Set HW_VAR_SHORTGI_DENSITY: %#x\n",
463
+			mac->min_space_cfg);
487464 
488465 		rtl_write_byte(rtlpriv, REG_AMPDU_MIN_SPACE,
489466 			       mac->min_space_cfg);
....@@ -522,9 +499,9 @@
522499 
523500 			}
524501 
525
-			RT_TRACE(rtlpriv, COMP_MLME, DBG_LOUD,
526
-				 "Set HW_VAR_AMPDU_FACTOR: %#x\n",
527
-				  factor_toset);
502
+			rtl_dbg(rtlpriv, COMP_MLME, DBG_LOUD,
503
+				"Set HW_VAR_AMPDU_FACTOR: %#x\n",
504
+				factor_toset);
528505 		}
529506 		break; }
530507 	case HW_VAR_AC_PARAM:{
....@@ -558,9 +535,9 @@
558535 				acm_ctrl |= ACMHW_VOQEN;
559536 				break;
560537 			default:
561
-				RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
562
-					 "HW_VAR_ACM_CTRL acm set failed: eACI is %d\n",
563
-					 acm);
538
+				rtl_dbg(rtlpriv, COMP_ERR, DBG_WARNING,
539
+					"HW_VAR_ACM_CTRL acm set failed: eACI is %d\n",
540
+					acm);
564541 				break;
565542 			}
566543 		} else {
....@@ -581,9 +558,9 @@
581558 			}
582559 		}
583560 
584
-		RT_TRACE(rtlpriv, COMP_QOS, DBG_TRACE,
585
-			 "SetHwReg8190pci(): [HW_VAR_ACM_CTRL] Write 0x%X\n",
586
-			 acm_ctrl);
561
+		rtl_dbg(rtlpriv, COMP_QOS, DBG_TRACE,
562
+			"SetHwReg8190pci(): [HW_VAR_ACM_CTRL] Write 0x%X\n",
563
+			acm_ctrl);
587564 		rtl_write_byte(rtlpriv, REG_ACMHWCTRL, acm_ctrl);
588565 		break; }
589566 	case HW_VAR_RCR:
....@@ -797,22 +774,22 @@
797774 
798775 	for (i = 0; i < (txpktbuf_bndy - 1); i++) {
799776 		status = _rtl88ee_llt_write(hw, i, i + 1);
800
-		if (true != status)
777
+		if (!status)
801778 			return status;
802779 	}
803780 
804781 	status = _rtl88ee_llt_write(hw, (txpktbuf_bndy - 1), 0xFF);
805
-	if (true != status)
782
+	if (!status)
806783 		return status;
807784 
808785 	for (i = txpktbuf_bndy; i < maxpage; i++) {
809786 		status = _rtl88ee_llt_write(hw, i, (i + 1));
810
-		if (true != status)
787
+		if (!status)
811788 			return status;
812789 	}
813790 
814791 	status = _rtl88ee_llt_write(hw, maxpage, txpktbuf_bndy);
815
-	if (true != status)
792
+	if (!status)
816793 		return status;
817794 
818795 	return true;
....@@ -856,8 +833,8 @@
856833 	if (!rtl_hal_pwrseqcmdparsing(rtlpriv, PWR_CUT_ALL_MSK,
857834 				      PWR_FAB_ALL_MSK, PWR_INTF_PCI_MSK,
858835 				      RTL8188EE_NIC_ENABLE_FLOW)) {
859
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
860
-			 "init MAC Fail as rtl_hal_pwrseqcmdparsing\n");
836
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD,
837
+			"init MAC Fail as rtl_hal_pwrseqcmdparsing\n");
861838 		return false;
862839 	}
863840 
....@@ -891,9 +868,9 @@
891868 	rtl_write_byte(rtlpriv, MSR, 0x00);
892869 
893870 	if (!rtlhal->mac_func_enable) {
894
-		if (_rtl88ee_llt_table_init(hw) == false) {
895
-			RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
896
-				 "LLT table init fail\n");
871
+		if (!_rtl88ee_llt_table_init(hw)) {
872
+			rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD,
873
+				"LLT table init fail\n");
897874 			return false;
898875 		}
899876 	}
....@@ -951,12 +928,8 @@
951928 static void _rtl88ee_hw_configure(struct ieee80211_hw *hw)
952929 {
953930 	struct rtl_priv *rtlpriv = rtl_priv(hw);
954
-	u8 reg_bw_opmode;
955
-	u32 reg_ratr, reg_prsr;
931
+	u32 reg_prsr;
956932 
957
-	reg_bw_opmode = BW_OPMODE_20MHZ;
958
-	reg_ratr = RATE_ALL_CCK | RATE_ALL_OFDM_AG |
959
-	    RATE_ALL_OFDM_1SS | RATE_ALL_OFDM_2SS;
960933 	reg_prsr = RATE_ALL_CCK | RATE_ALL_OFDM_AG;
961934 
962935 	rtl_write_dword(rtlpriv, REG_RRSR, reg_prsr);
....@@ -1028,14 +1001,14 @@
10281001 	struct rtl_priv *rtlpriv = rtl_priv(hw);
10291002 	u8 sec_reg_value;
10301003 
1031
-	RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
1032
-		 "PairwiseEncAlgorithm = %d GroupEncAlgorithm = %d\n",
1033
-		  rtlpriv->sec.pairwise_enc_algorithm,
1034
-		  rtlpriv->sec.group_enc_algorithm);
1004
+	rtl_dbg(rtlpriv, COMP_INIT, DBG_DMESG,
1005
+		"PairwiseEncAlgorithm = %d GroupEncAlgorithm = %d\n",
1006
+		rtlpriv->sec.pairwise_enc_algorithm,
1007
+		rtlpriv->sec.group_enc_algorithm);
10351008 
10361009 	if (rtlpriv->cfg->mod_params->sw_crypto || rtlpriv->sec.use_sw_sec) {
1037
-		RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
1038
-			 "not open hw encryption\n");
1010
+		rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG,
1011
+			"not open hw encryption\n");
10391012 		return;
10401013 	}
10411014 
....@@ -1050,8 +1023,8 @@
10501023 
10511024 	rtl_write_byte(rtlpriv, REG_CR + 1, 0x02);
10521025 
1053
-	RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
1054
-		 "The SECR-value %x\n", sec_reg_value);
1026
+	rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG,
1027
+		"The SECR-value %x\n", sec_reg_value);
10551028 
10561029 	rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_WPA_CONFIG, &sec_reg_value);
10571030 }
....@@ -1065,7 +1038,7 @@
10651038 	struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
10661039 	struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
10671040 	struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
1068
-	bool rtstatus = true;
1041
+	bool rtstatus;
10691042 	int err = 0;
10701043 	u8 tmp_u1b, u1byte;
10711044 	unsigned long flags;
....@@ -1094,7 +1067,7 @@
10941067 	}
10951068 
10961069 	rtstatus = _rtl88ee_init_mac(hw);
1097
-	if (rtstatus != true) {
1070
+	if (!rtstatus) {
10981071 		pr_info("Init MAC failed\n");
10991072 		err = 1;
11001073 		goto exit;
....@@ -1102,8 +1075,8 @@
11021075 
11031076 	err = rtl88e_download_fw(hw, false);
11041077 	if (err) {
1105
-		RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
1106
-			 "Failed to download FW. Init HW without FW now..\n");
1078
+		rtl_dbg(rtlpriv, COMP_ERR, DBG_WARNING,
1079
+			"Failed to download FW. Init HW without FW now..\n");
11071080 		err = 1;
11081081 		goto exit;
11091082 	}
....@@ -1156,9 +1129,9 @@
11561129 			rtl88e_phy_set_rfpath_switch(hw, false);
11571130 			rtlpriv->dm.fat_table.rx_idle_ant = AUX_ANT;
11581131 		}
1159
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "rx idle ant %s\n",
1160
-			 (rtlpriv->dm.fat_table.rx_idle_ant == MAIN_ANT) ?
1161
-			 ("MAIN_ANT") : ("AUX_ANT"));
1132
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD, "rx idle ant %s\n",
1133
+			(rtlpriv->dm.fat_table.rx_idle_ant == MAIN_ANT) ?
1134
+			("MAIN_ANT") : ("AUX_ANT"));
11621135 
11631136 		if (rtlphy->iqk_initialized) {
11641137 			rtl88e_phy_iq_calibrate(hw, true);
....@@ -1174,7 +1147,7 @@
11741147 	tmp_u1b = efuse_read_1byte(hw, 0x1FA);
11751148 	if (!(tmp_u1b & BIT(0))) {
11761149 		rtl_set_rfreg(hw, RF90_PATH_A, 0x15, 0x0F, 0x05);
1177
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "PA BIAS path A\n");
1150
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD, "PA BIAS path A\n");
11781151 	}
11791152 
11801153 	if (!(tmp_u1b & BIT(4))) {
....@@ -1183,7 +1156,7 @@
11831156 		rtl_write_byte(rtlpriv, 0x16, tmp_u1b | 0x80);
11841157 		udelay(10);
11851158 		rtl_write_byte(rtlpriv, 0x16, tmp_u1b | 0x90);
1186
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "under 1.5V\n");
1159
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD, "under 1.5V\n");
11871160 	}
11881161 	rtl_write_byte(rtlpriv, REG_NAV_CTRL+2,  ((30000+127)/128));
11891162 	rtl88e_dm_init(hw);
....@@ -1211,9 +1184,9 @@
12111184 	}
12121185 
12131186 	rtlphy->rf_type = RF_1T1R;
1214
-	RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
1215
-		 "Chip RF Type: %s\n", (rtlphy->rf_type == RF_2T2R) ?
1216
-		 "RF_2T2R" : "RF_1T1R");
1187
+	rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD,
1188
+		"Chip RF Type: %s\n", (rtlphy->rf_type == RF_2T2R) ?
1189
+		"RF_2T2R" : "RF_1T1R");
12171190 
12181191 	return version;
12191192 }
....@@ -1229,26 +1202,26 @@
12291202 	switch (type) {
12301203 	case NL80211_IFTYPE_UNSPECIFIED:
12311204 		mode = MSR_NOLINK;
1232
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
1233
-			 "Set Network type to NO LINK!\n");
1205
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
1206
+			"Set Network type to NO LINK!\n");
12341207 		break;
12351208 	case NL80211_IFTYPE_ADHOC:
12361209 	case NL80211_IFTYPE_MESH_POINT:
12371210 		mode = MSR_ADHOC;
1238
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
1239
-			 "Set Network type to Ad Hoc!\n");
1211
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
1212
+			"Set Network type to Ad Hoc!\n");
12401213 		break;
12411214 	case NL80211_IFTYPE_STATION:
12421215 		mode = MSR_INFRA;
12431216 		ledaction = LED_CTL_LINK;
1244
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
1245
-			 "Set Network type to STA!\n");
1217
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
1218
+			"Set Network type to STA!\n");
12461219 		break;
12471220 	case NL80211_IFTYPE_AP:
12481221 		mode = MSR_AP;
12491222 		ledaction = LED_CTL_LINK;
1250
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
1251
-			 "Set Network type to AP!\n");
1223
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
1224
+			"Set Network type to AP!\n");
12521225 		break;
12531226 	default:
12541227 		pr_err("Network type %d not support!\n", type);
....@@ -1274,9 +1247,9 @@
12741247 		_rtl88ee_resume_tx_beacon(hw);
12751248 		_rtl88ee_disable_bcn_sub_func(hw);
12761249 	} else {
1277
-		RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
1278
-			 "Set HW_VAR_MEDIA_STATUS: No such media status(%x).\n",
1279
-			 mode);
1250
+		rtl_dbg(rtlpriv, COMP_ERR, DBG_WARNING,
1251
+			"Set HW_VAR_MEDIA_STATUS: No such media status(%x).\n",
1252
+			mode);
12801253 	}
12811254 
12821255 	rtl_write_byte(rtlpriv, MSR, bt_msr | mode);
....@@ -1396,7 +1369,7 @@
13961369 	rtlhal->mac_func_enable = false;
13971370 	rtlpriv->intf_ops->enable_aspm(hw);
13981371 
1399
-	RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "POWER OFF adapter\n");
1372
+	rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD, "POWER OFF adapter\n");
14001373 	u1b_tmp = rtl_read_byte(rtlpriv, REG_TX_RPT_CTRL);
14011374 	rtl_write_byte(rtlpriv, REG_TX_RPT_CTRL, u1b_tmp & (~BIT(1)));
14021375 
....@@ -1453,7 +1426,7 @@
14531426 	struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
14541427 	enum nl80211_iftype opmode;
14551428 
1456
-	RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "RTL8188ee card disable\n");
1429
+	rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD, "RTL8188ee card disable\n");
14571430 
14581431 	mac->link_state = MAC80211_NOLINK;
14591432 	opmode = NL80211_IFTYPE_UNSPECIFIED;
....@@ -1512,8 +1485,8 @@
15121485 	struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
15131486 	u16 bcn_interval = mac->beacon_interval;
15141487 
1515
-	RT_TRACE(rtlpriv, COMP_BEACON, DBG_DMESG,
1516
-		 "beacon_interval:%d\n", bcn_interval);
1488
+	rtl_dbg(rtlpriv, COMP_BEACON, DBG_DMESG,
1489
+		"beacon_interval:%d\n", bcn_interval);
15171490 	/*rtl88ee_disable_interrupt(hw);*/
15181491 	rtl_write_word(rtlpriv, REG_BCN_INTERVAL, bcn_interval);
15191492 	/*rtl88ee_enable_interrupt(hw);*/
....@@ -1525,8 +1498,8 @@
15251498 	struct rtl_priv *rtlpriv = rtl_priv(hw);
15261499 	struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
15271500 
1528
-	RT_TRACE(rtlpriv, COMP_INTR, DBG_LOUD,
1529
-		 "add_msr:%x, rm_msr:%x\n", add_msr, rm_msr);
1501
+	rtl_dbg(rtlpriv, COMP_INTR, DBG_LOUD,
1502
+		"add_msr:%x, rm_msr:%x\n", add_msr, rm_msr);
15301503 
15311504 	if (add_msr)
15321505 		rtlpci->irq_mask[0] |= add_msr;
....@@ -1585,15 +1558,15 @@
15851558 	struct rtl_priv *rtlpriv = rtl_priv(hw);
15861559 	u32 rfpath, eeaddr = EEPROM_TX_PWR_INX, group, txcnt = 0;
15871560 
1588
-	RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
1589
-		 "hal_ReadPowerValueFromPROM88E():PROMContent[0x%x]=0x%x\n",
1590
-		 (eeaddr+1), hwinfo[eeaddr+1]);
1561
+	rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD,
1562
+		"hal_ReadPowerValueFromPROM88E():PROMContent[0x%x]=0x%x\n",
1563
+		(eeaddr + 1), hwinfo[eeaddr + 1]);
15911564 	if (0xFF == hwinfo[eeaddr+1])  /*YJ,add,120316*/
15921565 		autoload_fail = true;
15931566 
15941567 	if (autoload_fail) {
1595
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
1596
-			 "auto load fail : Use Default value!\n");
1568
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD,
1569
+			"auto load fail : Use Default value!\n");
15971570 		for (rfpath = 0 ; rfpath < MAX_RF_PATH ; rfpath++) {
15981571 			/* 2.4G default value */
15991572 			set_24g_base(pwrinfo24g, rfpath);
....@@ -1852,8 +1825,8 @@
18521825 	if (rtlefuse->eeprom_oemid == 0xFF)
18531826 		rtlefuse->eeprom_oemid = 0;
18541827 
1855
-	RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
1856
-		 "EEPROM Customer ID: 0x%2x\n", rtlefuse->eeprom_oemid);
1828
+	rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD,
1829
+		"EEPROM Customer ID: 0x%2x\n", rtlefuse->eeprom_oemid);
18571830 	/* set channel plan from efuse */
18581831 	rtlefuse->channel_plan = rtlefuse->eeprom_channelplan;
18591832 	/*tx power*/
....@@ -1951,8 +1924,8 @@
19511924 	default:
19521925 		break;
19531926 	}
1954
-	RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG,
1955
-		 "RT Customized ID: 0x%02X\n", rtlhal->oem_id);
1927
+	rtl_dbg(rtlpriv, COMP_INIT, DBG_DMESG,
1928
+		"RT Customized ID: 0x%02X\n", rtlhal->oem_id);
19561929 }
19571930 
19581931 void rtl88ee_read_eeprom_info(struct ieee80211_hw *hw)
....@@ -1969,18 +1942,18 @@
19691942 	else
19701943 		rtlpriv->dm.rfpath_rxenable[0] =
19711944 		    rtlpriv->dm.rfpath_rxenable[1] = true;
1972
-	RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "VersionID = 0x%4x\n",
1973
-						rtlhal->version);
1945
+	rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD, "VersionID = 0x%4x\n",
1946
+		rtlhal->version);
19741947 	tmp_u1b = rtl_read_byte(rtlpriv, REG_9346CR);
19751948 	if (tmp_u1b & BIT(4)) {
1976
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG, "Boot from EEPROM\n");
1949
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_DMESG, "Boot from EEPROM\n");
19771950 		rtlefuse->epromtype = EEPROM_93C46;
19781951 	} else {
1979
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_DMESG, "Boot from EFUSE\n");
1952
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_DMESG, "Boot from EFUSE\n");
19801953 		rtlefuse->epromtype = EEPROM_BOOT_EFUSE;
19811954 	}
19821955 	if (tmp_u1b & BIT(5)) {
1983
-		RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "Autoload OK\n");
1956
+		rtl_dbg(rtlpriv, COMP_INIT, DBG_LOUD, "Autoload OK\n");
19841957 		rtlefuse->autoload_failflag = false;
19851958 		_rtl88ee_read_adapter_info(hw);
19861959 	} else {
....@@ -2075,8 +2048,8 @@
20752048 
20762049 	rtl_write_dword(rtlpriv, REG_ARFR0 + ratr_index * 4, ratr_value);
20772050 
2078
-	RT_TRACE(rtlpriv, COMP_RATR, DBG_DMESG,
2079
-		 "%x\n", rtl_read_dword(rtlpriv, REG_ARFR0));
2051
+	rtl_dbg(rtlpriv, COMP_RATR, DBG_DMESG,
2052
+		"%x\n", rtl_read_dword(rtlpriv, REG_ARFR0));
20802053 }
20812054 
20822055 static void rtl88ee_update_hal_rate_mask(struct ieee80211_hw *hw,
....@@ -2195,17 +2168,17 @@
21952168 	}
21962169 	sta_entry->ratr_index = ratr_index;
21972170 
2198
-	RT_TRACE(rtlpriv, COMP_RATR, DBG_DMESG,
2199
-		 "ratr_bitmap :%x\n", ratr_bitmap);
2171
+	rtl_dbg(rtlpriv, COMP_RATR, DBG_DMESG,
2172
+		"ratr_bitmap :%x\n", ratr_bitmap);
22002173 	*(u32 *)&rate_mask = (ratr_bitmap & 0x0fffffff) |
22012174 			     (ratr_index << 28);
22022175 	rate_mask[4] = macid | (b_shortgi ? 0x20 : 0x00) | 0x80;
2203
-	RT_TRACE(rtlpriv, COMP_RATR, DBG_DMESG,
2204
-		 "Rate_index:%x, ratr_val:%x, %x:%x:%x:%x:%x\n",
2205
-		 ratr_index, ratr_bitmap,
2206
-		 rate_mask[0], rate_mask[1],
2207
-		 rate_mask[2], rate_mask[3],
2208
-		 rate_mask[4]);
2176
+	rtl_dbg(rtlpriv, COMP_RATR, DBG_DMESG,
2177
+		"Rate_index:%x, ratr_val:%x, %x:%x:%x:%x:%x\n",
2178
+		ratr_index, ratr_bitmap,
2179
+		rate_mask[0], rate_mask[1],
2180
+		rate_mask[2], rate_mask[3],
2181
+		rate_mask[4]);
22092182 	rtl88e_fill_h2c_cmd(hw, H2C_88E_RA_MASK, 5, rate_mask);
22102183 	_rtl88ee_set_bcn_ctrl_reg(hw, BIT(3), 0);
22112184 }
....@@ -2262,16 +2235,16 @@
22622235 	e_rfpowerstate_toset = (u4tmp & BIT(31)) ? ERFON : ERFOFF;
22632236 
22642237 	if (ppsc->hwradiooff && (e_rfpowerstate_toset == ERFON)) {
2265
-		RT_TRACE(rtlpriv, COMP_RF, DBG_DMESG,
2266
-			 "GPIOChangeRF  - HW Radio ON, RF ON\n");
2238
+		rtl_dbg(rtlpriv, COMP_RF, DBG_DMESG,
2239
+			"GPIOChangeRF  - HW Radio ON, RF ON\n");
22672240 
22682241 		e_rfpowerstate_toset = ERFON;
22692242 		ppsc->hwradiooff = false;
22702243 		b_actuallyset = true;
22712244 	} else if ((!ppsc->hwradiooff) &&
22722245 		   (e_rfpowerstate_toset == ERFOFF)) {
2273
-		RT_TRACE(rtlpriv, COMP_RF, DBG_DMESG,
2274
-			 "GPIOChangeRF  - HW Radio OFF, RF OFF\n");
2246
+		rtl_dbg(rtlpriv, COMP_RF, DBG_DMESG,
2247
+			"GPIOChangeRF  - HW Radio OFF, RF OFF\n");
22752248 
22762249 		e_rfpowerstate_toset = ERFOFF;
22772250 		ppsc->hwradiooff = true;
....@@ -2321,7 +2294,7 @@
23212294 		u8 cam_offset = 0;
23222295 		u8 clear_number = 5;
23232296 
2324
-		RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG, "clear_all\n");
2297
+		rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG, "clear_all\n");
23252298 
23262299 		for (idx = 0; idx < clear_number; idx++) {
23272300 			rtl_cam_mark_invalid(hw, cam_offset + idx);
....@@ -2380,27 +2353,27 @@
23802353 		}
23812354 
23822355 		if (rtlpriv->sec.key_len[key_index] == 0) {
2383
-			RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
2384
-				 "delete one entry, entry_id is %d\n",
2385
-				 entry_id);
2356
+			rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG,
2357
+				"delete one entry, entry_id is %d\n",
2358
+				entry_id);
23862359 			if (mac->opmode == NL80211_IFTYPE_AP ||
23872360 				mac->opmode == NL80211_IFTYPE_MESH_POINT)
23882361 				rtl_cam_del_entry(hw, p_macaddr);
23892362 			rtl_cam_delete_one_entry(hw, p_macaddr, entry_id);
23902363 		} else {
2391
-			RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
2392
-				 "add one entry\n");
2364
+			rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG,
2365
+				"add one entry\n");
23932366 			if (is_pairwise) {
2394
-				RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
2395
-					 "set Pairwise key\n");
2367
+				rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG,
2368
+					"set Pairwise key\n");
23962369 
23972370 				rtl_cam_add_one_entry(hw, macaddr, key_index,
23982371 						      entry_id, enc_algo,
23992372 						      CAM_CONFIG_NO_USEDK,
24002373 						      rtlpriv->sec.key_buf[key_index]);
24012374 			} else {
2402
-				RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
2403
-					 "set group key\n");
2375
+				rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG,
2376
+					"set group key\n");
24042377 
24052378 				if (mac->opmode == NL80211_IFTYPE_ADHOC) {
24062379 					rtl_cam_add_one_entry(hw,
....@@ -2512,13 +2485,12 @@
25122485 		if (rtlpriv->btcoexist.bt_ant_isolation)
25132486 			rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, 0xa0);
25142487 
2515
-		u1_tmp = rtl_read_byte(rtlpriv, 0x4fd) &
2516
-			 BIT_OFFSET_LEN_MASK_32(0, 1);
2488
+		u1_tmp = rtl_read_byte(rtlpriv, 0x4fd) & BIT(0);
25172489 		u1_tmp = u1_tmp |
25182490 			 ((rtlpriv->btcoexist.bt_ant_isolation == 1) ?
2519
-			 0 : BIT_OFFSET_LEN_MASK_32(1, 1)) |
2491
+			 0 : BIT((1)) |
25202492 			 ((rtlpriv->btcoexist.bt_service == BT_SCO) ?
2521
-			 0 : BIT_OFFSET_LEN_MASK_32(2, 1));
2493
+			 0 : BIT(2)));
25222494 		rtl_write_byte(rtlpriv, 0x4fd, u1_tmp);
25232495 
25242496 		rtl_write_dword(rtlpriv, REG_BT_COEX_TABLE+4, 0xaaaa9aaa);
....@@ -2528,11 +2500,11 @@
25282500 		/* Config to 1T1R. */
25292501 		if (rtlphy->rf_type == RF_1T1R) {
25302502 			u1_tmp = rtl_read_byte(rtlpriv, ROFDM0_TRXPATHENABLE);
2531
-			u1_tmp &= ~(BIT_OFFSET_LEN_MASK_32(1, 1));
2503
+			u1_tmp &= ~(BIT(1));
25322504 			rtl_write_byte(rtlpriv, ROFDM0_TRXPATHENABLE, u1_tmp);
25332505 
25342506 			u1_tmp = rtl_read_byte(rtlpriv, ROFDM1_TRXPATHENABLE);
2535
-			u1_tmp &= ~(BIT_OFFSET_LEN_MASK_32(1, 1));
2507
+			u1_tmp &= ~(BIT(1));
25362508 			rtl_write_byte(rtlpriv, ROFDM1_TRXPATHENABLE, u1_tmp);
25372509 		}
25382510 	}