hc
2023-12-11 6778948f9de86c3cfaf36725a7c87dcff9ba247f
kernel/drivers/net/ethernet/intel/e1000e/80003es2lan.c
....@@ -680,7 +680,7 @@
680680 ew32(TCTL, E1000_TCTL_PSP);
681681 e1e_flush();
682682
683
- usleep_range(10000, 20000);
683
+ usleep_range(10000, 11000);
684684
685685 ctrl = er32(CTRL);
686686
....@@ -696,11 +696,16 @@
696696 ret_val =
697697 e1000_read_kmrn_reg_80003es2lan(hw, E1000_KMRNCTRLSTA_INBAND_PARAM,
698698 &kum_reg_data);
699
- if (ret_val)
700
- return ret_val;
701
- kum_reg_data |= E1000_KMRNCTRLSTA_IBIST_DISABLE;
702
- e1000_write_kmrn_reg_80003es2lan(hw, E1000_KMRNCTRLSTA_INBAND_PARAM,
703
- kum_reg_data);
699
+ if (!ret_val) {
700
+ kum_reg_data |= E1000_KMRNCTRLSTA_IBIST_DISABLE;
701
+ ret_val = e1000_write_kmrn_reg_80003es2lan(hw,
702
+ E1000_KMRNCTRLSTA_INBAND_PARAM,
703
+ kum_reg_data);
704
+ if (ret_val)
705
+ e_dbg("Error disabling far-end loopback\n");
706
+ } else {
707
+ e_dbg("Error disabling far-end loopback\n");
708
+ }
704709
705710 ret_val = e1000e_get_auto_rd_done(hw);
706711 if (ret_val)
....@@ -754,11 +759,19 @@
754759 return ret_val;
755760
756761 /* Disable IBIST slave mode (far-end loopback) */
757
- e1000_read_kmrn_reg_80003es2lan(hw, E1000_KMRNCTRLSTA_INBAND_PARAM,
758
- &kum_reg_data);
759
- kum_reg_data |= E1000_KMRNCTRLSTA_IBIST_DISABLE;
760
- e1000_write_kmrn_reg_80003es2lan(hw, E1000_KMRNCTRLSTA_INBAND_PARAM,
761
- kum_reg_data);
762
+ ret_val =
763
+ e1000_read_kmrn_reg_80003es2lan(hw, E1000_KMRNCTRLSTA_INBAND_PARAM,
764
+ &kum_reg_data);
765
+ if (!ret_val) {
766
+ kum_reg_data |= E1000_KMRNCTRLSTA_IBIST_DISABLE;
767
+ ret_val = e1000_write_kmrn_reg_80003es2lan(hw,
768
+ E1000_KMRNCTRLSTA_INBAND_PARAM,
769
+ kum_reg_data);
770
+ if (ret_val)
771
+ e_dbg("Error disabling far-end loopback\n");
772
+ } else {
773
+ e_dbg("Error disabling far-end loopback\n");
774
+ }
762775
763776 /* Set the transmit descriptor write-back policy */
764777 reg_data = er32(TXDCTL(0));
....@@ -1059,7 +1072,6 @@
10591072 /**
10601073 * e1000_cfg_on_link_up_80003es2lan - es2 link configuration after link-up
10611074 * @hw: pointer to the HW structure
1062
- * @duplex: current duplex setting
10631075 *
10641076 * Configure the KMRN interface by applying last minute quirks for
10651077 * 10/100 operation.