hc
2023-12-11 6778948f9de86c3cfaf36725a7c87dcff9ba247f
kernel/drivers/infiniband/hw/qib/qib_iba6120.c
....@@ -1417,7 +1417,6 @@
14171417 *
14181418 * The exact combo of LEDs if on is true is determined by looking
14191419 * at the ibcstatus.
1420
-
14211420 * These LEDs indicate the physical and logical state of IB link.
14221421 * For this chip (at least with recommended board pinouts), LED1
14231422 * is Yellow (logical state) and LED2 is Green (physical state),
....@@ -1884,7 +1883,6 @@
18841883 qib_write_kreg(dd, kr_scratch, 0xfeeddeaf);
18851884 writel(pa, tidp32);
18861885 qib_write_kreg(dd, kr_scratch, 0xdeadbeef);
1887
- mmiowb();
18881886 spin_unlock_irqrestore(tidlockp, flags);
18891887 }
18901888
....@@ -1928,7 +1926,6 @@
19281926 pa |= 2 << 29;
19291927 }
19301928 writel(pa, tidp32);
1931
- mmiowb();
19321929 }
19331930
19341931
....@@ -2053,9 +2050,7 @@
20532050 {
20542051 if (updegr)
20552052 qib_write_ureg(rcd->dd, ur_rcvegrindexhead, egrhd, rcd->ctxt);
2056
- mmiowb();
20572053 qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
2058
- mmiowb();
20592054 }
20602055
20612056 static u32 qib_6120_hdrqempty(struct qib_ctxtdata *rcd)
....@@ -2978,11 +2973,11 @@
29782973 state = IB_PORT_ARMED;
29792974 break;
29802975 case IB_6120_L_STATE_ACTIVE:
2981
- /* fall through */
29822976 case IB_6120_L_STATE_ACT_DEFER:
29832977 state = IB_PORT_ACTIVE;
29842978 break;
2985
- default: /* fall through */
2979
+ default:
2980
+ fallthrough;
29862981 case IB_6120_L_STATE_DOWN:
29872982 state = IB_PORT_DOWN;
29882983 break;
....@@ -3237,7 +3232,6 @@
32373232 /* we always allocate at least 2048 bytes for eager buffers */
32383233 ret = ib_mtu_enum_to_int(qib_ibmtu);
32393234 dd->rcvegrbufsize = ret != -1 ? max(ret, 2048) : QIB_DEFAULT_MTU;
3240
- BUG_ON(!is_power_of_2(dd->rcvegrbufsize));
32413235 dd->rcvegrbufsize_shift = ilog2(dd->rcvegrbufsize);
32423236
32433237 qib_6120_tidtemplate(dd);