hc
2023-12-11 6778948f9de86c3cfaf36725a7c87dcff9ba247f
kernel/arch/x86/kernel/crash_dump_32.c
....@@ -13,6 +13,8 @@
1313
1414 #include <linux/uaccess.h>
1515
16
+static void *kdump_buf_page;
17
+
1618 static inline bool is_crashed_pfn_valid(unsigned long pfn)
1719 {
1820 #ifndef CONFIG_X86_PAE
....@@ -39,11 +41,15 @@
3941 * @userbuf: if set, @buf is in user address space, use copy_to_user(),
4042 * otherwise @buf is in kernel address space, use memcpy().
4143 *
42
- * Copy a page from "oldmem". For this page, there might be no pte mapped
43
- * in the current kernel.
44
+ * Copy a page from "oldmem". For this page, there is no pte mapped
45
+ * in the current kernel. We stitch up a pte, similar to kmap_atomic.
46
+ *
47
+ * Calling copy_to_user() in atomic context is not desirable. Hence first
48
+ * copying the data to a pre-allocated kernel page and then copying to user
49
+ * space in non-atomic context.
4450 */
45
-ssize_t copy_oldmem_page(unsigned long pfn, char *buf, size_t csize,
46
- unsigned long offset, int userbuf)
51
+ssize_t copy_oldmem_page(unsigned long pfn, char *buf,
52
+ size_t csize, unsigned long offset, int userbuf)
4753 {
4854 void *vaddr;
4955
....@@ -53,16 +59,38 @@
5359 if (!is_crashed_pfn_valid(pfn))
5460 return -EFAULT;
5561
56
- vaddr = kmap_local_pfn(pfn);
62
+ vaddr = kmap_atomic_pfn(pfn);
5763
5864 if (!userbuf) {
59
- memcpy(buf, vaddr + offset, csize);
65
+ memcpy(buf, (vaddr + offset), csize);
66
+ kunmap_atomic(vaddr);
6067 } else {
61
- if (copy_to_user(buf, vaddr + offset, csize))
62
- csize = -EFAULT;
68
+ if (!kdump_buf_page) {
69
+ printk(KERN_WARNING "Kdump: Kdump buffer page not"
70
+ " allocated\n");
71
+ kunmap_atomic(vaddr);
72
+ return -EFAULT;
73
+ }
74
+ copy_page(kdump_buf_page, vaddr);
75
+ kunmap_atomic(vaddr);
76
+ if (copy_to_user(buf, (kdump_buf_page + offset), csize))
77
+ return -EFAULT;
6378 }
64
-
65
- kunmap_local(vaddr);
6679
6780 return csize;
6881 }
82
+
83
+static int __init kdump_buf_page_init(void)
84
+{
85
+ int ret = 0;
86
+
87
+ kdump_buf_page = kmalloc(PAGE_SIZE, GFP_KERNEL);
88
+ if (!kdump_buf_page) {
89
+ printk(KERN_WARNING "Kdump: Failed to allocate kdump buffer"
90
+ " page\n");
91
+ ret = -ENOMEM;
92
+ }
93
+
94
+ return ret;
95
+}
96
+arch_initcall(kdump_buf_page_init);