hc
2024-05-10 37f49e37ab4cb5d0bc4c60eb5c6d4dd57db767bb
kernel/drivers/net/dsa/mv88e6xxx/global2_avb.c
....@@ -1,3 +1,4 @@
1
+// SPDX-License-Identifier: GPL-2.0-or-later
12 /*
23 * Marvell 88E6xxx Switch Global 2 Registers support
34 *
....@@ -8,12 +9,9 @@
89 *
910 * Copyright (c) 2017 National Instruments
1011 * Brandon Streiff <brandon.streiff@ni.com>
11
- *
12
- * This program is free software; you can redistribute it and/or modify
13
- * it under the terms of the GNU General Public License as published by
14
- * the Free Software Foundation; either version 2 of the License, or
15
- * (at your option) any later version.
1612 */
13
+
14
+#include <linux/bitfield.h>
1715
1816 #include "global2.h"
1917
....@@ -31,17 +29,33 @@
3129 /* mv88e6xxx_g2_avb_read -- Read one or multiple 16-bit words.
3230 * The hardware supports snapshotting up to four contiguous registers.
3331 */
32
+static int mv88e6xxx_g2_avb_wait(struct mv88e6xxx_chip *chip)
33
+{
34
+ int bit = __bf_shf(MV88E6352_G2_AVB_CMD_BUSY);
35
+
36
+ return mv88e6xxx_g2_wait_bit(chip, MV88E6352_G2_AVB_CMD, bit, 0);
37
+}
38
+
3439 static int mv88e6xxx_g2_avb_read(struct mv88e6xxx_chip *chip, u16 readop,
3540 u16 *data, int len)
3641 {
3742 int err;
3843 int i;
3944
45
+ err = mv88e6xxx_g2_avb_wait(chip);
46
+ if (err)
47
+ return err;
48
+
4049 /* Hardware can only snapshot four words. */
4150 if (len > 4)
4251 return -E2BIG;
4352
44
- err = mv88e6xxx_g2_update(chip, MV88E6352_G2_AVB_CMD, readop);
53
+ err = mv88e6xxx_g2_write(chip, MV88E6352_G2_AVB_CMD,
54
+ MV88E6352_G2_AVB_CMD_BUSY | readop);
55
+ if (err)
56
+ return err;
57
+
58
+ err = mv88e6xxx_g2_avb_wait(chip);
4559 if (err)
4660 return err;
4761
....@@ -61,11 +75,18 @@
6175 {
6276 int err;
6377
78
+ err = mv88e6xxx_g2_avb_wait(chip);
79
+ if (err)
80
+ return err;
81
+
6482 err = mv88e6xxx_g2_write(chip, MV88E6352_G2_AVB_DATA, data);
6583 if (err)
6684 return err;
6785
68
- return mv88e6xxx_g2_update(chip, MV88E6352_G2_AVB_CMD, writeop);
86
+ err = mv88e6xxx_g2_write(chip, MV88E6352_G2_AVB_CMD,
87
+ MV88E6352_G2_AVB_CMD_BUSY | writeop);
88
+
89
+ return mv88e6xxx_g2_avb_wait(chip);
6990 }
7091
7192 static int mv88e6352_g2_avb_port_ptp_read(struct mv88e6xxx_chip *chip,