forked from ~ljy/RK356X_SDK_RELEASE

hc
2024-01-03 2f7c68cb55ecb7331f2381deb497c27155f32faf
kernel/drivers/video/fbdev/pxa168fb.c
....@@ -60,8 +60,6 @@
6060 else
6161 return PIX_FMT_BGR1555;
6262 }
63
-
64
- /* fall through */
6563 }
6664
6765 /*
....@@ -87,8 +85,6 @@
8785 else
8886 return PIX_FMT_BGR888UNPACK;
8987 }
90
-
91
- /* fall through */
9288 }
9389
9490 return -EINVAL;
....@@ -279,7 +275,7 @@
279275
280276 /* check whether divisor is too small. */
281277 if (divider_int < 2) {
282
- dev_warn(fbi->dev, "Warning: clock source is too slow."
278
+ dev_warn(fbi->dev, "Warning: clock source is too slow. "
283279 "Try smaller resolution\n");
284280 divider_int = 2;
285281 }
....@@ -405,9 +401,6 @@
405401 struct fb_var_screeninfo *var = &info->var;
406402 struct fb_videomode mode;
407403 u32 x;
408
- struct pxa168fb_mach_info *mi;
409
-
410
- mi = dev_get_platdata(fbi->dev);
411404
412405 /*
413406 * Set additional mode info.
....@@ -548,7 +541,7 @@
548541 return IRQ_NONE;
549542 }
550543
551
-static struct fb_ops pxa168fb_ops = {
544
+static const struct fb_ops pxa168fb_ops = {
552545 .owner = THIS_MODULE,
553546 .fb_check_var = pxa168fb_check_var,
554547 .fb_set_par = pxa168fb_set_par,
....@@ -560,12 +553,11 @@
560553 .fb_imageblit = cfb_imageblit,
561554 };
562555
563
-static int pxa168fb_init_mode(struct fb_info *info,
556
+static void pxa168fb_init_mode(struct fb_info *info,
564557 struct pxa168fb_mach_info *mi)
565558 {
566559 struct pxa168fb_info *fbi = info->par;
567560 struct fb_var_screeninfo *var = &info->var;
568
- int ret = 0;
569561 u32 total_w, total_h, refresh;
570562 u64 div_result;
571563 const struct fb_videomode *m;
....@@ -596,8 +588,6 @@
596588 div_result = 1000000000000ll;
597589 do_div(div_result, total_w * total_h * refresh);
598590 var->pixclock = (u32)div_result;
599
-
600
- return ret;
601591 }
602592
603593 static int pxa168fb_probe(struct platform_device *pdev)
....@@ -668,7 +658,7 @@
668658 /*
669659 * Map LCD controller registers.
670660 */
671
- fbi->reg_base = devm_ioremap_nocache(&pdev->dev, res->start,
661
+ fbi->reg_base = devm_ioremap(&pdev->dev, res->start,
672662 resource_size(res));
673663 if (fbi->reg_base == NULL) {
674664 ret = -ENOMEM;
....@@ -772,7 +762,7 @@
772762 dma_free_wc(fbi->dev, info->fix.smem_len,
773763 info->screen_base, fbi->fb_start_dma);
774764 failed_free_info:
775
- kfree(info);
765
+ framebuffer_release(info);
776766
777767 dev_err(&pdev->dev, "frame buffer device init failed with %d\n", ret);
778768 return ret;
....@@ -782,7 +772,6 @@
782772 {
783773 struct pxa168fb_info *fbi = platform_get_drvdata(pdev);
784774 struct fb_info *info;
785
- int irq;
786775 unsigned int data;
787776
788777 if (!fbi)
....@@ -801,8 +790,6 @@
801790
802791 if (info->cmap.len)
803792 fb_dealloc_cmap(&info->cmap);
804
-
805
- irq = platform_get_irq(pdev, 0);
806793
807794 dma_free_wc(fbi->dev, info->fix.smem_len,
808795 info->screen_base, info->fix.smem_start);