hc
2024-01-03 2f7c68cb55ecb7331f2381deb497c27155f32faf
kernel/drivers/pinctrl/intel/pinctrl-cherryview.c
....@@ -945,11 +945,6 @@
945945
946946 break;
947947
948
- case PIN_CONFIG_DRIVE_OPEN_DRAIN:
949
- if (!(ctrl1 & CHV_PADCTRL1_ODEN))
950
- return -EINVAL;
951
- break;
952
-
953948 case PIN_CONFIG_BIAS_HIGH_IMPEDANCE: {
954949 u32 cfg;
955950
....@@ -958,6 +953,16 @@
958953 if (cfg != CHV_PADCTRL0_GPIOCFG_HIZ)
959954 return -EINVAL;
960955
956
+ break;
957
+
958
+ case PIN_CONFIG_DRIVE_PUSH_PULL:
959
+ if (ctrl1 & CHV_PADCTRL1_ODEN)
960
+ return -EINVAL;
961
+ break;
962
+
963
+ case PIN_CONFIG_DRIVE_OPEN_DRAIN:
964
+ if (!(ctrl1 & CHV_PADCTRL1_ODEN))
965
+ return -EINVAL;
961966 break;
962967 }
963968
....@@ -1620,7 +1625,6 @@
16201625 const struct intel_pinctrl_soc_data *soc_data;
16211626 struct intel_community *community;
16221627 struct device *dev = &pdev->dev;
1623
- struct acpi_device *adev = ACPI_COMPANION(dev);
16241628 struct intel_pinctrl *pctrl;
16251629 acpi_status status;
16261630 int ret, irq;
....@@ -1683,7 +1687,7 @@
16831687 if (ret)
16841688 return ret;
16851689
1686
- status = acpi_install_address_space_handler(adev->handle,
1690
+ status = acpi_install_address_space_handler(ACPI_HANDLE(dev),
16871691 community->acpi_space_id,
16881692 chv_pinctrl_mmio_access_handler,
16891693 NULL, pctrl);
....@@ -1700,7 +1704,7 @@
17001704 struct intel_pinctrl *pctrl = platform_get_drvdata(pdev);
17011705 const struct intel_community *community = &pctrl->communities[0];
17021706
1703
- acpi_remove_address_space_handler(ACPI_COMPANION(&pdev->dev),
1707
+ acpi_remove_address_space_handler(ACPI_HANDLE(&pdev->dev),
17041708 community->acpi_space_id,
17051709 chv_pinctrl_mmio_access_handler);
17061710