hc
2024-01-03 2f7c68cb55ecb7331f2381deb497c27155f32faf
kernel/drivers/infiniband/hw/usnic/usnic_ib_sysfs.c
....@@ -46,12 +46,11 @@
4646 #include "usnic_ib_sysfs.h"
4747 #include "usnic_log.h"
4848
49
-static ssize_t usnic_ib_show_board(struct device *device,
50
- struct device_attribute *attr,
51
- char *buf)
49
+static ssize_t board_id_show(struct device *device,
50
+ struct device_attribute *attr, char *buf)
5251 {
5352 struct usnic_ib_dev *us_ibdev =
54
- container_of(device, struct usnic_ib_dev, ib_dev.dev);
53
+ rdma_device_to_drv_device(device, struct usnic_ib_dev, ib_dev);
5554 unsigned short subsystem_device_id;
5655
5756 mutex_lock(&us_ibdev->usdev_lock);
....@@ -60,21 +59,20 @@
6059
6160 return scnprintf(buf, PAGE_SIZE, "%hu\n", subsystem_device_id);
6261 }
62
+static DEVICE_ATTR_RO(board_id);
6363
6464 /*
6565 * Report the configuration for this PF
6666 */
6767 static ssize_t
68
-usnic_ib_show_config(struct device *device, struct device_attribute *attr,
69
- char *buf)
68
+config_show(struct device *device, struct device_attribute *attr, char *buf)
7069 {
71
- struct usnic_ib_dev *us_ibdev;
70
+ struct usnic_ib_dev *us_ibdev =
71
+ rdma_device_to_drv_device(device, struct usnic_ib_dev, ib_dev);
7272 char *ptr;
7373 unsigned left;
7474 unsigned n;
7575 enum usnic_vnic_res_type res_type;
76
-
77
- us_ibdev = container_of(device, struct usnic_ib_dev, ib_dev.dev);
7876
7977 /* Buffer space limit is 1 page */
8078 ptr = buf;
....@@ -94,7 +92,7 @@
9492
9593 n = scnprintf(ptr, left,
9694 "%s: %s:%d.%d, %s, %pM, %u VFs\n Per VF:",
97
- us_ibdev->ib_dev.name,
95
+ dev_name(&us_ibdev->ib_dev.dev),
9896 busname,
9997 PCI_SLOT(us_ibdev->pdev->devfn),
10098 PCI_FUNC(us_ibdev->pdev->devfn),
....@@ -119,79 +117,75 @@
119117 UPDATE_PTR_LEFT(n, ptr, left);
120118 } else {
121119 n = scnprintf(ptr, left, "%s: no VFs\n",
122
- us_ibdev->ib_dev.name);
120
+ dev_name(&us_ibdev->ib_dev.dev));
123121 UPDATE_PTR_LEFT(n, ptr, left);
124122 }
125123 mutex_unlock(&us_ibdev->usdev_lock);
126124
127125 return ptr - buf;
128126 }
127
+static DEVICE_ATTR_RO(config);
129128
130129 static ssize_t
131
-usnic_ib_show_iface(struct device *device, struct device_attribute *attr,
132
- char *buf)
130
+iface_show(struct device *device, struct device_attribute *attr, char *buf)
133131 {
134
- struct usnic_ib_dev *us_ibdev;
135
-
136
- us_ibdev = container_of(device, struct usnic_ib_dev, ib_dev.dev);
132
+ struct usnic_ib_dev *us_ibdev =
133
+ rdma_device_to_drv_device(device, struct usnic_ib_dev, ib_dev);
137134
138135 return scnprintf(buf, PAGE_SIZE, "%s\n",
139136 netdev_name(us_ibdev->netdev));
140137 }
138
+static DEVICE_ATTR_RO(iface);
141139
142140 static ssize_t
143
-usnic_ib_show_max_vf(struct device *device, struct device_attribute *attr,
144
- char *buf)
141
+max_vf_show(struct device *device, struct device_attribute *attr, char *buf)
145142 {
146
- struct usnic_ib_dev *us_ibdev;
147
-
148
- us_ibdev = container_of(device, struct usnic_ib_dev, ib_dev.dev);
143
+ struct usnic_ib_dev *us_ibdev =
144
+ rdma_device_to_drv_device(device, struct usnic_ib_dev, ib_dev);
149145
150146 return scnprintf(buf, PAGE_SIZE, "%u\n",
151147 kref_read(&us_ibdev->vf_cnt));
152148 }
149
+static DEVICE_ATTR_RO(max_vf);
153150
154151 static ssize_t
155
-usnic_ib_show_qp_per_vf(struct device *device, struct device_attribute *attr,
156
- char *buf)
152
+qp_per_vf_show(struct device *device, struct device_attribute *attr, char *buf)
157153 {
158
- struct usnic_ib_dev *us_ibdev;
154
+ struct usnic_ib_dev *us_ibdev =
155
+ rdma_device_to_drv_device(device, struct usnic_ib_dev, ib_dev);
159156 int qp_per_vf;
160157
161
- us_ibdev = container_of(device, struct usnic_ib_dev, ib_dev.dev);
162158 qp_per_vf = max(us_ibdev->vf_res_cnt[USNIC_VNIC_RES_TYPE_WQ],
163159 us_ibdev->vf_res_cnt[USNIC_VNIC_RES_TYPE_RQ]);
164160
165161 return scnprintf(buf, PAGE_SIZE,
166162 "%d\n", qp_per_vf);
167163 }
164
+static DEVICE_ATTR_RO(qp_per_vf);
168165
169166 static ssize_t
170
-usnic_ib_show_cq_per_vf(struct device *device, struct device_attribute *attr,
171
- char *buf)
167
+cq_per_vf_show(struct device *device, struct device_attribute *attr, char *buf)
172168 {
173
- struct usnic_ib_dev *us_ibdev;
174
-
175
- us_ibdev = container_of(device, struct usnic_ib_dev, ib_dev.dev);
169
+ struct usnic_ib_dev *us_ibdev =
170
+ rdma_device_to_drv_device(device, struct usnic_ib_dev, ib_dev);
176171
177172 return scnprintf(buf, PAGE_SIZE, "%d\n",
178173 us_ibdev->vf_res_cnt[USNIC_VNIC_RES_TYPE_CQ]);
179174 }
175
+static DEVICE_ATTR_RO(cq_per_vf);
180176
181
-static DEVICE_ATTR(board_id, S_IRUGO, usnic_ib_show_board, NULL);
182
-static DEVICE_ATTR(config, S_IRUGO, usnic_ib_show_config, NULL);
183
-static DEVICE_ATTR(iface, S_IRUGO, usnic_ib_show_iface, NULL);
184
-static DEVICE_ATTR(max_vf, S_IRUGO, usnic_ib_show_max_vf, NULL);
185
-static DEVICE_ATTR(qp_per_vf, S_IRUGO, usnic_ib_show_qp_per_vf, NULL);
186
-static DEVICE_ATTR(cq_per_vf, S_IRUGO, usnic_ib_show_cq_per_vf, NULL);
177
+static struct attribute *usnic_class_attributes[] = {
178
+ &dev_attr_board_id.attr,
179
+ &dev_attr_config.attr,
180
+ &dev_attr_iface.attr,
181
+ &dev_attr_max_vf.attr,
182
+ &dev_attr_qp_per_vf.attr,
183
+ &dev_attr_cq_per_vf.attr,
184
+ NULL
185
+};
187186
188
-static struct device_attribute *usnic_class_attributes[] = {
189
- &dev_attr_board_id,
190
- &dev_attr_config,
191
- &dev_attr_iface,
192
- &dev_attr_max_vf,
193
- &dev_attr_qp_per_vf,
194
- &dev_attr_cq_per_vf,
187
+const struct attribute_group usnic_attr_group = {
188
+ .attrs = usnic_class_attributes,
195189 };
196190
197191 struct qpn_attribute {
....@@ -278,18 +272,6 @@
278272
279273 int usnic_ib_sysfs_register_usdev(struct usnic_ib_dev *us_ibdev)
280274 {
281
- int i;
282
- int err;
283
- for (i = 0; i < ARRAY_SIZE(usnic_class_attributes); ++i) {
284
- err = device_create_file(&us_ibdev->ib_dev.dev,
285
- usnic_class_attributes[i]);
286
- if (err) {
287
- usnic_err("Failed to create device file %d for %s eith err %d",
288
- i, us_ibdev->ib_dev.name, err);
289
- return -EINVAL;
290
- }
291
- }
292
-
293275 /* create kernel object for looking at individual QPs */
294276 kobject_get(&us_ibdev->ib_dev.dev.kobj);
295277 us_ibdev->qpn_kobj = kobject_create_and_add("qpn",
....@@ -304,12 +286,6 @@
304286
305287 void usnic_ib_sysfs_unregister_usdev(struct usnic_ib_dev *us_ibdev)
306288 {
307
- int i;
308
- for (i = 0; i < ARRAY_SIZE(usnic_class_attributes); ++i) {
309
- device_remove_file(&us_ibdev->ib_dev.dev,
310
- usnic_class_attributes[i]);
311
- }
312
-
313289 kobject_put(us_ibdev->qpn_kobj);
314290 }
315291