| .. | .. |
|---|
| 37 | 37 | /** |
|---|
| 38 | 38 | * bnx2x_exe_queue_init - init the Exe Queue object |
|---|
| 39 | 39 | * |
|---|
| 40 | + * @bp: driver handle |
|---|
| 40 | 41 | * @o: pointer to the object |
|---|
| 41 | 42 | * @exe_len: length |
|---|
| 42 | 43 | * @owner: pointer to the owner |
|---|
| 43 | 44 | * @validate: validate function pointer |
|---|
| 45 | + * @remove: remove function pointer |
|---|
| 44 | 46 | * @optimize: optimize function pointer |
|---|
| 45 | 47 | * @exec: execute function pointer |
|---|
| 46 | 48 | * @get: get function pointer |
|---|
| .. | .. |
|---|
| 103 | 105 | * |
|---|
| 104 | 106 | * @bp: driver handle |
|---|
| 105 | 107 | * @o: queue |
|---|
| 106 | | - * @cmd: new command to add |
|---|
| 108 | + * @elem: new command to add |
|---|
| 107 | 109 | * @restore: true - do not optimize the command |
|---|
| 108 | 110 | * |
|---|
| 109 | 111 | * If the element is optimized or is illegal, frees it. |
|---|
| .. | .. |
|---|
| 277 | 279 | * |
|---|
| 278 | 280 | * @bp: device handle |
|---|
| 279 | 281 | * @state: state which is to be cleared |
|---|
| 280 | | - * @state_p: state buffer |
|---|
| 282 | + * @pstate: state buffer |
|---|
| 281 | 283 | * |
|---|
| 282 | 284 | */ |
|---|
| 283 | 285 | static inline int bnx2x_state_wait(struct bnx2x *bp, int state, |
|---|
| .. | .. |
|---|
| 424 | 426 | * @bp: device handle |
|---|
| 425 | 427 | * @o: vlan_mac object |
|---|
| 426 | 428 | * |
|---|
| 427 | | - * @details: Non-blocking implementation; should be called under execution |
|---|
| 428 | | - * queue lock. |
|---|
| 429 | + * Context: Non-blocking implementation; should be called under execution |
|---|
| 430 | + * queue lock. |
|---|
| 429 | 431 | */ |
|---|
| 430 | 432 | static int __bnx2x_vlan_mac_h_write_trylock(struct bnx2x *bp, |
|---|
| 431 | 433 | struct bnx2x_vlan_mac_obj *o) |
|---|
| .. | .. |
|---|
| 445 | 447 | * @bp: device handle |
|---|
| 446 | 448 | * @o: vlan_mac object |
|---|
| 447 | 449 | * |
|---|
| 448 | | - * @details Should be called under execution queue lock; notice it might release |
|---|
| 450 | + * details Should be called under execution queue lock; notice it might release |
|---|
| 449 | 451 | * and reclaim it during its run. |
|---|
| 450 | 452 | */ |
|---|
| 451 | 453 | static void __bnx2x_vlan_mac_h_exec_pending(struct bnx2x *bp, |
|---|
| .. | .. |
|---|
| 475 | 477 | * @o: vlan_mac object |
|---|
| 476 | 478 | * @ramrod_flags: ramrod flags of missed execution |
|---|
| 477 | 479 | * |
|---|
| 478 | | - * @details Should be called under execution queue lock. |
|---|
| 480 | + * Context: Should be called under execution queue lock. |
|---|
| 479 | 481 | */ |
|---|
| 480 | 482 | static void __bnx2x_vlan_mac_h_pend(struct bnx2x *bp, |
|---|
| 481 | 483 | struct bnx2x_vlan_mac_obj *o, |
|---|
| .. | .. |
|---|
| 493 | 495 | * @bp: device handle |
|---|
| 494 | 496 | * @o: vlan_mac object |
|---|
| 495 | 497 | * |
|---|
| 496 | | - * @details Should be called under execution queue lock. Notice if a pending |
|---|
| 498 | + * Context: Should be called under execution queue lock. Notice if a pending |
|---|
| 497 | 499 | * execution exists, it would perform it - possibly releasing and |
|---|
| 498 | 500 | * reclaiming the execution queue lock. |
|---|
| 499 | 501 | */ |
|---|
| .. | .. |
|---|
| 516 | 518 | * @bp: device handle |
|---|
| 517 | 519 | * @o: vlan_mac object |
|---|
| 518 | 520 | * |
|---|
| 519 | | - * @details Should be called under the execution queue lock. May sleep. May |
|---|
| 521 | + * Context: Should be called under the execution queue lock. May sleep. May |
|---|
| 520 | 522 | * release and reclaim execution queue lock during its run. |
|---|
| 521 | 523 | */ |
|---|
| 522 | 524 | static int __bnx2x_vlan_mac_h_read_lock(struct bnx2x *bp, |
|---|
| .. | .. |
|---|
| 536 | 538 | * @bp: device handle |
|---|
| 537 | 539 | * @o: vlan_mac object |
|---|
| 538 | 540 | * |
|---|
| 539 | | - * @details May sleep. Claims and releases execution queue lock during its run. |
|---|
| 541 | + * Context: May sleep. Claims and releases execution queue lock during its run. |
|---|
| 540 | 542 | */ |
|---|
| 541 | 543 | int bnx2x_vlan_mac_h_read_lock(struct bnx2x *bp, |
|---|
| 542 | 544 | struct bnx2x_vlan_mac_obj *o) |
|---|
| .. | .. |
|---|
| 556 | 558 | * @bp: device handle |
|---|
| 557 | 559 | * @o: vlan_mac object |
|---|
| 558 | 560 | * |
|---|
| 559 | | - * @details Should be called under execution queue lock. Notice if a pending |
|---|
| 561 | + * Context: Should be called under execution queue lock. Notice if a pending |
|---|
| 560 | 562 | * execution exists, it would be performed if this was the last |
|---|
| 561 | 563 | * reader. possibly releasing and reclaiming the execution queue lock. |
|---|
| 562 | 564 | */ |
|---|
| .. | .. |
|---|
| 591 | 593 | * @bp: device handle |
|---|
| 592 | 594 | * @o: vlan_mac object |
|---|
| 593 | 595 | * |
|---|
| 594 | | - * @details Notice if a pending execution exists, it would be performed if this |
|---|
| 596 | + * Context: Notice if a pending execution exists, it would be performed if this |
|---|
| 595 | 597 | * was the last reader. Claims and releases the execution queue lock |
|---|
| 596 | 598 | * during its run. |
|---|
| 597 | 599 | */ |
|---|
| .. | .. |
|---|
| 968 | 970 | * |
|---|
| 969 | 971 | * @bp: device handle |
|---|
| 970 | 972 | * @o: queue |
|---|
| 971 | | - * @type: |
|---|
| 973 | + * @type: the type of echo |
|---|
| 972 | 974 | * @cam_offset: offset in cam memory |
|---|
| 973 | 975 | * @hdr: pointer to a header to setup |
|---|
| 974 | 976 | * |
|---|
| .. | .. |
|---|
| 1608 | 1610 | * |
|---|
| 1609 | 1611 | * @bp: device handle |
|---|
| 1610 | 1612 | * @o: bnx2x_vlan_mac_obj |
|---|
| 1611 | | - * @cqe: |
|---|
| 1612 | | - * @cont: if true schedule next execution chunk |
|---|
| 1613 | + * @cqe: completion element |
|---|
| 1614 | + * @ramrod_flags: if set schedule next execution chunk |
|---|
| 1613 | 1615 | * |
|---|
| 1614 | 1616 | */ |
|---|
| 1615 | 1617 | static int bnx2x_complete_vlan_mac(struct bnx2x *bp, |
|---|
| .. | .. |
|---|
| 1656 | 1658 | * bnx2x_optimize_vlan_mac - optimize ADD and DEL commands. |
|---|
| 1657 | 1659 | * |
|---|
| 1658 | 1660 | * @bp: device handle |
|---|
| 1659 | | - * @o: bnx2x_qable_obj |
|---|
| 1661 | + * @qo: bnx2x_qable_obj |
|---|
| 1660 | 1662 | * @elem: bnx2x_exeq_elem |
|---|
| 1661 | 1663 | */ |
|---|
| 1662 | 1664 | static int bnx2x_optimize_vlan_mac(struct bnx2x *bp, |
|---|
| .. | .. |
|---|
| 1714 | 1716 | * bnx2x_vlan_mac_get_registry_elem - prepare a registry element |
|---|
| 1715 | 1717 | * |
|---|
| 1716 | 1718 | * @bp: device handle |
|---|
| 1717 | | - * @o: |
|---|
| 1718 | | - * @elem: |
|---|
| 1719 | | - * @restore: |
|---|
| 1720 | | - * @re: |
|---|
| 1719 | + * @o: vlan object |
|---|
| 1720 | + * @elem: element |
|---|
| 1721 | + * @restore: to restore or not |
|---|
| 1722 | + * @re: registry |
|---|
| 1721 | 1723 | * |
|---|
| 1722 | 1724 | * prepare a registry element according to the current command request. |
|---|
| 1723 | 1725 | */ |
|---|
| .. | .. |
|---|
| 1768 | 1770 | * bnx2x_execute_vlan_mac - execute vlan mac command |
|---|
| 1769 | 1771 | * |
|---|
| 1770 | 1772 | * @bp: device handle |
|---|
| 1771 | | - * @qo: |
|---|
| 1772 | | - * @exe_chunk: |
|---|
| 1773 | | - * @ramrod_flags: |
|---|
| 1773 | + * @qo: bnx2x_qable_obj pointer |
|---|
| 1774 | + * @exe_chunk: chunk |
|---|
| 1775 | + * @ramrod_flags: flags |
|---|
| 1774 | 1776 | * |
|---|
| 1775 | 1777 | * go and send a ramrod! |
|---|
| 1776 | 1778 | */ |
|---|
| .. | .. |
|---|
| 2006 | 2008 | * bnx2x_vlan_mac_del_all - delete elements with given vlan_mac_flags spec |
|---|
| 2007 | 2009 | * |
|---|
| 2008 | 2010 | * @bp: device handle |
|---|
| 2009 | | - * @o: |
|---|
| 2010 | | - * @vlan_mac_flags: |
|---|
| 2011 | + * @o: vlan object info |
|---|
| 2012 | + * @vlan_mac_flags: vlan flags |
|---|
| 2011 | 2013 | * @ramrod_flags: execution flags to be used for this deletion |
|---|
| 2012 | 2014 | * |
|---|
| 2013 | 2015 | * if the last operation has completed successfully and there are no |
|---|
| .. | .. |
|---|
| 2767 | 2769 | /** |
|---|
| 2768 | 2770 | * bnx2x_mcast_get_next_bin - get the next set bin (index) |
|---|
| 2769 | 2771 | * |
|---|
| 2770 | | - * @o: |
|---|
| 2772 | + * @o: multicast object info |
|---|
| 2771 | 2773 | * @last: index to start looking from (including) |
|---|
| 2772 | 2774 | * |
|---|
| 2773 | 2775 | * returns the next found (set) bin or a negative value if none is found. |
|---|
| .. | .. |
|---|
| 2892 | 2894 | * bnx2x_mcast_handle_restore_cmd_e2 - restore configuration from the registry |
|---|
| 2893 | 2895 | * |
|---|
| 2894 | 2896 | * @bp: device handle |
|---|
| 2895 | | - * @o: |
|---|
| 2897 | + * @o: multicast object info |
|---|
| 2896 | 2898 | * @start_bin: index in the registry to start from (including) |
|---|
| 2897 | 2899 | * @rdata_idx: index in the ramrod data to start from |
|---|
| 2898 | 2900 | * |
|---|
| .. | .. |
|---|
| 2977 | 2979 | |
|---|
| 2978 | 2980 | cmd_pos->data.macs_num--; |
|---|
| 2979 | 2981 | |
|---|
| 2980 | | - DP(BNX2X_MSG_SP, "Deleting MAC. %d left,cnt is %d\n", |
|---|
| 2981 | | - cmd_pos->data.macs_num, cnt); |
|---|
| 2982 | + DP(BNX2X_MSG_SP, "Deleting MAC. %d left,cnt is %d\n", |
|---|
| 2983 | + cmd_pos->data.macs_num, cnt); |
|---|
| 2982 | 2984 | |
|---|
| 2983 | 2985 | /* Break if we reached the maximum |
|---|
| 2984 | 2986 | * number of rules. |
|---|
| .. | .. |
|---|
| 3202 | 3204 | } |
|---|
| 3203 | 3205 | |
|---|
| 3204 | 3206 | /** |
|---|
| 3205 | | - * bnx2x_mcast_handle_current_cmd - |
|---|
| 3207 | + * bnx2x_mcast_handle_current_cmd - send command if room |
|---|
| 3206 | 3208 | * |
|---|
| 3207 | 3209 | * @bp: device handle |
|---|
| 3208 | | - * @p: |
|---|
| 3209 | | - * @cmd: |
|---|
| 3210 | + * @p: ramrod mcast info |
|---|
| 3211 | + * @cmd: command |
|---|
| 3210 | 3212 | * @start_cnt: first line in the ramrod data that may be used |
|---|
| 3211 | 3213 | * |
|---|
| 3212 | 3214 | * This function is called iff there is enough place for the current command in |
|---|
| .. | .. |
|---|
| 3258 | 3260 | /* DEL command deletes all currently configured MACs */ |
|---|
| 3259 | 3261 | case BNX2X_MCAST_CMD_DEL: |
|---|
| 3260 | 3262 | o->set_registry_size(o, 0); |
|---|
| 3261 | | - /* fall through */ |
|---|
| 3263 | + fallthrough; |
|---|
| 3262 | 3264 | |
|---|
| 3263 | 3265 | /* RESTORE command will restore the entire multicast configuration */ |
|---|
| 3264 | 3266 | case BNX2X_MCAST_CMD_RESTORE: |
|---|
| .. | .. |
|---|
| 3323 | 3325 | * bnx2x_mcast_set_rdata_hdr_e2 - sets a header values |
|---|
| 3324 | 3326 | * |
|---|
| 3325 | 3327 | * @bp: device handle |
|---|
| 3326 | | - * @p: |
|---|
| 3328 | + * @p: ramrod parameters |
|---|
| 3327 | 3329 | * @len: number of rules to handle |
|---|
| 3328 | 3330 | */ |
|---|
| 3329 | 3331 | static inline void bnx2x_mcast_set_rdata_hdr_e2(struct bnx2x *bp, |
|---|
| .. | .. |
|---|
| 3592 | 3594 | /* DEL command deletes all currently configured MACs */ |
|---|
| 3593 | 3595 | case BNX2X_MCAST_CMD_DEL: |
|---|
| 3594 | 3596 | o->set_registry_size(o, 0); |
|---|
| 3595 | | - /* fall through */ |
|---|
| 3597 | + fallthrough; |
|---|
| 3596 | 3598 | |
|---|
| 3597 | 3599 | /* RESTORE command will restore the entire multicast configuration */ |
|---|
| 3598 | 3600 | case BNX2X_MCAST_CMD_RESTORE: |
|---|
| 3599 | 3601 | p->mcast_list_len = reg_sz; |
|---|
| 3600 | | - DP(BNX2X_MSG_SP, "Command %d, p->mcast_list_len=%d\n", |
|---|
| 3601 | | - cmd, p->mcast_list_len); |
|---|
| 3602 | + DP(BNX2X_MSG_SP, "Command %d, p->mcast_list_len=%d\n", |
|---|
| 3603 | + cmd, p->mcast_list_len); |
|---|
| 3602 | 3604 | break; |
|---|
| 3603 | 3605 | |
|---|
| 3604 | 3606 | case BNX2X_MCAST_CMD_ADD: |
|---|
| .. | .. |
|---|
| 3684 | 3686 | * bnx2x_mcast_set_rdata_hdr_e1 - set header values in mac_configuration_cmd |
|---|
| 3685 | 3687 | * |
|---|
| 3686 | 3688 | * @bp: device handle |
|---|
| 3687 | | - * @p: |
|---|
| 3689 | + * @p: ramrod parameters |
|---|
| 3688 | 3690 | * @len: number of rules to handle |
|---|
| 3689 | 3691 | */ |
|---|
| 3690 | 3692 | static inline void bnx2x_mcast_set_rdata_hdr_e1(struct bnx2x *bp, |
|---|
| .. | .. |
|---|
| 3711 | 3713 | * bnx2x_mcast_handle_restore_cmd_e1 - restore command for 57710 |
|---|
| 3712 | 3714 | * |
|---|
| 3713 | 3715 | * @bp: device handle |
|---|
| 3714 | | - * @o: |
|---|
| 3716 | + * @o: multicast info |
|---|
| 3715 | 3717 | * @start_idx: index in the registry to start from |
|---|
| 3716 | 3718 | * @rdata_idx: index in the ramrod data to start from |
|---|
| 3717 | 3719 | * |
|---|
| .. | .. |
|---|
| 3735 | 3737 | |
|---|
| 3736 | 3738 | i++; |
|---|
| 3737 | 3739 | |
|---|
| 3738 | | - DP(BNX2X_MSG_SP, "About to configure %pM mcast MAC\n", |
|---|
| 3739 | | - cfg_data.mac); |
|---|
| 3740 | + DP(BNX2X_MSG_SP, "About to configure %pM mcast MAC\n", |
|---|
| 3741 | + cfg_data.mac); |
|---|
| 3740 | 3742 | } |
|---|
| 3741 | 3743 | |
|---|
| 3742 | 3744 | *rdata_idx = i; |
|---|
| .. | .. |
|---|
| 3798 | 3800 | /** |
|---|
| 3799 | 3801 | * bnx2x_get_fw_mac_addr - revert the bnx2x_set_fw_mac_addr(). |
|---|
| 3800 | 3802 | * |
|---|
| 3801 | | - * @fw_hi: |
|---|
| 3802 | | - * @fw_mid: |
|---|
| 3803 | | - * @fw_lo: |
|---|
| 3804 | | - * @mac: |
|---|
| 3803 | + * @fw_hi: address |
|---|
| 3804 | + * @fw_mid: address |
|---|
| 3805 | + * @fw_lo: address |
|---|
| 3806 | + * @mac: mac address |
|---|
| 3805 | 3807 | */ |
|---|
| 3806 | 3808 | static inline void bnx2x_get_fw_mac_addr(__le16 *fw_hi, __le16 *fw_mid, |
|---|
| 3807 | 3809 | __le16 *fw_lo, u8 *mac) |
|---|
| .. | .. |
|---|
| 3818 | 3820 | * bnx2x_mcast_refresh_registry_e1 - |
|---|
| 3819 | 3821 | * |
|---|
| 3820 | 3822 | * @bp: device handle |
|---|
| 3821 | | - * @cnt: |
|---|
| 3823 | + * @o: multicast info |
|---|
| 3822 | 3824 | * |
|---|
| 3823 | 3825 | * Check the ramrod data first entry flag to see if it's a DELETE or ADD command |
|---|
| 3824 | 3826 | * and update the registry correspondingly: if ADD - allocate a memory and add |
|---|
| .. | .. |
|---|
| 4311 | 4313 | /** |
|---|
| 4312 | 4314 | * bnx2x_init_credit_pool - initialize credit pool internals. |
|---|
| 4313 | 4315 | * |
|---|
| 4314 | | - * @p: |
|---|
| 4316 | + * @p: credit pool |
|---|
| 4315 | 4317 | * @base: Base entry in the CAM to use. |
|---|
| 4316 | 4318 | * @credit: pool size. |
|---|
| 4317 | 4319 | * |
|---|
| .. | .. |
|---|
| 4725 | 4727 | * bnx2x_queue_comp_cmd - complete the state change command. |
|---|
| 4726 | 4728 | * |
|---|
| 4727 | 4729 | * @bp: device handle |
|---|
| 4728 | | - * @o: |
|---|
| 4729 | | - * @cmd: |
|---|
| 4730 | + * @o: queue info |
|---|
| 4731 | + * @cmd: command to exec |
|---|
| 4730 | 4732 | * |
|---|
| 4731 | 4733 | * Checks that the arrived completion is expected. |
|---|
| 4732 | 4734 | */ |
|---|
| .. | .. |
|---|
| 5039 | 5041 | /* As no ramrod is sent, complete the command immediately */ |
|---|
| 5040 | 5042 | o->complete_cmd(bp, o, BNX2X_Q_CMD_INIT); |
|---|
| 5041 | 5043 | |
|---|
| 5042 | | - mmiowb(); |
|---|
| 5043 | 5044 | smp_mb(); |
|---|
| 5044 | 5045 | |
|---|
| 5045 | 5046 | return 0; |
|---|
| .. | .. |
|---|
| 5478 | 5479 | * bnx2x_queue_chk_transition - check state machine of a regular Queue |
|---|
| 5479 | 5480 | * |
|---|
| 5480 | 5481 | * @bp: device handle |
|---|
| 5481 | | - * @o: |
|---|
| 5482 | | - * @params: |
|---|
| 5482 | + * @o: queue info |
|---|
| 5483 | + * @params: queue state |
|---|
| 5483 | 5484 | * |
|---|
| 5484 | 5485 | * (not Forwarding) |
|---|
| 5485 | 5486 | * It both checks if the requested command is legal in a current |
|---|
| .. | .. |
|---|
| 5736 | 5737 | * bnx2x_func_state_change_comp - complete the state machine transition |
|---|
| 5737 | 5738 | * |
|---|
| 5738 | 5739 | * @bp: device handle |
|---|
| 5739 | | - * @o: |
|---|
| 5740 | | - * @cmd: |
|---|
| 5740 | + * @o: function info |
|---|
| 5741 | + * @cmd: more info |
|---|
| 5741 | 5742 | * |
|---|
| 5742 | 5743 | * Called on state change transition. Completes the state |
|---|
| 5743 | 5744 | * machine transition only - no HW interaction. |
|---|
| .. | .. |
|---|
| 5777 | 5778 | * bnx2x_func_comp_cmd - complete the state change command |
|---|
| 5778 | 5779 | * |
|---|
| 5779 | 5780 | * @bp: device handle |
|---|
| 5780 | | - * @o: |
|---|
| 5781 | | - * @cmd: |
|---|
| 5781 | + * @o: function info |
|---|
| 5782 | + * @cmd: more info |
|---|
| 5782 | 5783 | * |
|---|
| 5783 | 5784 | * Checks that the arrived completion is expected. |
|---|
| 5784 | 5785 | */ |
|---|
| .. | .. |
|---|
| 5797 | 5798 | * bnx2x_func_chk_transition - perform function state machine transition |
|---|
| 5798 | 5799 | * |
|---|
| 5799 | 5800 | * @bp: device handle |
|---|
| 5800 | | - * @o: |
|---|
| 5801 | | - * @params: |
|---|
| 5801 | + * @o: function info |
|---|
| 5802 | + * @params: state parameters |
|---|
| 5802 | 5803 | * |
|---|
| 5803 | 5804 | * It both checks if the requested command is legal in a current |
|---|
| 5804 | 5805 | * state and, if it's legal, sets a `next_state' in the object |
|---|