disable pwm7

hc

2024-05-10 23fa18eaa71266feff7ba8d83022d9e1cc83c65a

 kernel/drivers/net/wireless/ath/ath5k/debug.c
..
..
@@ -161,33 +161,14 @@
161
161
 	return 0;
162
162
 }
163
163
 
164
-static const struct seq_operations register_seq_ops = {
164
+static const struct seq_operations registers_sops = {
165
165
 	.start = reg_start,
166
166
 	.next  = reg_next,
167
167
 	.stop  = reg_stop,
168
168
 	.show  = reg_show
169
169
 };
170
170
 
171
-static int open_file_registers(struct inode *inode, struct file *file)
172
-{
173
-	struct seq_file *s;
174
-	int res;
175
-	res = seq_open(file, &register_seq_ops);
176
-	if (res == 0) {
177
-		s = file->private_data;
178
-		s->private = inode->i_private;
179
-	}
180
-	return res;
181
-}
182
-
183
-static const struct file_operations fops_registers = {
184
-	.open = open_file_registers,
185
-	.read    = seq_read,
186
-	.llseek  = seq_lseek,
187
-	.release = seq_release,
188
-	.owner = THIS_MODULE,
189
-};
190
-
171
+DEFINE_SEQ_ATTRIBUTE(registers);
191
172
 
192
173
 /* debugfs: beacons */
193
174
 
..
..
@@ -201,35 +182,35 @@
201
182
 	u64 tsf;
202
183
 
203
184
 	v = ath5k_hw_reg_read(ah, AR5K_BEACON);
204
-	len += snprintf(buf + len, sizeof(buf) - len,
185
+	len += scnprintf(buf + len, sizeof(buf) - len,
205
186
 		"%-24s0x%08x\tintval: %d\tTIM: 0x%x\n",
206
187
 		"AR5K_BEACON", v, v & AR5K_BEACON_PERIOD,
207
188
 		(v & AR5K_BEACON_TIM) >> AR5K_BEACON_TIM_S);
208
189
 
209
-	len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\n",
190
+	len += scnprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\n",
210
191
 		"AR5K_LAST_TSTP", ath5k_hw_reg_read(ah, AR5K_LAST_TSTP));
211
192
 
212
-	len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\n\n",
193
+	len += scnprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\n\n",
213
194
 		"AR5K_BEACON_CNT", ath5k_hw_reg_read(ah, AR5K_BEACON_CNT));
214
195
 
215
196
 	v = ath5k_hw_reg_read(ah, AR5K_TIMER0);
216
-	len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
197
+	len += scnprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
217
198
 		"AR5K_TIMER0 (TBTT)", v, v);
218
199
 
219
200
 	v = ath5k_hw_reg_read(ah, AR5K_TIMER1);
220
-	len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
201
+	len += scnprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
221
202
 		"AR5K_TIMER1 (DMA)", v, v >> 3);
222
203
 
223
204
 	v = ath5k_hw_reg_read(ah, AR5K_TIMER2);
224
-	len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
205
+	len += scnprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
225
206
 		"AR5K_TIMER2 (SWBA)", v, v >> 3);
226
207
 
227
208
 	v = ath5k_hw_reg_read(ah, AR5K_TIMER3);
228
-	len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
209
+	len += scnprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
229
210
 		"AR5K_TIMER3 (ATIM)", v, v);
230
211
 
231
212
 	tsf = ath5k_hw_get_tsf64(ah);
232
-	len += snprintf(buf + len, sizeof(buf) - len,
213
+	len += scnprintf(buf + len, sizeof(buf) - len,
233
214
 		"TSF\t\t0x%016llx\tTU: %08x\n",
234
215
 		(unsigned long long)tsf, TSF_TO_TU(tsf));
235
216
 
..
..
@@ -320,16 +301,16 @@
320
301
 	unsigned int len = 0;
321
302
 	unsigned int i;
322
303
 
323
-	len += snprintf(buf + len, sizeof(buf) - len,
304
+	len += scnprintf(buf + len, sizeof(buf) - len,
324
305
 		"DEBUG LEVEL: 0x%08x\n\n", ah->debug.level);
325
306
 
326
307
 	for (i = 0; i < ARRAY_SIZE(dbg_info) - 1; i++) {
327
-		len += snprintf(buf + len, sizeof(buf) - len,
308
+		len += scnprintf(buf + len, sizeof(buf) - len,
328
309
 			"%10s %c 0x%08x - %s\n", dbg_info[i].name,
329
310
 			ah->debug.level & dbg_info[i].level ? '+' : ' ',
330
311
 			dbg_info[i].level, dbg_info[i].desc);
331
312
 	}
332
-	len += snprintf(buf + len, sizeof(buf) - len,
313
+	len += scnprintf(buf + len, sizeof(buf) - len,
333
314
 		"%10s %c 0x%08x - %s\n", dbg_info[i].name,
334
315
 		ah->debug.level == dbg_info[i].level ? '+' : ' ',
335
316
 		dbg_info[i].level, dbg_info[i].desc);
..
..
@@ -383,60 +364,60 @@
383
364
 	unsigned int i;
384
365
 	unsigned int v;
385
366
 
386
-	len += snprintf(buf + len, sizeof(buf) - len, "antenna mode\t%d\n",
367
+	len += scnprintf(buf + len, sizeof(buf) - len, "antenna mode\t%d\n",
387
368
 		ah->ah_ant_mode);
388
-	len += snprintf(buf + len, sizeof(buf) - len, "default antenna\t%d\n",
369
+	len += scnprintf(buf + len, sizeof(buf) - len, "default antenna\t%d\n",
389
370
 		ah->ah_def_ant);
390
-	len += snprintf(buf + len, sizeof(buf) - len, "tx antenna\t%d\n",
371
+	len += scnprintf(buf + len, sizeof(buf) - len, "tx antenna\t%d\n",
391
372
 		ah->ah_tx_ant);
392
373
 
393
-	len += snprintf(buf + len, sizeof(buf) - len, "\nANTENNA\t\tRX\tTX\n");
374
+	len += scnprintf(buf + len, sizeof(buf) - len, "\nANTENNA\t\tRX\tTX\n");
394
375
 	for (i = 1; i < ARRAY_SIZE(ah->stats.antenna_rx); i++) {
395
-		len += snprintf(buf + len, sizeof(buf) - len,
376
+		len += scnprintf(buf + len, sizeof(buf) - len,
396
377
 			"[antenna %d]\t%d\t%d\n",
397
378
 			i, ah->stats.antenna_rx[i], ah->stats.antenna_tx[i]);
398
379
 	}
399
-	len += snprintf(buf + len, sizeof(buf) - len, "[invalid]\t%d\t%d\n",
380
+	len += scnprintf(buf + len, sizeof(buf) - len, "[invalid]\t%d\t%d\n",
400
381
 			ah->stats.antenna_rx[0], ah->stats.antenna_tx[0]);
401
382
 
402
383
 	v = ath5k_hw_reg_read(ah, AR5K_DEFAULT_ANTENNA);
403
-	len += snprintf(buf + len, sizeof(buf) - len,
384
+	len += scnprintf(buf + len, sizeof(buf) - len,
404
385
 			"\nAR5K_DEFAULT_ANTENNA\t0x%08x\n", v);
405
386
 
406
387
 	v = ath5k_hw_reg_read(ah, AR5K_STA_ID1);
407
-	len += snprintf(buf + len, sizeof(buf) - len,
388
+	len += scnprintf(buf + len, sizeof(buf) - len,
408
389
 		"AR5K_STA_ID1_DEFAULT_ANTENNA\t%d\n",
409
390
 		(v & AR5K_STA_ID1_DEFAULT_ANTENNA) != 0);
410
-	len += snprintf(buf + len, sizeof(buf) - len,
391
+	len += scnprintf(buf + len, sizeof(buf) - len,
411
392
 		"AR5K_STA_ID1_DESC_ANTENNA\t%d\n",
412
393
 		(v & AR5K_STA_ID1_DESC_ANTENNA) != 0);
413
-	len += snprintf(buf + len, sizeof(buf) - len,
394
+	len += scnprintf(buf + len, sizeof(buf) - len,
414
395
 		"AR5K_STA_ID1_RTS_DEF_ANTENNA\t%d\n",
415
396
 		(v & AR5K_STA_ID1_RTS_DEF_ANTENNA) != 0);
416
-	len += snprintf(buf + len, sizeof(buf) - len,
397
+	len += scnprintf(buf + len, sizeof(buf) - len,
417
398
 		"AR5K_STA_ID1_SELFGEN_DEF_ANT\t%d\n",
418
399
 		(v & AR5K_STA_ID1_SELFGEN_DEF_ANT) != 0);
419
400
 
420
401
 	v = ath5k_hw_reg_read(ah, AR5K_PHY_AGCCTL);
421
-	len += snprintf(buf + len, sizeof(buf) - len,
402
+	len += scnprintf(buf + len, sizeof(buf) - len,
422
403
 		"\nAR5K_PHY_AGCCTL_OFDM_DIV_DIS\t%d\n",
423
404
 		(v & AR5K_PHY_AGCCTL_OFDM_DIV_DIS) != 0);
424
405
 
425
406
 	v = ath5k_hw_reg_read(ah, AR5K_PHY_RESTART);
426
-	len += snprintf(buf + len, sizeof(buf) - len,
407
+	len += scnprintf(buf + len, sizeof(buf) - len,
427
408
 		"AR5K_PHY_RESTART_DIV_GC\t\t%x\n",
428
409
 		(v & AR5K_PHY_RESTART_DIV_GC) >> AR5K_PHY_RESTART_DIV_GC_S);
429
410
 
430
411
 	v = ath5k_hw_reg_read(ah, AR5K_PHY_FAST_ANT_DIV);
431
-	len += snprintf(buf + len, sizeof(buf) - len,
412
+	len += scnprintf(buf + len, sizeof(buf) - len,
432
413
 		"AR5K_PHY_FAST_ANT_DIV_EN\t%d\n",
433
414
 		(v & AR5K_PHY_FAST_ANT_DIV_EN) != 0);
434
415
 
435
416
 	v = ath5k_hw_reg_read(ah, AR5K_PHY_ANT_SWITCH_TABLE_0);
436
-	len += snprintf(buf + len, sizeof(buf) - len,
417
+	len += scnprintf(buf + len, sizeof(buf) - len,
437
418
 			"\nAR5K_PHY_ANT_SWITCH_TABLE_0\t0x%08x\n", v);
438
419
 	v = ath5k_hw_reg_read(ah, AR5K_PHY_ANT_SWITCH_TABLE_1);
439
-	len += snprintf(buf + len, sizeof(buf) - len,
420
+	len += scnprintf(buf + len, sizeof(buf) - len,
440
421
 			"AR5K_PHY_ANT_SWITCH_TABLE_1\t0x%08x\n", v);
441
422
 
442
423
 	if (len > sizeof(buf))
..
..
@@ -495,36 +476,36 @@
495
476
 	unsigned int len = 0;
496
477
 	u32 filt = ath5k_hw_get_rx_filter(ah);
497
478
 
498
-	len += snprintf(buf + len, sizeof(buf) - len, "bssid-mask: %pM\n",
479
+	len += scnprintf(buf + len, sizeof(buf) - len, "bssid-mask: %pM\n",
499
480
 			ah->bssidmask);
500
-	len += snprintf(buf + len, sizeof(buf) - len, "filter-flags: 0x%x ",
481
+	len += scnprintf(buf + len, sizeof(buf) - len, "filter-flags: 0x%x ",
501
482
 			filt);
502
483
 	if (filt & AR5K_RX_FILTER_UCAST)
503
-		len += snprintf(buf + len, sizeof(buf) - len, " UCAST");
484
+		len += scnprintf(buf + len, sizeof(buf) - len, " UCAST");
504
485
 	if (filt & AR5K_RX_FILTER_MCAST)
505
-		len += snprintf(buf + len, sizeof(buf) - len, " MCAST");
486
+		len += scnprintf(buf + len, sizeof(buf) - len, " MCAST");
506
487
 	if (filt & AR5K_RX_FILTER_BCAST)
507
-		len += snprintf(buf + len, sizeof(buf) - len, " BCAST");
488
+		len += scnprintf(buf + len, sizeof(buf) - len, " BCAST");
508
489
 	if (filt & AR5K_RX_FILTER_CONTROL)
509
-		len += snprintf(buf + len, sizeof(buf) - len, " CONTROL");
490
+		len += scnprintf(buf + len, sizeof(buf) - len, " CONTROL");
510
491
 	if (filt & AR5K_RX_FILTER_BEACON)
511
-		len += snprintf(buf + len, sizeof(buf) - len, " BEACON");
492
+		len += scnprintf(buf + len, sizeof(buf) - len, " BEACON");
512
493
 	if (filt & AR5K_RX_FILTER_PROM)
513
-		len += snprintf(buf + len, sizeof(buf) - len, " PROM");
494
+		len += scnprintf(buf + len, sizeof(buf) - len, " PROM");
514
495
 	if (filt & AR5K_RX_FILTER_XRPOLL)
515
-		len += snprintf(buf + len, sizeof(buf) - len, " XRPOLL");
496
+		len += scnprintf(buf + len, sizeof(buf) - len, " XRPOLL");
516
497
 	if (filt & AR5K_RX_FILTER_PROBEREQ)
517
-		len += snprintf(buf + len, sizeof(buf) - len, " PROBEREQ");
498
+		len += scnprintf(buf + len, sizeof(buf) - len, " PROBEREQ");
518
499
 	if (filt & AR5K_RX_FILTER_PHYERR_5212)
519
-		len += snprintf(buf + len, sizeof(buf) - len, " PHYERR-5212");
500
+		len += scnprintf(buf + len, sizeof(buf) - len, " PHYERR-5212");
520
501
 	if (filt & AR5K_RX_FILTER_RADARERR_5212)
521
-		len += snprintf(buf + len, sizeof(buf) - len, " RADARERR-5212");
502
+		len += scnprintf(buf + len, sizeof(buf) - len, " RADARERR-5212");
522
503
 	if (filt & AR5K_RX_FILTER_PHYERR_5211)
523
504
 		snprintf(buf + len, sizeof(buf) - len, " PHYERR-5211");
524
505
 	if (filt & AR5K_RX_FILTER_RADARERR_5211)
525
-		len += snprintf(buf + len, sizeof(buf) - len, " RADARERR-5211");
506
+		len += scnprintf(buf + len, sizeof(buf) - len, " RADARERR-5211");
526
507
 
527
-	len += snprintf(buf + len, sizeof(buf) - len, "\nopmode: %s (%d)\n",
508
+	len += scnprintf(buf + len, sizeof(buf) - len, "\nopmode: %s (%d)\n",
528
509
 			ath_opmode_to_string(ah->opmode), ah->opmode);
529
510
 
530
511
 	if (len > sizeof(buf))
..
..
@@ -551,65 +532,65 @@
551
532
 	unsigned int len = 0;
552
533
 	int i;
553
534
 
554
-	len += snprintf(buf + len, sizeof(buf) - len,
535
+	len += scnprintf(buf + len, sizeof(buf) - len,
555
536
 			"RX\n---------------------\n");
556
-	len += snprintf(buf + len, sizeof(buf) - len, "CRC\t%u\t(%u%%)\n",
537
+	len += scnprintf(buf + len, sizeof(buf) - len, "CRC\t%u\t(%u%%)\n",
557
538
 			st->rxerr_crc,
558
539
 			st->rx_all_count > 0 ?
559
540
 				st->rxerr_crc * 100 / st->rx_all_count : 0);
560
-	len += snprintf(buf + len, sizeof(buf) - len, "PHY\t%u\t(%u%%)\n",
541
+	len += scnprintf(buf + len, sizeof(buf) - len, "PHY\t%u\t(%u%%)\n",
561
542
 			st->rxerr_phy,
562
543
 			st->rx_all_count > 0 ?
563
544
 				st->rxerr_phy * 100 / st->rx_all_count : 0);
564
545
 	for (i = 0; i < 32; i++) {
565
546
 		if (st->rxerr_phy_code[i])
566
-			len += snprintf(buf + len, sizeof(buf) - len,
547
+			len += scnprintf(buf + len, sizeof(buf) - len,
567
548
 				" phy_err[%u]\t%u\n",
568
549
 				i, st->rxerr_phy_code[i]);
569
550
 	}
570
551
 
571
-	len += snprintf(buf + len, sizeof(buf) - len, "FIFO\t%u\t(%u%%)\n",
552
+	len += scnprintf(buf + len, sizeof(buf) - len, "FIFO\t%u\t(%u%%)\n",
572
553
 			st->rxerr_fifo,
573
554
 			st->rx_all_count > 0 ?
574
555
 				st->rxerr_fifo * 100 / st->rx_all_count : 0);
575
-	len += snprintf(buf + len, sizeof(buf) - len, "decrypt\t%u\t(%u%%)\n",
556
+	len += scnprintf(buf + len, sizeof(buf) - len, "decrypt\t%u\t(%u%%)\n",
576
557
 			st->rxerr_decrypt,
577
558
 			st->rx_all_count > 0 ?
578
559
 				st->rxerr_decrypt * 100 / st->rx_all_count : 0);
579
-	len += snprintf(buf + len, sizeof(buf) - len, "MIC\t%u\t(%u%%)\n",
560
+	len += scnprintf(buf + len, sizeof(buf) - len, "MIC\t%u\t(%u%%)\n",
580
561
 			st->rxerr_mic,
581
562
 			st->rx_all_count > 0 ?
582
563
 				st->rxerr_mic * 100 / st->rx_all_count : 0);
583
-	len += snprintf(buf + len, sizeof(buf) - len, "process\t%u\t(%u%%)\n",
564
+	len += scnprintf(buf + len, sizeof(buf) - len, "process\t%u\t(%u%%)\n",
584
565
 			st->rxerr_proc,
585
566
 			st->rx_all_count > 0 ?
586
567
 				st->rxerr_proc * 100 / st->rx_all_count : 0);
587
-	len += snprintf(buf + len, sizeof(buf) - len, "jumbo\t%u\t(%u%%)\n",
568
+	len += scnprintf(buf + len, sizeof(buf) - len, "jumbo\t%u\t(%u%%)\n",
588
569
 			st->rxerr_jumbo,
589
570
 			st->rx_all_count > 0 ?
590
571
 				st->rxerr_jumbo * 100 / st->rx_all_count : 0);
591
-	len += snprintf(buf + len, sizeof(buf) - len, "[RX all\t%u]\n",
572
+	len += scnprintf(buf + len, sizeof(buf) - len, "[RX all\t%u]\n",
592
573
 			st->rx_all_count);
593
-	len += snprintf(buf + len, sizeof(buf) - len, "RX-all-bytes\t%u\n",
574
+	len += scnprintf(buf + len, sizeof(buf) - len, "RX-all-bytes\t%u\n",
594
575
 			st->rx_bytes_count);
595
576
 
596
-	len += snprintf(buf + len, sizeof(buf) - len,
577
+	len += scnprintf(buf + len, sizeof(buf) - len,
597
578
 			"\nTX\n---------------------\n");
598
-	len += snprintf(buf + len, sizeof(buf) - len, "retry\t%u\t(%u%%)\n",
579
+	len += scnprintf(buf + len, sizeof(buf) - len, "retry\t%u\t(%u%%)\n",
599
580
 			st->txerr_retry,
600
581
 			st->tx_all_count > 0 ?
601
582
 				st->txerr_retry * 100 / st->tx_all_count : 0);
602
-	len += snprintf(buf + len, sizeof(buf) - len, "FIFO\t%u\t(%u%%)\n",
583
+	len += scnprintf(buf + len, sizeof(buf) - len, "FIFO\t%u\t(%u%%)\n",
603
584
 			st->txerr_fifo,
604
585
 			st->tx_all_count > 0 ?
605
586
 				st->txerr_fifo * 100 / st->tx_all_count : 0);
606
-	len += snprintf(buf + len, sizeof(buf) - len, "filter\t%u\t(%u%%)\n",
587
+	len += scnprintf(buf + len, sizeof(buf) - len, "filter\t%u\t(%u%%)\n",
607
588
 			st->txerr_filt,
608
589
 			st->tx_all_count > 0 ?
609
590
 				st->txerr_filt * 100 / st->tx_all_count : 0);
610
-	len += snprintf(buf + len, sizeof(buf) - len, "[TX all\t%u]\n",
591
+	len += scnprintf(buf + len, sizeof(buf) - len, "[TX all\t%u]\n",
611
592
 			st->tx_all_count);
612
-	len += snprintf(buf + len, sizeof(buf) - len, "TX-all-bytes\t%u\n",
593
+	len += scnprintf(buf + len, sizeof(buf) - len, "TX-all-bytes\t%u\n",
613
594
 			st->tx_bytes_count);
614
595
 
615
596
 	if (len > sizeof(buf))
..
..
@@ -670,56 +651,56 @@
670
651
 	char buf[700];
671
652
 	unsigned int len = 0;
672
653
 
673
-	len += snprintf(buf + len, sizeof(buf) - len,
654
+	len += scnprintf(buf + len, sizeof(buf) - len,
674
655
 			"HW has PHY error counters:\t%s\n",
675
656
 			ah->ah_capabilities.cap_has_phyerr_counters ?
676
657
 			"yes" : "no");
677
-	len += snprintf(buf + len, sizeof(buf) - len,
658
+	len += scnprintf(buf + len, sizeof(buf) - len,
678
659
 			"HW max spur immunity level:\t%d\n",
679
660
 			as->max_spur_level);
680
-	len += snprintf(buf + len, sizeof(buf) - len,
661
+	len += scnprintf(buf + len, sizeof(buf) - len,
681
662
 		"\nANI state\n--------------------------------------------\n");
682
-	len += snprintf(buf + len, sizeof(buf) - len, "operating mode:\t\t\t");
663
+	len += scnprintf(buf + len, sizeof(buf) - len, "operating mode:\t\t\t");
683
664
 	switch (as->ani_mode) {
684
665
 	case ATH5K_ANI_MODE_OFF:
685
-		len += snprintf(buf + len, sizeof(buf) - len, "OFF\n");
666
+		len += scnprintf(buf + len, sizeof(buf) - len, "OFF\n");
686
667
 		break;
687
668
 	case ATH5K_ANI_MODE_MANUAL_LOW:
688
-		len += snprintf(buf + len, sizeof(buf) - len,
669
+		len += scnprintf(buf + len, sizeof(buf) - len,
689
670
 			"MANUAL LOW\n");
690
671
 		break;
691
672
 	case ATH5K_ANI_MODE_MANUAL_HIGH:
692
-		len += snprintf(buf + len, sizeof(buf) - len,
673
+		len += scnprintf(buf + len, sizeof(buf) - len,
693
674
 			"MANUAL HIGH\n");
694
675
 		break;
695
676
 	case ATH5K_ANI_MODE_AUTO:
696
-		len += snprintf(buf + len, sizeof(buf) - len, "AUTO\n");
677
+		len += scnprintf(buf + len, sizeof(buf) - len, "AUTO\n");
697
678
 		break;
698
679
 	default:
699
-		len += snprintf(buf + len, sizeof(buf) - len,
680
+		len += scnprintf(buf + len, sizeof(buf) - len,
700
681
 			"??? (not good)\n");
701
682
 		break;
702
683
 	}
703
-	len += snprintf(buf + len, sizeof(buf) - len,
684
+	len += scnprintf(buf + len, sizeof(buf) - len,
704
685
 			"noise immunity level:\t\t%d\n",
705
686
 			as->noise_imm_level);
706
-	len += snprintf(buf + len, sizeof(buf) - len,
687
+	len += scnprintf(buf + len, sizeof(buf) - len,
707
688
 			"spur immunity level:\t\t%d\n",
708
689
 			as->spur_level);
709
-	len += snprintf(buf + len, sizeof(buf) - len,
690
+	len += scnprintf(buf + len, sizeof(buf) - len,
710
691
 			"firstep level:\t\t\t%d\n",
711
692
 			as->firstep_level);
712
-	len += snprintf(buf + len, sizeof(buf) - len,
693
+	len += scnprintf(buf + len, sizeof(buf) - len,
713
694
 			"OFDM weak signal detection:\t%s\n",
714
695
 			as->ofdm_weak_sig ? "on" : "off");
715
-	len += snprintf(buf + len, sizeof(buf) - len,
696
+	len += scnprintf(buf + len, sizeof(buf) - len,
716
697
 			"CCK weak signal detection:\t%s\n",
717
698
 			as->cck_weak_sig ? "on" : "off");
718
699
 
719
-	len += snprintf(buf + len, sizeof(buf) - len,
700
+	len += scnprintf(buf + len, sizeof(buf) - len,
720
701
 			"\nMIB INTERRUPTS:\t\t%u\n",
721
702
 			st->mib_intr);
722
-	len += snprintf(buf + len, sizeof(buf) - len,
703
+	len += scnprintf(buf + len, sizeof(buf) - len,
723
704
 			"beacon RSSI average:\t%d\n",
724
705
 			(int)ewma_beacon_rssi_read(&ah->ah_beacon_rssi_avg));
725
706
 
..
..
@@ -728,35 +709,35 @@
728
709
 	_struct.cycles > 0 ? \
729
710
 	_struct._field * 100 / _struct.cycles : 0
730
711
 
731
-	len += snprintf(buf + len, sizeof(buf) - len,
712
+	len += scnprintf(buf + len, sizeof(buf) - len,
732
713
 			"profcnt tx\t\t%u\t(%d%%)\n",
733
714
 			CC_PRINT(as->last_cc, tx_frame));
734
-	len += snprintf(buf + len, sizeof(buf) - len,
715
+	len += scnprintf(buf + len, sizeof(buf) - len,
735
716
 			"profcnt rx\t\t%u\t(%d%%)\n",
736
717
 			CC_PRINT(as->last_cc, rx_frame));
737
-	len += snprintf(buf + len, sizeof(buf) - len,
718
+	len += scnprintf(buf + len, sizeof(buf) - len,
738
719
 			"profcnt busy\t\t%u\t(%d%%)\n",
739
720
 			CC_PRINT(as->last_cc, rx_busy));
740
721
 #undef CC_PRINT
741
-	len += snprintf(buf + len, sizeof(buf) - len, "profcnt cycles\t\t%u\n",
722
+	len += scnprintf(buf + len, sizeof(buf) - len, "profcnt cycles\t\t%u\n",
742
723
 			as->last_cc.cycles);
743
-	len += snprintf(buf + len, sizeof(buf) - len,
724
+	len += scnprintf(buf + len, sizeof(buf) - len,
744
725
 			"listen time\t\t%d\tlast: %d\n",
745
726
 			as->listen_time, as->last_listen);
746
-	len += snprintf(buf + len, sizeof(buf) - len,
727
+	len += scnprintf(buf + len, sizeof(buf) - len,
747
728
 			"OFDM errors\t\t%u\tlast: %u\tsum: %u\n",
748
729
 			as->ofdm_errors, as->last_ofdm_errors,
749
730
 			as->sum_ofdm_errors);
750
-	len += snprintf(buf + len, sizeof(buf) - len,
731
+	len += scnprintf(buf + len, sizeof(buf) - len,
751
732
 			"CCK errors\t\t%u\tlast: %u\tsum: %u\n",
752
733
 			as->cck_errors, as->last_cck_errors,
753
734
 			as->sum_cck_errors);
754
-	len += snprintf(buf + len, sizeof(buf) - len,
735
+	len += scnprintf(buf + len, sizeof(buf) - len,
755
736
 			"AR5K_PHYERR_CNT1\t%x\t(=%d)\n",
756
737
 			ath5k_hw_reg_read(ah, AR5K_PHYERR_CNT1),
757
738
 			ATH5K_ANI_OFDM_TRIG_HIGH - (ATH5K_PHYERR_CNT_MAX -
758
739
 			ath5k_hw_reg_read(ah, AR5K_PHYERR_CNT1)));
759
-	len += snprintf(buf + len, sizeof(buf) - len,
740
+	len += scnprintf(buf + len, sizeof(buf) - len,
760
741
 			"AR5K_PHYERR_CNT2\t%x\t(=%d)\n",
761
742
 			ath5k_hw_reg_read(ah, AR5K_PHYERR_CNT2),
762
743
 			ATH5K_ANI_CCK_TRIG_HIGH - (ATH5K_PHYERR_CNT_MAX -
..
..
@@ -836,13 +817,13 @@
836
817
 	struct ath5k_buf *bf, *bf0;
837
818
 	int i, n;
838
819
 
839
-	len += snprintf(buf + len, sizeof(buf) - len,
820
+	len += scnprintf(buf + len, sizeof(buf) - len,
840
821
 			"available txbuffers: %d\n", ah->txbuf_len);
841
822
 
842
823
 	for (i = 0; i < ARRAY_SIZE(ah->txqs); i++) {
843
824
 		txq = &ah->txqs[i];
844
825
 
845
-		len += snprintf(buf + len, sizeof(buf) - len,
826
+		len += scnprintf(buf + len, sizeof(buf) - len,
846
827
 			"%02d: %ssetup\n", i, txq->setup ? "" : "not ");
847
828
 
848
829
 		if (!txq->setup)
..
..
@@ -854,9 +835,9 @@
854
835
 			n++;
855
836
 		spin_unlock_bh(&txq->lock);
856
837
 
857
-		len += snprintf(buf + len, sizeof(buf) - len,
838
+		len += scnprintf(buf + len, sizeof(buf) - len,
858
839
 				"  len: %d bufs: %d\n", txq->txq_len, n);
859
-		len += snprintf(buf + len, sizeof(buf) - len,
840
+		len += scnprintf(buf + len, sizeof(buf) - len,
860
841
 				"  stuck: %d\n", txq->txq_stuck);
861
842
 	}
862
843
 
..
..
@@ -1005,7 +986,7 @@
1005
986
 		return;
1006
987
 
1007
988
 	debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
1008
-	debugfs_create_file("registers", 0400, phydir, ah, &fops_registers);
989
+	debugfs_create_file("registers", 0400, phydir, ah, &registers_fops);
1009
990
 	debugfs_create_file("beacon", 0600, phydir, ah, &fops_beacon);
1010
991
 	debugfs_create_file("reset", 0200, phydir, ah, &fops_reset);
1011
992
 	debugfs_create_file("antenna", 0600, phydir, ah, &fops_antenna);
..
..
@@ -1027,8 +1008,6 @@
1027
1008
 
1028
1009
 	if (likely(!(ah->debug.level & ATH5K_DEBUG_DUMPBANDS)))
1029
1010
 		return;
1030
-
1031
-	BUG_ON(!ah->sbands);
1032
1011
 
1033
1012
 	for (b = 0; b < NUM_NL80211_BANDS; b++) {
1034
1013
 		struct ieee80211_supported_band *band = &ah->sbands[b];