| .. | .. |
|---|
| 335 | 335 | MPT_ADAPTER *ioc = (MPT_ADAPTER *)arg; |
|---|
| 336 | 336 | struct pci_dev *pdev; |
|---|
| 337 | 337 | |
|---|
| 338 | | - if ((ioc == NULL)) |
|---|
| 338 | + if (!ioc) |
|---|
| 339 | 339 | return -1; |
|---|
| 340 | 340 | |
|---|
| 341 | 341 | pdev = ioc->pcidev; |
|---|
| 342 | | - if ((pdev == NULL)) |
|---|
| 342 | + if (!pdev) |
|---|
| 343 | 343 | return -1; |
|---|
| 344 | 344 | |
|---|
| 345 | 345 | pci_stop_and_remove_bus_device_locked(pdev); |
|---|
| .. | .. |
|---|
| 642 | 642 | freereq = 0; |
|---|
| 643 | 643 | if (event != MPI_EVENT_EVENT_CHANGE) |
|---|
| 644 | 644 | break; |
|---|
| 645 | | - /* else: fall through */ |
|---|
| 645 | + fallthrough; |
|---|
| 646 | 646 | case MPI_FUNCTION_CONFIG: |
|---|
| 647 | 647 | case MPI_FUNCTION_SAS_IO_UNIT_CONTROL: |
|---|
| 648 | 648 | ioc->mptbase_cmds.status |= MPT_MGMT_STATUS_COMMAND_GOOD; |
|---|
| .. | .. |
|---|
| 1324 | 1324 | return 0; /* fw doesn't need any host buffers */ |
|---|
| 1325 | 1325 | |
|---|
| 1326 | 1326 | /* spin till we get enough memory */ |
|---|
| 1327 | | - while(host_page_buffer_sz > 0) { |
|---|
| 1328 | | - |
|---|
| 1329 | | - if((ioc->HostPageBuffer = pci_alloc_consistent( |
|---|
| 1330 | | - ioc->pcidev, |
|---|
| 1331 | | - host_page_buffer_sz, |
|---|
| 1332 | | - &ioc->HostPageBuffer_dma)) != NULL) { |
|---|
| 1333 | | - |
|---|
| 1327 | + while (host_page_buffer_sz > 0) { |
|---|
| 1328 | + ioc->HostPageBuffer = |
|---|
| 1329 | + dma_alloc_coherent(&ioc->pcidev->dev, |
|---|
| 1330 | + host_page_buffer_sz, |
|---|
| 1331 | + &ioc->HostPageBuffer_dma, |
|---|
| 1332 | + GFP_KERNEL); |
|---|
| 1333 | + if (ioc->HostPageBuffer) { |
|---|
| 1334 | 1334 | dinitprintk(ioc, printk(MYIOC_s_DEBUG_FMT |
|---|
| 1335 | 1335 | "host_page_buffer @ %p, dma @ %x, sz=%d bytes\n", |
|---|
| 1336 | 1336 | ioc->name, ioc->HostPageBuffer, |
|---|
| .. | .. |
|---|
| 1887 | 1887 | case MPI_MANUFACTPAGE_DEVICEID_FC939X: |
|---|
| 1888 | 1888 | case MPI_MANUFACTPAGE_DEVICEID_FC949X: |
|---|
| 1889 | 1889 | ioc->errata_flag_1064 = 1; |
|---|
| 1890 | | - /* fall through */ |
|---|
| 1890 | + fallthrough; |
|---|
| 1891 | 1891 | case MPI_MANUFACTPAGE_DEVICEID_FC909: |
|---|
| 1892 | 1892 | case MPI_MANUFACTPAGE_DEVICEID_FC929: |
|---|
| 1893 | 1893 | case MPI_MANUFACTPAGE_DEVICEID_FC919: |
|---|
| .. | .. |
|---|
| 1932 | 1932 | pcixcmd &= 0x8F; |
|---|
| 1933 | 1933 | pci_write_config_byte(pdev, 0x6a, pcixcmd); |
|---|
| 1934 | 1934 | } |
|---|
| 1935 | | - /* fall through */ |
|---|
| 1935 | + fallthrough; |
|---|
| 1936 | 1936 | |
|---|
| 1937 | 1937 | case MPI_MANUFACTPAGE_DEVID_1030_53C1035: |
|---|
| 1938 | 1938 | ioc->bus_type = SPI; |
|---|
| .. | .. |
|---|
| 2741 | 2741 | sz = ioc->alloc_sz; |
|---|
| 2742 | 2742 | dexitprintk(ioc, printk(MYIOC_s_INFO_FMT "free @ %p, sz=%d bytes\n", |
|---|
| 2743 | 2743 | ioc->name, ioc->alloc, ioc->alloc_sz)); |
|---|
| 2744 | | - pci_free_consistent(ioc->pcidev, sz, |
|---|
| 2745 | | - ioc->alloc, ioc->alloc_dma); |
|---|
| 2744 | + dma_free_coherent(&ioc->pcidev->dev, sz, ioc->alloc, |
|---|
| 2745 | + ioc->alloc_dma); |
|---|
| 2746 | 2746 | ioc->reply_frames = NULL; |
|---|
| 2747 | 2747 | ioc->req_frames = NULL; |
|---|
| 2748 | 2748 | ioc->alloc = NULL; |
|---|
| .. | .. |
|---|
| 2751 | 2751 | |
|---|
| 2752 | 2752 | if (ioc->sense_buf_pool != NULL) { |
|---|
| 2753 | 2753 | sz = (ioc->req_depth * MPT_SENSE_BUFFER_ALLOC); |
|---|
| 2754 | | - pci_free_consistent(ioc->pcidev, sz, |
|---|
| 2755 | | - ioc->sense_buf_pool, ioc->sense_buf_pool_dma); |
|---|
| 2754 | + dma_free_coherent(&ioc->pcidev->dev, sz, ioc->sense_buf_pool, |
|---|
| 2755 | + ioc->sense_buf_pool_dma); |
|---|
| 2756 | 2756 | ioc->sense_buf_pool = NULL; |
|---|
| 2757 | 2757 | ioc->alloc_total -= sz; |
|---|
| 2758 | 2758 | } |
|---|
| .. | .. |
|---|
| 2802 | 2802 | "HostPageBuffer free @ %p, sz=%d bytes\n", |
|---|
| 2803 | 2803 | ioc->name, ioc->HostPageBuffer, |
|---|
| 2804 | 2804 | ioc->HostPageBuffer_sz)); |
|---|
| 2805 | | - pci_free_consistent(ioc->pcidev, ioc->HostPageBuffer_sz, |
|---|
| 2805 | + dma_free_coherent(&ioc->pcidev->dev, ioc->HostPageBuffer_sz, |
|---|
| 2806 | 2806 | ioc->HostPageBuffer, ioc->HostPageBuffer_dma); |
|---|
| 2807 | 2807 | ioc->HostPageBuffer = NULL; |
|---|
| 2808 | 2808 | ioc->HostPageBuffer_sz = 0; |
|---|
| .. | .. |
|---|
| 4497 | 4497 | ioc->name, sz, sz, num_chain)); |
|---|
| 4498 | 4498 | |
|---|
| 4499 | 4499 | total_size += sz; |
|---|
| 4500 | | - mem = pci_alloc_consistent(ioc->pcidev, total_size, &alloc_dma); |
|---|
| 4500 | + mem = dma_alloc_coherent(&ioc->pcidev->dev, total_size, |
|---|
| 4501 | + &alloc_dma, GFP_KERNEL); |
|---|
| 4501 | 4502 | if (mem == NULL) { |
|---|
| 4502 | 4503 | printk(MYIOC_s_ERR_FMT "Unable to allocate Reply, Request, Chain Buffers!\n", |
|---|
| 4503 | 4504 | ioc->name); |
|---|
| .. | .. |
|---|
| 4574 | 4575 | spin_unlock_irqrestore(&ioc->FreeQlock, flags); |
|---|
| 4575 | 4576 | |
|---|
| 4576 | 4577 | sz = (ioc->req_depth * MPT_SENSE_BUFFER_ALLOC); |
|---|
| 4577 | | - ioc->sense_buf_pool = |
|---|
| 4578 | | - pci_alloc_consistent(ioc->pcidev, sz, &ioc->sense_buf_pool_dma); |
|---|
| 4578 | + ioc->sense_buf_pool = dma_alloc_coherent(&ioc->pcidev->dev, sz, |
|---|
| 4579 | + &ioc->sense_buf_pool_dma, GFP_KERNEL); |
|---|
| 4579 | 4580 | if (ioc->sense_buf_pool == NULL) { |
|---|
| 4580 | 4581 | printk(MYIOC_s_ERR_FMT "Unable to allocate Sense Buffers!\n", |
|---|
| 4581 | 4582 | ioc->name); |
|---|
| .. | .. |
|---|
| 4613 | 4614 | |
|---|
| 4614 | 4615 | if (ioc->alloc != NULL) { |
|---|
| 4615 | 4616 | sz = ioc->alloc_sz; |
|---|
| 4616 | | - pci_free_consistent(ioc->pcidev, |
|---|
| 4617 | | - sz, |
|---|
| 4618 | | - ioc->alloc, ioc->alloc_dma); |
|---|
| 4617 | + dma_free_coherent(&ioc->pcidev->dev, sz, ioc->alloc, |
|---|
| 4618 | + ioc->alloc_dma); |
|---|
| 4619 | 4619 | ioc->reply_frames = NULL; |
|---|
| 4620 | 4620 | ioc->req_frames = NULL; |
|---|
| 4621 | 4621 | ioc->alloc_total -= sz; |
|---|
| 4622 | 4622 | } |
|---|
| 4623 | 4623 | if (ioc->sense_buf_pool != NULL) { |
|---|
| 4624 | 4624 | sz = (ioc->req_depth * MPT_SENSE_BUFFER_ALLOC); |
|---|
| 4625 | | - pci_free_consistent(ioc->pcidev, |
|---|
| 4626 | | - sz, |
|---|
| 4627 | | - ioc->sense_buf_pool, ioc->sense_buf_pool_dma); |
|---|
| 4625 | + dma_free_coherent(&ioc->pcidev->dev, sz, ioc->sense_buf_pool, |
|---|
| 4626 | + ioc->sense_buf_pool_dma); |
|---|
| 4628 | 4627 | ioc->sense_buf_pool = NULL; |
|---|
| 4629 | 4628 | } |
|---|
| 4630 | 4629 | |
|---|
| .. | .. |
|---|
| 5052 | 5051 | * @ioc: Pointer to MPT_ADAPTER structure |
|---|
| 5053 | 5052 | * @persist_opcode: see below |
|---|
| 5054 | 5053 | * |
|---|
| 5055 | | - * MPI_SAS_OP_CLEAR_NOT_PRESENT - Free all persist TargetID mappings for |
|---|
| 5056 | | - * devices not currently present. |
|---|
| 5057 | | - * MPI_SAS_OP_CLEAR_ALL_PERSISTENT - Clear al persist TargetID mappings |
|---|
| 5054 | + * =============================== ====================================== |
|---|
| 5055 | + * MPI_SAS_OP_CLEAR_NOT_PRESENT Free all persist TargetID mappings for |
|---|
| 5056 | + * devices not currently present. |
|---|
| 5057 | + * MPI_SAS_OP_CLEAR_ALL_PERSISTENT Clear al persist TargetID mappings |
|---|
| 5058 | + * =============================== ====================================== |
|---|
| 5058 | 5059 | * |
|---|
| 5059 | 5060 | * NOTE: Don't use not this function during interrupt time. |
|---|
| 5060 | 5061 | * |
|---|
| .. | .. |
|---|
| 6001 | 6002 | if (mpt_config(ioc, &cfg) != 0) |
|---|
| 6002 | 6003 | goto out; |
|---|
| 6003 | 6004 | |
|---|
| 6004 | | - mem = kmalloc(iocpage2sz, GFP_KERNEL); |
|---|
| 6005 | + mem = kmemdup(pIoc2, iocpage2sz, GFP_KERNEL); |
|---|
| 6005 | 6006 | if (!mem) { |
|---|
| 6006 | 6007 | rc = -ENOMEM; |
|---|
| 6007 | 6008 | goto out; |
|---|
| 6008 | 6009 | } |
|---|
| 6009 | 6010 | |
|---|
| 6010 | | - memcpy(mem, (u8 *)pIoc2, iocpage2sz); |
|---|
| 6011 | 6011 | ioc->raid_data.pIocPg2 = (IOCPage2_t *) mem; |
|---|
| 6012 | 6012 | |
|---|
| 6013 | 6013 | mpt_read_ioc_pg_3(ioc); |
|---|
| .. | .. |
|---|
| 7570 | 7570 | u8 phy_num = (u8)(evData0); |
|---|
| 7571 | 7571 | u8 port_num = (u8)(evData0 >> 8); |
|---|
| 7572 | 7572 | u8 port_width = (u8)(evData0 >> 16); |
|---|
| 7573 | | - u8 primative = (u8)(evData0 >> 24); |
|---|
| 7573 | + u8 primitive = (u8)(evData0 >> 24); |
|---|
| 7574 | 7574 | snprintf(evStr, EVENT_DESCR_STR_SZ, |
|---|
| 7575 | | - "SAS Broadcase Primative: phy=%d port=%d " |
|---|
| 7576 | | - "width=%d primative=0x%02x", |
|---|
| 7577 | | - phy_num, port_num, port_width, primative); |
|---|
| 7575 | + "SAS Broadcast Primitive: phy=%d port=%d " |
|---|
| 7576 | + "width=%d primitive=0x%02x", |
|---|
| 7577 | + phy_num, port_num, port_width, primitive); |
|---|
| 7578 | 7578 | break; |
|---|
| 7579 | 7579 | } |
|---|
| 7580 | 7580 | |
|---|