hc
2024-05-10 23fa18eaa71266feff7ba8d83022d9e1cc83c65a
kernel/drivers/infiniband/ulp/ipoib/ipoib_fs.c
....@@ -124,35 +124,14 @@
124124 return 0;
125125 }
126126
127
-static const struct seq_operations ipoib_mcg_seq_ops = {
127
+static const struct seq_operations ipoib_mcg_sops = {
128128 .start = ipoib_mcg_seq_start,
129129 .next = ipoib_mcg_seq_next,
130130 .stop = ipoib_mcg_seq_stop,
131131 .show = ipoib_mcg_seq_show,
132132 };
133133
134
-static int ipoib_mcg_open(struct inode *inode, struct file *file)
135
-{
136
- struct seq_file *seq;
137
- int ret;
138
-
139
- ret = seq_open(file, &ipoib_mcg_seq_ops);
140
- if (ret)
141
- return ret;
142
-
143
- seq = file->private_data;
144
- seq->private = inode->i_private;
145
-
146
- return 0;
147
-}
148
-
149
-static const struct file_operations ipoib_mcg_fops = {
150
- .owner = THIS_MODULE,
151
- .open = ipoib_mcg_open,
152
- .read = seq_read,
153
- .llseek = seq_lseek,
154
- .release = seq_release
155
-};
134
+DEFINE_SEQ_ATTRIBUTE(ipoib_mcg);
156135
157136 static void *ipoib_path_seq_start(struct seq_file *file, loff_t *pos)
158137 {
....@@ -229,35 +208,14 @@
229208 return 0;
230209 }
231210
232
-static const struct seq_operations ipoib_path_seq_ops = {
211
+static const struct seq_operations ipoib_path_sops = {
233212 .start = ipoib_path_seq_start,
234213 .next = ipoib_path_seq_next,
235214 .stop = ipoib_path_seq_stop,
236215 .show = ipoib_path_seq_show,
237216 };
238217
239
-static int ipoib_path_open(struct inode *inode, struct file *file)
240
-{
241
- struct seq_file *seq;
242
- int ret;
243
-
244
- ret = seq_open(file, &ipoib_path_seq_ops);
245
- if (ret)
246
- return ret;
247
-
248
- seq = file->private_data;
249
- seq->private = inode->i_private;
250
-
251
- return 0;
252
-}
253
-
254
-static const struct file_operations ipoib_path_fops = {
255
- .owner = THIS_MODULE,
256
- .open = ipoib_path_open,
257
- .read = seq_read,
258
- .llseek = seq_lseek,
259
- .release = seq_release
260
-};
218
+DEFINE_SEQ_ATTRIBUTE(ipoib_path);
261219
262220 void ipoib_create_debug_files(struct net_device *dev)
263221 {
....@@ -267,14 +225,10 @@
267225 snprintf(name, sizeof(name), "%s_mcg", dev->name);
268226 priv->mcg_dentry = debugfs_create_file(name, S_IFREG | S_IRUGO,
269227 ipoib_root, dev, &ipoib_mcg_fops);
270
- if (!priv->mcg_dentry)
271
- ipoib_warn(priv, "failed to create mcg debug file\n");
272228
273229 snprintf(name, sizeof(name), "%s_path", dev->name);
274230 priv->path_dentry = debugfs_create_file(name, S_IFREG | S_IRUGO,
275231 ipoib_root, dev, &ipoib_path_fops);
276
- if (!priv->path_dentry)
277
- ipoib_warn(priv, "failed to create path debug file\n");
278232 }
279233
280234 void ipoib_delete_debug_files(struct net_device *dev)
....@@ -286,10 +240,9 @@
286240 priv->mcg_dentry = priv->path_dentry = NULL;
287241 }
288242
289
-int ipoib_register_debugfs(void)
243
+void ipoib_register_debugfs(void)
290244 {
291245 ipoib_root = debugfs_create_dir("ipoib", NULL);
292
- return ipoib_root ? 0 : -ENOMEM;
293246 }
294247
295248 void ipoib_unregister_debugfs(void)