hc
2024-02-19 1c055e55a242a33e574e48be530e06770a210dcd
kernel/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c
....@@ -1,17 +1,6 @@
1
+// SPDX-License-Identifier: ISC
12 /*
23 * Copyright (c) 2012 Broadcom Corporation
3
- *
4
- * Permission to use, copy, modify, and/or distribute this software for any
5
- * purpose with or without fee is hereby granted, provided that the above
6
- * copyright notice and this permission notice appear in all copies.
7
- *
8
- * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
9
- * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
10
- * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
11
- * SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
12
- * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
13
- * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
14
- * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
154 */
165 #include <linux/netdevice.h>
176
....@@ -34,6 +23,7 @@
3423 * @ifidx: interface index related to this event.
3524 * @ifaddr: ethernet address for interface.
3625 * @emsg: common parameters of the firmware event message.
26
+ * @datalen: length of the data array
3727 * @data: event specific data part of the firmware event.
3828 */
3929 struct brcmf_fweh_queue_item {
....@@ -43,10 +33,10 @@
4333 u8 ifaddr[ETH_ALEN];
4434 struct brcmf_event_msg_be emsg;
4535 u32 datalen;
46
- u8 data[0];
36
+ u8 data[];
4737 };
4838
49
-/**
39
+/*
5040 * struct brcmf_fweh_event_name - code, name mapping entry.
5141 */
5242 struct brcmf_fweh_event_name {
....@@ -102,7 +92,8 @@
10292 schedule_work(&fweh->event_work);
10393 }
10494
105
-static int brcmf_fweh_call_event_handler(struct brcmf_if *ifp,
95
+static int brcmf_fweh_call_event_handler(struct brcmf_pub *drvr,
96
+ struct brcmf_if *ifp,
10697 enum brcmf_fweh_event_code code,
10798 struct brcmf_event_msg *emsg,
10899 void *data)
....@@ -117,9 +108,9 @@
117108 if (fweh->evt_handler[code])
118109 err = fweh->evt_handler[code](ifp, emsg, data);
119110 else
120
- brcmf_err("unhandled event %d ignored\n", code);
111
+ bphy_err(drvr, "unhandled event %d ignored\n", code);
121112 } else {
122
- brcmf_err("no interface object\n");
113
+ bphy_err(drvr, "no interface object\n");
123114 }
124115 return err;
125116 }
....@@ -128,8 +119,8 @@
128119 * brcmf_fweh_handle_if_event() - handle IF event.
129120 *
130121 * @drvr: driver information object.
131
- * @item: queue entry.
132
- * @ifpp: interface object (may change upon ADD action).
122
+ * @emsg: event message object.
123
+ * @data: event object.
133124 */
134125 static void brcmf_fweh_handle_if_event(struct brcmf_pub *drvr,
135126 struct brcmf_event_msg *emsg,
....@@ -138,7 +129,6 @@
138129 struct brcmf_if_event *ifevent = data;
139130 struct brcmf_if *ifp;
140131 bool is_p2pdev;
141
- int err = 0;
142132
143133 brcmf_dbg(EVENT, "action: %u ifidx: %u bsscfgidx: %u flags: %u role: %u\n",
144134 ifevent->action, ifevent->ifidx, ifevent->bsscfgidx,
....@@ -158,7 +148,7 @@
158148 return;
159149 }
160150 if (ifevent->ifidx >= BRCMF_MAX_IFS) {
161
- brcmf_err("invalid interface index: %u\n", ifevent->ifidx);
151
+ bphy_err(drvr, "invalid interface index: %u\n", ifevent->ifidx);
162152 return;
163153 }
164154
....@@ -181,7 +171,8 @@
181171 if (ifp && ifevent->action == BRCMF_E_IF_CHANGE)
182172 brcmf_proto_reset_if(drvr, ifp);
183173
184
- err = brcmf_fweh_call_event_handler(ifp, emsg->event_code, emsg, data);
174
+ brcmf_fweh_call_event_handler(drvr, ifp, emsg->event_code, emsg,
175
+ data);
185176
186177 if (ifp && ifevent->action == BRCMF_E_IF_DEL) {
187178 bool armed = brcmf_cfg80211_vif_event_armed(drvr->config);
....@@ -237,6 +228,10 @@
237228 brcmf_fweh_event_name(event->code), event->code,
238229 event->emsg.ifidx, event->emsg.bsscfgidx,
239230 event->emsg.addr);
231
+ if (event->emsg.bsscfgidx >= BRCMF_MAX_IFS) {
232
+ bphy_err(drvr, "invalid bsscfg index: %u\n", event->emsg.bsscfgidx);
233
+ goto event_free;
234
+ }
240235
241236 /* convert event message */
242237 emsg_be = &event->emsg;
....@@ -268,11 +263,11 @@
268263 ifp = drvr->iflist[0];
269264 else
270265 ifp = drvr->iflist[emsg.bsscfgidx];
271
- err = brcmf_fweh_call_event_handler(ifp, event->code, &emsg,
272
- event->data);
266
+ err = brcmf_fweh_call_event_handler(drvr, ifp, event->code,
267
+ &emsg, event->data);
273268 if (err) {
274
- brcmf_err("event handler failed (%d)\n",
275
- event->code);
269
+ bphy_err(drvr, "event handler failed (%d)\n",
270
+ event->code);
276271 err = 0;
277272 }
278273 event_free:
....@@ -312,20 +307,13 @@
312307 void brcmf_fweh_detach(struct brcmf_pub *drvr)
313308 {
314309 struct brcmf_fweh_info *fweh = &drvr->fweh;
315
- struct brcmf_if *ifp = brcmf_get_ifp(drvr, 0);
316
- s8 eventmask[BRCMF_EVENTING_MASK_LEN];
317310
318
- if (ifp) {
319
- /* clear all events */
320
- memset(eventmask, 0, BRCMF_EVENTING_MASK_LEN);
321
- (void)brcmf_fil_iovar_data_set(ifp, "event_msgs",
322
- eventmask,
323
- BRCMF_EVENTING_MASK_LEN);
311
+ /* cancel the worker if initialized */
312
+ if (fweh->event_work.func) {
313
+ cancel_work_sync(&fweh->event_work);
314
+ WARN_ON(!list_empty(&fweh->event_q));
315
+ memset(fweh->evt_handler, 0, sizeof(fweh->evt_handler));
324316 }
325
- /* cancel the worker */
326
- cancel_work_sync(&fweh->event_work);
327
- WARN_ON(!list_empty(&fweh->event_q));
328
- memset(fweh->evt_handler, 0, sizeof(fweh->evt_handler));
329317 }
330318
331319 /**
....@@ -339,7 +327,7 @@
339327 brcmf_fweh_handler_t handler)
340328 {
341329 if (drvr->fweh.evt_handler[code]) {
342
- brcmf_err("event code %d already registered\n", code);
330
+ bphy_err(drvr, "event code %d already registered\n", code);
343331 return -ENOSPC;
344332 }
345333 drvr->fweh.evt_handler[code] = handler;
....@@ -369,6 +357,7 @@
369357 */
370358 int brcmf_fweh_activate_events(struct brcmf_if *ifp)
371359 {
360
+ struct brcmf_pub *drvr = ifp->drvr;
372361 int i, err;
373362 s8 eventmask[BRCMF_EVENTING_MASK_LEN];
374363
....@@ -388,7 +377,7 @@
388377 err = brcmf_fil_iovar_data_set(ifp, "event_msgs",
389378 eventmask, BRCMF_EVENTING_MASK_LEN);
390379 if (err)
391
- brcmf_err("Set event_msgs error (%d)\n", err);
380
+ bphy_err(drvr, "Set event_msgs error (%d)\n", err);
392381
393382 return err;
394383 }
....@@ -398,18 +387,18 @@
398387 *
399388 * @drvr: driver information object.
400389 * @event_packet: event packet to process.
390
+ * @packet_len: length of the packet
401391 *
402392 * If the packet buffer contains a firmware event message it will
403393 * dispatch the event to a registered handler (using worker).
404394 */
405395 void brcmf_fweh_process_event(struct brcmf_pub *drvr,
406396 struct brcmf_event *event_packet,
407
- u32 packet_len)
397
+ u32 packet_len, gfp_t gfp)
408398 {
409399 enum brcmf_fweh_event_code code;
410400 struct brcmf_fweh_info *fweh = &drvr->fweh;
411401 struct brcmf_fweh_queue_item *event;
412
- gfp_t alloc_flag = GFP_KERNEL;
413402 void *data;
414403 u32 datalen;
415404
....@@ -428,10 +417,7 @@
428417 datalen + sizeof(*event_packet) > packet_len)
429418 return;
430419
431
- if (in_interrupt())
432
- alloc_flag = GFP_ATOMIC;
433
-
434
- event = kzalloc(sizeof(*event) + datalen, alloc_flag);
420
+ event = kzalloc(sizeof(*event) + datalen, gfp);
435421 if (!event)
436422 return;
437423