forked from ~ljy/RK356X_SDK_RELEASE

blame | history | patch | commit | commitdiff
hc
2024-02-20 102a0743326a03cd1a1202ceda21e175b7d3575c 
 kernel/net/mac80211/key.c
....@@ -1,3 +1,4 @@
1
+// SPDX-License-Identifier: GPL-2.0-only
12 /*
23  * Copyright 2002-2005, Instant802 Networks, Inc.
34  * Copyright 2005-2006, Devicescape Software, Inc.
....@@ -5,10 +6,7 @@
56  * Copyright 2007-2008	Johannes Berg <johannes@sipsolutions.net>
67  * Copyright 2013-2014  Intel Mobile Communications GmbH
78  * Copyright 2015-2017	Intel Deutschland GmbH
8
- *
9
- * This program is free software; you can redistribute it and/or modify
10
- * it under the terms of the GNU General Public License version 2 as
11
- * published by the Free Software Foundation.
9
+ * Copyright 2018-2020  Intel Corporation
1210  */
1311 
1412 #include <linux/if_ether.h>
....@@ -140,6 +138,12 @@
140138 		 * so clear that flag now to avoid trying to remove
141139 		 * it again later.
142140 		 */
141
+		if (key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE &&
142
+		    !(key->conf.flags & (IEEE80211_KEY_FLAG_GENERATE_MMIC |
143
+					 IEEE80211_KEY_FLAG_PUT_MIC_SPACE |
144
+					 IEEE80211_KEY_FLAG_RESERVE_TAILROOM)))
145
+			increment_tailroom_need_count(sdata);
146
+
143147 		key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;
144148 		return -EINVAL;
145149 	}
....@@ -179,9 +183,9 @@
179183 	if (!ret) {
180184 		key->flags |= KEY_FLAG_UPLOADED_TO_HARDWARE;
181185 
182
-		if (!((key->conf.flags & (IEEE80211_KEY_FLAG_GENERATE_MMIC |
183
-					   IEEE80211_KEY_FLAG_PUT_MIC_SPACE)) ||
184
-		      (key->conf.flags & IEEE80211_KEY_FLAG_RESERVE_TAILROOM)))
186
+		if (!(key->conf.flags & (IEEE80211_KEY_FLAG_GENERATE_MMIC |
187
+					 IEEE80211_KEY_FLAG_PUT_MIC_SPACE |
188
+					 IEEE80211_KEY_FLAG_RESERVE_TAILROOM)))
185189 			decrease_tailroom_need_count(sdata, 1);
186190 
187191 		WARN_ON((key->conf.flags & IEEE80211_KEY_FLAG_PUT_IV_SPACE) &&
....@@ -206,12 +210,12 @@
206210 	case WLAN_CIPHER_SUITE_TKIP:
207211 	case WLAN_CIPHER_SUITE_CCMP:
208212 	case WLAN_CIPHER_SUITE_CCMP_256:
213
+	case WLAN_CIPHER_SUITE_GCMP:
214
+	case WLAN_CIPHER_SUITE_GCMP_256:
209215 	case WLAN_CIPHER_SUITE_AES_CMAC:
210216 	case WLAN_CIPHER_SUITE_BIP_CMAC_256:
211217 	case WLAN_CIPHER_SUITE_BIP_GMAC_128:
212218 	case WLAN_CIPHER_SUITE_BIP_GMAC_256:
213
-	case WLAN_CIPHER_SUITE_GCMP:
214
-	case WLAN_CIPHER_SUITE_GCMP_256:
215219 		/* all of these we can do in software - if driver can */
216220 		if (ret == 1)
217221 			return 0;
....@@ -242,11 +246,12 @@
242246 	sta = key->sta;
243247 	sdata = key->sdata;
244248 
245
-	if (!((key->conf.flags & (IEEE80211_KEY_FLAG_GENERATE_MMIC |
246
-				   IEEE80211_KEY_FLAG_PUT_MIC_SPACE)) ||
247
-	      (key->conf.flags & IEEE80211_KEY_FLAG_RESERVE_TAILROOM)))
249
+	if (!(key->conf.flags & (IEEE80211_KEY_FLAG_GENERATE_MMIC |
250
+				 IEEE80211_KEY_FLAG_PUT_MIC_SPACE |
251
+				 IEEE80211_KEY_FLAG_RESERVE_TAILROOM)))
248252 		increment_tailroom_need_count(sdata);
249253 
254
+	key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;
250255 	ret = drv_set_key(key->local, DISABLE_KEY, sdata,
251256 			  sta ? &sta->sta : NULL, &key->conf);
252257 
....@@ -255,8 +260,88 @@
255260 			  "failed to remove key (%d, %pM) from hardware (%d)\n",
256261 			  key->conf.keyidx,
257262 			  sta ? sta->sta.addr : bcast_addr, ret);
263
+}
258264 
259
-	key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;
265
+static int _ieee80211_set_tx_key(struct ieee80211_key *key, bool force)
266
+{
267
+	struct sta_info *sta = key->sta;
268
+	struct ieee80211_local *local = key->local;
269
+
270
+	assert_key_lock(local);
271
+
272
+	set_sta_flag(sta, WLAN_STA_USES_ENCRYPTION);
273
+
274
+	sta->ptk_idx = key->conf.keyidx;
275
+
276
+	if (force || !ieee80211_hw_check(&local->hw, AMPDU_KEYBORDER_SUPPORT))
277
+		clear_sta_flag(sta, WLAN_STA_BLOCK_BA);
278
+	ieee80211_check_fast_xmit(sta);
279
+
280
+	return 0;
281
+}
282
+
283
+int ieee80211_set_tx_key(struct ieee80211_key *key)
284
+{
285
+	return _ieee80211_set_tx_key(key, false);
286
+}
287
+
288
+static void ieee80211_pairwise_rekey(struct ieee80211_key *old,
289
+				     struct ieee80211_key *new)
290
+{
291
+	struct ieee80211_local *local = new->local;
292
+	struct sta_info *sta = new->sta;
293
+	int i;
294
+
295
+	assert_key_lock(local);
296
+
297
+	if (new->conf.flags & IEEE80211_KEY_FLAG_NO_AUTO_TX) {
298
+		/* Extended Key ID key install, initial one or rekey */
299
+
300
+		if (sta->ptk_idx != INVALID_PTK_KEYIDX &&
301
+		    !ieee80211_hw_check(&local->hw, AMPDU_KEYBORDER_SUPPORT)) {
302
+			/* Aggregation Sessions with Extended Key ID must not
303
+			 * mix MPDUs with different keyIDs within one A-MPDU.
304
+			 * Tear down running Tx aggregation sessions and block
305
+			 * new Rx/Tx aggregation requests during rekey to
306
+			 * ensure there are no A-MPDUs when the driver is not
307
+			 * supporting A-MPDU key borders. (Blocking Tx only
308
+			 * would be sufficient but WLAN_STA_BLOCK_BA gets the
309
+			 * job done for the few ms we need it.)
310
+			 */
311
+			set_sta_flag(sta, WLAN_STA_BLOCK_BA);
312
+			mutex_lock(&sta->ampdu_mlme.mtx);
313
+			for (i = 0; i <  IEEE80211_NUM_TIDS; i++)
314
+				___ieee80211_stop_tx_ba_session(sta, i,
315
+								AGG_STOP_LOCAL_REQUEST);
316
+			mutex_unlock(&sta->ampdu_mlme.mtx);
317
+		}
318
+	} else if (old) {
319
+		/* Rekey without Extended Key ID.
320
+		 * Aggregation sessions are OK when running on SW crypto.
321
+		 * A broken remote STA may cause issues not observed with HW
322
+		 * crypto, though.
323
+		 */
324
+		if (!(old->flags & KEY_FLAG_UPLOADED_TO_HARDWARE))
325
+			return;
326
+
327
+		/* Stop Tx till we are on the new key */
328
+		old->flags |= KEY_FLAG_TAINTED;
329
+		ieee80211_clear_fast_xmit(sta);
330
+		if (ieee80211_hw_check(&local->hw, AMPDU_AGGREGATION)) {
331
+			set_sta_flag(sta, WLAN_STA_BLOCK_BA);
332
+			ieee80211_sta_tear_down_BA_sessions(sta,
333
+							    AGG_STOP_LOCAL_REQUEST);
334
+		}
335
+		if (!wiphy_ext_feature_isset(local->hw.wiphy,
336
+					     NL80211_EXT_FEATURE_CAN_REPLACE_PTK0)) {
337
+			pr_warn_ratelimited("Rekeying PTK for STA %pM but driver can't safely do that.",
338
+					    sta->sta.addr);
339
+			/* Flushing the driver queues *may* help prevent
340
+			 * the clear text leaks and freezes.
341
+			 */
342
+			ieee80211_flush_queues(local, old->sdata, false);
343
+		}
344
+	}
260345 }
261346 
262347 static void __ieee80211_set_default_key(struct ieee80211_sub_if_data *sdata,
....@@ -314,40 +399,91 @@
314399 	mutex_unlock(&sdata->local->key_mtx);
315400 }
316401 
402
+static void
403
+__ieee80211_set_default_beacon_key(struct ieee80211_sub_if_data *sdata, int idx)
404
+{
405
+	struct ieee80211_key *key = NULL;
317406 
318
-static void ieee80211_key_replace(struct ieee80211_sub_if_data *sdata,
407
+	assert_key_lock(sdata->local);
408
+
409
+	if (idx >= NUM_DEFAULT_KEYS + NUM_DEFAULT_MGMT_KEYS &&
410
+	    idx < NUM_DEFAULT_KEYS + NUM_DEFAULT_MGMT_KEYS +
411
+	    NUM_DEFAULT_BEACON_KEYS)
412
+		key = key_mtx_dereference(sdata->local, sdata->keys[idx]);
413
+
414
+	rcu_assign_pointer(sdata->default_beacon_key, key);
415
+
416
+	ieee80211_debugfs_key_update_default(sdata);
417
+}
418
+
419
+void ieee80211_set_default_beacon_key(struct ieee80211_sub_if_data *sdata,
420
+				      int idx)
421
+{
422
+	mutex_lock(&sdata->local->key_mtx);
423
+	__ieee80211_set_default_beacon_key(sdata, idx);
424
+	mutex_unlock(&sdata->local->key_mtx);
425
+}
426
+
427
+static int ieee80211_key_replace(struct ieee80211_sub_if_data *sdata,
319428 				  struct sta_info *sta,
320429 				  bool pairwise,
321430 				  struct ieee80211_key *old,
322431 				  struct ieee80211_key *new)
323432 {
324433 	int idx;
325
-	bool defunikey, defmultikey, defmgmtkey;
434
+	int ret = 0;
435
+	bool defunikey, defmultikey, defmgmtkey, defbeaconkey;
326436 
327437 	/* caller must provide at least one old/new */
328438 	if (WARN_ON(!new && !old))
329
-		return;
439
+		return 0;
330440 
331441 	if (new)
332442 		list_add_tail_rcu(&new->list, &sdata->key_list);
333443 
334444 	WARN_ON(new && old && new->conf.keyidx != old->conf.keyidx);
335445 
336
-	if (old)
446
+	if (new && sta && pairwise) {
447
+		/* Unicast rekey needs special handling. With Extended Key ID
448
+		 * old is still NULL for the first rekey.
449
+		 */
450
+		ieee80211_pairwise_rekey(old, new);
451
+	}
452
+
453
+	if (old) {
337454 		idx = old->conf.keyidx;
338
-	else
455
+
456
+		if (old->flags & KEY_FLAG_UPLOADED_TO_HARDWARE) {
457
+			ieee80211_key_disable_hw_accel(old);
458
+
459
+			if (new)
460
+				ret = ieee80211_key_enable_hw_accel(new);
461
+		}
462
+	} else {
463
+		/* new must be provided in case old is not */
339464 		idx = new->conf.keyidx;
465
+		if (!new->local->wowlan)
466
+			ret = ieee80211_key_enable_hw_accel(new);
467
+	}
468
+
469
+	if (ret)
470
+		return ret;
340471 
341472 	if (sta) {
342473 		if (pairwise) {
343474 			rcu_assign_pointer(sta->ptk[idx], new);
344
-			set_sta_flag(sta, WLAN_STA_USES_ENCRYPTION);
345
-			sta->ptk_idx = idx;
346
-			ieee80211_check_fast_xmit(sta);
475
+			if (new &&
476
+			    !(new->conf.flags & IEEE80211_KEY_FLAG_NO_AUTO_TX))
477
+				_ieee80211_set_tx_key(new, true);
347478 		} else {
348479 			rcu_assign_pointer(sta->gtk[idx], new);
349480 		}
350
-		ieee80211_check_fast_rx(sta);
481
+		/* Only needed for transition from no key -> key.
482
+		 * Still triggers unnecessary when using Extended Key ID
483
+		 * and installing the second key ID the first time.
484
+		 */
485
+		if (new && !old)
486
+			ieee80211_check_fast_rx(sta);
351487 	} else {
352488 		defunikey = old &&
353489 			old == key_mtx_dereference(sdata->local,
....@@ -358,6 +494,9 @@
358494 		defmgmtkey = old &&
359495 			old == key_mtx_dereference(sdata->local,
360496 						sdata->default_mgmt_key);
497
+		defbeaconkey = old &&
498
+			old == key_mtx_dereference(sdata->local,
499
+						   sdata->default_beacon_key);
361500 
362501 		if (defunikey && !new)
363502 			__ieee80211_set_default_key(sdata, -1, true, false);
....@@ -365,6 +504,8 @@
365504 			__ieee80211_set_default_key(sdata, -1, false, true);
366505 		if (defmgmtkey && !new)
367506 			__ieee80211_set_default_mgmt_key(sdata, -1);
507
+		if (defbeaconkey && !new)
508
+			__ieee80211_set_default_beacon_key(sdata, -1);
368509 
369510 		rcu_assign_pointer(sdata->keys[idx], new);
370511 		if (defunikey && new)
....@@ -376,10 +517,15 @@
376517 		if (defmgmtkey && new)
377518 			__ieee80211_set_default_mgmt_key(sdata,
378519 							 new->conf.keyidx);
520
+		if (defbeaconkey && new)
521
+			__ieee80211_set_default_beacon_key(sdata,
522
+							   new->conf.keyidx);
379523 	}
380524 
381525 	if (old)
382526 		list_del_rcu(&old->list);
527
+
528
+	return 0;
383529 }
384530 
385531 struct ieee80211_key *
....@@ -391,7 +537,9 @@
391537 	struct ieee80211_key *key;
392538 	int i, j, err;
393539 
394
-	if (WARN_ON(idx < 0 || idx >= NUM_DEFAULT_KEYS + NUM_DEFAULT_MGMT_KEYS))
540
+	if (WARN_ON(idx < 0 ||
541
+		    idx >= NUM_DEFAULT_KEYS + NUM_DEFAULT_MGMT_KEYS +
542
+		    NUM_DEFAULT_BEACON_KEYS))
395543 		return ERR_PTR(-EINVAL);
396544 
397545 	key = kzalloc(sizeof(struct ieee80211_key) + key_len, GFP_KERNEL);
....@@ -569,15 +717,12 @@
569717 		ieee80211_aes_gcm_key_free(key->u.gcmp.tfm);
570718 		break;
571719 	}
572
-	kzfree(key);
720
+	kfree_sensitive(key);
573721 }
574722 
575723 static void __ieee80211_key_destroy(struct ieee80211_key *key,
576724 				    bool delay_tailroom)
577725 {
578
-	if (key->local)
579
-		ieee80211_key_disable_hw_accel(key);
580
-
581726 	if (key->local) {
582727 		struct ieee80211_sub_if_data *sdata = key->sdata;
583728 
....@@ -655,7 +800,6 @@
655800 		       struct sta_info *sta)
656801 {
657802 	static atomic_t key_color = ATOMIC_INIT(0);
658
-	struct ieee80211_local *local = sdata->local;
659803 	struct ieee80211_key *old_key;
660804 	int idx = key->conf.keyidx;
661805 	bool pairwise = key->conf.flags & IEEE80211_KEY_FLAG_PAIRWISE;
....@@ -665,16 +809,33 @@
665809 	 * can cause warnings to appear.
666810 	 */
667811 	bool delay_tailroom = sdata->vif.type == NL80211_IFTYPE_STATION;
668
-	int ret;
812
+	int ret = -EOPNOTSUPP;
669813 
670814 	mutex_lock(&sdata->local->key_mtx);
671815 
672
-	if (sta && pairwise)
816
+	if (sta && pairwise) {
817
+		struct ieee80211_key *alt_key;
818
+
673819 		old_key = key_mtx_dereference(sdata->local, sta->ptk[idx]);
674
-	else if (sta)
820
+		alt_key = key_mtx_dereference(sdata->local, sta->ptk[idx ^ 1]);
821
+
822
+		/* The rekey code assumes that the old and new key are using
823
+		 * the same cipher. Enforce the assumption for pairwise keys.
824
+		 */
825
+		if ((alt_key && alt_key->conf.cipher != key->conf.cipher) ||
826
+		    (old_key && old_key->conf.cipher != key->conf.cipher))
827
+			goto out;
828
+	} else if (sta) {
675829 		old_key = key_mtx_dereference(sdata->local, sta->gtk[idx]);
676
-	else
830
+	} else {
677831 		old_key = key_mtx_dereference(sdata->local, sdata->keys[idx]);
832
+	}
833
+
834
+	/* Non-pairwise keys must also not switch the cipher on rekey */
835
+	if (!pairwise) {
836
+		if (old_key && old_key->conf.cipher != key->conf.cipher)
837
+			goto out;
838
+	}
678839 
679840 	/*
680841 	 * Silently accept key re-installation without really installing the
....@@ -698,17 +859,13 @@
698859 
699860 	increment_tailroom_need_count(sdata);
700861 
701
-	ieee80211_key_replace(sdata, sta, pairwise, old_key, key);
702
-	ieee80211_key_destroy(old_key, delay_tailroom);
862
+	ret = ieee80211_key_replace(sdata, sta, pairwise, old_key, key);
703863 
704
-	ieee80211_debugfs_key_add(key);
705
-
706
-	if (!local->wowlan) {
707
-		ret = ieee80211_key_enable_hw_accel(key);
708
-		if (ret)
709
-			ieee80211_key_free(key, delay_tailroom);
864
+	if (!ret) {
865
+		ieee80211_debugfs_key_add(key);
866
+		ieee80211_key_destroy(old_key, delay_tailroom);
710867 	} else {
711
-		ret = 0;
868
+		ieee80211_key_free(key, delay_tailroom);
712869 	}
713870 
714871  out:
....@@ -732,46 +889,30 @@
732889 	ieee80211_key_destroy(key, delay_tailroom);
733890 }
734891 
735
-void ieee80211_enable_keys(struct ieee80211_sub_if_data *sdata)
892
+void ieee80211_reenable_keys(struct ieee80211_sub_if_data *sdata)
736893 {
737894 	struct ieee80211_key *key;
738895 	struct ieee80211_sub_if_data *vlan;
739896 
740897 	ASSERT_RTNL();
741898 
742
-	if (WARN_ON(!ieee80211_sdata_running(sdata)))
743
-		return;
744
-
745
-	mutex_lock(&sdata->local->key_mtx);
746
-
747
-	WARN_ON_ONCE(sdata->crypto_tx_tailroom_needed_cnt ||
748
-		     sdata->crypto_tx_tailroom_pending_dec);
749
-
750
-	if (sdata->vif.type == NL80211_IFTYPE_AP) {
751
-		list_for_each_entry(vlan, &sdata->u.ap.vlans, u.vlan.list)
752
-			WARN_ON_ONCE(vlan->crypto_tx_tailroom_needed_cnt ||
753
-				     vlan->crypto_tx_tailroom_pending_dec);
754
-	}
755
-
756
-	list_for_each_entry(key, &sdata->key_list, list) {
757
-		increment_tailroom_need_count(sdata);
758
-		ieee80211_key_enable_hw_accel(key);
759
-	}
760
-
761
-	mutex_unlock(&sdata->local->key_mtx);
762
-}
763
-
764
-void ieee80211_reset_crypto_tx_tailroom(struct ieee80211_sub_if_data *sdata)
765
-{
766
-	struct ieee80211_sub_if_data *vlan;
767
-
768899 	mutex_lock(&sdata->local->key_mtx);
769900 
770901 	sdata->crypto_tx_tailroom_needed_cnt = 0;
902
+	sdata->crypto_tx_tailroom_pending_dec = 0;
771903 
772904 	if (sdata->vif.type == NL80211_IFTYPE_AP) {
773
-		list_for_each_entry(vlan, &sdata->u.ap.vlans, u.vlan.list)
905
+		list_for_each_entry(vlan, &sdata->u.ap.vlans, u.vlan.list) {
774906 			vlan->crypto_tx_tailroom_needed_cnt = 0;
907
+			vlan->crypto_tx_tailroom_pending_dec = 0;
908
+		}
909
+	}
910
+
911
+	if (ieee80211_sdata_running(sdata)) {
912
+		list_for_each_entry(key, &sdata->key_list, list) {
913
+			increment_tailroom_need_count(sdata);
914
+			ieee80211_key_enable_hw_accel(key);
915
+		}
775916 	}
776917 
777918 	mutex_unlock(&sdata->local->key_mtx);
....@@ -868,6 +1009,7 @@
8681009 	sdata->crypto_tx_tailroom_pending_dec = 0;
8691010 
8701011 	ieee80211_debugfs_key_remove_mgmt_default(sdata);
1012
+	ieee80211_debugfs_key_remove_beacon_default(sdata);
8711013 
8721014 	list_for_each_entry_safe(key, tmp, &sdata->key_list, list) {
8731015 		ieee80211_key_replace(key->sdata, key->sta,
....@@ -1124,9 +1266,9 @@
11241266 	if (key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE) {
11251267 		key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;
11261268 
1127
-		if (!((key->conf.flags & (IEEE80211_KEY_FLAG_GENERATE_MMIC |
1128
-					   IEEE80211_KEY_FLAG_PUT_MIC_SPACE)) ||
1129
-		      (key->conf.flags & IEEE80211_KEY_FLAG_RESERVE_TAILROOM)))
1269
+		if (!(key->conf.flags & (IEEE80211_KEY_FLAG_GENERATE_MMIC |
1270
+					 IEEE80211_KEY_FLAG_PUT_MIC_SPACE |
1271
+					 IEEE80211_KEY_FLAG_RESERVE_TAILROOM)))
11301272 			increment_tailroom_need_count(key->sdata);
11311273 	}
11321274