hc
2024-02-20 102a0743326a03cd1a1202ceda21e175b7d3575c
kernel/mm/compaction.c
....@@ -45,10 +45,33 @@
4545 #define CREATE_TRACE_POINTS
4646 #include <trace/events/compaction.h>
4747
48
+#undef CREATE_TRACE_POINTS
49
+#ifndef __GENKSYMS__
50
+#include <trace/hooks/mm.h>
51
+#endif
52
+
4853 #define block_start_pfn(pfn, order) round_down(pfn, 1UL << (order))
4954 #define block_end_pfn(pfn, order) ALIGN((pfn) + 1, 1UL << (order))
5055 #define pageblock_start_pfn(pfn) block_start_pfn(pfn, pageblock_order)
5156 #define pageblock_end_pfn(pfn) block_end_pfn(pfn, pageblock_order)
57
+
58
+/*
59
+ * Fragmentation score check interval for proactive compaction purposes.
60
+ */
61
+static const unsigned int HPAGE_FRAG_CHECK_INTERVAL_MSEC = 500;
62
+
63
+/*
64
+ * Page order with-respect-to which proactive compaction
65
+ * calculates external fragmentation, which is used as
66
+ * the "fragmentation score" of a node/zone.
67
+ */
68
+#if defined CONFIG_TRANSPARENT_HUGEPAGE
69
+#define COMPACTION_HPAGE_ORDER HPAGE_PMD_ORDER
70
+#elif defined CONFIG_HUGETLBFS
71
+#define COMPACTION_HPAGE_ORDER HUGETLB_PAGE_ORDER
72
+#else
73
+#define COMPACTION_HPAGE_ORDER (PMD_SHIFT - PAGE_SHIFT)
74
+#endif
5275
5376 static unsigned long release_freepages(struct list_head *freelist)
5477 {
....@@ -66,7 +89,7 @@
6689 return high_pfn;
6790 }
6891
69
-static void map_pages(struct list_head *list)
92
+static void split_map_pages(struct list_head *list)
7093 {
7194 unsigned int i, order, nr_pages;
7295 struct page *page, *next;
....@@ -136,7 +159,7 @@
136159
137160 /*
138161 * Compaction is deferred when compaction fails to result in a page
139
- * allocation success. 1 << compact_defer_limit compactions are skipped up
162
+ * allocation success. 1 << compact_defer_shift, compactions are skipped up
140163 * to a limit of 1 << COMPACT_MAX_DEFER_SHIFT
141164 */
142165 void defer_compaction(struct zone *zone, int order)
....@@ -162,11 +185,10 @@
162185 return false;
163186
164187 /* Avoid possible overflow */
165
- if (++zone->compact_considered > defer_limit)
188
+ if (++zone->compact_considered >= defer_limit) {
166189 zone->compact_considered = defer_limit;
167
-
168
- if (zone->compact_considered >= defer_limit)
169190 return false;
191
+ }
170192
171193 trace_mm_compaction_deferred(zone, order);
172194
....@@ -237,6 +259,78 @@
237259 return false;
238260 }
239261
262
+static bool
263
+__reset_isolation_pfn(struct zone *zone, unsigned long pfn, bool check_source,
264
+ bool check_target)
265
+{
266
+ struct page *page = pfn_to_online_page(pfn);
267
+ struct page *block_page;
268
+ struct page *end_page;
269
+ unsigned long block_pfn;
270
+
271
+ if (!page)
272
+ return false;
273
+ if (zone != page_zone(page))
274
+ return false;
275
+ if (pageblock_skip_persistent(page))
276
+ return false;
277
+
278
+ /*
279
+ * If skip is already cleared do no further checking once the
280
+ * restart points have been set.
281
+ */
282
+ if (check_source && check_target && !get_pageblock_skip(page))
283
+ return true;
284
+
285
+ /*
286
+ * If clearing skip for the target scanner, do not select a
287
+ * non-movable pageblock as the starting point.
288
+ */
289
+ if (!check_source && check_target &&
290
+ get_pageblock_migratetype(page) != MIGRATE_MOVABLE)
291
+ return false;
292
+
293
+ /* Ensure the start of the pageblock or zone is online and valid */
294
+ block_pfn = pageblock_start_pfn(pfn);
295
+ block_pfn = max(block_pfn, zone->zone_start_pfn);
296
+ block_page = pfn_to_online_page(block_pfn);
297
+ if (block_page) {
298
+ page = block_page;
299
+ pfn = block_pfn;
300
+ }
301
+
302
+ /* Ensure the end of the pageblock or zone is online and valid */
303
+ block_pfn = pageblock_end_pfn(pfn) - 1;
304
+ block_pfn = min(block_pfn, zone_end_pfn(zone) - 1);
305
+ end_page = pfn_to_online_page(block_pfn);
306
+ if (!end_page)
307
+ return false;
308
+
309
+ /*
310
+ * Only clear the hint if a sample indicates there is either a
311
+ * free page or an LRU page in the block. One or other condition
312
+ * is necessary for the block to be a migration source/target.
313
+ */
314
+ do {
315
+ if (pfn_valid_within(pfn)) {
316
+ if (check_source && PageLRU(page)) {
317
+ clear_pageblock_skip(page);
318
+ return true;
319
+ }
320
+
321
+ if (check_target && PageBuddy(page)) {
322
+ clear_pageblock_skip(page);
323
+ return true;
324
+ }
325
+ }
326
+
327
+ page += (1 << PAGE_ALLOC_COSTLY_ORDER);
328
+ pfn += (1 << PAGE_ALLOC_COSTLY_ORDER);
329
+ } while (page <= end_page);
330
+
331
+ return false;
332
+}
333
+
240334 /*
241335 * This function is called to clear all cached information on pageblocks that
242336 * should be skipped for page isolation when the migrate and free page scanner
....@@ -244,30 +338,54 @@
244338 */
245339 static void __reset_isolation_suitable(struct zone *zone)
246340 {
247
- unsigned long start_pfn = zone->zone_start_pfn;
248
- unsigned long end_pfn = zone_end_pfn(zone);
249
- unsigned long pfn;
341
+ unsigned long migrate_pfn = zone->zone_start_pfn;
342
+ unsigned long free_pfn = zone_end_pfn(zone) - 1;
343
+ unsigned long reset_migrate = free_pfn;
344
+ unsigned long reset_free = migrate_pfn;
345
+ bool source_set = false;
346
+ bool free_set = false;
347
+
348
+ if (!zone->compact_blockskip_flush)
349
+ return;
250350
251351 zone->compact_blockskip_flush = false;
252352
253
- /* Walk the zone and mark every pageblock as suitable for isolation */
254
- for (pfn = start_pfn; pfn < end_pfn; pfn += pageblock_nr_pages) {
255
- struct page *page;
256
-
353
+ /*
354
+ * Walk the zone and update pageblock skip information. Source looks
355
+ * for PageLRU while target looks for PageBuddy. When the scanner
356
+ * is found, both PageBuddy and PageLRU are checked as the pageblock
357
+ * is suitable as both source and target.
358
+ */
359
+ for (; migrate_pfn < free_pfn; migrate_pfn += pageblock_nr_pages,
360
+ free_pfn -= pageblock_nr_pages) {
257361 cond_resched();
258362
259
- page = pfn_to_online_page(pfn);
260
- if (!page)
261
- continue;
262
- if (zone != page_zone(page))
263
- continue;
264
- if (pageblock_skip_persistent(page))
265
- continue;
363
+ /* Update the migrate PFN */
364
+ if (__reset_isolation_pfn(zone, migrate_pfn, true, source_set) &&
365
+ migrate_pfn < reset_migrate) {
366
+ source_set = true;
367
+ reset_migrate = migrate_pfn;
368
+ zone->compact_init_migrate_pfn = reset_migrate;
369
+ zone->compact_cached_migrate_pfn[0] = reset_migrate;
370
+ zone->compact_cached_migrate_pfn[1] = reset_migrate;
371
+ }
266372
267
- clear_pageblock_skip(page);
373
+ /* Update the free PFN */
374
+ if (__reset_isolation_pfn(zone, free_pfn, free_set, true) &&
375
+ free_pfn > reset_free) {
376
+ free_set = true;
377
+ reset_free = free_pfn;
378
+ zone->compact_init_free_pfn = reset_free;
379
+ zone->compact_cached_free_pfn = reset_free;
380
+ }
268381 }
269382
270
- reset_cached_positions(zone);
383
+ /* Leave no distance if no suitable block was reset */
384
+ if (reset_migrate >= reset_free) {
385
+ zone->compact_cached_migrate_pfn[0] = migrate_pfn;
386
+ zone->compact_cached_migrate_pfn[1] = migrate_pfn;
387
+ zone->compact_cached_free_pfn = free_pfn;
388
+ }
271389 }
272390
273391 void reset_isolation_suitable(pg_data_t *pgdat)
....@@ -286,15 +404,53 @@
286404 }
287405
288406 /*
407
+ * Sets the pageblock skip bit if it was clear. Note that this is a hint as
408
+ * locks are not required for read/writers. Returns true if it was already set.
409
+ */
410
+static bool test_and_set_skip(struct compact_control *cc, struct page *page,
411
+ unsigned long pfn)
412
+{
413
+ bool skip;
414
+
415
+ /* Do no update if skip hint is being ignored */
416
+ if (cc->ignore_skip_hint)
417
+ return false;
418
+
419
+ if (!IS_ALIGNED(pfn, pageblock_nr_pages))
420
+ return false;
421
+
422
+ skip = get_pageblock_skip(page);
423
+ if (!skip && !cc->no_set_skip_hint)
424
+ set_pageblock_skip(page);
425
+
426
+ return skip;
427
+}
428
+
429
+static void update_cached_migrate(struct compact_control *cc, unsigned long pfn)
430
+{
431
+ struct zone *zone = cc->zone;
432
+
433
+ pfn = pageblock_end_pfn(pfn);
434
+
435
+ /* Set for isolation rather than compaction */
436
+ if (cc->no_set_skip_hint)
437
+ return;
438
+
439
+ if (pfn > zone->compact_cached_migrate_pfn[0])
440
+ zone->compact_cached_migrate_pfn[0] = pfn;
441
+ if (cc->mode != MIGRATE_ASYNC &&
442
+ pfn > zone->compact_cached_migrate_pfn[1])
443
+ zone->compact_cached_migrate_pfn[1] = pfn;
444
+}
445
+
446
+/*
289447 * If no pages were isolated then mark this pageblock to be skipped in the
290448 * future. The information is later cleared by __reset_isolation_suitable().
291449 */
292450 static void update_pageblock_skip(struct compact_control *cc,
293
- struct page *page, unsigned long nr_isolated,
294
- bool migrate_scanner)
451
+ struct page *page, unsigned long pfn)
295452 {
296453 struct zone *zone = cc->zone;
297
- unsigned long pfn;
298454
299455 if (cc->no_set_skip_hint)
300456 return;
....@@ -302,24 +458,11 @@
302458 if (!page)
303459 return;
304460
305
- if (nr_isolated)
306
- return;
307
-
308461 set_pageblock_skip(page);
309462
310
- pfn = page_to_pfn(page);
311
-
312463 /* Update where async and sync compaction should restart */
313
- if (migrate_scanner) {
314
- if (pfn > zone->compact_cached_migrate_pfn[0])
315
- zone->compact_cached_migrate_pfn[0] = pfn;
316
- if (cc->mode != MIGRATE_ASYNC &&
317
- pfn > zone->compact_cached_migrate_pfn[1])
318
- zone->compact_cached_migrate_pfn[1] = pfn;
319
- } else {
320
- if (pfn < zone->compact_cached_free_pfn)
321
- zone->compact_cached_free_pfn = pfn;
322
- }
464
+ if (pfn < zone->compact_cached_free_pfn)
465
+ zone->compact_cached_free_pfn = pfn;
323466 }
324467 #else
325468 static inline bool isolation_suitable(struct compact_control *cc,
....@@ -334,32 +477,43 @@
334477 }
335478
336479 static inline void update_pageblock_skip(struct compact_control *cc,
337
- struct page *page, unsigned long nr_isolated,
338
- bool migrate_scanner)
480
+ struct page *page, unsigned long pfn)
339481 {
482
+}
483
+
484
+static void update_cached_migrate(struct compact_control *cc, unsigned long pfn)
485
+{
486
+}
487
+
488
+static bool test_and_set_skip(struct compact_control *cc, struct page *page,
489
+ unsigned long pfn)
490
+{
491
+ return false;
340492 }
341493 #endif /* CONFIG_COMPACTION */
342494
343495 /*
344496 * Compaction requires the taking of some coarse locks that are potentially
345
- * very heavily contended. For async compaction, back out if the lock cannot
346
- * be taken immediately. For sync compaction, spin on the lock if needed.
497
+ * very heavily contended. For async compaction, trylock and record if the
498
+ * lock is contended. The lock will still be acquired but compaction will
499
+ * abort when the current block is finished regardless of success rate.
500
+ * Sync compaction acquires the lock.
347501 *
348
- * Returns true if the lock is held
349
- * Returns false if the lock is not held and compaction should abort
502
+ * Always returns true which makes it easier to track lock state in callers.
350503 */
351
-static bool compact_trylock_irqsave(spinlock_t *lock, unsigned long *flags,
504
+static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags,
352505 struct compact_control *cc)
506
+ __acquires(lock)
353507 {
354
- if (cc->mode == MIGRATE_ASYNC) {
355
- if (!spin_trylock_irqsave(lock, *flags)) {
356
- cc->contended = true;
357
- return false;
358
- }
359
- } else {
360
- spin_lock_irqsave(lock, *flags);
508
+ /* Track if the lock is contended in async mode */
509
+ if (cc->mode == MIGRATE_ASYNC && !cc->contended) {
510
+ if (spin_trylock_irqsave(lock, *flags))
511
+ return true;
512
+
513
+ cc->contended = true;
361514 }
362515
516
+ spin_lock_irqsave(lock, *flags);
363517 return true;
364518 }
365519
....@@ -391,37 +545,7 @@
391545 return true;
392546 }
393547
394
- if (need_resched()) {
395
- if (cc->mode == MIGRATE_ASYNC) {
396
- cc->contended = true;
397
- return true;
398
- }
399
- cond_resched();
400
- }
401
-
402
- return false;
403
-}
404
-
405
-/*
406
- * Aside from avoiding lock contention, compaction also periodically checks
407
- * need_resched() and either schedules in sync compaction or aborts async
408
- * compaction. This is similar to what compact_unlock_should_abort() does, but
409
- * is used where no lock is concerned.
410
- *
411
- * Returns false when no scheduling was needed, or sync compaction scheduled.
412
- * Returns true when async compaction should abort.
413
- */
414
-static inline bool compact_should_abort(struct compact_control *cc)
415
-{
416
- /* async compaction aborts if contended */
417
- if (need_resched()) {
418
- if (cc->mode == MIGRATE_ASYNC) {
419
- cc->contended = true;
420
- return true;
421
- }
422
-
423
- cond_resched();
424
- }
548
+ cond_resched();
425549
426550 return false;
427551 }
....@@ -435,19 +559,24 @@
435559 unsigned long *start_pfn,
436560 unsigned long end_pfn,
437561 struct list_head *freelist,
562
+ unsigned int stride,
438563 bool strict)
439564 {
440565 int nr_scanned = 0, total_isolated = 0;
441
- struct page *cursor, *valid_page = NULL;
566
+ struct page *cursor;
442567 unsigned long flags = 0;
443568 bool locked = false;
444569 unsigned long blockpfn = *start_pfn;
445570 unsigned int order;
446571
572
+ /* Strict mode is for isolation, speed is secondary */
573
+ if (strict)
574
+ stride = 1;
575
+
447576 cursor = pfn_to_page(blockpfn);
448577
449578 /* Isolate free pages. */
450
- for (; blockpfn < end_pfn; blockpfn++, cursor++) {
579
+ for (; blockpfn < end_pfn; blockpfn += stride, cursor += stride) {
451580 int isolated;
452581 struct page *page = cursor;
453582
....@@ -464,9 +593,6 @@
464593 nr_scanned++;
465594 if (!pfn_valid_within(blockpfn))
466595 goto isolate_fail;
467
-
468
- if (!valid_page)
469
- valid_page = page;
470596
471597 /*
472598 * For compound pages such as THP and hugetlbfs, we can save
....@@ -495,18 +621,8 @@
495621 * recheck as well.
496622 */
497623 if (!locked) {
498
- /*
499
- * The zone lock must be held to isolate freepages.
500
- * Unfortunately this is a very coarse lock and can be
501
- * heavily contended if there are parallel allocations
502
- * or parallel compactions. For async compaction do not
503
- * spin on the lock and we acquire the lock as late as
504
- * possible.
505
- */
506
- locked = compact_trylock_irqsave(&cc->zone->lock,
624
+ locked = compact_lock_irqsave(&cc->zone->lock,
507625 &flags, cc);
508
- if (!locked)
509
- break;
510626
511627 /* Recheck this is a buddy page under lock */
512628 if (!PageBuddy(page))
....@@ -514,7 +630,7 @@
514630 }
515631
516632 /* Found a free page, will break it into order-0 pages */
517
- order = page_order(page);
633
+ order = buddy_order(page);
518634 isolated = __isolate_free_page(page, order);
519635 if (!isolated)
520636 break;
....@@ -564,10 +680,6 @@
564680 */
565681 if (strict && blockpfn < end_pfn)
566682 total_isolated = 0;
567
-
568
- /* Update the pageblock-skip if the whole pageblock was scanned */
569
- if (blockpfn == end_pfn)
570
- update_pageblock_skip(cc, valid_page, total_isolated, false);
571683
572684 cc->total_free_scanned += nr_scanned;
573685 if (total_isolated)
....@@ -626,7 +738,7 @@
626738 break;
627739
628740 isolated = isolate_freepages_block(cc, &isolate_start_pfn,
629
- block_end_pfn, &freelist, true);
741
+ block_end_pfn, &freelist, 0, true);
630742
631743 /*
632744 * In strict mode, isolate_freepages_block() returns 0 if
....@@ -644,7 +756,7 @@
644756 }
645757
646758 /* __isolate_free_page() does not map the pages */
647
- map_pages(&freelist);
759
+ split_map_pages(&freelist);
648760
649761 if (pfn < end_pfn) {
650762 /* Loop terminated early, cleanup. */
....@@ -656,17 +768,42 @@
656768 return pfn;
657769 }
658770
771
+#ifdef CONFIG_COMPACTION
772
+unsigned long isolate_and_split_free_page(struct page *page,
773
+ struct list_head *list)
774
+{
775
+ unsigned long isolated;
776
+ unsigned int order;
777
+
778
+ if (!PageBuddy(page))
779
+ return 0;
780
+
781
+ order = buddy_order(page);
782
+ isolated = __isolate_free_page(page, order);
783
+ if (!isolated)
784
+ return 0;
785
+
786
+ set_page_private(page, order);
787
+ list_add(&page->lru, list);
788
+
789
+ split_map_pages(list);
790
+
791
+ return isolated;
792
+}
793
+EXPORT_SYMBOL_GPL(isolate_and_split_free_page);
794
+#endif
795
+
659796 /* Similar to reclaim, but different enough that they don't share logic */
660
-static bool too_many_isolated(struct zone *zone)
797
+static bool too_many_isolated(pg_data_t *pgdat)
661798 {
662799 unsigned long active, inactive, isolated;
663800
664
- inactive = node_page_state(zone->zone_pgdat, NR_INACTIVE_FILE) +
665
- node_page_state(zone->zone_pgdat, NR_INACTIVE_ANON);
666
- active = node_page_state(zone->zone_pgdat, NR_ACTIVE_FILE) +
667
- node_page_state(zone->zone_pgdat, NR_ACTIVE_ANON);
668
- isolated = node_page_state(zone->zone_pgdat, NR_ISOLATED_FILE) +
669
- node_page_state(zone->zone_pgdat, NR_ISOLATED_ANON);
801
+ inactive = node_page_state(pgdat, NR_INACTIVE_FILE) +
802
+ node_page_state(pgdat, NR_INACTIVE_ANON);
803
+ active = node_page_state(pgdat, NR_ACTIVE_FILE) +
804
+ node_page_state(pgdat, NR_ACTIVE_ANON);
805
+ isolated = node_page_state(pgdat, NR_ISOLATED_FILE) +
806
+ node_page_state(pgdat, NR_ISOLATED_ANON);
670807
671808 return isolated > (inactive + active) / 2;
672809 }
....@@ -693,7 +830,7 @@
693830 isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
694831 unsigned long end_pfn, isolate_mode_t isolate_mode)
695832 {
696
- struct zone *zone = cc->zone;
833
+ pg_data_t *pgdat = cc->zone->zone_pgdat;
697834 unsigned long nr_scanned = 0, nr_isolated = 0;
698835 struct lruvec *lruvec;
699836 unsigned long flags = 0;
....@@ -702,13 +839,18 @@
702839 unsigned long start_pfn = low_pfn;
703840 bool skip_on_failure = false;
704841 unsigned long next_skip_pfn = 0;
842
+ bool skip_updated = false;
705843
706844 /*
707845 * Ensure that there are not too many pages isolated from the LRU
708846 * list by either parallel reclaimers or compaction. If there are,
709847 * delay for some time until fewer pages are isolated
710848 */
711
- while (unlikely(too_many_isolated(zone))) {
849
+ while (unlikely(too_many_isolated(pgdat))) {
850
+ /* stop isolation if there are still pages not migrated */
851
+ if (cc->nr_migratepages)
852
+ return 0;
853
+
712854 /* async migration should just abort */
713855 if (cc->mode == MIGRATE_ASYNC)
714856 return 0;
....@@ -719,8 +861,7 @@
719861 return 0;
720862 }
721863
722
- if (compact_should_abort(cc))
723
- return 0;
864
+ cond_resched();
724865
725866 if (cc->direct_compaction && (cc->mode == MIGRATE_ASYNC)) {
726867 skip_on_failure = true;
....@@ -754,13 +895,15 @@
754895
755896 /*
756897 * Periodically drop the lock (if held) regardless of its
757
- * contention, to give chance to IRQs. Abort async compaction
758
- * if contended.
898
+ * contention, to give chance to IRQs. Abort completely if
899
+ * a fatal signal is pending.
759900 */
760901 if (!(low_pfn % SWAP_CLUSTER_MAX)
761
- && compact_unlock_should_abort(zone_lru_lock(zone), flags,
762
- &locked, cc))
763
- break;
902
+ && compact_unlock_should_abort(&pgdat->lru_lock,
903
+ flags, &locked, cc)) {
904
+ low_pfn = 0;
905
+ goto fatal_pending;
906
+ }
764907
765908 if (!pfn_valid_within(low_pfn))
766909 goto isolate_fail;
....@@ -768,8 +911,19 @@
768911
769912 page = pfn_to_page(low_pfn);
770913
771
- if (!valid_page)
914
+ /*
915
+ * Check if the pageblock has already been marked skipped.
916
+ * Only the aligned PFN is checked as the caller isolates
917
+ * COMPACT_CLUSTER_MAX at a time so the second call must
918
+ * not falsely conclude that the block should be skipped.
919
+ */
920
+ if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages)) {
921
+ if (!cc->ignore_skip_hint && get_pageblock_skip(page)) {
922
+ low_pfn = end_pfn;
923
+ goto isolate_abort;
924
+ }
772925 valid_page = page;
926
+ }
773927
774928 /*
775929 * Skip if free. We read page order here without zone lock
....@@ -778,7 +932,7 @@
778932 * potential isolation targets.
779933 */
780934 if (PageBuddy(page)) {
781
- unsigned long freepage_order = page_order_unsafe(page);
935
+ unsigned long freepage_order = buddy_order_unsafe(page);
782936
783937 /*
784938 * Without lock, we cannot be sure that what we got is
....@@ -792,12 +946,13 @@
792946
793947 /*
794948 * Regardless of being on LRU, compound pages such as THP and
795
- * hugetlbfs are not to be compacted. We can potentially save
796
- * a lot of iterations if we skip them at once. The check is
797
- * racy, but we can consider only valid values and the only
798
- * danger is skipping too much.
949
+ * hugetlbfs are not to be compacted unless we are attempting
950
+ * an allocation much larger than the huge page size (eg CMA).
951
+ * We can potentially save a lot of iterations if we skip them
952
+ * at once. The check is racy, but we can consider only valid
953
+ * values and the only danger is skipping too much.
799954 */
800
- if (PageCompound(page)) {
955
+ if (PageCompound(page) && !cc->alloc_contig) {
801956 const unsigned int order = compound_order(page);
802957
803958 if (likely(order < MAX_ORDER))
....@@ -818,7 +973,7 @@
818973 if (unlikely(__PageMovable(page)) &&
819974 !PageIsolated(page)) {
820975 if (locked) {
821
- spin_unlock_irqrestore(zone_lru_lock(zone),
976
+ spin_unlock_irqrestore(&pgdat->lru_lock,
822977 flags);
823978 locked = false;
824979 }
....@@ -848,10 +1003,15 @@
8481003
8491004 /* If we already hold the lock, we can skip some rechecking */
8501005 if (!locked) {
851
- locked = compact_trylock_irqsave(zone_lru_lock(zone),
1006
+ locked = compact_lock_irqsave(&pgdat->lru_lock,
8521007 &flags, cc);
853
- if (!locked)
854
- break;
1008
+
1009
+ /* Try get exclusive access under lock */
1010
+ if (!skip_updated) {
1011
+ skip_updated = true;
1012
+ if (test_and_set_skip(cc, page, low_pfn))
1013
+ goto isolate_abort;
1014
+ }
8551015
8561016 /* Recheck PageLRU and PageCompound under lock */
8571017 if (!PageLRU(page))
....@@ -862,41 +1022,41 @@
8621022 * and it's on LRU. It can only be a THP so the order
8631023 * is safe to read and it's 0 for tail pages.
8641024 */
865
- if (unlikely(PageCompound(page))) {
866
- low_pfn += (1UL << compound_order(page)) - 1;
1025
+ if (unlikely(PageCompound(page) && !cc->alloc_contig)) {
1026
+ low_pfn += compound_nr(page) - 1;
8671027 goto isolate_fail;
8681028 }
8691029 }
8701030
871
- lruvec = mem_cgroup_page_lruvec(page, zone->zone_pgdat);
1031
+ lruvec = mem_cgroup_page_lruvec(page, pgdat);
8721032
8731033 /* Try isolate the page */
8741034 if (__isolate_lru_page(page, isolate_mode) != 0)
8751035 goto isolate_fail;
8761036
877
- VM_BUG_ON_PAGE(PageCompound(page), page);
1037
+ /* The whole page is taken off the LRU; skip the tail pages. */
1038
+ if (PageCompound(page))
1039
+ low_pfn += compound_nr(page) - 1;
8781040
8791041 /* Successfully isolated */
8801042 del_page_from_lru_list(page, lruvec, page_lru(page));
881
- inc_node_page_state(page,
882
- NR_ISOLATED_ANON + page_is_file_cache(page));
1043
+ mod_node_page_state(page_pgdat(page),
1044
+ NR_ISOLATED_ANON + page_is_file_lru(page),
1045
+ thp_nr_pages(page));
8831046
8841047 isolate_success:
8851048 list_add(&page->lru, &cc->migratepages);
886
- cc->nr_migratepages++;
887
- nr_isolated++;
1049
+ cc->nr_migratepages += compound_nr(page);
1050
+ nr_isolated += compound_nr(page);
8881051
8891052 /*
890
- * Record where we could have freed pages by migration and not
891
- * yet flushed them to buddy allocator.
892
- * - this is the lowest page that was isolated and likely be
893
- * then freed by migration.
1053
+ * Avoid isolating too much unless this block is being
1054
+ * rescanned (e.g. dirty/writeback pages, parallel allocation)
1055
+ * or a lock is contended. For contention, isolate quickly to
1056
+ * potentially remove one source of contention.
8941057 */
895
- if (!cc->last_migrated_pfn)
896
- cc->last_migrated_pfn = low_pfn;
897
-
898
- /* Avoid isolating too much */
899
- if (cc->nr_migratepages == COMPACT_CLUSTER_MAX) {
1058
+ if (cc->nr_migratepages >= COMPACT_CLUSTER_MAX &&
1059
+ !cc->rescan && !cc->contended) {
9001060 ++low_pfn;
9011061 break;
9021062 }
....@@ -913,12 +1073,11 @@
9131073 */
9141074 if (nr_isolated) {
9151075 if (locked) {
916
- spin_unlock_irqrestore(zone_lru_lock(zone), flags);
1076
+ spin_unlock_irqrestore(&pgdat->lru_lock, flags);
9171077 locked = false;
9181078 }
9191079 putback_movable_pages(&cc->migratepages);
9201080 cc->nr_migratepages = 0;
921
- cc->last_migrated_pfn = 0;
9221081 nr_isolated = 0;
9231082 }
9241083
....@@ -939,19 +1098,28 @@
9391098 if (unlikely(low_pfn > end_pfn))
9401099 low_pfn = end_pfn;
9411100
1101
+isolate_abort:
9421102 if (locked)
943
- spin_unlock_irqrestore(zone_lru_lock(zone), flags);
1103
+ spin_unlock_irqrestore(&pgdat->lru_lock, flags);
9441104
9451105 /*
946
- * Update the pageblock-skip information and cached scanner pfn,
947
- * if the whole pageblock was scanned without isolating any page.
1106
+ * Updated the cached scanner pfn once the pageblock has been scanned
1107
+ * Pages will either be migrated in which case there is no point
1108
+ * scanning in the near future or migration failed in which case the
1109
+ * failure reason may persist. The block is marked for skipping if
1110
+ * there were no pages isolated in the block or if the block is
1111
+ * rescanned twice in a row.
9481112 */
949
- if (low_pfn == end_pfn)
950
- update_pageblock_skip(cc, valid_page, nr_isolated, true);
1113
+ if (low_pfn == end_pfn && (!nr_isolated || cc->rescan)) {
1114
+ if (valid_page && !skip_updated)
1115
+ set_pageblock_skip(valid_page);
1116
+ update_cached_migrate(cc, low_pfn);
1117
+ }
9511118
9521119 trace_mm_compaction_isolate_migratepages(start_pfn, low_pfn,
9531120 nr_scanned, nr_isolated);
9541121
1122
+fatal_pending:
9551123 cc->total_migrate_scanned += nr_scanned;
9561124 if (nr_isolated)
9571125 count_compact_events(COMPACTISOLATED, nr_isolated);
....@@ -998,7 +1166,7 @@
9981166 if (!pfn)
9991167 break;
10001168
1001
- if (cc->nr_migratepages == COMPACT_CLUSTER_MAX)
1169
+ if (cc->nr_migratepages >= COMPACT_CLUSTER_MAX)
10021170 break;
10031171 }
10041172
....@@ -1012,6 +1180,9 @@
10121180 struct page *page)
10131181 {
10141182 int block_mt;
1183
+
1184
+ if (pageblock_skip_persistent(page))
1185
+ return false;
10151186
10161187 if ((cc->mode != MIGRATE_ASYNC) || !cc->direct_compaction)
10171188 return true;
....@@ -1035,7 +1206,7 @@
10351206 * the only small danger is that we skip a potentially suitable
10361207 * pageblock, so it's not worth to check order for valid range.
10371208 */
1038
- if (page_order_unsafe(page) >= pageblock_order)
1209
+ if (buddy_order_unsafe(page) >= pageblock_order)
10391210 return false;
10401211 }
10411212
....@@ -1050,6 +1221,14 @@
10501221 return false;
10511222 }
10521223
1224
+static inline unsigned int
1225
+freelist_scan_limit(struct compact_control *cc)
1226
+{
1227
+ unsigned short shift = BITS_PER_LONG - 1;
1228
+
1229
+ return (COMPACT_CLUSTER_MAX >> min(shift, cc->fast_search_fail)) + 1;
1230
+}
1231
+
10531232 /*
10541233 * Test whether the free scanner has reached the same or lower pageblock than
10551234 * the migration scanner, and compaction should thus terminate.
....@@ -1058,6 +1237,249 @@
10581237 {
10591238 return (cc->free_pfn >> pageblock_order)
10601239 <= (cc->migrate_pfn >> pageblock_order);
1240
+}
1241
+
1242
+/*
1243
+ * Used when scanning for a suitable migration target which scans freelists
1244
+ * in reverse. Reorders the list such as the unscanned pages are scanned
1245
+ * first on the next iteration of the free scanner
1246
+ */
1247
+static void
1248
+move_freelist_head(struct list_head *freelist, struct page *freepage)
1249
+{
1250
+ LIST_HEAD(sublist);
1251
+
1252
+ if (!list_is_last(freelist, &freepage->lru)) {
1253
+ list_cut_before(&sublist, freelist, &freepage->lru);
1254
+ if (!list_empty(&sublist))
1255
+ list_splice_tail(&sublist, freelist);
1256
+ }
1257
+}
1258
+
1259
+/*
1260
+ * Similar to move_freelist_head except used by the migration scanner
1261
+ * when scanning forward. It's possible for these list operations to
1262
+ * move against each other if they search the free list exactly in
1263
+ * lockstep.
1264
+ */
1265
+static void
1266
+move_freelist_tail(struct list_head *freelist, struct page *freepage)
1267
+{
1268
+ LIST_HEAD(sublist);
1269
+
1270
+ if (!list_is_first(freelist, &freepage->lru)) {
1271
+ list_cut_position(&sublist, freelist, &freepage->lru);
1272
+ if (!list_empty(&sublist))
1273
+ list_splice_tail(&sublist, freelist);
1274
+ }
1275
+}
1276
+
1277
+static void
1278
+fast_isolate_around(struct compact_control *cc, unsigned long pfn)
1279
+{
1280
+ unsigned long start_pfn, end_pfn;
1281
+ struct page *page;
1282
+
1283
+ /* Do not search around if there are enough pages already */
1284
+ if (cc->nr_freepages >= cc->nr_migratepages)
1285
+ return;
1286
+
1287
+ /* Minimise scanning during async compaction */
1288
+ if (cc->direct_compaction && cc->mode == MIGRATE_ASYNC)
1289
+ return;
1290
+
1291
+ /* Pageblock boundaries */
1292
+ start_pfn = max(pageblock_start_pfn(pfn), cc->zone->zone_start_pfn);
1293
+ end_pfn = min(pageblock_end_pfn(pfn), zone_end_pfn(cc->zone));
1294
+
1295
+ page = pageblock_pfn_to_page(start_pfn, end_pfn, cc->zone);
1296
+ if (!page)
1297
+ return;
1298
+
1299
+ isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false);
1300
+
1301
+ /* Skip this pageblock in the future as it's full or nearly full */
1302
+ if (cc->nr_freepages < cc->nr_migratepages)
1303
+ set_pageblock_skip(page);
1304
+
1305
+ return;
1306
+}
1307
+
1308
+/* Search orders in round-robin fashion */
1309
+static int next_search_order(struct compact_control *cc, int order)
1310
+{
1311
+ order--;
1312
+ if (order < 0)
1313
+ order = cc->order - 1;
1314
+
1315
+ /* Search wrapped around? */
1316
+ if (order == cc->search_order) {
1317
+ cc->search_order--;
1318
+ if (cc->search_order < 0)
1319
+ cc->search_order = cc->order - 1;
1320
+ return -1;
1321
+ }
1322
+
1323
+ return order;
1324
+}
1325
+
1326
+static unsigned long
1327
+fast_isolate_freepages(struct compact_control *cc)
1328
+{
1329
+ unsigned int limit = min(1U, freelist_scan_limit(cc) >> 1);
1330
+ unsigned int nr_scanned = 0;
1331
+ unsigned long low_pfn, min_pfn, highest = 0;
1332
+ unsigned long nr_isolated = 0;
1333
+ unsigned long distance;
1334
+ struct page *page = NULL;
1335
+ bool scan_start = false;
1336
+ int order;
1337
+
1338
+ /* Full compaction passes in a negative order */
1339
+ if (cc->order <= 0)
1340
+ return cc->free_pfn;
1341
+
1342
+ /*
1343
+ * If starting the scan, use a deeper search and use the highest
1344
+ * PFN found if a suitable one is not found.
1345
+ */
1346
+ if (cc->free_pfn >= cc->zone->compact_init_free_pfn) {
1347
+ limit = pageblock_nr_pages >> 1;
1348
+ scan_start = true;
1349
+ }
1350
+
1351
+ /*
1352
+ * Preferred point is in the top quarter of the scan space but take
1353
+ * a pfn from the top half if the search is problematic.
1354
+ */
1355
+ distance = (cc->free_pfn - cc->migrate_pfn);
1356
+ low_pfn = pageblock_start_pfn(cc->free_pfn - (distance >> 2));
1357
+ min_pfn = pageblock_start_pfn(cc->free_pfn - (distance >> 1));
1358
+
1359
+ if (WARN_ON_ONCE(min_pfn > low_pfn))
1360
+ low_pfn = min_pfn;
1361
+
1362
+ /*
1363
+ * Search starts from the last successful isolation order or the next
1364
+ * order to search after a previous failure
1365
+ */
1366
+ cc->search_order = min_t(unsigned int, cc->order - 1, cc->search_order);
1367
+
1368
+ for (order = cc->search_order;
1369
+ !page && order >= 0;
1370
+ order = next_search_order(cc, order)) {
1371
+ struct free_area *area = &cc->zone->free_area[order];
1372
+ struct list_head *freelist;
1373
+ struct page *freepage;
1374
+ unsigned long flags;
1375
+ unsigned int order_scanned = 0;
1376
+ unsigned long high_pfn = 0;
1377
+
1378
+ if (!area->nr_free)
1379
+ continue;
1380
+
1381
+ spin_lock_irqsave(&cc->zone->lock, flags);
1382
+ freelist = &area->free_list[MIGRATE_MOVABLE];
1383
+ list_for_each_entry_reverse(freepage, freelist, lru) {
1384
+ unsigned long pfn;
1385
+
1386
+ order_scanned++;
1387
+ nr_scanned++;
1388
+ pfn = page_to_pfn(freepage);
1389
+
1390
+ if (pfn >= highest)
1391
+ highest = max(pageblock_start_pfn(pfn),
1392
+ cc->zone->zone_start_pfn);
1393
+
1394
+ if (pfn >= low_pfn) {
1395
+ cc->fast_search_fail = 0;
1396
+ cc->search_order = order;
1397
+ page = freepage;
1398
+ break;
1399
+ }
1400
+
1401
+ if (pfn >= min_pfn && pfn > high_pfn) {
1402
+ high_pfn = pfn;
1403
+
1404
+ /* Shorten the scan if a candidate is found */
1405
+ limit >>= 1;
1406
+ }
1407
+
1408
+ if (order_scanned >= limit)
1409
+ break;
1410
+ }
1411
+
1412
+ /* Use a minimum pfn if a preferred one was not found */
1413
+ if (!page && high_pfn) {
1414
+ page = pfn_to_page(high_pfn);
1415
+
1416
+ /* Update freepage for the list reorder below */
1417
+ freepage = page;
1418
+ }
1419
+
1420
+ /* Reorder to so a future search skips recent pages */
1421
+ move_freelist_head(freelist, freepage);
1422
+
1423
+ /* Isolate the page if available */
1424
+ if (page) {
1425
+ if (__isolate_free_page(page, order)) {
1426
+ set_page_private(page, order);
1427
+ nr_isolated = 1 << order;
1428
+ cc->nr_freepages += nr_isolated;
1429
+ list_add_tail(&page->lru, &cc->freepages);
1430
+ count_compact_events(COMPACTISOLATED, nr_isolated);
1431
+ } else {
1432
+ /* If isolation fails, abort the search */
1433
+ order = cc->search_order + 1;
1434
+ page = NULL;
1435
+ }
1436
+ }
1437
+
1438
+ spin_unlock_irqrestore(&cc->zone->lock, flags);
1439
+
1440
+ /*
1441
+ * Smaller scan on next order so the total scan ig related
1442
+ * to freelist_scan_limit.
1443
+ */
1444
+ if (order_scanned >= limit)
1445
+ limit = min(1U, limit >> 1);
1446
+ }
1447
+
1448
+ if (!page) {
1449
+ cc->fast_search_fail++;
1450
+ if (scan_start) {
1451
+ /*
1452
+ * Use the highest PFN found above min. If one was
1453
+ * not found, be pessimistic for direct compaction
1454
+ * and use the min mark.
1455
+ */
1456
+ if (highest) {
1457
+ page = pfn_to_page(highest);
1458
+ cc->free_pfn = highest;
1459
+ } else {
1460
+ if (cc->direct_compaction && pfn_valid(min_pfn)) {
1461
+ page = pageblock_pfn_to_page(min_pfn,
1462
+ min(pageblock_end_pfn(min_pfn),
1463
+ zone_end_pfn(cc->zone)),
1464
+ cc->zone);
1465
+ cc->free_pfn = min_pfn;
1466
+ }
1467
+ }
1468
+ }
1469
+ }
1470
+
1471
+ if (highest && highest >= cc->zone->compact_cached_free_pfn) {
1472
+ highest -= pageblock_nr_pages;
1473
+ cc->zone->compact_cached_free_pfn = highest;
1474
+ }
1475
+
1476
+ cc->total_free_scanned += nr_scanned;
1477
+ if (!page)
1478
+ return cc->free_pfn;
1479
+
1480
+ low_pfn = page_to_pfn(page);
1481
+ fast_isolate_around(cc, low_pfn);
1482
+ return low_pfn;
10611483 }
10621484
10631485 /*
....@@ -1073,6 +1495,12 @@
10731495 unsigned long block_end_pfn; /* end of current pageblock */
10741496 unsigned long low_pfn; /* lowest pfn scanner is able to scan */
10751497 struct list_head *freelist = &cc->freepages;
1498
+ unsigned int stride;
1499
+
1500
+ /* Try a small search of the free lists for a candidate */
1501
+ isolate_start_pfn = fast_isolate_freepages(cc);
1502
+ if (cc->nr_freepages)
1503
+ goto splitmap;
10761504
10771505 /*
10781506 * Initialise the free scanner. The starting point is where we last
....@@ -1081,15 +1509,16 @@
10811509 * this pfn aligned down to the pageblock boundary, because we do
10821510 * block_start_pfn -= pageblock_nr_pages in the for loop.
10831511 * For ending point, take care when isolating in last pageblock of a
1084
- * a zone which ends in the middle of a pageblock.
1512
+ * zone which ends in the middle of a pageblock.
10851513 * The low boundary is the end of the pageblock the migration scanner
10861514 * is using.
10871515 */
10881516 isolate_start_pfn = cc->free_pfn;
1089
- block_start_pfn = pageblock_start_pfn(cc->free_pfn);
1517
+ block_start_pfn = pageblock_start_pfn(isolate_start_pfn);
10901518 block_end_pfn = min(block_start_pfn + pageblock_nr_pages,
10911519 zone_end_pfn(zone));
10921520 low_pfn = pageblock_end_pfn(cc->migrate_pfn);
1521
+ stride = cc->mode == MIGRATE_ASYNC ? COMPACT_CLUSTER_MAX : 1;
10931522
10941523 /*
10951524 * Isolate free pages until enough are available to migrate the
....@@ -1100,14 +1529,14 @@
11001529 block_end_pfn = block_start_pfn,
11011530 block_start_pfn -= pageblock_nr_pages,
11021531 isolate_start_pfn = block_start_pfn) {
1532
+ unsigned long nr_isolated;
1533
+
11031534 /*
11041535 * This can iterate a massively long zone without finding any
1105
- * suitable migration targets, so periodically check if we need
1106
- * to schedule, or even abort async compaction.
1536
+ * suitable migration targets, so periodically check resched.
11071537 */
1108
- if (!(block_start_pfn % (SWAP_CLUSTER_MAX * pageblock_nr_pages))
1109
- && compact_should_abort(cc))
1110
- break;
1538
+ if (!(block_start_pfn % (SWAP_CLUSTER_MAX * pageblock_nr_pages)))
1539
+ cond_resched();
11111540
11121541 page = pageblock_pfn_to_page(block_start_pfn, block_end_pfn,
11131542 zone);
....@@ -1123,15 +1552,15 @@
11231552 continue;
11241553
11251554 /* Found a block suitable for isolating free pages from. */
1126
- isolate_freepages_block(cc, &isolate_start_pfn, block_end_pfn,
1127
- freelist, false);
1555
+ nr_isolated = isolate_freepages_block(cc, &isolate_start_pfn,
1556
+ block_end_pfn, freelist, stride, false);
11281557
1129
- /*
1130
- * If we isolated enough freepages, or aborted due to lock
1131
- * contention, terminate.
1132
- */
1133
- if ((cc->nr_freepages >= cc->nr_migratepages)
1134
- || cc->contended) {
1558
+ /* Update the skip hint if the full pageblock was scanned */
1559
+ if (isolate_start_pfn == block_end_pfn)
1560
+ update_pageblock_skip(cc, page, block_start_pfn);
1561
+
1562
+ /* Are enough freepages isolated? */
1563
+ if (cc->nr_freepages >= cc->nr_migratepages) {
11351564 if (isolate_start_pfn >= block_end_pfn) {
11361565 /*
11371566 * Restart at previous pageblock if more
....@@ -1148,10 +1577,14 @@
11481577 */
11491578 break;
11501579 }
1151
- }
11521580
1153
- /* __isolate_free_page() does not map the pages */
1154
- map_pages(freelist);
1581
+ /* Adjust stride depending on isolation */
1582
+ if (nr_isolated) {
1583
+ stride = 1;
1584
+ continue;
1585
+ }
1586
+ stride = min_t(unsigned int, COMPACT_CLUSTER_MAX, stride << 1);
1587
+ }
11551588
11561589 /*
11571590 * Record where the free scanner will restart next time. Either we
....@@ -1160,6 +1593,10 @@
11601593 * and the loop terminated due to isolate_start_pfn < low_pfn
11611594 */
11621595 cc->free_pfn = isolate_start_pfn;
1596
+
1597
+splitmap:
1598
+ /* __isolate_free_page() does not map the pages */
1599
+ split_map_pages(freelist);
11631600 }
11641601
11651602 /*
....@@ -1172,13 +1609,8 @@
11721609 struct compact_control *cc = (struct compact_control *)data;
11731610 struct page *freepage;
11741611
1175
- /*
1176
- * Isolate free pages if necessary, and if we are not aborting due to
1177
- * contention.
1178
- */
11791612 if (list_empty(&cc->freepages)) {
1180
- if (!cc->contended)
1181
- isolate_freepages(cc);
1613
+ isolate_freepages(cc);
11821614
11831615 if (list_empty(&cc->freepages))
11841616 return NULL;
....@@ -1215,15 +1647,158 @@
12151647 * Allow userspace to control policy on scanning the unevictable LRU for
12161648 * compactable pages.
12171649 */
1650
+#ifdef CONFIG_PREEMPT_RT
1651
+int sysctl_compact_unevictable_allowed __read_mostly = 0;
1652
+#else
12181653 int sysctl_compact_unevictable_allowed __read_mostly = 1;
1654
+#endif
1655
+
1656
+static inline void
1657
+update_fast_start_pfn(struct compact_control *cc, unsigned long pfn)
1658
+{
1659
+ if (cc->fast_start_pfn == ULONG_MAX)
1660
+ return;
1661
+
1662
+ if (!cc->fast_start_pfn)
1663
+ cc->fast_start_pfn = pfn;
1664
+
1665
+ cc->fast_start_pfn = min(cc->fast_start_pfn, pfn);
1666
+}
1667
+
1668
+static inline unsigned long
1669
+reinit_migrate_pfn(struct compact_control *cc)
1670
+{
1671
+ if (!cc->fast_start_pfn || cc->fast_start_pfn == ULONG_MAX)
1672
+ return cc->migrate_pfn;
1673
+
1674
+ cc->migrate_pfn = cc->fast_start_pfn;
1675
+ cc->fast_start_pfn = ULONG_MAX;
1676
+
1677
+ return cc->migrate_pfn;
1678
+}
1679
+
1680
+/*
1681
+ * Briefly search the free lists for a migration source that already has
1682
+ * some free pages to reduce the number of pages that need migration
1683
+ * before a pageblock is free.
1684
+ */
1685
+static unsigned long fast_find_migrateblock(struct compact_control *cc)
1686
+{
1687
+ unsigned int limit = freelist_scan_limit(cc);
1688
+ unsigned int nr_scanned = 0;
1689
+ unsigned long distance;
1690
+ unsigned long pfn = cc->migrate_pfn;
1691
+ unsigned long high_pfn;
1692
+ int order;
1693
+ bool found_block = false;
1694
+
1695
+ /* Skip hints are relied on to avoid repeats on the fast search */
1696
+ if (cc->ignore_skip_hint)
1697
+ return pfn;
1698
+
1699
+ /*
1700
+ * If the migrate_pfn is not at the start of a zone or the start
1701
+ * of a pageblock then assume this is a continuation of a previous
1702
+ * scan restarted due to COMPACT_CLUSTER_MAX.
1703
+ */
1704
+ if (pfn != cc->zone->zone_start_pfn && pfn != pageblock_start_pfn(pfn))
1705
+ return pfn;
1706
+
1707
+ /*
1708
+ * For smaller orders, just linearly scan as the number of pages
1709
+ * to migrate should be relatively small and does not necessarily
1710
+ * justify freeing up a large block for a small allocation.
1711
+ */
1712
+ if (cc->order <= PAGE_ALLOC_COSTLY_ORDER)
1713
+ return pfn;
1714
+
1715
+ /*
1716
+ * Only allow kcompactd and direct requests for movable pages to
1717
+ * quickly clear out a MOVABLE pageblock for allocation. This
1718
+ * reduces the risk that a large movable pageblock is freed for
1719
+ * an unmovable/reclaimable small allocation.
1720
+ */
1721
+ if (cc->direct_compaction && cc->migratetype != MIGRATE_MOVABLE)
1722
+ return pfn;
1723
+
1724
+ /*
1725
+ * When starting the migration scanner, pick any pageblock within the
1726
+ * first half of the search space. Otherwise try and pick a pageblock
1727
+ * within the first eighth to reduce the chances that a migration
1728
+ * target later becomes a source.
1729
+ */
1730
+ distance = (cc->free_pfn - cc->migrate_pfn) >> 1;
1731
+ if (cc->migrate_pfn != cc->zone->zone_start_pfn)
1732
+ distance >>= 2;
1733
+ high_pfn = pageblock_start_pfn(cc->migrate_pfn + distance);
1734
+
1735
+ for (order = cc->order - 1;
1736
+ order >= PAGE_ALLOC_COSTLY_ORDER && !found_block && nr_scanned < limit;
1737
+ order--) {
1738
+ struct free_area *area = &cc->zone->free_area[order];
1739
+ struct list_head *freelist;
1740
+ unsigned long flags;
1741
+ struct page *freepage;
1742
+
1743
+ if (!area->nr_free)
1744
+ continue;
1745
+
1746
+ spin_lock_irqsave(&cc->zone->lock, flags);
1747
+ freelist = &area->free_list[MIGRATE_MOVABLE];
1748
+ list_for_each_entry(freepage, freelist, lru) {
1749
+ unsigned long free_pfn;
1750
+
1751
+ if (nr_scanned++ >= limit) {
1752
+ move_freelist_tail(freelist, freepage);
1753
+ break;
1754
+ }
1755
+
1756
+ free_pfn = page_to_pfn(freepage);
1757
+ if (free_pfn < high_pfn) {
1758
+ /*
1759
+ * Avoid if skipped recently. Ideally it would
1760
+ * move to the tail but even safe iteration of
1761
+ * the list assumes an entry is deleted, not
1762
+ * reordered.
1763
+ */
1764
+ if (get_pageblock_skip(freepage))
1765
+ continue;
1766
+
1767
+ /* Reorder to so a future search skips recent pages */
1768
+ move_freelist_tail(freelist, freepage);
1769
+
1770
+ update_fast_start_pfn(cc, free_pfn);
1771
+ pfn = pageblock_start_pfn(free_pfn);
1772
+ if (pfn < cc->zone->zone_start_pfn)
1773
+ pfn = cc->zone->zone_start_pfn;
1774
+ cc->fast_search_fail = 0;
1775
+ found_block = true;
1776
+ set_pageblock_skip(freepage);
1777
+ break;
1778
+ }
1779
+ }
1780
+ spin_unlock_irqrestore(&cc->zone->lock, flags);
1781
+ }
1782
+
1783
+ cc->total_migrate_scanned += nr_scanned;
1784
+
1785
+ /*
1786
+ * If fast scanning failed then use a cached entry for a page block
1787
+ * that had free pages as the basis for starting a linear scan.
1788
+ */
1789
+ if (!found_block) {
1790
+ cc->fast_search_fail++;
1791
+ pfn = reinit_migrate_pfn(cc);
1792
+ }
1793
+ return pfn;
1794
+}
12191795
12201796 /*
12211797 * Isolate all pages that can be migrated from the first suitable block,
12221798 * starting at the block pointed to by the migrate scanner pfn within
12231799 * compact_control.
12241800 */
1225
-static isolate_migrate_t isolate_migratepages(struct zone *zone,
1226
- struct compact_control *cc)
1801
+static isolate_migrate_t isolate_migratepages(struct compact_control *cc)
12271802 {
12281803 unsigned long block_start_pfn;
12291804 unsigned long block_end_pfn;
....@@ -1232,15 +1807,24 @@
12321807 const isolate_mode_t isolate_mode =
12331808 (sysctl_compact_unevictable_allowed ? ISOLATE_UNEVICTABLE : 0) |
12341809 (cc->mode != MIGRATE_SYNC ? ISOLATE_ASYNC_MIGRATE : 0);
1810
+ bool fast_find_block;
12351811
12361812 /*
12371813 * Start at where we last stopped, or beginning of the zone as
1238
- * initialized by compact_zone()
1814
+ * initialized by compact_zone(). The first failure will use
1815
+ * the lowest PFN as the starting point for linear scanning.
12391816 */
1240
- low_pfn = cc->migrate_pfn;
1817
+ low_pfn = fast_find_migrateblock(cc);
12411818 block_start_pfn = pageblock_start_pfn(low_pfn);
1242
- if (block_start_pfn < zone->zone_start_pfn)
1243
- block_start_pfn = zone->zone_start_pfn;
1819
+ if (block_start_pfn < cc->zone->zone_start_pfn)
1820
+ block_start_pfn = cc->zone->zone_start_pfn;
1821
+
1822
+ /*
1823
+ * fast_find_migrateblock marks a pageblock skipped so to avoid
1824
+ * the isolation_suitable check below, check whether the fast
1825
+ * search was successful.
1826
+ */
1827
+ fast_find_block = low_pfn != cc->migrate_pfn && !cc->fast_search_fail;
12441828
12451829 /* Only scan within a pageblock boundary */
12461830 block_end_pfn = pageblock_end_pfn(low_pfn);
....@@ -1250,6 +1834,7 @@
12501834 * Do not cross the free scanner.
12511835 */
12521836 for (; block_end_pfn <= cc->free_pfn;
1837
+ fast_find_block = false,
12531838 low_pfn = block_end_pfn,
12541839 block_start_pfn = block_end_pfn,
12551840 block_end_pfn += pageblock_nr_pages) {
....@@ -1257,34 +1842,45 @@
12571842 /*
12581843 * This can potentially iterate a massively long zone with
12591844 * many pageblocks unsuitable, so periodically check if we
1260
- * need to schedule, or even abort async compaction.
1845
+ * need to schedule.
12611846 */
1262
- if (!(low_pfn % (SWAP_CLUSTER_MAX * pageblock_nr_pages))
1263
- && compact_should_abort(cc))
1264
- break;
1847
+ if (!(low_pfn % (SWAP_CLUSTER_MAX * pageblock_nr_pages)))
1848
+ cond_resched();
12651849
1266
- page = pageblock_pfn_to_page(block_start_pfn, block_end_pfn,
1267
- zone);
1850
+ page = pageblock_pfn_to_page(block_start_pfn,
1851
+ block_end_pfn, cc->zone);
12681852 if (!page)
12691853 continue;
12701854
1271
- /* If isolation recently failed, do not retry */
1272
- if (!isolation_suitable(cc, page))
1855
+ /*
1856
+ * If isolation recently failed, do not retry. Only check the
1857
+ * pageblock once. COMPACT_CLUSTER_MAX causes a pageblock
1858
+ * to be visited multiple times. Assume skip was checked
1859
+ * before making it "skip" so other compaction instances do
1860
+ * not scan the same block.
1861
+ */
1862
+ if (IS_ALIGNED(low_pfn, pageblock_nr_pages) &&
1863
+ !fast_find_block && !isolation_suitable(cc, page))
12731864 continue;
12741865
12751866 /*
1276
- * For async compaction, also only scan in MOVABLE blocks.
1277
- * Async compaction is optimistic to see if the minimum amount
1278
- * of work satisfies the allocation.
1867
+ * For async compaction, also only scan in MOVABLE blocks
1868
+ * without huge pages. Async compaction is optimistic to see
1869
+ * if the minimum amount of work satisfies the allocation.
1870
+ * The cached PFN is updated as it's possible that all
1871
+ * remaining blocks between source and target are unsuitable
1872
+ * and the compaction scanners fail to meet.
12791873 */
1280
- if (!suitable_migration_source(cc, page))
1874
+ if (!suitable_migration_source(cc, page)) {
1875
+ update_cached_migrate(cc, block_end_pfn);
12811876 continue;
1877
+ }
12821878
12831879 /* Perform the isolation */
12841880 low_pfn = isolate_migratepages_block(cc, low_pfn,
12851881 block_end_pfn, isolate_mode);
12861882
1287
- if (!low_pfn || cc->contended)
1883
+ if (!low_pfn)
12881884 return ISOLATE_ABORT;
12891885
12901886 /*
....@@ -1310,19 +1906,95 @@
13101906 return order == -1;
13111907 }
13121908
1313
-static enum compact_result __compact_finished(struct zone *zone,
1314
- struct compact_control *cc)
1909
+static bool kswapd_is_running(pg_data_t *pgdat)
1910
+{
1911
+ return pgdat->kswapd && (pgdat->kswapd->state == TASK_RUNNING);
1912
+}
1913
+
1914
+/*
1915
+ * A zone's fragmentation score is the external fragmentation wrt to the
1916
+ * COMPACTION_HPAGE_ORDER. It returns a value in the range [0, 100].
1917
+ */
1918
+static unsigned int fragmentation_score_zone(struct zone *zone)
1919
+{
1920
+ return extfrag_for_order(zone, COMPACTION_HPAGE_ORDER);
1921
+}
1922
+
1923
+/*
1924
+ * A weighted zone's fragmentation score is the external fragmentation
1925
+ * wrt to the COMPACTION_HPAGE_ORDER scaled by the zone's size. It
1926
+ * returns a value in the range [0, 100].
1927
+ *
1928
+ * The scaling factor ensures that proactive compaction focuses on larger
1929
+ * zones like ZONE_NORMAL, rather than smaller, specialized zones like
1930
+ * ZONE_DMA32. For smaller zones, the score value remains close to zero,
1931
+ * and thus never exceeds the high threshold for proactive compaction.
1932
+ */
1933
+static unsigned int fragmentation_score_zone_weighted(struct zone *zone)
1934
+{
1935
+ unsigned long score;
1936
+
1937
+ score = zone->present_pages * fragmentation_score_zone(zone);
1938
+ return div64_ul(score, zone->zone_pgdat->node_present_pages + 1);
1939
+}
1940
+
1941
+/*
1942
+ * The per-node proactive (background) compaction process is started by its
1943
+ * corresponding kcompactd thread when the node's fragmentation score
1944
+ * exceeds the high threshold. The compaction process remains active till
1945
+ * the node's score falls below the low threshold, or one of the back-off
1946
+ * conditions is met.
1947
+ */
1948
+static unsigned int fragmentation_score_node(pg_data_t *pgdat)
1949
+{
1950
+ unsigned int score = 0;
1951
+ int zoneid;
1952
+
1953
+ for (zoneid = 0; zoneid < MAX_NR_ZONES; zoneid++) {
1954
+ struct zone *zone;
1955
+
1956
+ zone = &pgdat->node_zones[zoneid];
1957
+ score += fragmentation_score_zone_weighted(zone);
1958
+ }
1959
+
1960
+ return score;
1961
+}
1962
+
1963
+static unsigned int fragmentation_score_wmark(pg_data_t *pgdat, bool low)
1964
+{
1965
+ unsigned int wmark_low;
1966
+
1967
+ /*
1968
+ * Cap the low watermak to avoid excessive compaction
1969
+ * activity in case a user sets the proactivess tunable
1970
+ * close to 100 (maximum).
1971
+ */
1972
+ wmark_low = max(100U - sysctl_compaction_proactiveness, 5U);
1973
+ return low ? wmark_low : min(wmark_low + 10, 100U);
1974
+}
1975
+
1976
+static bool should_proactive_compact_node(pg_data_t *pgdat)
1977
+{
1978
+ int wmark_high;
1979
+
1980
+ if (!sysctl_compaction_proactiveness || kswapd_is_running(pgdat))
1981
+ return false;
1982
+
1983
+ wmark_high = fragmentation_score_wmark(pgdat, false);
1984
+ return fragmentation_score_node(pgdat) > wmark_high;
1985
+}
1986
+
1987
+static enum compact_result __compact_finished(struct compact_control *cc)
13151988 {
13161989 unsigned int order;
13171990 const int migratetype = cc->migratetype;
1318
-
1319
- if (cc->contended || fatal_signal_pending(current))
1320
- return COMPACT_CONTENDED;
1991
+ int ret;
1992
+ bool abort_compact = false;
13211993
13221994 /* Compaction run completes if the migrate and free scanner meet */
13231995 if (compact_scanners_met(cc)) {
13241996 /* Let the next compaction start anew. */
1325
- reset_cached_positions(zone);
1997
+ reset_cached_positions(cc->zone);
13261998
13271999 /*
13282000 * Mark that the PG_migrate_skip information should be cleared
....@@ -1331,7 +2003,7 @@
13312003 * based on an allocation request.
13322004 */
13332005 if (cc->direct_compaction)
1334
- zone->compact_blockskip_flush = true;
2006
+ cc->zone->compact_blockskip_flush = true;
13352007
13362008 if (cc->whole_zone)
13372009 return COMPACT_COMPLETE;
....@@ -1339,33 +2011,51 @@
13392011 return COMPACT_PARTIAL_SKIPPED;
13402012 }
13412013
2014
+ if (cc->proactive_compaction) {
2015
+ int score, wmark_low;
2016
+ pg_data_t *pgdat;
2017
+
2018
+ pgdat = cc->zone->zone_pgdat;
2019
+ if (kswapd_is_running(pgdat))
2020
+ return COMPACT_PARTIAL_SKIPPED;
2021
+
2022
+ score = fragmentation_score_zone(cc->zone);
2023
+ wmark_low = fragmentation_score_wmark(pgdat, true);
2024
+
2025
+ if (score > wmark_low)
2026
+ ret = COMPACT_CONTINUE;
2027
+ else
2028
+ ret = COMPACT_SUCCESS;
2029
+
2030
+ goto out;
2031
+ }
2032
+
13422033 if (is_via_compact_memory(cc->order))
13432034 return COMPACT_CONTINUE;
13442035
1345
- if (cc->finishing_block) {
1346
- /*
1347
- * We have finished the pageblock, but better check again that
1348
- * we really succeeded.
1349
- */
1350
- if (IS_ALIGNED(cc->migrate_pfn, pageblock_nr_pages))
1351
- cc->finishing_block = false;
1352
- else
1353
- return COMPACT_CONTINUE;
1354
- }
2036
+ /*
2037
+ * Always finish scanning a pageblock to reduce the possibility of
2038
+ * fallbacks in the future. This is particularly important when
2039
+ * migration source is unmovable/reclaimable but it's not worth
2040
+ * special casing.
2041
+ */
2042
+ if (!IS_ALIGNED(cc->migrate_pfn, pageblock_nr_pages))
2043
+ return COMPACT_CONTINUE;
13552044
13562045 /* Direct compactor: Is a suitable page free? */
2046
+ ret = COMPACT_NO_SUITABLE_PAGE;
13572047 for (order = cc->order; order < MAX_ORDER; order++) {
1358
- struct free_area *area = &zone->free_area[order];
2048
+ struct free_area *area = &cc->zone->free_area[order];
13592049 bool can_steal;
13602050
13612051 /* Job done if page is free of the right migratetype */
1362
- if (!list_empty(&area->free_list[migratetype]))
2052
+ if (!free_area_empty(area, migratetype))
13632053 return COMPACT_SUCCESS;
13642054
13652055 #ifdef CONFIG_CMA
13662056 /* MIGRATE_MOVABLE can fallback on MIGRATE_CMA */
13672057 if (migratetype == MIGRATE_MOVABLE &&
1368
- !list_empty(&area->free_list[MIGRATE_CMA]))
2058
+ !free_area_empty(area, MIGRATE_CMA))
13692059 return COMPACT_SUCCESS;
13702060 #endif
13712061 /*
....@@ -1393,21 +2083,25 @@
13932083 return COMPACT_SUCCESS;
13942084 }
13952085
1396
- cc->finishing_block = true;
1397
- return COMPACT_CONTINUE;
2086
+ ret = COMPACT_CONTINUE;
2087
+ break;
13982088 }
13992089 }
14002090
1401
- return COMPACT_NO_SUITABLE_PAGE;
2091
+out:
2092
+ trace_android_vh_compact_finished(&abort_compact);
2093
+ if (cc->contended || fatal_signal_pending(current) || abort_compact)
2094
+ ret = COMPACT_CONTENDED;
2095
+
2096
+ return ret;
14022097 }
14032098
1404
-static enum compact_result compact_finished(struct zone *zone,
1405
- struct compact_control *cc)
2099
+static enum compact_result compact_finished(struct compact_control *cc)
14062100 {
14072101 int ret;
14082102
1409
- ret = __compact_finished(zone, cc);
1410
- trace_mm_compaction_finished(zone, cc->order, ret);
2103
+ ret = __compact_finished(cc);
2104
+ trace_mm_compaction_finished(cc->zone, cc->order, ret);
14112105 if (ret == COMPACT_NO_SUITABLE_PAGE)
14122106 ret = COMPACT_CONTINUE;
14132107
....@@ -1423,7 +2117,7 @@
14232117 */
14242118 static enum compact_result __compaction_suitable(struct zone *zone, int order,
14252119 unsigned int alloc_flags,
1426
- int classzone_idx,
2120
+ int highest_zoneidx,
14272121 unsigned long wmark_target)
14282122 {
14292123 unsigned long watermark;
....@@ -1431,12 +2125,12 @@
14312125 if (is_via_compact_memory(order))
14322126 return COMPACT_CONTINUE;
14332127
1434
- watermark = zone->watermark[alloc_flags & ALLOC_WMARK_MASK];
2128
+ watermark = wmark_pages(zone, alloc_flags & ALLOC_WMARK_MASK);
14352129 /*
14362130 * If watermarks for high-order allocation are already met, there
14372131 * should be no need for compaction at all.
14382132 */
1439
- if (zone_watermark_ok(zone, order, watermark, classzone_idx,
2133
+ if (zone_watermark_ok(zone, order, watermark, highest_zoneidx,
14402134 alloc_flags))
14412135 return COMPACT_SUCCESS;
14422136
....@@ -1446,9 +2140,9 @@
14462140 * watermark and alloc_flags have to match, or be more pessimistic than
14472141 * the check in __isolate_free_page(). We don't use the direct
14482142 * compactor's alloc_flags, as they are not relevant for freepage
1449
- * isolation. We however do use the direct compactor's classzone_idx to
1450
- * skip over zones where lowmem reserves would prevent allocation even
1451
- * if compaction succeeds.
2143
+ * isolation. We however do use the direct compactor's highest_zoneidx
2144
+ * to skip over zones where lowmem reserves would prevent allocation
2145
+ * even if compaction succeeds.
14522146 * For costly orders, we require low watermark instead of min for
14532147 * compaction to proceed to increase its chances.
14542148 * ALLOC_CMA is used, as pages in CMA pageblocks are considered
....@@ -1457,7 +2151,7 @@
14572151 watermark = (order > PAGE_ALLOC_COSTLY_ORDER) ?
14582152 low_wmark_pages(zone) : min_wmark_pages(zone);
14592153 watermark += compact_gap(order);
1460
- if (!__zone_watermark_ok(zone, 0, watermark, classzone_idx,
2154
+ if (!__zone_watermark_ok(zone, 0, watermark, highest_zoneidx,
14612155 ALLOC_CMA, wmark_target))
14622156 return COMPACT_SKIPPED;
14632157
....@@ -1466,12 +2160,12 @@
14662160
14672161 enum compact_result compaction_suitable(struct zone *zone, int order,
14682162 unsigned int alloc_flags,
1469
- int classzone_idx)
2163
+ int highest_zoneidx)
14702164 {
14712165 enum compact_result ret;
14722166 int fragindex;
14732167
1474
- ret = __compaction_suitable(zone, order, alloc_flags, classzone_idx,
2168
+ ret = __compaction_suitable(zone, order, alloc_flags, highest_zoneidx,
14752169 zone_page_state(zone, NR_FREE_PAGES));
14762170 /*
14772171 * fragmentation index determines if allocation failures are due to
....@@ -1512,8 +2206,8 @@
15122206 * Make sure at least one zone would pass __compaction_suitable if we continue
15132207 * retrying the reclaim.
15142208 */
1515
- for_each_zone_zonelist_nodemask(zone, z, ac->zonelist, ac->high_zoneidx,
1516
- ac->nodemask) {
2209
+ for_each_zone_zonelist_nodemask(zone, z, ac->zonelist,
2210
+ ac->highest_zoneidx, ac->nodemask) {
15172211 unsigned long available;
15182212 enum compact_result compact_result;
15192213
....@@ -1526,7 +2220,7 @@
15262220 available = zone_reclaimable_pages(zone) / order;
15272221 available += zone_page_state_snapshot(zone, NR_FREE_PAGES);
15282222 compact_result = __compaction_suitable(zone, order, alloc_flags,
1529
- ac_classzone_idx(ac), available);
2223
+ ac->highest_zoneidx, available);
15302224 if (compact_result != COMPACT_SKIPPED)
15312225 return true;
15322226 }
....@@ -1534,12 +2228,15 @@
15342228 return false;
15352229 }
15362230
1537
-static enum compact_result compact_zone(struct zone *zone, struct compact_control *cc)
2231
+static enum compact_result
2232
+compact_zone(struct compact_control *cc, struct capture_control *capc)
15382233 {
15392234 enum compact_result ret;
1540
- unsigned long start_pfn = zone->zone_start_pfn;
1541
- unsigned long end_pfn = zone_end_pfn(zone);
2235
+ unsigned long start_pfn = cc->zone->zone_start_pfn;
2236
+ unsigned long end_pfn = zone_end_pfn(cc->zone);
2237
+ unsigned long last_migrated_pfn;
15422238 const bool sync = cc->mode != MIGRATE_ASYNC;
2239
+ bool update_cached;
15432240
15442241 /*
15452242 * These counters track activities during zone compaction. Initialize
....@@ -1552,9 +2249,9 @@
15522249 INIT_LIST_HEAD(&cc->freepages);
15532250 INIT_LIST_HEAD(&cc->migratepages);
15542251
1555
- cc->migratetype = gfpflags_to_migratetype(cc->gfp_mask);
1556
- ret = compaction_suitable(zone, cc->order, cc->alloc_flags,
1557
- cc->classzone_idx);
2252
+ cc->migratetype = gfp_migratetype(cc->gfp_mask);
2253
+ ret = compaction_suitable(cc->zone, cc->order, cc->alloc_flags,
2254
+ cc->highest_zoneidx);
15582255 /* Compaction is likely to fail */
15592256 if (ret == COMPACT_SUCCESS || ret == COMPACT_SKIPPED)
15602257 return ret;
....@@ -1566,8 +2263,8 @@
15662263 * Clear pageblock skip if there were failures recently and compaction
15672264 * is about to be retried after being deferred.
15682265 */
1569
- if (compaction_restarting(zone, cc->order))
1570
- __reset_isolation_suitable(zone);
2266
+ if (compaction_restarting(cc->zone, cc->order))
2267
+ __reset_isolation_suitable(cc->zone);
15712268
15722269 /*
15732270 * Setup to move all movable pages to the end of the zone. Used cached
....@@ -1575,43 +2272,76 @@
15752272 * want to compact the whole zone), but check that it is initialised
15762273 * by ensuring the values are within zone boundaries.
15772274 */
2275
+ cc->fast_start_pfn = 0;
15782276 if (cc->whole_zone) {
15792277 cc->migrate_pfn = start_pfn;
15802278 cc->free_pfn = pageblock_start_pfn(end_pfn - 1);
15812279 } else {
1582
- cc->migrate_pfn = zone->compact_cached_migrate_pfn[sync];
1583
- cc->free_pfn = zone->compact_cached_free_pfn;
2280
+ cc->migrate_pfn = cc->zone->compact_cached_migrate_pfn[sync];
2281
+ cc->free_pfn = cc->zone->compact_cached_free_pfn;
15842282 if (cc->free_pfn < start_pfn || cc->free_pfn >= end_pfn) {
15852283 cc->free_pfn = pageblock_start_pfn(end_pfn - 1);
1586
- zone->compact_cached_free_pfn = cc->free_pfn;
2284
+ cc->zone->compact_cached_free_pfn = cc->free_pfn;
15872285 }
15882286 if (cc->migrate_pfn < start_pfn || cc->migrate_pfn >= end_pfn) {
15892287 cc->migrate_pfn = start_pfn;
1590
- zone->compact_cached_migrate_pfn[0] = cc->migrate_pfn;
1591
- zone->compact_cached_migrate_pfn[1] = cc->migrate_pfn;
2288
+ cc->zone->compact_cached_migrate_pfn[0] = cc->migrate_pfn;
2289
+ cc->zone->compact_cached_migrate_pfn[1] = cc->migrate_pfn;
15922290 }
15932291
1594
- if (cc->migrate_pfn == start_pfn)
2292
+ if (cc->migrate_pfn <= cc->zone->compact_init_migrate_pfn)
15952293 cc->whole_zone = true;
15962294 }
15972295
1598
- cc->last_migrated_pfn = 0;
2296
+ last_migrated_pfn = 0;
2297
+
2298
+ /*
2299
+ * Migrate has separate cached PFNs for ASYNC and SYNC* migration on
2300
+ * the basis that some migrations will fail in ASYNC mode. However,
2301
+ * if the cached PFNs match and pageblocks are skipped due to having
2302
+ * no isolation candidates, then the sync state does not matter.
2303
+ * Until a pageblock with isolation candidates is found, keep the
2304
+ * cached PFNs in sync to avoid revisiting the same blocks.
2305
+ */
2306
+ update_cached = !sync &&
2307
+ cc->zone->compact_cached_migrate_pfn[0] == cc->zone->compact_cached_migrate_pfn[1];
15992308
16002309 trace_mm_compaction_begin(start_pfn, cc->migrate_pfn,
16012310 cc->free_pfn, end_pfn, sync);
16022311
1603
- migrate_prep_local();
2312
+ /* lru_add_drain_all could be expensive with involving other CPUs */
2313
+ lru_add_drain();
16042314
1605
- while ((ret = compact_finished(zone, cc)) == COMPACT_CONTINUE) {
2315
+ while ((ret = compact_finished(cc)) == COMPACT_CONTINUE) {
16062316 int err;
2317
+ unsigned long start_pfn = cc->migrate_pfn;
16072318
1608
- switch (isolate_migratepages(zone, cc)) {
2319
+ /*
2320
+ * Avoid multiple rescans which can happen if a page cannot be
2321
+ * isolated (dirty/writeback in async mode) or if the migrated
2322
+ * pages are being allocated before the pageblock is cleared.
2323
+ * The first rescan will capture the entire pageblock for
2324
+ * migration. If it fails, it'll be marked skip and scanning
2325
+ * will proceed as normal.
2326
+ */
2327
+ cc->rescan = false;
2328
+ if (pageblock_start_pfn(last_migrated_pfn) ==
2329
+ pageblock_start_pfn(start_pfn)) {
2330
+ cc->rescan = true;
2331
+ }
2332
+
2333
+ switch (isolate_migratepages(cc)) {
16092334 case ISOLATE_ABORT:
16102335 ret = COMPACT_CONTENDED;
16112336 putback_movable_pages(&cc->migratepages);
16122337 cc->nr_migratepages = 0;
16132338 goto out;
16142339 case ISOLATE_NONE:
2340
+ if (update_cached) {
2341
+ cc->zone->compact_cached_migrate_pfn[1] =
2342
+ cc->zone->compact_cached_migrate_pfn[0];
2343
+ }
2344
+
16152345 /*
16162346 * We haven't isolated and migrated anything, but
16172347 * there might still be unflushed migrations from
....@@ -1619,6 +2349,8 @@
16192349 */
16202350 goto check_drain;
16212351 case ISOLATE_SUCCESS:
2352
+ update_cached = false;
2353
+ last_migrated_pfn = start_pfn;
16222354 ;
16232355 }
16242356
....@@ -1650,8 +2382,7 @@
16502382 cc->migrate_pfn = block_end_pfn(
16512383 cc->migrate_pfn - 1, cc->order);
16522384 /* Draining pcplists is useless in this case */
1653
- cc->last_migrated_pfn = 0;
1654
-
2385
+ last_migrated_pfn = 0;
16552386 }
16562387 }
16572388
....@@ -1663,23 +2394,22 @@
16632394 * compact_finished() can detect immediately if allocation
16642395 * would succeed.
16652396 */
1666
- if (cc->order > 0 && cc->last_migrated_pfn) {
1667
- int cpu;
2397
+ if (cc->order > 0 && last_migrated_pfn) {
16682398 unsigned long current_block_start =
16692399 block_start_pfn(cc->migrate_pfn, cc->order);
16702400
1671
- if (cc->last_migrated_pfn < current_block_start) {
1672
- cpu = get_cpu_light();
1673
- local_lock_irq(swapvec_lock);
1674
- lru_add_drain_cpu(cpu);
1675
- local_unlock_irq(swapvec_lock);
1676
- drain_local_pages(zone);
1677
- put_cpu_light();
2401
+ if (last_migrated_pfn < current_block_start) {
2402
+ lru_add_drain_cpu_zone(cc->zone);
16782403 /* No more flushing until we migrate again */
1679
- cc->last_migrated_pfn = 0;
2404
+ last_migrated_pfn = 0;
16802405 }
16812406 }
16822407
2408
+ /* Stop if a page has been captured */
2409
+ if (capc && capc->page) {
2410
+ ret = COMPACT_SUCCESS;
2411
+ break;
2412
+ }
16832413 }
16842414
16852415 out:
....@@ -1698,8 +2428,8 @@
16982428 * Only go back, not forward. The cached pfn might have been
16992429 * already reset to zone end in compact_finished()
17002430 */
1701
- if (free_pfn > zone->compact_cached_free_pfn)
1702
- zone->compact_cached_free_pfn = free_pfn;
2431
+ if (free_pfn > cc->zone->compact_cached_free_pfn)
2432
+ cc->zone->compact_cached_free_pfn = free_pfn;
17032433 }
17042434
17052435 count_compact_events(COMPACTMIGRATE_SCANNED, cc->total_migrate_scanned);
....@@ -1713,27 +2443,49 @@
17132443
17142444 static enum compact_result compact_zone_order(struct zone *zone, int order,
17152445 gfp_t gfp_mask, enum compact_priority prio,
1716
- unsigned int alloc_flags, int classzone_idx)
2446
+ unsigned int alloc_flags, int highest_zoneidx,
2447
+ struct page **capture)
17172448 {
17182449 enum compact_result ret;
17192450 struct compact_control cc = {
17202451 .order = order,
2452
+ .search_order = order,
17212453 .gfp_mask = gfp_mask,
17222454 .zone = zone,
17232455 .mode = (prio == COMPACT_PRIO_ASYNC) ?
17242456 MIGRATE_ASYNC : MIGRATE_SYNC_LIGHT,
17252457 .alloc_flags = alloc_flags,
1726
- .classzone_idx = classzone_idx,
2458
+ .highest_zoneidx = highest_zoneidx,
17272459 .direct_compaction = true,
17282460 .whole_zone = (prio == MIN_COMPACT_PRIORITY),
17292461 .ignore_skip_hint = (prio == MIN_COMPACT_PRIORITY),
17302462 .ignore_block_suitable = (prio == MIN_COMPACT_PRIORITY)
17312463 };
2464
+ struct capture_control capc = {
2465
+ .cc = &cc,
2466
+ .page = NULL,
2467
+ };
17322468
1733
- ret = compact_zone(zone, &cc);
2469
+ /*
2470
+ * Make sure the structs are really initialized before we expose the
2471
+ * capture control, in case we are interrupted and the interrupt handler
2472
+ * frees a page.
2473
+ */
2474
+ barrier();
2475
+ WRITE_ONCE(current->capture_control, &capc);
2476
+
2477
+ ret = compact_zone(&cc, &capc);
17342478
17352479 VM_BUG_ON(!list_empty(&cc.freepages));
17362480 VM_BUG_ON(!list_empty(&cc.migratepages));
2481
+
2482
+ /*
2483
+ * Make sure we hide capture control first before we read the captured
2484
+ * page pointer, otherwise an interrupt could free and capture a page
2485
+ * and we would leak it.
2486
+ */
2487
+ WRITE_ONCE(current->capture_control, NULL);
2488
+ *capture = READ_ONCE(capc.page);
17372489
17382490 return ret;
17392491 }
....@@ -1747,12 +2499,13 @@
17472499 * @alloc_flags: The allocation flags of the current allocation
17482500 * @ac: The context of current allocation
17492501 * @prio: Determines how hard direct compaction should try to succeed
2502
+ * @capture: Pointer to free page created by compaction will be stored here
17502503 *
17512504 * This is the main entry point for direct page compaction.
17522505 */
17532506 enum compact_result try_to_compact_pages(gfp_t gfp_mask, unsigned int order,
17542507 unsigned int alloc_flags, const struct alloc_context *ac,
1755
- enum compact_priority prio)
2508
+ enum compact_priority prio, struct page **capture)
17562509 {
17572510 int may_perform_io = gfp_mask & __GFP_IO;
17582511 struct zoneref *z;
....@@ -1769,8 +2522,8 @@
17692522 trace_mm_compaction_try_to_compact_pages(order, gfp_mask, prio);
17702523
17712524 /* Compact each zone in the list */
1772
- for_each_zone_zonelist_nodemask(zone, z, ac->zonelist, ac->high_zoneidx,
1773
- ac->nodemask) {
2525
+ for_each_zone_zonelist_nodemask(zone, z, ac->zonelist,
2526
+ ac->highest_zoneidx, ac->nodemask) {
17742527 enum compact_result status;
17752528
17762529 if (prio > MIN_COMPACT_PRIORITY
....@@ -1780,7 +2533,7 @@
17802533 }
17812534
17822535 status = compact_zone_order(zone, order, gfp_mask, prio,
1783
- alloc_flags, ac_classzone_idx(ac));
2536
+ alloc_flags, ac->highest_zoneidx, capture);
17842537 rc = max(status, rc);
17852538
17862539 /* The allocation should succeed, stop compacting */
....@@ -1818,6 +2571,41 @@
18182571 return rc;
18192572 }
18202573
2574
+/*
2575
+ * Compact all zones within a node till each zone's fragmentation score
2576
+ * reaches within proactive compaction thresholds (as determined by the
2577
+ * proactiveness tunable).
2578
+ *
2579
+ * It is possible that the function returns before reaching score targets
2580
+ * due to various back-off conditions, such as, contention on per-node or
2581
+ * per-zone locks.
2582
+ */
2583
+static void proactive_compact_node(pg_data_t *pgdat)
2584
+{
2585
+ int zoneid;
2586
+ struct zone *zone;
2587
+ struct compact_control cc = {
2588
+ .order = -1,
2589
+ .mode = MIGRATE_SYNC_LIGHT,
2590
+ .ignore_skip_hint = true,
2591
+ .whole_zone = true,
2592
+ .gfp_mask = GFP_KERNEL,
2593
+ .proactive_compaction = true,
2594
+ };
2595
+
2596
+ for (zoneid = 0; zoneid < MAX_NR_ZONES; zoneid++) {
2597
+ zone = &pgdat->node_zones[zoneid];
2598
+ if (!populated_zone(zone))
2599
+ continue;
2600
+
2601
+ cc.zone = zone;
2602
+
2603
+ compact_zone(&cc, NULL);
2604
+
2605
+ VM_BUG_ON(!list_empty(&cc.freepages));
2606
+ VM_BUG_ON(!list_empty(&cc.migratepages));
2607
+ }
2608
+}
18212609
18222610 /* Compact all zones within a node */
18232611 static void compact_node(int nid)
....@@ -1842,7 +2630,7 @@
18422630
18432631 cc.zone = zone;
18442632
1845
- compact_zone(zone, &cc);
2633
+ compact_zone(&cc, NULL);
18462634
18472635 VM_BUG_ON(!list_empty(&cc.freepages));
18482636 VM_BUG_ON(!list_empty(&cc.migratepages));
....@@ -1865,22 +2653,45 @@
18652653 int sysctl_compact_memory;
18662654
18672655 /*
1868
- * This is the entry point for compacting all nodes via
1869
- * /proc/sys/vm/compact_memory
2656
+ * Tunable for proactive compaction. It determines how
2657
+ * aggressively the kernel should compact memory in the
2658
+ * background. It takes values in the range [0, 100].
18702659 */
1871
-int sysctl_compaction_handler(struct ctl_table *table, int write,
1872
- void __user *buffer, size_t *length, loff_t *ppos)
2660
+unsigned int __read_mostly sysctl_compaction_proactiveness = 20;
2661
+
2662
+int compaction_proactiveness_sysctl_handler(struct ctl_table *table, int write,
2663
+ void *buffer, size_t *length, loff_t *ppos)
18732664 {
1874
- if (write)
1875
- compact_nodes();
2665
+ int rc, nid;
2666
+
2667
+ rc = proc_dointvec_minmax(table, write, buffer, length, ppos);
2668
+ if (rc)
2669
+ return rc;
2670
+
2671
+ if (write && sysctl_compaction_proactiveness) {
2672
+ for_each_online_node(nid) {
2673
+ pg_data_t *pgdat = NODE_DATA(nid);
2674
+
2675
+ if (pgdat->proactive_compact_trigger)
2676
+ continue;
2677
+
2678
+ pgdat->proactive_compact_trigger = true;
2679
+ wake_up_interruptible(&pgdat->kcompactd_wait);
2680
+ }
2681
+ }
18762682
18772683 return 0;
18782684 }
18792685
1880
-int sysctl_extfrag_handler(struct ctl_table *table, int write,
1881
- void __user *buffer, size_t *length, loff_t *ppos)
2686
+/*
2687
+ * This is the entry point for compacting all nodes via
2688
+ * /proc/sys/vm/compact_memory
2689
+ */
2690
+int sysctl_compaction_handler(struct ctl_table *table, int write,
2691
+ void *buffer, size_t *length, loff_t *ppos)
18822692 {
1883
- proc_dointvec_minmax(table, write, buffer, length, ppos);
2693
+ if (write)
2694
+ compact_nodes();
18842695
18852696 return 0;
18862697 }
....@@ -1916,23 +2727,24 @@
19162727
19172728 static inline bool kcompactd_work_requested(pg_data_t *pgdat)
19182729 {
1919
- return pgdat->kcompactd_max_order > 0 || kthread_should_stop();
2730
+ return pgdat->kcompactd_max_order > 0 || kthread_should_stop() ||
2731
+ pgdat->proactive_compact_trigger;
19202732 }
19212733
19222734 static bool kcompactd_node_suitable(pg_data_t *pgdat)
19232735 {
19242736 int zoneid;
19252737 struct zone *zone;
1926
- enum zone_type classzone_idx = pgdat->kcompactd_classzone_idx;
2738
+ enum zone_type highest_zoneidx = pgdat->kcompactd_highest_zoneidx;
19272739
1928
- for (zoneid = 0; zoneid <= classzone_idx; zoneid++) {
2740
+ for (zoneid = 0; zoneid <= highest_zoneidx; zoneid++) {
19292741 zone = &pgdat->node_zones[zoneid];
19302742
19312743 if (!populated_zone(zone))
19322744 continue;
19332745
19342746 if (compaction_suitable(zone, pgdat->kcompactd_max_order, 0,
1935
- classzone_idx) == COMPACT_CONTINUE)
2747
+ highest_zoneidx) == COMPACT_CONTINUE)
19362748 return true;
19372749 }
19382750
....@@ -1949,16 +2761,17 @@
19492761 struct zone *zone;
19502762 struct compact_control cc = {
19512763 .order = pgdat->kcompactd_max_order,
1952
- .classzone_idx = pgdat->kcompactd_classzone_idx,
2764
+ .search_order = pgdat->kcompactd_max_order,
2765
+ .highest_zoneidx = pgdat->kcompactd_highest_zoneidx,
19532766 .mode = MIGRATE_SYNC_LIGHT,
19542767 .ignore_skip_hint = false,
19552768 .gfp_mask = GFP_KERNEL,
19562769 };
19572770 trace_mm_compaction_kcompactd_wake(pgdat->node_id, cc.order,
1958
- cc.classzone_idx);
2771
+ cc.highest_zoneidx);
19592772 count_compact_event(KCOMPACTD_WAKE);
19602773
1961
- for (zoneid = 0; zoneid <= cc.classzone_idx; zoneid++) {
2774
+ for (zoneid = 0; zoneid <= cc.highest_zoneidx; zoneid++) {
19622775 int status;
19632776
19642777 zone = &pgdat->node_zones[zoneid];
....@@ -1976,7 +2789,7 @@
19762789 return;
19772790
19782791 cc.zone = zone;
1979
- status = compact_zone(zone, &cc);
2792
+ status = compact_zone(&cc, NULL);
19802793
19812794 if (status == COMPACT_SUCCESS) {
19822795 compaction_defer_reset(zone, cc.order, false);
....@@ -2007,16 +2820,16 @@
20072820
20082821 /*
20092822 * Regardless of success, we are done until woken up next. But remember
2010
- * the requested order/classzone_idx in case it was higher/tighter than
2011
- * our current ones
2823
+ * the requested order/highest_zoneidx in case it was higher/tighter
2824
+ * than our current ones
20122825 */
20132826 if (pgdat->kcompactd_max_order <= cc.order)
20142827 pgdat->kcompactd_max_order = 0;
2015
- if (pgdat->kcompactd_classzone_idx >= cc.classzone_idx)
2016
- pgdat->kcompactd_classzone_idx = pgdat->nr_zones - 1;
2828
+ if (pgdat->kcompactd_highest_zoneidx >= cc.highest_zoneidx)
2829
+ pgdat->kcompactd_highest_zoneidx = pgdat->nr_zones - 1;
20172830 }
20182831
2019
-void wakeup_kcompactd(pg_data_t *pgdat, int order, int classzone_idx)
2832
+void wakeup_kcompactd(pg_data_t *pgdat, int order, int highest_zoneidx)
20202833 {
20212834 if (!order)
20222835 return;
....@@ -2024,8 +2837,8 @@
20242837 if (pgdat->kcompactd_max_order < order)
20252838 pgdat->kcompactd_max_order = order;
20262839
2027
- if (pgdat->kcompactd_classzone_idx > classzone_idx)
2028
- pgdat->kcompactd_classzone_idx = classzone_idx;
2840
+ if (pgdat->kcompactd_highest_zoneidx > highest_zoneidx)
2841
+ pgdat->kcompactd_highest_zoneidx = highest_zoneidx;
20292842
20302843 /*
20312844 * Pairs with implicit barrier in wait_event_freezable()
....@@ -2038,7 +2851,7 @@
20382851 return;
20392852
20402853 trace_mm_compaction_wakeup_kcompactd(pgdat->node_id, order,
2041
- classzone_idx);
2854
+ highest_zoneidx);
20422855 wake_up_interruptible(&pgdat->kcompactd_wait);
20432856 }
20442857
....@@ -2050,6 +2863,7 @@
20502863 {
20512864 pg_data_t *pgdat = (pg_data_t*)p;
20522865 struct task_struct *tsk = current;
2866
+ unsigned int proactive_defer = 0;
20532867
20542868 const struct cpumask *cpumask = cpumask_of_node(pgdat->node_id);
20552869
....@@ -2059,18 +2873,56 @@
20592873 set_freezable();
20602874
20612875 pgdat->kcompactd_max_order = 0;
2062
- pgdat->kcompactd_classzone_idx = pgdat->nr_zones - 1;
2876
+ pgdat->kcompactd_highest_zoneidx = pgdat->nr_zones - 1;
20632877
20642878 while (!kthread_should_stop()) {
20652879 unsigned long pflags;
2880
+ long timeout;
20662881
2882
+ timeout = sysctl_compaction_proactiveness ?
2883
+ msecs_to_jiffies(HPAGE_FRAG_CHECK_INTERVAL_MSEC) :
2884
+ MAX_SCHEDULE_TIMEOUT;
20672885 trace_mm_compaction_kcompactd_sleep(pgdat->node_id);
2068
- wait_event_freezable(pgdat->kcompactd_wait,
2069
- kcompactd_work_requested(pgdat));
2886
+ if (wait_event_freezable_timeout(pgdat->kcompactd_wait,
2887
+ kcompactd_work_requested(pgdat), timeout) &&
2888
+ !pgdat->proactive_compact_trigger) {
20702889
2071
- psi_memstall_enter(&pflags);
2072
- kcompactd_do_work(pgdat);
2073
- psi_memstall_leave(&pflags);
2890
+ psi_memstall_enter(&pflags);
2891
+ kcompactd_do_work(pgdat);
2892
+ psi_memstall_leave(&pflags);
2893
+ continue;
2894
+ }
2895
+
2896
+ /* kcompactd wait timeout */
2897
+ if (should_proactive_compact_node(pgdat)) {
2898
+ unsigned int prev_score, score;
2899
+
2900
+ /*
2901
+ * On wakeup of proactive compaction by sysctl
2902
+ * write, ignore the accumulated defer score.
2903
+ * Anyway, if the proactive compaction didn't
2904
+ * make any progress for the new value, it will
2905
+ * be further deferred by 2^COMPACT_MAX_DEFER_SHIFT
2906
+ * times.
2907
+ */
2908
+ if (proactive_defer &&
2909
+ !pgdat->proactive_compact_trigger) {
2910
+ proactive_defer--;
2911
+ continue;
2912
+ }
2913
+
2914
+ prev_score = fragmentation_score_node(pgdat);
2915
+ proactive_compact_node(pgdat);
2916
+ score = fragmentation_score_node(pgdat);
2917
+ /*
2918
+ * Defer proactive compaction if the fragmentation
2919
+ * score did not go down i.e. no progress made.
2920
+ */
2921
+ proactive_defer = score < prev_score ?
2922
+ 0 : 1 << COMPACT_MAX_DEFER_SHIFT;
2923
+ }
2924
+ if (pgdat->proactive_compact_trigger)
2925
+ pgdat->proactive_compact_trigger = false;
20742926 }
20752927
20762928 return 0;