forked from ~ljy/RK356X_SDK_RELEASE

blame | history | patch | commit | commitdiff
hc
2024-02-20 102a0743326a03cd1a1202ceda21e175b7d3575c 
 kernel/drivers/video/fbdev/smscufx.c
....@@ -1,3 +1,4 @@
1
+// SPDX-License-Identifier: GPL-2.0-only
12 /*
23  * smscufx.c -- Framebuffer driver for SMSC UFX USB controller
34  *
....@@ -5,10 +6,6 @@
56  * Copyright (C) 2009 Roberto De Ioris <roberto@unbit.it>
67  * Copyright (C) 2009 Jaya Kumar <jayakumar.lkml@gmail.com>
78  * Copyright (C) 2009 Bernie Thompson <bernie@plugable.com>
8
- *
9
- * This file is subject to the terms and conditions of the GNU General Public
10
- * License v2. See the file COPYING in the main directory of this archive for
11
- * more details.
129  *
1310  * Based on udlfb, with work from Florian Echtler, Henrik Bjerregaard Pedersen,
1411  * and others.
....@@ -100,7 +97,6 @@
10097 	struct kref kref;
10198 	int fb_count;
10299 	bool virtualized; /* true when physical usb device not present */
103
-	struct delayed_work free_framebuffer_work;
104100 	atomic_t usb_active; /* 0 = update virtual buffer, but no usb traffic */
105101 	atomic_t lost_pixels; /* 1 = a render op failed. Need screen refresh */
106102 	u8 *edid; /* null until we read edid from hw or get from sysfs */
....@@ -139,6 +135,8 @@
139135 static int ufx_submit_urb(struct ufx_data *dev, struct urb * urb, size_t len);
140136 static int ufx_alloc_urb_list(struct ufx_data *dev, int count, size_t size);
141137 static void ufx_free_urb_list(struct ufx_data *dev);
138
+
139
+static DEFINE_MUTEX(disconnect_mutex);
142140 
143141 /* reads a control register */
144142 static int ufx_reg_read(struct ufx_data *dev, u32 index, u32 *data)
....@@ -1073,9 +1071,13 @@
10731071 	if (user == 0 && !console)
10741072 		return -EBUSY;
10751073 
1074
+	mutex_lock(&disconnect_mutex);
1075
+
10761076 	/* If the USB device is gone, we don't accept new opens */
1077
-	if (dev->virtualized)
1077
+	if (dev->virtualized) {
1078
+		mutex_unlock(&disconnect_mutex);
10781079 		return -ENODEV;
1080
+	}
10791081 
10801082 	dev->fb_count++;
10811083 
....@@ -1099,6 +1101,8 @@
10991101 	pr_debug("open /dev/fb%d user=%d fb_info=%p count=%d",
11001102 		info->node, user, info, dev->fb_count);
11011103 
1104
+	mutex_unlock(&disconnect_mutex);
1105
+
11021106 	return 0;
11031107 }
11041108 
....@@ -1111,14 +1115,23 @@
11111115 {
11121116 	struct ufx_data *dev = container_of(kref, struct ufx_data, kref);
11131117 
1114
-	/* this function will wait for all in-flight urbs to complete */
1115
-	if (dev->urbs.count > 0)
1116
-		ufx_free_urb_list(dev);
1117
-
1118
-	pr_debug("freeing ufx_data %p", dev);
1119
-
11201118 	kfree(dev);
11211119 }
1120
+
1121
+static void ufx_ops_destory(struct fb_info *info)
1122
+{
1123
+	struct ufx_data *dev = info->par;
1124
+	int node = info->node;
1125
+
1126
+	/* Assume info structure is freed after this point */
1127
+	framebuffer_release(info);
1128
+
1129
+	pr_debug("fb_info for /dev/fb%d has been freed", node);
1130
+
1131
+	/* release reference taken by kref_init in probe() */
1132
+	kref_put(&dev->kref, ufx_free);
1133
+}
1134
+
11221135 
11231136 static void ufx_release_urb_work(struct work_struct *work)
11241137 {
....@@ -1128,14 +1141,9 @@
11281141 	up(&unode->dev->urbs.limit_sem);
11291142 }
11301143 
1131
-static void ufx_free_framebuffer_work(struct work_struct *work)
1144
+static void ufx_free_framebuffer(struct ufx_data *dev)
11321145 {
1133
-	struct ufx_data *dev = container_of(work, struct ufx_data,
1134
-					    free_framebuffer_work.work);
11351146 	struct fb_info *info = dev->info;
1136
-	int node = info->node;
1137
-
1138
-	unregister_framebuffer(info);
11391147 
11401148 	if (info->cmap.len != 0)
11411149 		fb_dealloc_cmap(&info->cmap);
....@@ -1146,11 +1154,6 @@
11461154 	fb_destroy_modelist(&info->modelist);
11471155 
11481156 	dev->info = NULL;
1149
-
1150
-	/* Assume info structure is freed after this point */
1151
-	framebuffer_release(info);
1152
-
1153
-	pr_debug("fb_info for /dev/fb%d has been freed", node);
11541157 
11551158 	/* ref taken in probe() as part of registering framebfufer */
11561159 	kref_put(&dev->kref, ufx_free);
....@@ -1163,23 +1166,26 @@
11631166 {
11641167 	struct ufx_data *dev = info->par;
11651168 
1169
+	mutex_lock(&disconnect_mutex);
1170
+
11661171 	dev->fb_count--;
11671172 
11681173 	/* We can't free fb_info here - fbmem will touch it when we return */
11691174 	if (dev->virtualized && (dev->fb_count == 0))
1170
-		schedule_delayed_work(&dev->free_framebuffer_work, HZ);
1175
+		ufx_free_framebuffer(dev);
11711176 
11721177 	if ((dev->fb_count == 0) && (info->fbdefio)) {
11731178 		fb_deferred_io_cleanup(info);
11741179 		kfree(info->fbdefio);
11751180 		info->fbdefio = NULL;
1176
-		info->fbops->fb_mmap = ufx_ops_mmap;
11771181 	}
11781182 
11791183 	pr_debug("released /dev/fb%d user=%d count=%d",
11801184 		  info->node, user, dev->fb_count);
11811185 
11821186 	kref_put(&dev->kref, ufx_free);
1187
+
1188
+	mutex_unlock(&disconnect_mutex);
11831189 
11841190 	return 0;
11851191 }
....@@ -1272,7 +1278,7 @@
12721278 	return 0;
12731279 }
12741280 
1275
-static struct fb_ops ufx_ops = {
1281
+static const struct fb_ops ufx_ops = {
12761282 	.owner = THIS_MODULE,
12771283 	.fb_read = fb_sys_read,
12781284 	.fb_write = ufx_ops_write,
....@@ -1287,6 +1293,7 @@
12871293 	.fb_blank = ufx_ops_blank,
12881294 	.fb_check_var = ufx_ops_check_var,
12891295 	.fb_set_par = ufx_ops_set_par,
1296
+	.fb_destroy = ufx_ops_destory,
12901297 };
12911298 
12921299 /* Assumes &info->lock held by caller
....@@ -1614,7 +1621,7 @@
16141621 	struct usb_device *usbdev;
16151622 	struct ufx_data *dev;
16161623 	struct fb_info *info;
1617
-	int retval;
1624
+	int retval = -ENOMEM;
16181625 	u32 id_rev, fpga_rev;
16191626 
16201627 	/* usb initialization */
....@@ -1646,7 +1653,7 @@
16461653 
16471654 	if (!ufx_alloc_urb_list(dev, WRITES_IN_FLIGHT, MAX_TRANSFER)) {
16481655 		dev_err(dev->gdev, "ufx_alloc_urb_list failed\n");
1649
-		goto e_nomem;
1656
+		goto put_ref;
16501657 	}
16511658 
16521659 	/* We don't register a new USB class. Our client interface is fbdev */
....@@ -1655,24 +1662,20 @@
16551662 	info = framebuffer_alloc(0, &usbdev->dev);
16561663 	if (!info) {
16571664 		dev_err(dev->gdev, "framebuffer_alloc failed\n");
1658
-		goto e_nomem;
1665
+		goto free_urb_list;
16591666 	}
16601667 
16611668 	dev->info = info;
16621669 	info->par = dev;
16631670 	info->pseudo_palette = dev->pseudo_palette;
16641671 	info->fbops = &ufx_ops;
1672
+	INIT_LIST_HEAD(&info->modelist);
16651673 
16661674 	retval = fb_alloc_cmap(&info->cmap, 256, 0);
16671675 	if (retval < 0) {
16681676 		dev_err(dev->gdev, "fb_alloc_cmap failed %x\n", retval);
16691677 		goto destroy_modedb;
16701678 	}
1671
-
1672
-	INIT_DELAYED_WORK(&dev->free_framebuffer_work,
1673
-			  ufx_free_framebuffer_work);
1674
-
1675
-	INIT_LIST_HEAD(&info->modelist);
16761679 
16771680 	retval = ufx_reg_read(dev, 0x3000, &id_rev);
16781681 	check_warn_goto_error(retval, "error %d reading 0x3000 register from device", retval);
....@@ -1703,22 +1706,34 @@
17031706 	check_warn_goto_error(retval, "unable to find common mode for display and adapter");
17041707 
17051708 	retval = ufx_reg_set_bits(dev, 0x4000, 0x00000001);
1706
-	check_warn_goto_error(retval, "error %d enabling graphics engine", retval);
1709
+	if (retval < 0) {
1710
+		dev_err(dev->gdev, "error %d enabling graphics engine", retval);
1711
+		goto setup_modes;
1712
+	}
17071713 
17081714 	/* ready to begin using device */
17091715 	atomic_set(&dev->usb_active, 1);
17101716 
17111717 	dev_dbg(dev->gdev, "checking var");
17121718 	retval = ufx_ops_check_var(&info->var, info);
1713
-	check_warn_goto_error(retval, "error %d ufx_ops_check_var", retval);
1719
+	if (retval < 0) {
1720
+		dev_err(dev->gdev, "error %d ufx_ops_check_var", retval);
1721
+		goto reset_active;
1722
+	}
17141723 
17151724 	dev_dbg(dev->gdev, "setting par");
17161725 	retval = ufx_ops_set_par(info);
1717
-	check_warn_goto_error(retval, "error %d ufx_ops_set_par", retval);
1726
+	if (retval < 0) {
1727
+		dev_err(dev->gdev, "error %d ufx_ops_set_par", retval);
1728
+		goto reset_active;
1729
+	}
17181730 
17191731 	dev_dbg(dev->gdev, "registering framebuffer");
17201732 	retval = register_framebuffer(info);
1721
-	check_warn_goto_error(retval, "error %d register_framebuffer", retval);
1733
+	if (retval < 0) {
1734
+		dev_err(dev->gdev, "error %d register_framebuffer", retval);
1735
+		goto reset_active;
1736
+	}
17221737 
17231738 	dev_info(dev->gdev, "SMSC UDX USB device /dev/fb%d attached. %dx%d resolution."
17241739 		" Using %dK framebuffer memory\n", info->node,
....@@ -1726,28 +1741,34 @@
17261741 
17271742 	return 0;
17281743 
1729
-error:
1730
-	fb_dealloc_cmap(&info->cmap);
1731
-destroy_modedb:
1744
+reset_active:
1745
+	atomic_set(&dev->usb_active, 0);
1746
+setup_modes:
17321747 	fb_destroy_modedb(info->monspecs.modedb);
17331748 	vfree(info->screen_base);
17341749 	fb_destroy_modelist(&info->modelist);
1750
+error:
1751
+	fb_dealloc_cmap(&info->cmap);
1752
+destroy_modedb:
17351753 	framebuffer_release(info);
1754
+free_urb_list:
1755
+	if (dev->urbs.count > 0)
1756
+		ufx_free_urb_list(dev);
17361757 put_ref:
17371758 	kref_put(&dev->kref, ufx_free); /* ref for framebuffer */
17381759 	kref_put(&dev->kref, ufx_free); /* last ref from kref_init */
17391760 	return retval;
1740
-
1741
-e_nomem:
1742
-	retval = -ENOMEM;
1743
-	goto put_ref;
17441761 }
17451762 
17461763 static void ufx_usb_disconnect(struct usb_interface *interface)
17471764 {
17481765 	struct ufx_data *dev;
1766
+	struct fb_info *info;
1767
+
1768
+	mutex_lock(&disconnect_mutex);
17491769 
17501770 	dev = usb_get_intfdata(interface);
1771
+	info = dev->info;
17511772 
17521773 	pr_debug("USB disconnect starting\n");
17531774 
....@@ -1761,12 +1782,17 @@
17611782 
17621783 	/* if clients still have us open, will be freed on last close */
17631784 	if (dev->fb_count == 0)
1764
-		schedule_delayed_work(&dev->free_framebuffer_work, 0);
1785
+		ufx_free_framebuffer(dev);
17651786 
1766
-	/* release reference taken by kref_init in probe() */
1767
-	kref_put(&dev->kref, ufx_free);
1787
+	/* this function will wait for all in-flight urbs to complete */
1788
+	if (dev->urbs.count > 0)
1789
+		ufx_free_urb_list(dev);
17681790 
1769
-	/* consider ufx_data freed */
1791
+	pr_debug("freeing ufx_data %p", dev);
1792
+
1793
+	unregister_framebuffer(info);
1794
+
1795
+	mutex_unlock(&disconnect_mutex);
17701796 }
17711797 
17721798 static struct usb_driver ufx_driver = {