hc
2024-02-20 102a0743326a03cd1a1202ceda21e175b7d3575c
kernel/drivers/tty/nozomi.c
....@@ -301,7 +301,7 @@
301301 unsigned int DCD:1;
302302 unsigned int RI:1;
303303 unsigned int CTS:1;
304
- unsigned int reserverd:4;
304
+ unsigned int reserved:4;
305305 u8 port;
306306 } __attribute__ ((packed));
307307
....@@ -839,40 +839,39 @@
839839 static char buf[TMP_BUF_MAX];
840840 char *p = buf;
841841
842
- interrupt & MDM_DL1 ? p += snprintf(p, TMP_BUF_MAX, "MDM_DL1 ") : NULL;
843
- interrupt & MDM_DL2 ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
844
- "MDM_DL2 ") : NULL;
842
+ if (interrupt & MDM_DL1)
843
+ p += scnprintf(p, TMP_BUF_MAX, "MDM_DL1 ");
844
+ if (interrupt & MDM_DL2)
845
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "MDM_DL2 ");
846
+ if (interrupt & MDM_UL1)
847
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "MDM_UL1 ");
848
+ if (interrupt & MDM_UL2)
849
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "MDM_UL2 ");
850
+ if (interrupt & DIAG_DL1)
851
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "DIAG_DL1 ");
852
+ if (interrupt & DIAG_DL2)
853
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "DIAG_DL2 ");
845854
846
- interrupt & MDM_UL1 ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
847
- "MDM_UL1 ") : NULL;
848
- interrupt & MDM_UL2 ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
849
- "MDM_UL2 ") : NULL;
855
+ if (interrupt & DIAG_UL)
856
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "DIAG_UL ");
850857
851
- interrupt & DIAG_DL1 ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
852
- "DIAG_DL1 ") : NULL;
853
- interrupt & DIAG_DL2 ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
854
- "DIAG_DL2 ") : NULL;
858
+ if (interrupt & APP1_DL)
859
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "APP1_DL ");
860
+ if (interrupt & APP2_DL)
861
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "APP2_DL ");
855862
856
- interrupt & DIAG_UL ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
857
- "DIAG_UL ") : NULL;
863
+ if (interrupt & APP1_UL)
864
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "APP1_UL ");
865
+ if (interrupt & APP2_UL)
866
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "APP2_UL ");
858867
859
- interrupt & APP1_DL ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
860
- "APP1_DL ") : NULL;
861
- interrupt & APP2_DL ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
862
- "APP2_DL ") : NULL;
868
+ if (interrupt & CTRL_DL)
869
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "CTRL_DL ");
870
+ if (interrupt & CTRL_UL)
871
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "CTRL_UL ");
863872
864
- interrupt & APP1_UL ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
865
- "APP1_UL ") : NULL;
866
- interrupt & APP2_UL ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
867
- "APP2_UL ") : NULL;
868
-
869
- interrupt & CTRL_DL ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
870
- "CTRL_DL ") : NULL;
871
- interrupt & CTRL_UL ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
872
- "CTRL_UL ") : NULL;
873
-
874
- interrupt & RESET ? p += snprintf(p, TMP_BUF_MAX - (p - buf),
875
- "RESET ") : NULL;
873
+ if (interrupt & RESET)
874
+ p += scnprintf(p, TMP_BUF_MAX - (p - buf), "RESET ");
876875
877876 return buf;
878877 }
....@@ -1282,7 +1281,7 @@
12821281 static ssize_t card_type_show(struct device *dev, struct device_attribute *attr,
12831282 char *buf)
12841283 {
1285
- const struct nozomi *dc = pci_get_drvdata(to_pci_dev(dev));
1284
+ const struct nozomi *dc = dev_get_drvdata(dev);
12861285
12871286 return sprintf(buf, "%d\n", dc->card_type);
12881287 }
....@@ -1291,7 +1290,7 @@
12911290 static ssize_t open_ttys_show(struct device *dev, struct device_attribute *attr,
12921291 char *buf)
12931292 {
1294
- const struct nozomi *dc = pci_get_drvdata(to_pci_dev(dev));
1293
+ const struct nozomi *dc = dev_get_drvdata(dev);
12951294
12961295 return sprintf(buf, "%u\n", dc->open_ttys);
12971296 }
....@@ -1317,7 +1316,6 @@
13171316 static int nozomi_card_init(struct pci_dev *pdev,
13181317 const struct pci_device_id *ent)
13191318 {
1320
- resource_size_t start;
13211319 int ret;
13221320 struct nozomi *dc = NULL;
13231321 int ndev_idx;
....@@ -1357,17 +1355,10 @@
13571355 goto err_disable_device;
13581356 }
13591357
1360
- start = pci_resource_start(dc->pdev, 0);
1361
- if (start == 0) {
1362
- dev_err(&pdev->dev, "No I/O address for card detected\n");
1363
- ret = -ENODEV;
1364
- goto err_rel_regs;
1365
- }
1366
-
13671358 /* Find out what card type it is */
13681359 nozomi_get_card_type(dc);
13691360
1370
- dc->base_addr = ioremap_nocache(start, dc->card_type);
1361
+ dc->base_addr = pci_iomap(dc->pdev, 0, dc->card_type);
13711362 if (!dc->base_addr) {
13721363 dev_err(&pdev->dev, "Unable to map card MMIO\n");
13731364 ret = -ENODEV;