hc
2024-02-20 102a0743326a03cd1a1202ceda21e175b7d3575c
kernel/drivers/s390/net/ctcm_mpc.c
....@@ -357,6 +357,7 @@
357357 /*fsm_newstate(grp->fsm, MPCG_STATE_XID2INITW);*/
358358 if (callback)
359359 grp->send_qllc_disc = 1;
360
+ fallthrough;
360361 case MPCG_STATE_XID0IOWAIT:
361362 fsm_deltimer(&grp->timer);
362363 grp->outstanding_xid2 = 0;
....@@ -624,8 +625,6 @@
624625 ch->th_seq_num = 0x00;
625626 ctcm_clear_busy_do(dev);
626627 }
627
-
628
- kfree(mpcginfo);
629628
630629 return;
631630
....@@ -1205,10 +1204,10 @@
12051204 CTCM_FUNTAIL, dev->name);
12061205 priv->stats.rx_dropped++;
12071206 /* mpcginfo only used for non-data transfers */
1208
- kfree(mpcginfo);
12091207 if (do_debug_data)
12101208 ctcmpc_dump_skb(pskb, -8);
12111209 }
1210
+ kfree(mpcginfo);
12121211 }
12131212 done:
12141213
....@@ -1469,6 +1468,7 @@
14691468 if ((fsm_getstate(rch->fsm) == CH_XID0_PENDING) &&
14701469 (fsm_getstate(wch->fsm) == CH_XID0_PENDING))
14711470 break;
1471
+ fallthrough;
14721472 default:
14731473 fsm_event(grp->fsm, MPCG_EVENT_INOP, dev);
14741474 }
....@@ -1521,8 +1521,7 @@
15211521 unsigned long saveflags = 0;
15221522
15231523 spin_lock_irqsave(get_ccwdev_lock(ch->cdev), saveflags);
1524
- rc = ccw_device_start(ch->cdev, &ch->ccw[15],
1525
- (unsigned long)ch, 0xff, 0);
1524
+ rc = ccw_device_start(ch->cdev, &ch->ccw[15], 0, 0xff, 0);
15261525 spin_unlock_irqrestore(get_ccwdev_lock(ch->cdev), saveflags);
15271526
15281527 if (rc != 0) {
....@@ -1795,8 +1794,7 @@
17951794 }
17961795
17971796 fsm_addtimer(&ch->timer, 5000 , CTC_EVENT_TIMER, ch);
1798
- rc = ccw_device_start(ch->cdev, &ch->ccw[8],
1799
- (unsigned long)ch, 0xff, 0);
1797
+ rc = ccw_device_start(ch->cdev, &ch->ccw[8], 0, 0xff, 0);
18001798
18011799 if (gotlock) /* see remark above about conditional locking */
18021800 spin_unlock_irqrestore(get_ccwdev_lock(ch->cdev), saveflags);
....@@ -1991,7 +1989,6 @@
19911989 }
19921990 break;
19931991 }
1994
- kfree(mpcginfo);
19951992
19961993 CTCM_PR_DEBUG("ctcmpc:%s() %s xid2:%i xid7:%i xidt_p2:%i \n",
19971994 __func__, ch->id, grp->outstanding_xid2,
....@@ -2052,7 +2049,6 @@
20522049 mpc_validate_xid(mpcginfo);
20532050 break;
20542051 }
2055
- kfree(mpcginfo);
20562052 return;
20572053 }
20582054
....@@ -2089,6 +2085,7 @@
20892085 grp->estconnfunc = NULL;
20902086 break;
20912087 }
2088
+ fallthrough;
20922089 case MPCG_STATE_FLOWC:
20932090 case MPCG_STATE_READY:
20942091 grp->send_qllc_disc = 2;