.. | .. |
---|
14 | 14 | #include <linux/of_address.h> |
---|
15 | 15 | #include <linux/slab.h> |
---|
16 | 16 | #include <linux/of_mdio.h> |
---|
| 17 | +#include <linux/platform_data/xilinx-ll-temac.h> |
---|
17 | 18 | |
---|
18 | 19 | #include "ll_temac.h" |
---|
19 | 20 | |
---|
.. | .. |
---|
24 | 25 | { |
---|
25 | 26 | struct temac_local *lp = bus->priv; |
---|
26 | 27 | u32 rc; |
---|
| 28 | + unsigned long flags; |
---|
27 | 29 | |
---|
28 | 30 | /* Write the PHY address to the MIIM Access Initiator register. |
---|
29 | 31 | * When the transfer completes, the PHY register value will appear |
---|
30 | 32 | * in the LSW0 register */ |
---|
31 | | - mutex_lock(&lp->indirect_mutex); |
---|
| 33 | + spin_lock_irqsave(lp->indirect_lock, flags); |
---|
32 | 34 | temac_iow(lp, XTE_LSW0_OFFSET, (phy_id << 5) | reg); |
---|
33 | | - rc = temac_indirect_in32(lp, XTE_MIIMAI_OFFSET); |
---|
34 | | - mutex_unlock(&lp->indirect_mutex); |
---|
| 35 | + rc = temac_indirect_in32_locked(lp, XTE_MIIMAI_OFFSET); |
---|
| 36 | + spin_unlock_irqrestore(lp->indirect_lock, flags); |
---|
35 | 37 | |
---|
36 | 38 | dev_dbg(lp->dev, "temac_mdio_read(phy_id=%i, reg=%x) == %x\n", |
---|
37 | 39 | phy_id, reg, rc); |
---|
.. | .. |
---|
42 | 44 | static int temac_mdio_write(struct mii_bus *bus, int phy_id, int reg, u16 val) |
---|
43 | 45 | { |
---|
44 | 46 | struct temac_local *lp = bus->priv; |
---|
| 47 | + unsigned long flags; |
---|
45 | 48 | |
---|
46 | 49 | dev_dbg(lp->dev, "temac_mdio_write(phy_id=%i, reg=%x, val=%x)\n", |
---|
47 | 50 | phy_id, reg, val); |
---|
.. | .. |
---|
49 | 52 | /* First write the desired value into the write data register |
---|
50 | 53 | * and then write the address into the access initiator register |
---|
51 | 54 | */ |
---|
52 | | - mutex_lock(&lp->indirect_mutex); |
---|
53 | | - temac_indirect_out32(lp, XTE_MGTDR_OFFSET, val); |
---|
54 | | - temac_indirect_out32(lp, XTE_MIIMAI_OFFSET, (phy_id << 5) | reg); |
---|
55 | | - mutex_unlock(&lp->indirect_mutex); |
---|
| 55 | + spin_lock_irqsave(lp->indirect_lock, flags); |
---|
| 56 | + temac_indirect_out32_locked(lp, XTE_MGTDR_OFFSET, val); |
---|
| 57 | + temac_indirect_out32_locked(lp, XTE_MIIMAI_OFFSET, (phy_id << 5) | reg); |
---|
| 58 | + spin_unlock_irqrestore(lp->indirect_lock, flags); |
---|
56 | 59 | |
---|
57 | 60 | return 0; |
---|
58 | 61 | } |
---|
59 | 62 | |
---|
60 | | -int temac_mdio_setup(struct temac_local *lp, struct device_node *np) |
---|
| 63 | +int temac_mdio_setup(struct temac_local *lp, struct platform_device *pdev) |
---|
61 | 64 | { |
---|
| 65 | + struct ll_temac_platform_data *pdata = dev_get_platdata(&pdev->dev); |
---|
| 66 | + struct device_node *np = dev_of_node(&pdev->dev); |
---|
62 | 67 | struct mii_bus *bus; |
---|
63 | 68 | u32 bus_hz; |
---|
64 | 69 | int clk_div; |
---|
65 | 70 | int rc; |
---|
66 | 71 | struct resource res; |
---|
67 | 72 | |
---|
| 73 | + /* Get MDIO bus frequency (if specified) */ |
---|
| 74 | + bus_hz = 0; |
---|
| 75 | + if (np) |
---|
| 76 | + of_property_read_u32(np, "clock-frequency", &bus_hz); |
---|
| 77 | + else if (pdata) |
---|
| 78 | + bus_hz = pdata->mdio_clk_freq; |
---|
| 79 | + |
---|
68 | 80 | /* Calculate a reasonable divisor for the clock rate */ |
---|
69 | 81 | clk_div = 0x3f; /* worst-case default setting */ |
---|
70 | | - if (of_property_read_u32(np, "clock-frequency", &bus_hz) == 0) { |
---|
| 82 | + if (bus_hz != 0) { |
---|
71 | 83 | clk_div = bus_hz / (2500 * 1000 * 2) - 1; |
---|
72 | 84 | if (clk_div < 1) |
---|
73 | 85 | clk_div = 1; |
---|
.. | .. |
---|
77 | 89 | |
---|
78 | 90 | /* Enable the MDIO bus by asserting the enable bit and writing |
---|
79 | 91 | * in the clock config */ |
---|
80 | | - mutex_lock(&lp->indirect_mutex); |
---|
81 | 92 | temac_indirect_out32(lp, XTE_MC_OFFSET, 1 << 6 | clk_div); |
---|
82 | | - mutex_unlock(&lp->indirect_mutex); |
---|
83 | 93 | |
---|
84 | | - bus = mdiobus_alloc(); |
---|
| 94 | + bus = devm_mdiobus_alloc(&pdev->dev); |
---|
85 | 95 | if (!bus) |
---|
86 | 96 | return -ENOMEM; |
---|
87 | 97 | |
---|
88 | | - of_address_to_resource(np, 0, &res); |
---|
89 | | - snprintf(bus->id, MII_BUS_ID_SIZE, "%.8llx", |
---|
90 | | - (unsigned long long)res.start); |
---|
| 98 | + if (np) { |
---|
| 99 | + of_address_to_resource(np, 0, &res); |
---|
| 100 | + snprintf(bus->id, MII_BUS_ID_SIZE, "%.8llx", |
---|
| 101 | + (unsigned long long)res.start); |
---|
| 102 | + } else if (pdata) { |
---|
| 103 | + snprintf(bus->id, MII_BUS_ID_SIZE, "%.8llx", |
---|
| 104 | + pdata->mdio_bus_id); |
---|
| 105 | + } |
---|
| 106 | + |
---|
91 | 107 | bus->priv = lp; |
---|
92 | 108 | bus->name = "Xilinx TEMAC MDIO"; |
---|
93 | 109 | bus->read = temac_mdio_read; |
---|
.. | .. |
---|
98 | 114 | |
---|
99 | 115 | rc = of_mdiobus_register(bus, np); |
---|
100 | 116 | if (rc) |
---|
101 | | - goto err_register; |
---|
| 117 | + return rc; |
---|
102 | 118 | |
---|
103 | | - mutex_lock(&lp->indirect_mutex); |
---|
104 | 119 | dev_dbg(lp->dev, "MDIO bus registered; MC:%x\n", |
---|
105 | 120 | temac_indirect_in32(lp, XTE_MC_OFFSET)); |
---|
106 | | - mutex_unlock(&lp->indirect_mutex); |
---|
107 | 121 | return 0; |
---|
108 | | - |
---|
109 | | - err_register: |
---|
110 | | - mdiobus_free(bus); |
---|
111 | | - return rc; |
---|
112 | 122 | } |
---|
113 | 123 | |
---|
114 | 124 | void temac_mdio_teardown(struct temac_local *lp) |
---|
115 | 125 | { |
---|
116 | 126 | mdiobus_unregister(lp->mii_bus); |
---|
117 | | - mdiobus_free(lp->mii_bus); |
---|
118 | | - lp->mii_bus = NULL; |
---|
119 | 127 | } |
---|
120 | | - |
---|