hc
2024-02-20 102a0743326a03cd1a1202ceda21e175b7d3575c
kernel/drivers/iio/adc/ad7923.c
....@@ -1,10 +1,9 @@
1
+// SPDX-License-Identifier: GPL-2.0-only
12 /*
2
- * AD7904/AD7914/AD7923/AD7924 SPI ADC driver
3
+ * AD7904/AD7914/AD7923/AD7924/AD7908/AD7918/AD7928 SPI ADC driver
34 *
45 * Copyright 2011 Analog Devices Inc (from AD7923 Driver)
56 * Copyright 2012 CS Systemes d'Information
6
- *
7
- * Licensed under the GPL-2.
87 */
98
109 #include <linux/device.h>
....@@ -24,32 +23,27 @@
2423 #include <linux/iio/trigger_consumer.h>
2524 #include <linux/iio/triggered_buffer.h>
2625
27
-#define AD7923_WRITE_CR (1 << 11) /* write control register */
28
-#define AD7923_RANGE (1 << 1) /* range to REFin */
29
-#define AD7923_CODING (1 << 0) /* coding is straight binary */
26
+#define AD7923_WRITE_CR BIT(11) /* write control register */
27
+#define AD7923_RANGE BIT(1) /* range to REFin */
28
+#define AD7923_CODING BIT(0) /* coding is straight binary */
3029 #define AD7923_PM_MODE_AS (1) /* auto shutdown */
3130 #define AD7923_PM_MODE_FS (2) /* full shutdown */
3231 #define AD7923_PM_MODE_OPS (3) /* normal operation */
33
-#define AD7923_CHANNEL_0 (0) /* analog input 0 */
34
-#define AD7923_CHANNEL_1 (1) /* analog input 1 */
35
-#define AD7923_CHANNEL_2 (2) /* analog input 2 */
36
-#define AD7923_CHANNEL_3 (3) /* analog input 3 */
3732 #define AD7923_SEQUENCE_OFF (0) /* no sequence fonction */
3833 #define AD7923_SEQUENCE_PROTECT (2) /* no interrupt write cycle */
3934 #define AD7923_SEQUENCE_ON (3) /* continuous sequence */
4035
41
-#define AD7923_MAX_CHAN 4
4236
43
-#define AD7923_PM_MODE_WRITE(mode) (mode << 4) /* write mode */
44
-#define AD7923_CHANNEL_WRITE(channel) (channel << 6) /* write channel */
45
-#define AD7923_SEQUENCE_WRITE(sequence) (((sequence & 1) << 3) \
46
- + ((sequence & 2) << 9))
37
+#define AD7923_PM_MODE_WRITE(mode) ((mode) << 4) /* write mode */
38
+#define AD7923_CHANNEL_WRITE(channel) ((channel) << 6) /* write channel */
39
+#define AD7923_SEQUENCE_WRITE(sequence) ((((sequence) & 1) << 3) \
40
+ + (((sequence) & 2) << 9))
4741 /* write sequence fonction */
4842 /* left shift for CR : bit 11 transmit in first */
4943 #define AD7923_SHIFT_REGISTER 4
5044
5145 /* val = value, dec = left shift, bits = number of bits of the mask */
52
-#define EXTRACT(val, dec, bits) ((val >> dec) & ((1 << bits) - 1))
46
+#define EXTRACT(val, dec, bits) (((val) >> (dec)) & ((1 << (bits)) - 1))
5347
5448 struct ad7923_state {
5549 struct spi_device *spi;
....@@ -65,8 +59,10 @@
6559 /*
6660 * DMA (thus cache coherency maintenance) requires the
6761 * transfer buffers to live in their own cache lines.
62
+ * Ensure rx_buf can be directly used in iio_push_to_buffers_with_timetamp
63
+ * Length = 8 channels + 4 extra for 8 byte timestamp
6864 */
69
- __be16 rx_buf[4] ____cacheline_aligned;
65
+ __be16 rx_buf[12] ____cacheline_aligned;
7066 __be16 tx_buf[4];
7167 };
7268
....@@ -79,6 +75,9 @@
7975 AD7904,
8076 AD7914,
8177 AD7924,
78
+ AD7908,
79
+ AD7918,
80
+ AD7928
8281 };
8382
8483 #define AD7923_V_CHAN(index, bits) \
....@@ -94,6 +93,7 @@
9493 .sign = 'u', \
9594 .realbits = (bits), \
9695 .storagebits = 16, \
96
+ .shift = 12 - (bits), \
9797 .endianness = IIO_BE, \
9898 }, \
9999 }
....@@ -107,9 +107,25 @@
107107 IIO_CHAN_SOFT_TIMESTAMP(4), \
108108 }
109109
110
+#define DECLARE_AD7908_CHANNELS(name, bits) \
111
+const struct iio_chan_spec name ## _channels[] = { \
112
+ AD7923_V_CHAN(0, bits), \
113
+ AD7923_V_CHAN(1, bits), \
114
+ AD7923_V_CHAN(2, bits), \
115
+ AD7923_V_CHAN(3, bits), \
116
+ AD7923_V_CHAN(4, bits), \
117
+ AD7923_V_CHAN(5, bits), \
118
+ AD7923_V_CHAN(6, bits), \
119
+ AD7923_V_CHAN(7, bits), \
120
+ IIO_CHAN_SOFT_TIMESTAMP(8), \
121
+}
122
+
110123 static DECLARE_AD7923_CHANNELS(ad7904, 8);
111124 static DECLARE_AD7923_CHANNELS(ad7914, 10);
112125 static DECLARE_AD7923_CHANNELS(ad7924, 12);
126
+static DECLARE_AD7908_CHANNELS(ad7908, 8);
127
+static DECLARE_AD7908_CHANNELS(ad7918, 10);
128
+static DECLARE_AD7908_CHANNELS(ad7928, 12);
113129
114130 static const struct ad7923_chip_info ad7923_chip_info[] = {
115131 [AD7904] = {
....@@ -124,19 +140,35 @@
124140 .channels = ad7924_channels,
125141 .num_channels = ARRAY_SIZE(ad7924_channels),
126142 },
143
+ [AD7908] = {
144
+ .channels = ad7908_channels,
145
+ .num_channels = ARRAY_SIZE(ad7908_channels),
146
+ },
147
+ [AD7918] = {
148
+ .channels = ad7918_channels,
149
+ .num_channels = ARRAY_SIZE(ad7918_channels),
150
+ },
151
+ [AD7928] = {
152
+ .channels = ad7928_channels,
153
+ .num_channels = ARRAY_SIZE(ad7928_channels),
154
+ },
127155 };
128156
129
-/**
157
+/*
130158 * ad7923_update_scan_mode() setup the spi transfer buffer for the new scan mask
131
- **/
159
+ */
132160 static int ad7923_update_scan_mode(struct iio_dev *indio_dev,
133
- const unsigned long *active_scan_mask)
161
+ const unsigned long *active_scan_mask)
134162 {
135163 struct ad7923_state *st = iio_priv(indio_dev);
136164 int i, cmd, len;
137165
138166 len = 0;
139
- for_each_set_bit(i, active_scan_mask, AD7923_MAX_CHAN) {
167
+ /*
168
+ * For this driver the last channel is always the software timestamp so
169
+ * skip that one.
170
+ */
171
+ for_each_set_bit(i, active_scan_mask, indio_dev->num_channels - 1) {
140172 cmd = AD7923_WRITE_CR | AD7923_CHANNEL_WRITE(i) |
141173 AD7923_SEQUENCE_WRITE(AD7923_SEQUENCE_OFF) |
142174 st->settings;
....@@ -163,12 +195,12 @@
163195 return 0;
164196 }
165197
166
-/**
198
+/*
167199 * ad7923_trigger_handler() bh of trigger launched polling to ring buffer
168200 *
169201 * Currently there is no option in this driver to disable the saving of
170202 * timestamps within the ring.
171
- **/
203
+ */
172204 static irqreturn_t ad7923_trigger_handler(int irq, void *p)
173205 {
174206 struct iio_poll_func *pf = p;
....@@ -181,7 +213,7 @@
181213 goto done;
182214
183215 iio_push_to_buffers_with_timestamp(indio_dev, st->rx_buf,
184
- iio_get_time_ns(indio_dev));
216
+ iio_get_time_ns(indio_dev));
185217
186218 done:
187219 iio_trigger_notify_done(indio_dev->trig);
....@@ -189,7 +221,7 @@
189221 return IRQ_HANDLED;
190222 }
191223
192
-static int ad7923_scan_direct(struct ad7923_state *st, unsigned ch)
224
+static int ad7923_scan_direct(struct ad7923_state *st, unsigned int ch)
193225 {
194226 int ret, cmd;
195227
....@@ -243,7 +275,8 @@
243275 return ret;
244276
245277 if (chan->address == EXTRACT(ret, 12, 4))
246
- *val = EXTRACT(ret, 0, 12);
278
+ *val = EXTRACT(ret, chan->scan_type.shift,
279
+ chan->scan_type.realbits);
247280 else
248281 return -EIO;
249282
....@@ -272,7 +305,7 @@
272305 int ret;
273306
274307 indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
275
- if (indio_dev == NULL)
308
+ if (!indio_dev)
276309 return -ENOMEM;
277310
278311 st = iio_priv(indio_dev);
....@@ -286,8 +319,6 @@
286319 info = &ad7923_chip_info[spi_get_device_id(spi)->driver_data];
287320
288321 indio_dev->name = spi_get_device_id(spi)->name;
289
- indio_dev->dev.parent = &spi->dev;
290
- indio_dev->dev.of_node = spi->dev.of_node;
291322 indio_dev->modes = INDIO_DIRECT_MODE;
292323 indio_dev->channels = info->channels;
293324 indio_dev->num_channels = info->num_channels;
....@@ -314,7 +345,7 @@
314345 return ret;
315346
316347 ret = iio_triggered_buffer_setup(indio_dev, NULL,
317
- &ad7923_trigger_handler, NULL);
348
+ &ad7923_trigger_handler, NULL);
318349 if (ret)
319350 goto error_disable_reg;
320351
....@@ -349,13 +380,29 @@
349380 {"ad7914", AD7914},
350381 {"ad7923", AD7924},
351382 {"ad7924", AD7924},
383
+ {"ad7908", AD7908},
384
+ {"ad7918", AD7918},
385
+ {"ad7928", AD7928},
352386 {}
353387 };
354388 MODULE_DEVICE_TABLE(spi, ad7923_id);
355389
390
+static const struct of_device_id ad7923_of_match[] = {
391
+ { .compatible = "adi,ad7904", },
392
+ { .compatible = "adi,ad7914", },
393
+ { .compatible = "adi,ad7923", },
394
+ { .compatible = "adi,ad7924", },
395
+ { .compatible = "adi,ad7908", },
396
+ { .compatible = "adi,ad7918", },
397
+ { .compatible = "adi,ad7928", },
398
+ { },
399
+};
400
+MODULE_DEVICE_TABLE(of, ad7923_of_match);
401
+
356402 static struct spi_driver ad7923_driver = {
357403 .driver = {
358404 .name = "ad7923",
405
+ .of_match_table = ad7923_of_match,
359406 },
360407 .probe = ad7923_probe,
361408 .remove = ad7923_remove,
....@@ -363,7 +410,7 @@
363410 };
364411 module_spi_driver(ad7923_driver);
365412
366
-MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
413
+MODULE_AUTHOR("Michael Hennerich <michael.hennerich@analog.com>");
367414 MODULE_AUTHOR("Patrick Vasseur <patrick.vasseur@c-s.fr>");
368
-MODULE_DESCRIPTION("Analog Devices AD7904/AD7914/AD7923/AD7924 ADC");
415
+MODULE_DESCRIPTION("Analog Devices AD7923 and similar ADC");
369416 MODULE_LICENSE("GPL v2");