.. | .. |
---|
433 | 433 | default: |
---|
434 | 434 | return -ENOTSUPP; |
---|
435 | 435 | } |
---|
| 436 | + break; |
---|
436 | 437 | default: |
---|
437 | 438 | dev_err(chip->parent, "Unsupported EIC type.\n"); |
---|
438 | 439 | return -ENOTSUPP; |
---|
.. | .. |
---|
585 | 586 | sprd_eic->type = pdata->type; |
---|
586 | 587 | |
---|
587 | 588 | sprd_eic->irq = platform_get_irq(pdev, 0); |
---|
588 | | - if (sprd_eic->irq < 0) { |
---|
589 | | - dev_err(&pdev->dev, "Failed to get EIC interrupt.\n"); |
---|
| 589 | + if (sprd_eic->irq < 0) |
---|
590 | 590 | return sprd_eic->irq; |
---|
591 | | - } |
---|
592 | 591 | |
---|
593 | 592 | for (i = 0; i < SPRD_EIC_MAX_BANK; i++) { |
---|
594 | 593 | /* |
---|
.. | .. |
---|
618 | 617 | sprd_eic->chip.free = sprd_eic_free; |
---|
619 | 618 | sprd_eic->chip.set_config = sprd_eic_set_config; |
---|
620 | 619 | sprd_eic->chip.set = sprd_eic_set; |
---|
621 | | - /* fall-through */ |
---|
| 620 | + fallthrough; |
---|
622 | 621 | case SPRD_EIC_ASYNC: |
---|
623 | | - /* fall-through */ |
---|
624 | 622 | case SPRD_EIC_SYNC: |
---|
625 | 623 | sprd_eic->chip.get = sprd_eic_get; |
---|
626 | 624 | break; |
---|
627 | 625 | case SPRD_EIC_LATCH: |
---|
628 | | - /* fall-through */ |
---|
629 | 626 | default: |
---|
630 | 627 | break; |
---|
631 | 628 | } |
---|