hc
2024-02-20 102a0743326a03cd1a1202ceda21e175b7d3575c
kernel/drivers/firmware/efi/apple-properties.c
....@@ -1,26 +1,16 @@
1
+// SPDX-License-Identifier: GPL-2.0
12 /*
23 * apple-properties.c - EFI device properties on Macs
34 * Copyright (C) 2016 Lukas Wunner <lukas@wunner.de>
45 *
5
- * This program is free software; you can redistribute it and/or modify
6
- * it under the terms of the GNU General Public License (version 2) as
7
- * published by the Free Software Foundation.
8
- *
9
- * This program is distributed in the hope that it will be useful,
10
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
11
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12
- * GNU General Public License for more details.
13
- *
14
- * You should have received a copy of the GNU General Public License
15
- * along with this program; if not, see <http://www.gnu.org/licenses/>.
16
- *
17
- * Note, all properties are considered as u8 arrays.
18
- * To get a value of any of them the caller must use device_property_read_u8_array().
6
+ * Properties are stored either as:
7
+ * u8 arrays which can be retrieved with device_property_read_u8_array() or
8
+ * booleans which can be queried with device_property_present().
199 */
2010
2111 #define pr_fmt(fmt) "apple-properties: " fmt
2212
23
-#include <linux/bootmem.h>
13
+#include <linux/memblock.h>
2414 #include <linux/efi.h>
2515 #include <linux/io.h>
2616 #include <linux/platform_data/x86/apple.h>
....@@ -34,7 +24,7 @@
3424 static int __init dump_properties_enable(char *arg)
3525 {
3626 dump_properties = true;
37
- return 0;
27
+ return 1;
3828 }
3929
4030 __setup("dump_apple_properties", dump_properties_enable);
....@@ -42,7 +32,7 @@
4232 struct dev_header {
4333 u32 len;
4434 u32 prop_count;
45
- struct efi_dev_path path[0];
35
+ struct efi_dev_path path[];
4636 /*
4737 * followed by key/value pairs, each key and value preceded by u32 len,
4838 * len includes itself, value may be empty (in which case its len is 4)
....@@ -53,18 +43,19 @@
5343 u32 len;
5444 u32 version;
5545 u32 dev_count;
56
- struct dev_header dev_header[0];
46
+ struct dev_header dev_header[];
5747 };
5848
5949 static void __init unmarshal_key_value_pairs(struct dev_header *dev_header,
60
- struct device *dev, void *ptr,
50
+ struct device *dev, const void *ptr,
6151 struct property_entry entry[])
6252 {
6353 int i;
6454
6555 for (i = 0; i < dev_header->prop_count; i++) {
6656 int remaining = dev_header->len - (ptr - (void *)dev_header);
67
- u32 key_len, val_len;
57
+ u32 key_len, val_len, entry_len;
58
+ const u8 *entry_data;
6859 char *key;
6960
7061 if (sizeof(key_len) > remaining)
....@@ -96,17 +87,18 @@
9687 ucs2_as_utf8(key, ptr + sizeof(key_len),
9788 key_len - sizeof(key_len));
9889
99
- entry[i].name = key;
100
- entry[i].length = val_len - sizeof(val_len);
101
- entry[i].is_array = !!entry[i].length;
102
- entry[i].type = DEV_PROP_U8;
103
- entry[i].pointer.u8_data = ptr + key_len + sizeof(val_len);
90
+ entry_data = ptr + key_len + sizeof(val_len);
91
+ entry_len = val_len - sizeof(val_len);
92
+ if (entry_len)
93
+ entry[i] = PROPERTY_ENTRY_U8_ARRAY_LEN(key, entry_data,
94
+ entry_len);
95
+ else
96
+ entry[i] = PROPERTY_ENTRY_BOOL(key);
10497
10598 if (dump_properties) {
106
- dev_info(dev, "property: %s\n", entry[i].name);
99
+ dev_info(dev, "property: %s\n", key);
107100 print_hex_dump(KERN_INFO, pr_fmt(), DUMP_PREFIX_OFFSET,
108
- 16, 1, entry[i].pointer.u8_data,
109
- entry[i].length, true);
101
+ 16, 1, entry_data, entry_len, true);
110102 }
111103
112104 ptr += key_len + val_len;
....@@ -130,10 +122,10 @@
130122 while (offset + sizeof(struct dev_header) < properties->len) {
131123 struct dev_header *dev_header = (void *)properties + offset;
132124 struct property_entry *entry = NULL;
125
+ const struct efi_dev_path *ptr;
133126 struct device *dev;
134127 size_t len;
135128 int ret, i;
136
- void *ptr;
137129
138130 if (offset + dev_header->len > properties->len ||
139131 dev_header->len <= sizeof(*dev_header)) {
....@@ -144,10 +136,10 @@
144136 ptr = dev_header->path;
145137 len = dev_header->len - sizeof(*dev_header);
146138
147
- dev = efi_get_device_by_path((struct efi_dev_path **)&ptr, &len);
139
+ dev = efi_get_device_by_path(&ptr, &len);
148140 if (IS_ERR(dev)) {
149141 pr_err("device path parse error %ld at %#zx:\n",
150
- PTR_ERR(dev), ptr - (void *)dev_header);
142
+ PTR_ERR(dev), (void *)ptr - (void *)dev_header);
151143 print_hex_dump(KERN_ERR, pr_fmt(), DUMP_PREFIX_OFFSET,
152144 16, 1, dev_header, dev_header->len, true);
153145 dev = NULL;
....@@ -235,7 +227,7 @@
235227 */
236228 data->len = 0;
237229 memunmap(data);
238
- free_bootmem_late(pa_data + sizeof(*data), data_len);
230
+ memblock_free_late(pa_data + sizeof(*data), data_len);
239231
240232 return ret;
241233 }