disable kernel build waring

hc

2024-05-10 093a6c67005148ae32a5c9e4553491b9f5c2457b

 kernel/drivers/media/v4l2-core/v4l2-mc.c
..
..
@@ -28,7 +28,7 @@
28
28
 	struct media_entity *io_v4l = NULL, *io_vbi = NULL, *io_swradio = NULL;
29
29
 	bool is_webcam = false;
30
30
 	u32 flags;
31
-	int ret;
31
+	int ret, pad_sink, pad_source;
32
32
 
33
33
 	if (!mdev)
34
34
 		return 0;
..
..
@@ -63,8 +63,10 @@
63
63
 	}
64
64
 
65
65
 	/* It should have at least one I/O entity */
66
-	if (!io_v4l && !io_vbi && !io_swradio)
66
+	if (!io_v4l && !io_vbi && !io_swradio) {
67
+		dev_warn(mdev->dev, "Didn't find any I/O entity\n");
67
68
 		return -EINVAL;
69
+	}
68
70
 
69
71
 	/*
70
72
 	 * Here, webcams are modelled on a very simple way: the sensor is
..
..
@@ -74,8 +76,10 @@
74
76
 	 * PC-consumer's hardware.
75
77
 	 */
76
78
 	if (is_webcam) {
77
-		if (!io_v4l)
79
+		if (!io_v4l) {
80
+			dev_warn(mdev->dev, "Didn't find a MEDIA_ENT_F_IO_V4L\n");
78
81
 			return -EINVAL;
82
+		}
79
83
 
80
84
 		media_device_for_each_entity(entity, mdev) {
81
85
 			if (entity->function != MEDIA_ENT_F_CAM_SENSOR)
..
..
@@ -83,46 +87,91 @@
83
87
 			ret = media_create_pad_link(entity, 0,
84
88
 						    io_v4l, 0,
85
89
 						    MEDIA_LNK_FL_ENABLED);
86
-			if (ret)
90
+			if (ret) {
91
+				dev_warn(mdev->dev, "Failed to create a sensor link\n");
87
92
 				return ret;
93
+			}
88
94
 		}
89
95
 		if (!decoder)
90
96
 			return 0;
91
97
 	}
92
98
 
93
99
 	/* The device isn't a webcam. So, it should have a decoder */
94
-	if (!decoder)
100
+	if (!decoder) {
101
+		dev_warn(mdev->dev, "Decoder not found\n");
95
102
 		return -EINVAL;
103
+	}
96
104
 
97
105
 	/* Link the tuner and IF video output pads */
98
106
 	if (tuner) {
99
107
 		if (if_vid) {
100
-			ret = media_create_pad_link(tuner, TUNER_PAD_OUTPUT,
101
-						    if_vid,
102
-						    IF_VID_DEC_PAD_IF_INPUT,
108
+			pad_source = media_get_pad_index(tuner, false,
109
+							 PAD_SIGNAL_ANALOG);
110
+			pad_sink = media_get_pad_index(if_vid, true,
111
+						       PAD_SIGNAL_ANALOG);
112
+			if (pad_source < 0 || pad_sink < 0) {
113
+				dev_warn(mdev->dev, "Couldn't get tuner and/or PLL pad(s): (%d, %d)\n",
114
+					 pad_source, pad_sink);
115
+				return -EINVAL;
116
+			}
117
+			ret = media_create_pad_link(tuner, pad_source,
118
+						    if_vid, pad_sink,
103
119
 						    MEDIA_LNK_FL_ENABLED);
104
-			if (ret)
120
+			if (ret) {
121
+				dev_warn(mdev->dev, "Couldn't create tuner->PLL link)\n");
105
122
 				return ret;
106
-			ret = media_create_pad_link(if_vid, IF_VID_DEC_PAD_OUT,
107
-						decoder, DEMOD_PAD_IF_INPUT,
108
-						MEDIA_LNK_FL_ENABLED);
109
-			if (ret)
123
+			}
124
+
125
+			pad_source = media_get_pad_index(if_vid, false,
126
+							 PAD_SIGNAL_ANALOG);
127
+			pad_sink = media_get_pad_index(decoder, true,
128
+						       PAD_SIGNAL_ANALOG);
129
+			if (pad_source < 0 || pad_sink < 0) {
130
+				dev_warn(mdev->dev, "get decoder and/or PLL pad(s): (%d, %d)\n",
131
+					 pad_source, pad_sink);
132
+				return -EINVAL;
133
+			}
134
+			ret = media_create_pad_link(if_vid, pad_source,
135
+						    decoder, pad_sink,
136
+						    MEDIA_LNK_FL_ENABLED);
137
+			if (ret) {
138
+				dev_warn(mdev->dev, "couldn't link PLL to decoder\n");
110
139
 				return ret;
140
+			}
111
141
 		} else {
112
-			ret = media_create_pad_link(tuner, TUNER_PAD_OUTPUT,
113
-						decoder, DEMOD_PAD_IF_INPUT,
114
-						MEDIA_LNK_FL_ENABLED);
142
+			pad_source = media_get_pad_index(tuner, false,
143
+							 PAD_SIGNAL_ANALOG);
144
+			pad_sink = media_get_pad_index(decoder, true,
145
+						       PAD_SIGNAL_ANALOG);
146
+			if (pad_source < 0 || pad_sink < 0) {
147
+				dev_warn(mdev->dev, "couldn't get tuner and/or decoder pad(s): (%d, %d)\n",
148
+					 pad_source, pad_sink);
149
+				return -EINVAL;
150
+			}
151
+			ret = media_create_pad_link(tuner, pad_source,
152
+						    decoder, pad_sink,
153
+						    MEDIA_LNK_FL_ENABLED);
115
154
 			if (ret)
116
155
 				return ret;
117
156
 		}
118
157
 
119
158
 		if (if_aud) {
120
-			ret = media_create_pad_link(tuner, TUNER_PAD_AUD_OUT,
121
-						    if_aud,
122
-						    IF_AUD_DEC_PAD_IF_INPUT,
159
+			pad_source = media_get_pad_index(tuner, false,
160
+							 PAD_SIGNAL_AUDIO);
161
+			pad_sink = media_get_pad_index(if_aud, true,
162
+						       PAD_SIGNAL_AUDIO);
163
+			if (pad_source < 0 || pad_sink < 0) {
164
+				dev_warn(mdev->dev, "couldn't get tuner and/or decoder pad(s) for audio: (%d, %d)\n",
165
+					 pad_source, pad_sink);
166
+				return -EINVAL;
167
+			}
168
+			ret = media_create_pad_link(tuner, pad_source,
169
+						    if_aud, pad_sink,
123
170
 						    MEDIA_LNK_FL_ENABLED);
124
-			if (ret)
171
+			if (ret) {
172
+				dev_warn(mdev->dev, "couldn't link tuner->audio PLL\n");
125
173
 				return ret;
174
+			}
126
175
 		} else {
127
176
 			if_aud = tuner;
128
177
 		}
..
..
@@ -131,27 +180,48 @@
131
180
 
132
181
 	/* Create demod to V4L, VBI and SDR radio links */
133
182
 	if (io_v4l) {
134
-		ret = media_create_pad_link(decoder, DEMOD_PAD_VID_OUT,
135
-					io_v4l, 0,
136
-					MEDIA_LNK_FL_ENABLED);
137
-		if (ret)
183
+		pad_source = media_get_pad_index(decoder, false, PAD_SIGNAL_DV);
184
+		if (pad_source < 0) {
185
+			dev_warn(mdev->dev, "couldn't get decoder output pad for V4L I/O\n");
186
+			return -EINVAL;
187
+		}
188
+		ret = media_create_pad_link(decoder, pad_source,
189
+					    io_v4l, 0,
190
+					    MEDIA_LNK_FL_ENABLED);
191
+		if (ret) {
192
+			dev_warn(mdev->dev, "couldn't link decoder output to V4L I/O\n");
138
193
 			return ret;
194
+		}
139
195
 	}
140
196
 
141
197
 	if (io_swradio) {
142
-		ret = media_create_pad_link(decoder, DEMOD_PAD_VID_OUT,
143
-					io_swradio, 0,
144
-					MEDIA_LNK_FL_ENABLED);
145
-		if (ret)
198
+		pad_source = media_get_pad_index(decoder, false, PAD_SIGNAL_DV);
199
+		if (pad_source < 0) {
200
+			dev_warn(mdev->dev, "couldn't get decoder output pad for SDR\n");
201
+			return -EINVAL;
202
+		}
203
+		ret = media_create_pad_link(decoder, pad_source,
204
+					    io_swradio, 0,
205
+					    MEDIA_LNK_FL_ENABLED);
206
+		if (ret) {
207
+			dev_warn(mdev->dev, "couldn't link decoder output to SDR\n");
146
208
 			return ret;
209
+		}
147
210
 	}
148
211
 
149
212
 	if (io_vbi) {
150
-		ret = media_create_pad_link(decoder, DEMOD_PAD_VBI_OUT,
213
+		pad_source = media_get_pad_index(decoder, false, PAD_SIGNAL_DV);
214
+		if (pad_source < 0) {
215
+			dev_warn(mdev->dev, "couldn't get decoder output pad for VBI\n");
216
+			return -EINVAL;
217
+		}
218
+		ret = media_create_pad_link(decoder, pad_source,
151
219
 					    io_vbi, 0,
152
220
 					    MEDIA_LNK_FL_ENABLED);
153
-		if (ret)
221
+		if (ret) {
222
+			dev_warn(mdev->dev, "couldn't link decoder output to VBI\n");
154
223
 			return ret;
224
+		}
155
225
 	}
156
226
 
157
227
 	/* Create links for the media connectors */
..
..
@@ -161,15 +231,26 @@
161
231
 		case MEDIA_ENT_F_CONN_RF:
162
232
 			if (!tuner)
163
233
 				continue;
164
-
234
+			pad_sink = media_get_pad_index(tuner, true,
235
+						       PAD_SIGNAL_ANALOG);
236
+			if (pad_sink < 0) {
237
+				dev_warn(mdev->dev, "couldn't get tuner analog pad sink\n");
238
+				return -EINVAL;
239
+			}
165
240
 			ret = media_create_pad_link(entity, 0, tuner,
166
-						    TUNER_PAD_RF_INPUT,
241
+						    pad_sink,
167
242
 						    flags);
168
243
 			break;
169
244
 		case MEDIA_ENT_F_CONN_SVIDEO:
170
245
 		case MEDIA_ENT_F_CONN_COMPOSITE:
246
+			pad_sink = media_get_pad_index(decoder, true,
247
+						       PAD_SIGNAL_ANALOG);
248
+			if (pad_sink < 0) {
249
+				dev_warn(mdev->dev, "couldn't get tuner analog pad sink\n");
250
+				return -EINVAL;
251
+			}
171
252
 			ret = media_create_pad_link(entity, 0, decoder,
172
-						    DEMOD_PAD_IF_INPUT,
253
+						    pad_sink,
173
254
 						    flags);
174
255
 			break;
175
256
 		default:
..
..
@@ -228,6 +309,101 @@
228
309
 }
229
310
 EXPORT_SYMBOL_GPL(v4l_vb2q_enable_media_source);
230
311
 
312
+int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd,
313
+				    struct media_pad *sink)
314
+{
315
+	struct fwnode_handle *endpoint;
316
+	struct v4l2_subdev *sink_sd;
317
+
318
+	if (!(sink->flags & MEDIA_PAD_FL_SINK) ||
319
+	    !is_media_entity_v4l2_subdev(sink->entity))
320
+		return -EINVAL;
321
+
322
+	sink_sd = media_entity_to_v4l2_subdev(sink->entity);
323
+
324
+	fwnode_graph_for_each_endpoint(dev_fwnode(src_sd->dev), endpoint) {
325
+		struct fwnode_handle *remote_ep;
326
+		int src_idx, sink_idx, ret;
327
+		struct media_pad *src;
328
+
329
+		src_idx = media_entity_get_fwnode_pad(&src_sd->entity,
330
+						      endpoint,
331
+						      MEDIA_PAD_FL_SOURCE);
332
+		if (src_idx < 0)
333
+			continue;
334
+
335
+		remote_ep = fwnode_graph_get_remote_endpoint(endpoint);
336
+		if (!remote_ep)
337
+			continue;
338
+
339
+		/*
340
+		 * ask the sink to verify it owns the remote endpoint,
341
+		 * and translate to a sink pad.
342
+		 */
343
+		sink_idx = media_entity_get_fwnode_pad(&sink_sd->entity,
344
+						       remote_ep,
345
+						       MEDIA_PAD_FL_SINK);
346
+		fwnode_handle_put(remote_ep);
347
+
348
+		if (sink_idx < 0 || sink_idx != sink->index)
349
+			continue;
350
+
351
+		/*
352
+		 * the source endpoint corresponds to one of its source pads,
353
+		 * the source endpoint connects to an endpoint at the sink
354
+		 * entity, and the sink endpoint corresponds to the sink
355
+		 * pad requested, so we have found an endpoint connection
356
+		 * that works, create the media link for it.
357
+		 */
358
+
359
+		src = &src_sd->entity.pads[src_idx];
360
+
361
+		/* skip if link already exists */
362
+		if (media_entity_find_link(src, sink))
363
+			continue;
364
+
365
+		dev_dbg(sink_sd->dev, "creating link %s:%d -> %s:%d\n",
366
+			src_sd->entity.name, src_idx,
367
+			sink_sd->entity.name, sink_idx);
368
+
369
+		ret = media_create_pad_link(&src_sd->entity, src_idx,
370
+					    &sink_sd->entity, sink_idx, 0);
371
+		if (ret) {
372
+			dev_err(sink_sd->dev,
373
+				"link %s:%d -> %s:%d failed with %d\n",
374
+				src_sd->entity.name, src_idx,
375
+				sink_sd->entity.name, sink_idx, ret);
376
+
377
+			fwnode_handle_put(endpoint);
378
+			return ret;
379
+		}
380
+	}
381
+
382
+	return 0;
383
+}
384
+EXPORT_SYMBOL_GPL(v4l2_create_fwnode_links_to_pad);
385
+
386
+int v4l2_create_fwnode_links(struct v4l2_subdev *src_sd,
387
+			     struct v4l2_subdev *sink_sd)
388
+{
389
+	unsigned int i;
390
+
391
+	for (i = 0; i < sink_sd->entity.num_pads; i++) {
392
+		struct media_pad *pad = &sink_sd->entity.pads[i];
393
+		int ret;
394
+
395
+		if (!(pad->flags & MEDIA_PAD_FL_SINK))
396
+			continue;
397
+
398
+		ret = v4l2_create_fwnode_links_to_pad(src_sd, pad);
399
+		if (ret)
400
+			return ret;
401
+	}
402
+
403
+	return 0;
404
+}
405
+EXPORT_SYMBOL_GPL(v4l2_create_fwnode_links);
406
+
231
407
 /* -----------------------------------------------------------------------------
232
408
  * Pipeline power management
233
409
  *
..
..
@@ -240,7 +416,7 @@
240
416
  * use_count field stores the total number of users of all video device nodes
241
417
  * in the pipeline.
242
418
  *
243
- * The v4l2_pipeline_pm_use() function must be called in the open() and
419
+ * The v4l2_pipeline_pm_{get, put}() functions must be called in the open() and
244
420
  * close() handlers of video device nodes. It increments or decrements the use
245
421
  * count of all subdev entities in the pipeline.
246
422
  *
..
..
@@ -342,7 +518,7 @@
342
518
 	return ret;
343
519
 }
344
520
 
345
-int v4l2_pipeline_pm_use(struct media_entity *entity, int use)
521
+static int v4l2_pipeline_pm_use(struct media_entity *entity, unsigned int use)
346
522
 {
347
523
 	struct media_device *mdev = entity->graph_obj.mdev;
348
524
 	int change = use ? 1 : -1;
..
..
@@ -363,7 +539,19 @@
363
539
 
364
540
 	return ret;
365
541
 }
366
-EXPORT_SYMBOL_GPL(v4l2_pipeline_pm_use);
542
+
543
+int v4l2_pipeline_pm_get(struct media_entity *entity)
544
+{
545
+	return v4l2_pipeline_pm_use(entity, 1);
546
+}
547
+EXPORT_SYMBOL_GPL(v4l2_pipeline_pm_get);
548
+
549
+void v4l2_pipeline_pm_put(struct media_entity *entity)
550
+{
551
+	/* Powering off entities shouldn't fail. */
552
+	WARN_ON(v4l2_pipeline_pm_use(entity, 0));
553
+}
554
+EXPORT_SYMBOL_GPL(v4l2_pipeline_pm_put);
367
555
 
368
556
 int v4l2_pipeline_link_notify(struct media_link *link, u32 flags,
369
557
 			      unsigned int notification)