forked from ~ljy/RK356X_SDK_RELEASE

hc
2023-12-11 072de836f53be56a70cecf70b43ae43b7ce17376
kernel/drivers/md/md.c
....@@ -1,3 +1,4 @@
1
+// SPDX-License-Identifier: GPL-2.0-or-later
12 /*
23 md.c : Multiple Devices driver for Linux
34 Copyright (C) 1998, 1999, 2000 Ingo Molnar
....@@ -22,14 +23,6 @@
2223 - persistent bitmap code
2324 Copyright (C) 2003-2004, Paul Clements, SteelEye Technology, Inc.
2425
25
- This program is free software; you can redistribute it and/or modify
26
- it under the terms of the GNU General Public License as published by
27
- the Free Software Foundation; either version 2, or (at your option)
28
- any later version.
29
-
30
- You should have received a copy of the GNU General Public License
31
- (for example /usr/src/linux/COPYING); if not, write to the Free
32
- Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
3326
3427 Errors, Warnings, etc.
3528 Please use:
....@@ -44,6 +37,7 @@
4437
4538 */
4639
40
+#include <linux/sched/mm.h>
4741 #include <linux/sched/signal.h>
4842 #include <linux/kthread.h>
4943 #include <linux/blkdev.h>
....@@ -64,17 +58,15 @@
6458 #include <linux/delay.h>
6559 #include <linux/raid/md_p.h>
6660 #include <linux/raid/md_u.h>
61
+#include <linux/raid/detect.h>
6762 #include <linux/slab.h>
6863 #include <linux/percpu-refcount.h>
64
+#include <linux/part_stat.h>
6965
7066 #include <trace/events/block.h>
7167 #include "md.h"
7268 #include "md-bitmap.h"
7369 #include "md-cluster.h"
74
-
75
-#ifndef MODULE
76
-static void autostart_arrays(int part);
77
-#endif
7870
7971 /* pers_list is a list of registered personalities protected
8072 * by pers_lock.
....@@ -88,12 +80,12 @@
8880
8981 struct md_cluster_operations *md_cluster_ops;
9082 EXPORT_SYMBOL(md_cluster_ops);
91
-struct module *md_cluster_mod;
92
-EXPORT_SYMBOL(md_cluster_mod);
83
+static struct module *md_cluster_mod;
9384
9485 static DECLARE_WAIT_QUEUE_HEAD(resync_wait);
9586 static struct workqueue_struct *md_wq;
9687 static struct workqueue_struct *md_misc_wq;
88
+static struct workqueue_struct *md_rdev_misc_wq;
9789
9890 static int remove_and_add_spares(struct mddev *mddev,
9991 struct md_rdev *this);
....@@ -105,6 +97,8 @@
10597 * count by 2 for every hour elapsed between read errors.
10698 */
10799 #define MD_DEFAULT_MAX_CORRECTED_READ_ERRORS 20
100
+/* Default safemode delay: 200 msec */
101
+#define DEFAULT_SAFEMODE_DELAY ((200 * HZ)/1000 +1)
108102 /*
109103 * Current RAID-1,4,5 parallel reconstruction 'guaranteed speed limit'
110104 * is 1000 KB/sec, so the extra system load does not show up that much.
....@@ -130,6 +124,168 @@
130124 {
131125 return mddev->sync_speed_max ?
132126 mddev->sync_speed_max : sysctl_speed_limit_max;
127
+}
128
+
129
+static void rdev_uninit_serial(struct md_rdev *rdev)
130
+{
131
+ if (!test_and_clear_bit(CollisionCheck, &rdev->flags))
132
+ return;
133
+
134
+ kvfree(rdev->serial);
135
+ rdev->serial = NULL;
136
+}
137
+
138
+static void rdevs_uninit_serial(struct mddev *mddev)
139
+{
140
+ struct md_rdev *rdev;
141
+
142
+ rdev_for_each(rdev, mddev)
143
+ rdev_uninit_serial(rdev);
144
+}
145
+
146
+static int rdev_init_serial(struct md_rdev *rdev)
147
+{
148
+ /* serial_nums equals with BARRIER_BUCKETS_NR */
149
+ int i, serial_nums = 1 << ((PAGE_SHIFT - ilog2(sizeof(atomic_t))));
150
+ struct serial_in_rdev *serial = NULL;
151
+
152
+ if (test_bit(CollisionCheck, &rdev->flags))
153
+ return 0;
154
+
155
+ serial = kvmalloc(sizeof(struct serial_in_rdev) * serial_nums,
156
+ GFP_KERNEL);
157
+ if (!serial)
158
+ return -ENOMEM;
159
+
160
+ for (i = 0; i < serial_nums; i++) {
161
+ struct serial_in_rdev *serial_tmp = &serial[i];
162
+
163
+ spin_lock_init(&serial_tmp->serial_lock);
164
+ serial_tmp->serial_rb = RB_ROOT_CACHED;
165
+ init_waitqueue_head(&serial_tmp->serial_io_wait);
166
+ }
167
+
168
+ rdev->serial = serial;
169
+ set_bit(CollisionCheck, &rdev->flags);
170
+
171
+ return 0;
172
+}
173
+
174
+static int rdevs_init_serial(struct mddev *mddev)
175
+{
176
+ struct md_rdev *rdev;
177
+ int ret = 0;
178
+
179
+ rdev_for_each(rdev, mddev) {
180
+ ret = rdev_init_serial(rdev);
181
+ if (ret)
182
+ break;
183
+ }
184
+
185
+ /* Free all resources if pool is not existed */
186
+ if (ret && !mddev->serial_info_pool)
187
+ rdevs_uninit_serial(mddev);
188
+
189
+ return ret;
190
+}
191
+
192
+/*
193
+ * rdev needs to enable serial stuffs if it meets the conditions:
194
+ * 1. it is multi-queue device flaged with writemostly.
195
+ * 2. the write-behind mode is enabled.
196
+ */
197
+static int rdev_need_serial(struct md_rdev *rdev)
198
+{
199
+ return (rdev && rdev->mddev->bitmap_info.max_write_behind > 0 &&
200
+ rdev->bdev->bd_disk->queue->nr_hw_queues != 1 &&
201
+ test_bit(WriteMostly, &rdev->flags));
202
+}
203
+
204
+/*
205
+ * Init resource for rdev(s), then create serial_info_pool if:
206
+ * 1. rdev is the first device which return true from rdev_enable_serial.
207
+ * 2. rdev is NULL, means we want to enable serialization for all rdevs.
208
+ */
209
+void mddev_create_serial_pool(struct mddev *mddev, struct md_rdev *rdev,
210
+ bool is_suspend)
211
+{
212
+ int ret = 0;
213
+
214
+ if (rdev && !rdev_need_serial(rdev) &&
215
+ !test_bit(CollisionCheck, &rdev->flags))
216
+ return;
217
+
218
+ if (!is_suspend)
219
+ mddev_suspend(mddev);
220
+
221
+ if (!rdev)
222
+ ret = rdevs_init_serial(mddev);
223
+ else
224
+ ret = rdev_init_serial(rdev);
225
+ if (ret)
226
+ goto abort;
227
+
228
+ if (mddev->serial_info_pool == NULL) {
229
+ /*
230
+ * already in memalloc noio context by
231
+ * mddev_suspend()
232
+ */
233
+ mddev->serial_info_pool =
234
+ mempool_create_kmalloc_pool(NR_SERIAL_INFOS,
235
+ sizeof(struct serial_info));
236
+ if (!mddev->serial_info_pool) {
237
+ rdevs_uninit_serial(mddev);
238
+ pr_err("can't alloc memory pool for serialization\n");
239
+ }
240
+ }
241
+
242
+abort:
243
+ if (!is_suspend)
244
+ mddev_resume(mddev);
245
+}
246
+
247
+/*
248
+ * Free resource from rdev(s), and destroy serial_info_pool under conditions:
249
+ * 1. rdev is the last device flaged with CollisionCheck.
250
+ * 2. when bitmap is destroyed while policy is not enabled.
251
+ * 3. for disable policy, the pool is destroyed only when no rdev needs it.
252
+ */
253
+void mddev_destroy_serial_pool(struct mddev *mddev, struct md_rdev *rdev,
254
+ bool is_suspend)
255
+{
256
+ if (rdev && !test_bit(CollisionCheck, &rdev->flags))
257
+ return;
258
+
259
+ if (mddev->serial_info_pool) {
260
+ struct md_rdev *temp;
261
+ int num = 0; /* used to track if other rdevs need the pool */
262
+
263
+ if (!is_suspend)
264
+ mddev_suspend(mddev);
265
+ rdev_for_each(temp, mddev) {
266
+ if (!rdev) {
267
+ if (!mddev->serialize_policy ||
268
+ !rdev_need_serial(temp))
269
+ rdev_uninit_serial(temp);
270
+ else
271
+ num++;
272
+ } else if (temp != rdev &&
273
+ test_bit(CollisionCheck, &temp->flags))
274
+ num++;
275
+ }
276
+
277
+ if (rdev)
278
+ rdev_uninit_serial(rdev);
279
+
280
+ if (num)
281
+ pr_info("The mempool could be used by other devices\n");
282
+ else {
283
+ mempool_destroy(mddev->serial_info_pool);
284
+ mddev->serial_info_pool = NULL;
285
+ }
286
+ if (!is_suspend)
287
+ mddev_resume(mddev);
288
+ }
133289 }
134290
135291 static struct ctl_table_header *raid_table_header;
....@@ -172,8 +328,6 @@
172328 { }
173329 };
174330
175
-static const struct block_device_operations md_fops;
176
-
177331 static int start_readonly;
178332
179333 /*
....@@ -189,15 +343,10 @@
189343 struct bio *bio_alloc_mddev(gfp_t gfp_mask, int nr_iovecs,
190344 struct mddev *mddev)
191345 {
192
- struct bio *b;
193
-
194346 if (!mddev || !bioset_initialized(&mddev->bio_set))
195347 return bio_alloc(gfp_mask, nr_iovecs);
196348
197
- b = bio_alloc_bioset(gfp_mask, nr_iovecs, &mddev->bio_set);
198
- if (!b)
199
- return NULL;
200
- return b;
349
+ return bio_alloc_bioset(gfp_mask, nr_iovecs, &mddev->bio_set);
201350 }
202351 EXPORT_SYMBOL_GPL(bio_alloc_mddev);
203352
....@@ -310,20 +459,25 @@
310459 }
311460 EXPORT_SYMBOL(md_handle_request);
312461
313
-static blk_qc_t md_make_request(struct request_queue *q, struct bio *bio)
462
+static blk_qc_t md_submit_bio(struct bio *bio)
314463 {
315464 const int rw = bio_data_dir(bio);
316465 const int sgrp = op_stat_group(bio_op(bio));
317
- struct mddev *mddev = q->queuedata;
466
+ struct mddev *mddev = bio->bi_disk->private_data;
318467 unsigned int sectors;
319
- int cpu;
320
-
321
- blk_queue_split(q, &bio);
322468
323469 if (mddev == NULL || mddev->pers == NULL) {
324470 bio_io_error(bio);
325471 return BLK_QC_T_NONE;
326472 }
473
+
474
+ if (unlikely(test_bit(MD_BROKEN, &mddev->flags)) && (rw == WRITE)) {
475
+ bio_io_error(bio);
476
+ return BLK_QC_T_NONE;
477
+ }
478
+
479
+ blk_queue_split(&bio);
480
+
327481 if (mddev->ro == 1 && unlikely(rw == WRITE)) {
328482 if (bio_sectors(bio) != 0)
329483 bio->bi_status = BLK_STS_IOERR;
....@@ -341,9 +495,9 @@
341495
342496 md_handle_request(mddev, bio);
343497
344
- cpu = part_stat_lock();
345
- part_stat_inc(cpu, &mddev->gendisk->part0, ios[sgrp]);
346
- part_stat_add(cpu, &mddev->gendisk->part0, sectors[sgrp], sectors);
498
+ part_stat_lock();
499
+ part_stat_inc(&mddev->gendisk->part0, ios[sgrp]);
500
+ part_stat_add(&mddev->gendisk->part0, sectors[sgrp], sectors);
347501 part_stat_unlock();
348502
349503 return BLK_QC_T_NONE;
....@@ -371,11 +525,15 @@
371525 wait_event(mddev->sb_wait, !test_bit(MD_UPDATING_SB, &mddev->flags));
372526
373527 del_timer_sync(&mddev->safemode_timer);
528
+ /* restrict memory reclaim I/O during raid array is suspend */
529
+ mddev->noio_flag = memalloc_noio_save();
374530 }
375531 EXPORT_SYMBOL_GPL(mddev_suspend);
376532
377533 void mddev_resume(struct mddev *mddev)
378534 {
535
+ /* entred the memalloc scope from mddev_suspend() */
536
+ memalloc_noio_restore(mddev->noio_flag);
379537 lockdep_assert_held(&mddev->reconfig_mutex);
380538 if (--mddev->suspended)
381539 return;
....@@ -387,26 +545,6 @@
387545 md_wakeup_thread(mddev->sync_thread); /* possibly kick off a reshape */
388546 }
389547 EXPORT_SYMBOL_GPL(mddev_resume);
390
-
391
-int mddev_congested(struct mddev *mddev, int bits)
392
-{
393
- struct md_personality *pers = mddev->pers;
394
- int ret = 0;
395
-
396
- rcu_read_lock();
397
- if (mddev->suspended)
398
- ret = 1;
399
- else if (pers && pers->congested)
400
- ret = pers->congested(mddev, bits);
401
- rcu_read_unlock();
402
- return ret;
403
-}
404
-EXPORT_SYMBOL_GPL(mddev_congested);
405
-static int md_congested(void *data, int bits)
406
-{
407
- struct mddev *mddev = data;
408
- return mddev_congested(mddev, bits);
409
-}
410548
411549 /*
412550 * Generic flush handling for md
....@@ -709,7 +847,13 @@
709847 sysfs_remove_group(&mddev->kobj, &md_redundancy_group);
710848 if (mddev->sysfs_action)
711849 sysfs_put(mddev->sysfs_action);
850
+ if (mddev->sysfs_completed)
851
+ sysfs_put(mddev->sysfs_completed);
852
+ if (mddev->sysfs_degraded)
853
+ sysfs_put(mddev->sysfs_degraded);
712854 mddev->sysfs_action = NULL;
855
+ mddev->sysfs_completed = NULL;
856
+ mddev->sysfs_degraded = NULL;
713857 }
714858 }
715859 mddev->sysfs_active = 0;
....@@ -811,7 +955,8 @@
811955 struct mddev *mddev = rdev->mddev;
812956
813957 if (bio->bi_status) {
814
- pr_err("md: super_written gets error=%d\n", bio->bi_status);
958
+ pr_err("md: %s gets error=%d\n", __func__,
959
+ blk_status_to_errno(bio->bi_status));
815960 md_error(mddev, rdev);
816961 if (!test_bit(Faulty, &rdev->flags)
817962 && (bio->bi_opf & MD_FAILFAST)) {
....@@ -1066,6 +1211,7 @@
10661211 char b[BDEVNAME_SIZE], b2[BDEVNAME_SIZE];
10671212 mdp_super_t *sb;
10681213 int ret;
1214
+ bool spare_disk = true;
10691215
10701216 /*
10711217 * Calculate the position of the superblock (512byte sectors),
....@@ -1116,8 +1262,19 @@
11161262 else
11171263 rdev->desc_nr = sb->this_disk.number;
11181264
1265
+ /* not spare disk, or LEVEL_MULTIPATH */
1266
+ if (sb->level == LEVEL_MULTIPATH ||
1267
+ (rdev->desc_nr >= 0 &&
1268
+ rdev->desc_nr < MD_SB_DISKS &&
1269
+ sb->disks[rdev->desc_nr].state &
1270
+ ((1<<MD_DISK_SYNC) | (1 << MD_DISK_ACTIVE))))
1271
+ spare_disk = false;
1272
+
11191273 if (!refdev) {
1120
- ret = 1;
1274
+ if (!spare_disk)
1275
+ ret = 1;
1276
+ else
1277
+ ret = 0;
11211278 } else {
11221279 __u64 ev1, ev2;
11231280 mdp_super_t *refsb = page_address(refdev->sb_page);
....@@ -1133,7 +1290,8 @@
11331290 }
11341291 ev1 = md_event(sb);
11351292 ev2 = md_event(refsb);
1136
- if (ev1 > ev2)
1293
+
1294
+ if (!spare_disk && ev1 > ev2)
11371295 ret = 1;
11381296 else
11391297 ret = 0;
....@@ -1143,8 +1301,7 @@
11431301 * (not needed for Linear and RAID0 as metadata doesn't
11441302 * record this size)
11451303 */
1146
- if (IS_ENABLED(CONFIG_LBDAF) && (u64)rdev->sectors >= (2ULL << 32) &&
1147
- sb->level >= 1)
1304
+ if ((u64)rdev->sectors >= (2ULL << 32) && sb->level >= 1)
11481305 rdev->sectors = (sector_t)(2ULL << 32) - 2;
11491306
11501307 if (rdev->sectors < ((sector_t)sb->size) * 2 && sb->level >= 1)
....@@ -1444,8 +1601,7 @@
14441601 /* Limit to 4TB as metadata cannot record more than that.
14451602 * 4TB == 2^32 KB, or 2*2^32 sectors.
14461603 */
1447
- if (IS_ENABLED(CONFIG_LBDAF) && (u64)num_sectors >= (2ULL << 32) &&
1448
- rdev->mddev->level >= 1)
1604
+ if ((u64)num_sectors >= (2ULL << 32) && rdev->mddev->level >= 1)
14491605 num_sectors = (sector_t)(2ULL << 32) - 2;
14501606 do {
14511607 md_super_write(rdev->mddev, rdev, rdev->sb_start, rdev->sb_size,
....@@ -1495,6 +1651,7 @@
14951651 sector_t sectors;
14961652 char b[BDEVNAME_SIZE], b2[BDEVNAME_SIZE];
14971653 int bmask;
1654
+ bool spare_disk = true;
14981655
14991656 /*
15001657 * Calculate the position of the superblock in 512byte sectors.
....@@ -1589,7 +1746,7 @@
15891746 */
15901747 s32 offset;
15911748 sector_t bb_sector;
1592
- u64 *bbp;
1749
+ __le64 *bbp;
15931750 int i;
15941751 int sectors = le16_to_cpu(sb->bblog_size);
15951752 if (sectors > (PAGE_SIZE / 512))
....@@ -1601,7 +1758,7 @@
16011758 if (!sync_page_io(rdev, bb_sector, sectors << 9,
16021759 rdev->bb_page, REQ_OP_READ, 0, true))
16031760 return -EIO;
1604
- bbp = (u64 *)page_address(rdev->bb_page);
1761
+ bbp = (__le64 *)page_address(rdev->bb_page);
16051762 rdev->badblocks.shift = sb->bblog_shift;
16061763 for (i = 0 ; i < (sectors << (9-3)) ; i++, bbp++) {
16071764 u64 bb = le64_to_cpu(*bbp);
....@@ -1628,8 +1785,19 @@
16281785 sb->level != 0)
16291786 return -EINVAL;
16301787
1788
+ /* not spare disk, or LEVEL_MULTIPATH */
1789
+ if (sb->level == cpu_to_le32(LEVEL_MULTIPATH) ||
1790
+ (rdev->desc_nr >= 0 &&
1791
+ rdev->desc_nr < le32_to_cpu(sb->max_dev) &&
1792
+ (le16_to_cpu(sb->dev_roles[rdev->desc_nr]) < MD_DISK_ROLE_MAX ||
1793
+ le16_to_cpu(sb->dev_roles[rdev->desc_nr]) == MD_DISK_ROLE_JOURNAL)))
1794
+ spare_disk = false;
1795
+
16311796 if (!refdev) {
1632
- ret = 1;
1797
+ if (!spare_disk)
1798
+ ret = 1;
1799
+ else
1800
+ ret = 0;
16331801 } else {
16341802 __u64 ev1, ev2;
16351803 struct mdp_superblock_1 *refsb = page_address(refdev->sb_page);
....@@ -1646,7 +1814,7 @@
16461814 ev1 = le64_to_cpu(sb->events);
16471815 ev2 = le64_to_cpu(refsb->events);
16481816
1649
- if (ev1 > ev2)
1817
+ if (!spare_disk && ev1 > ev2)
16501818 ret = 1;
16511819 else
16521820 ret = 0;
....@@ -1928,7 +2096,7 @@
19282096 md_error(mddev, rdev);
19292097 else {
19302098 struct badblocks *bb = &rdev->badblocks;
1931
- u64 *bbp = (u64 *)page_address(rdev->bb_page);
2099
+ __le64 *bbp = (__le64 *)page_address(rdev->bb_page);
19322100 u64 *p = bb->page;
19332101 sb->feature_map |= cpu_to_le32(MD_FEATURE_BAD_BLOCKS);
19342102 if (bb->changed) {
....@@ -2003,6 +2171,24 @@
20032171 sb->sb_csum = calc_sb_1_csum(sb);
20042172 }
20052173
2174
+static sector_t super_1_choose_bm_space(sector_t dev_size)
2175
+{
2176
+ sector_t bm_space;
2177
+
2178
+ /* if the device is bigger than 8Gig, save 64k for bitmap
2179
+ * usage, if bigger than 200Gig, save 128k
2180
+ */
2181
+ if (dev_size < 64*2)
2182
+ bm_space = 0;
2183
+ else if (dev_size - 64*2 >= 200*1024*1024*2)
2184
+ bm_space = 128*2;
2185
+ else if (dev_size - 4*2 > 8*1024*1024*2)
2186
+ bm_space = 64*2;
2187
+ else
2188
+ bm_space = 4*2;
2189
+ return bm_space;
2190
+}
2191
+
20062192 static unsigned long long
20072193 super_1_rdev_size_change(struct md_rdev *rdev, sector_t num_sectors)
20082194 {
....@@ -2023,10 +2209,20 @@
20232209 return 0;
20242210 } else {
20252211 /* minor version 0; superblock after data */
2026
- sector_t sb_start;
2027
- sb_start = (i_size_read(rdev->bdev->bd_inode) >> 9) - 8*2;
2212
+ sector_t sb_start, bm_space;
2213
+ sector_t dev_size = i_size_read(rdev->bdev->bd_inode) >> 9;
2214
+
2215
+ /* 8K is for superblock */
2216
+ sb_start = dev_size - 8*2;
20282217 sb_start &= ~(sector_t)(4*2 - 1);
2029
- max_sectors = rdev->sectors + sb_start - rdev->sb_start;
2218
+
2219
+ bm_space = super_1_choose_bm_space(dev_size);
2220
+
2221
+ /* Space that can be used to store date needs to decrease
2222
+ * superblock bitmap space and bad block space(4K)
2223
+ */
2224
+ max_sectors = sb_start - bm_space - 4*2;
2225
+
20302226 if (!num_sectors || num_sectors > max_sectors)
20312227 num_sectors = max_sectors;
20322228 rdev->sb_start = sb_start;
....@@ -2124,8 +2320,7 @@
21242320 test_bit(Journal, &rdev2->flags) ||
21252321 rdev2->raid_disk == -1)
21262322 continue;
2127
- if (rdev->bdev->bd_contains ==
2128
- rdev2->bdev->bd_contains) {
2323
+ if (rdev->bdev->bd_disk == rdev2->bdev->bd_disk) {
21292324 rcu_read_unlock();
21302325 return 1;
21312326 }
....@@ -2193,14 +2388,12 @@
21932388 */
21942389 int md_integrity_add_rdev(struct md_rdev *rdev, struct mddev *mddev)
21952390 {
2196
- struct blk_integrity *bi_rdev;
21972391 struct blk_integrity *bi_mddev;
21982392 char name[BDEVNAME_SIZE];
21992393
22002394 if (!mddev->gendisk)
22012395 return 0;
22022396
2203
- bi_rdev = bdev_get_integrity(rdev->bdev);
22042397 bi_mddev = blk_get_integrity(mddev->gendisk);
22052398
22062399 if (!bi_mddev) /* nothing to do */
....@@ -2276,13 +2469,20 @@
22762469 rdev->mddev = mddev;
22772470 pr_debug("md: bind<%s>\n", b);
22782471
2472
+ if (mddev->raid_disks)
2473
+ mddev_create_serial_pool(mddev, rdev, false);
2474
+
22792475 if ((err = kobject_add(&rdev->kobj, &mddev->kobj, "dev-%s", b)))
22802476 goto fail;
22812477
22822478 ko = &part_to_dev(rdev->bdev->bd_part)->kobj;
2283
- if (sysfs_create_link(&rdev->kobj, ko, "block"))
2284
- /* failure here is OK */;
2479
+ /* failure here is OK */
2480
+ err = sysfs_create_link(&rdev->kobj, ko, "block");
22852481 rdev->sysfs_state = sysfs_get_dirent_safe(rdev->kobj.sd, "state");
2482
+ rdev->sysfs_unack_badblocks =
2483
+ sysfs_get_dirent_safe(rdev->kobj.sd, "unacknowledged_bad_blocks");
2484
+ rdev->sysfs_badblocks =
2485
+ sysfs_get_dirent_safe(rdev->kobj.sd, "bad_blocks");
22862486
22872487 list_add_rcu(&rdev->same_set, &mddev->disks);
22882488 bd_link_disk_holder(rdev->bdev, mddev->gendisk);
....@@ -2298,7 +2498,7 @@
22982498 return err;
22992499 }
23002500
2301
-static void md_delayed_delete(struct work_struct *ws)
2501
+static void rdev_delayed_delete(struct work_struct *ws)
23022502 {
23032503 struct md_rdev *rdev = container_of(ws, struct md_rdev, del_work);
23042504 kobject_del(&rdev->kobj);
....@@ -2312,19 +2512,24 @@
23122512 bd_unlink_disk_holder(rdev->bdev, rdev->mddev->gendisk);
23132513 list_del_rcu(&rdev->same_set);
23142514 pr_debug("md: unbind<%s>\n", bdevname(rdev->bdev,b));
2515
+ mddev_destroy_serial_pool(rdev->mddev, rdev, false);
23152516 rdev->mddev = NULL;
23162517 sysfs_remove_link(&rdev->kobj, "block");
23172518 sysfs_put(rdev->sysfs_state);
2519
+ sysfs_put(rdev->sysfs_unack_badblocks);
2520
+ sysfs_put(rdev->sysfs_badblocks);
23182521 rdev->sysfs_state = NULL;
2522
+ rdev->sysfs_unack_badblocks = NULL;
2523
+ rdev->sysfs_badblocks = NULL;
23192524 rdev->badblocks.count = 0;
23202525 /* We need to delay this, otherwise we can deadlock when
23212526 * writing to 'remove' to "dev/state". We also need
23222527 * to delay it due to rcu usage.
23232528 */
23242529 synchronize_rcu();
2325
- INIT_WORK(&rdev->del_work, md_delayed_delete);
2530
+ INIT_WORK(&rdev->del_work, rdev_delayed_delete);
23262531 kobject_get(&rdev->kobj);
2327
- queue_work(md_misc_wq, &rdev->del_work);
2532
+ queue_work(md_rdev_misc_wq, &rdev->del_work);
23282533 }
23292534
23302535 /*
....@@ -2336,12 +2541,12 @@
23362541 {
23372542 int err = 0;
23382543 struct block_device *bdev;
2339
- char b[BDEVNAME_SIZE];
23402544
23412545 bdev = blkdev_get_by_dev(dev, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
23422546 shared ? (struct md_rdev *)lock_rdev : rdev);
23432547 if (IS_ERR(bdev)) {
2344
- pr_warn("md: could not open %s.\n", __bdevname(dev, b));
2548
+ pr_warn("md: could not open device unknown-block(%u,%u).\n",
2549
+ MAJOR(dev), MINOR(dev));
23452550 return PTR_ERR(bdev);
23462551 }
23472552 rdev->bdev = bdev;
....@@ -2443,14 +2648,16 @@
24432648
24442649 static bool does_sb_need_changing(struct mddev *mddev)
24452650 {
2446
- struct md_rdev *rdev;
2651
+ struct md_rdev *rdev = NULL, *iter;
24472652 struct mdp_superblock_1 *sb;
24482653 int role;
24492654
24502655 /* Find a good rdev */
2451
- rdev_for_each(rdev, mddev)
2452
- if ((rdev->raid_disk >= 0) && !test_bit(Faulty, &rdev->flags))
2656
+ rdev_for_each(iter, mddev)
2657
+ if ((iter->raid_disk >= 0) && !test_bit(Faulty, &iter->flags)) {
2658
+ rdev = iter;
24532659 break;
2660
+ }
24542661
24552662 /* No good device found. */
24562663 if (!rdev)
....@@ -2660,7 +2867,7 @@
26602867 goto repeat;
26612868 wake_up(&mddev->sb_wait);
26622869 if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery))
2663
- sysfs_notify(&mddev->kobj, NULL, "sync_completed");
2870
+ sysfs_notify_dirent_safe(mddev->sysfs_completed);
26642871
26652872 rdev_for_each(rdev, mddev) {
26662873 if (test_and_clear_bit(FaultRecorded, &rdev->flags))
....@@ -2793,7 +3000,11 @@
27933000 * -write_error - clears WriteErrorSeen
27943001 * {,-}failfast - set/clear FailFast
27953002 */
3003
+
3004
+ struct mddev *mddev = rdev->mddev;
27963005 int err = -EINVAL;
3006
+ bool need_update_sb = false;
3007
+
27973008 if (cmd_match(buf, "faulty") && rdev->mddev->pers) {
27983009 md_error(rdev->mddev, rdev);
27993010 if (test_bit(Faulty, &rdev->flags))
....@@ -2808,7 +3019,6 @@
28083019 if (rdev->raid_disk >= 0)
28093020 err = -EBUSY;
28103021 else {
2811
- struct mddev *mddev = rdev->mddev;
28123022 err = 0;
28133023 if (mddev_is_clustered(mddev))
28143024 err = md_cluster_ops->remove_disk(mddev, rdev);
....@@ -2824,9 +3034,13 @@
28243034 }
28253035 } else if (cmd_match(buf, "writemostly")) {
28263036 set_bit(WriteMostly, &rdev->flags);
3037
+ mddev_create_serial_pool(rdev->mddev, rdev, false);
3038
+ need_update_sb = true;
28273039 err = 0;
28283040 } else if (cmd_match(buf, "-writemostly")) {
3041
+ mddev_destroy_serial_pool(rdev->mddev, rdev, false);
28293042 clear_bit(WriteMostly, &rdev->flags);
3043
+ need_update_sb = true;
28303044 err = 0;
28313045 } else if (cmd_match(buf, "blocked")) {
28323046 set_bit(Blocked, &rdev->flags);
....@@ -2852,9 +3066,11 @@
28523066 err = 0;
28533067 } else if (cmd_match(buf, "failfast")) {
28543068 set_bit(FailFast, &rdev->flags);
3069
+ need_update_sb = true;
28553070 err = 0;
28563071 } else if (cmd_match(buf, "-failfast")) {
28573072 clear_bit(FailFast, &rdev->flags);
3073
+ need_update_sb = true;
28583074 err = 0;
28593075 } else if (cmd_match(buf, "-insync") && rdev->raid_disk >= 0 &&
28603076 !test_bit(Journal, &rdev->flags)) {
....@@ -2933,6 +3149,8 @@
29333149 clear_bit(ExternalBbl, &rdev->flags);
29343150 err = 0;
29353151 }
3152
+ if (need_update_sb)
3153
+ md_update_sb(mddev, 1);
29363154 if (!err)
29373155 sysfs_notify_dirent_safe(rdev->sysfs_state);
29383156 return err ? err : len;
....@@ -3032,15 +3250,14 @@
30323250 rdev->saved_raid_disk = -1;
30333251 clear_bit(In_sync, &rdev->flags);
30343252 clear_bit(Bitmap_sync, &rdev->flags);
3035
- err = rdev->mddev->pers->
3036
- hot_add_disk(rdev->mddev, rdev);
3253
+ err = rdev->mddev->pers->hot_add_disk(rdev->mddev, rdev);
30373254 if (err) {
30383255 rdev->raid_disk = -1;
30393256 return err;
30403257 } else
30413258 sysfs_notify_dirent_safe(rdev->sysfs_state);
3042
- if (sysfs_link_rdev(rdev->mddev, rdev))
3043
- /* failure here is OK */;
3259
+ /* failure here is OK */;
3260
+ sysfs_link_rdev(rdev->mddev, rdev);
30443261 /* don't wakeup anyone, leave that to userspace. */
30453262 } else {
30463263 if (slot >= rdev->mddev->raid_disks &&
....@@ -3422,7 +3639,7 @@
34223639 if (!entry->show)
34233640 return -EIO;
34243641 if (!rdev->mddev)
3425
- return -EBUSY;
3642
+ return -ENODEV;
34263643 return entry->show(rdev, page);
34273644 }
34283645
....@@ -3439,10 +3656,10 @@
34393656 return -EIO;
34403657 if (!capable(CAP_SYS_ADMIN))
34413658 return -EACCES;
3442
- rv = mddev ? mddev_lock(mddev): -EBUSY;
3659
+ rv = mddev ? mddev_lock(mddev) : -ENODEV;
34433660 if (!rv) {
34443661 if (rdev->mddev == NULL)
3445
- rv = -EBUSY;
3662
+ rv = -ENODEV;
34463663 else
34473664 rv = entry->store(rdev, page, length);
34483665 mddev_unlock(mddev);
....@@ -3563,7 +3780,7 @@
35633780 * Check a full RAID array for plausibility
35643781 */
35653782
3566
-static void analyze_sbs(struct mddev *mddev)
3783
+static int analyze_sbs(struct mddev *mddev)
35673784 {
35683785 int i;
35693786 struct md_rdev *rdev, *freshest, *tmp;
....@@ -3583,6 +3800,12 @@
35833800 bdevname(rdev->bdev,b));
35843801 md_kick_rdev_from_array(rdev);
35853802 }
3803
+
3804
+ /* Cannot find a valid fresh disk */
3805
+ if (!freshest) {
3806
+ pr_warn("md: cannot find a valid disk\n");
3807
+ return -EINVAL;
3808
+ }
35863809
35873810 super_types[mddev->major_version].
35883811 validate_super(mddev, freshest);
....@@ -3618,6 +3841,8 @@
36183841 clear_bit(In_sync, &rdev->flags);
36193842 }
36203843 }
3844
+
3845
+ return 0;
36213846 }
36223847
36233848 /* Read a fixed-point number.
....@@ -3652,11 +3877,7 @@
36523877 return -EINVAL;
36533878 if (decimals < 0)
36543879 decimals = 0;
3655
- while (decimals < scale) {
3656
- result *= 10;
3657
- decimals ++;
3658
- }
3659
- *res = result;
3880
+ *res = result * int_pow(10, scale - decimals);
36603881 return 0;
36613882 }
36623883
....@@ -3861,6 +4082,8 @@
38614082 pr_warn("md: cannot register extra attributes for %s\n",
38624083 mdname(mddev));
38634084 mddev->sysfs_action = sysfs_get_dirent(mddev->kobj.sd, "sync_action");
4085
+ mddev->sysfs_completed = sysfs_get_dirent_safe(mddev->kobj.sd, "sync_completed");
4086
+ mddev->sysfs_degraded = sysfs_get_dirent_safe(mddev->kobj.sd, "degraded");
38644087 }
38654088 if (oldpers->sync_request != NULL &&
38664089 pers->sync_request == NULL) {
....@@ -3908,7 +4131,7 @@
39084131 mddev_resume(mddev);
39094132 if (!mddev->thread)
39104133 md_update_sb(mddev, 1);
3911
- sysfs_notify(&mddev->kobj, NULL, "level");
4134
+ sysfs_notify_dirent_safe(mddev->sysfs_level);
39124135 md_new_event(mddev);
39134136 rv = len;
39144137 out_unlock:
....@@ -4019,6 +4242,14 @@
40194242 }
40204243 static struct md_sysfs_entry md_raid_disks =
40214244 __ATTR(raid_disks, S_IRUGO|S_IWUSR, raid_disks_show, raid_disks_store);
4245
+
4246
+static ssize_t
4247
+uuid_show(struct mddev *mddev, char *page)
4248
+{
4249
+ return sprintf(page, "%pU\n", mddev->uuid);
4250
+}
4251
+static struct md_sysfs_entry md_uuid =
4252
+__ATTR(uuid, S_IRUGO, uuid_show, NULL);
40224253
40234254 static ssize_t
40244255 chunk_size_show(struct mddev *mddev, char *page)
....@@ -4143,12 +4374,17 @@
41434374 * active-idle
41444375 * like active, but no writes have been seen for a while (100msec).
41454376 *
4377
+ * broken
4378
+ * RAID0/LINEAR-only: same as clean, but array is missing a member.
4379
+ * It's useful because RAID0/LINEAR mounted-arrays aren't stopped
4380
+ * when a member is gone, so this state will at least alert the
4381
+ * user that something is wrong.
41464382 */
41474383 enum array_state { clear, inactive, suspended, readonly, read_auto, clean, active,
4148
- write_pending, active_idle, bad_word};
4384
+ write_pending, active_idle, broken, bad_word};
41494385 static char *array_states[] = {
41504386 "clear", "inactive", "suspended", "readonly", "read-auto", "clean", "active",
4151
- "write-pending", "active-idle", NULL };
4387
+ "write-pending", "active-idle", "broken", NULL };
41524388
41534389 static int match_word(const char *word, char **list)
41544390 {
....@@ -4164,7 +4400,7 @@
41644400 {
41654401 enum array_state st = inactive;
41664402
4167
- if (mddev->pers && !test_bit(MD_NOT_READY, &mddev->flags))
4403
+ if (mddev->pers && !test_bit(MD_NOT_READY, &mddev->flags)) {
41684404 switch(mddev->ro) {
41694405 case 1:
41704406 st = readonly;
....@@ -4184,7 +4420,10 @@
41844420 st = active;
41854421 spin_unlock(&mddev->lock);
41864422 }
4187
- else {
4423
+
4424
+ if (test_bit(MD_BROKEN, &mddev->flags) && st == clean)
4425
+ st = broken;
4426
+ } else {
41884427 if (list_empty(&mddev->disks) &&
41894428 mddev->raid_disks == 0 &&
41904429 mddev->dev_sectors == 0)
....@@ -4197,7 +4436,6 @@
41974436
41984437 static int do_md_stop(struct mddev *mddev, int ro, struct block_device *bdev);
41994438 static int md_set_readonly(struct mddev *mddev, struct block_device *bdev);
4200
-static int do_md_run(struct mddev *mddev);
42014439 static int restart_array(struct mddev *mddev);
42024440
42034441 static ssize_t
....@@ -4298,6 +4536,7 @@
42984536 break;
42994537 case write_pending:
43004538 case active_idle:
4539
+ case broken:
43014540 /* these cannot be set */
43024541 break;
43034542 }
....@@ -4342,6 +4581,20 @@
43424581 return -EINVAL;
43434582 }
43444583
4584
+/* need to ensure rdev_delayed_delete() has completed */
4585
+static void flush_rdev_wq(struct mddev *mddev)
4586
+{
4587
+ struct md_rdev *rdev;
4588
+
4589
+ rcu_read_lock();
4590
+ rdev_for_each_rcu(rdev, mddev)
4591
+ if (work_pending(&rdev->del_work)) {
4592
+ flush_workqueue(md_rdev_misc_wq);
4593
+ break;
4594
+ }
4595
+ rcu_read_unlock();
4596
+}
4597
+
43454598 static ssize_t
43464599 new_dev_store(struct mddev *mddev, const char *buf, size_t len)
43474600 {
....@@ -4369,8 +4622,7 @@
43694622 minor != MINOR(dev))
43704623 return -EOVERFLOW;
43714624
4372
- flush_workqueue(md_misc_wq);
4373
-
4625
+ flush_rdev_wq(mddev);
43744626 err = mddev_lock(mddev);
43754627 if (err)
43764628 return err;
....@@ -4608,7 +4860,8 @@
46084860 clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
46094861 if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery) &&
46104862 mddev_lock(mddev) == 0) {
4611
- flush_workqueue(md_misc_wq);
4863
+ if (work_pending(&mddev->del_work))
4864
+ flush_workqueue(md_misc_wq);
46124865 if (mddev->sync_thread) {
46134866 set_bit(MD_RECOVERY_INTR, &mddev->recovery);
46144867 md_reap_sync_thread(mddev);
....@@ -4638,7 +4891,7 @@
46384891 }
46394892 if (err)
46404893 return err;
4641
- sysfs_notify(&mddev->kobj, NULL, "degraded");
4894
+ sysfs_notify_dirent_safe(mddev->sysfs_degraded);
46424895 } else {
46434896 if (cmd_match(page, "check"))
46444897 set_bit(MD_RECOVERY_CHECK, &mddev->recovery);
....@@ -5113,7 +5366,7 @@
51135366 mddev->array_sectors = sectors;
51145367 if (mddev->pers) {
51155368 set_capacity(mddev->gendisk, mddev->array_sectors);
5116
- revalidate_disk(mddev->gendisk);
5369
+ revalidate_disk_size(mddev->gendisk, true);
51175370 }
51185371 }
51195372 mddev_unlock(mddev);
....@@ -5170,10 +5423,90 @@
51705423 __ATTR(consistency_policy, S_IRUGO | S_IWUSR, consistency_policy_show,
51715424 consistency_policy_store);
51725425
5426
+static ssize_t fail_last_dev_show(struct mddev *mddev, char *page)
5427
+{
5428
+ return sprintf(page, "%d\n", mddev->fail_last_dev);
5429
+}
5430
+
5431
+/*
5432
+ * Setting fail_last_dev to true to allow last device to be forcibly removed
5433
+ * from RAID1/RAID10.
5434
+ */
5435
+static ssize_t
5436
+fail_last_dev_store(struct mddev *mddev, const char *buf, size_t len)
5437
+{
5438
+ int ret;
5439
+ bool value;
5440
+
5441
+ ret = kstrtobool(buf, &value);
5442
+ if (ret)
5443
+ return ret;
5444
+
5445
+ if (value != mddev->fail_last_dev)
5446
+ mddev->fail_last_dev = value;
5447
+
5448
+ return len;
5449
+}
5450
+static struct md_sysfs_entry md_fail_last_dev =
5451
+__ATTR(fail_last_dev, S_IRUGO | S_IWUSR, fail_last_dev_show,
5452
+ fail_last_dev_store);
5453
+
5454
+static ssize_t serialize_policy_show(struct mddev *mddev, char *page)
5455
+{
5456
+ if (mddev->pers == NULL || (mddev->pers->level != 1))
5457
+ return sprintf(page, "n/a\n");
5458
+ else
5459
+ return sprintf(page, "%d\n", mddev->serialize_policy);
5460
+}
5461
+
5462
+/*
5463
+ * Setting serialize_policy to true to enforce write IO is not reordered
5464
+ * for raid1.
5465
+ */
5466
+static ssize_t
5467
+serialize_policy_store(struct mddev *mddev, const char *buf, size_t len)
5468
+{
5469
+ int err;
5470
+ bool value;
5471
+
5472
+ err = kstrtobool(buf, &value);
5473
+ if (err)
5474
+ return err;
5475
+
5476
+ if (value == mddev->serialize_policy)
5477
+ return len;
5478
+
5479
+ err = mddev_lock(mddev);
5480
+ if (err)
5481
+ return err;
5482
+ if (mddev->pers == NULL || (mddev->pers->level != 1)) {
5483
+ pr_err("md: serialize_policy is only effective for raid1\n");
5484
+ err = -EINVAL;
5485
+ goto unlock;
5486
+ }
5487
+
5488
+ mddev_suspend(mddev);
5489
+ if (value)
5490
+ mddev_create_serial_pool(mddev, NULL, true);
5491
+ else
5492
+ mddev_destroy_serial_pool(mddev, NULL, true);
5493
+ mddev->serialize_policy = value;
5494
+ mddev_resume(mddev);
5495
+unlock:
5496
+ mddev_unlock(mddev);
5497
+ return err ?: len;
5498
+}
5499
+
5500
+static struct md_sysfs_entry md_serialize_policy =
5501
+__ATTR(serialize_policy, S_IRUGO | S_IWUSR, serialize_policy_show,
5502
+ serialize_policy_store);
5503
+
5504
+
51735505 static struct attribute *md_default_attrs[] = {
51745506 &md_level.attr,
51755507 &md_layout.attr,
51765508 &md_raid_disks.attr,
5509
+ &md_uuid.attr,
51775510 &md_chunk_size.attr,
51785511 &md_size.attr,
51795512 &md_resync_start.attr,
....@@ -5186,6 +5519,8 @@
51865519 &md_array_size.attr,
51875520 &max_corr_read_errors.attr,
51885521 &md_consistency_policy.attr,
5522
+ &md_fail_last_dev.attr,
5523
+ &md_serialize_policy.attr,
51895524 NULL,
51905525 };
51915526
....@@ -5263,6 +5598,8 @@
52635598
52645599 if (mddev->sysfs_state)
52655600 sysfs_put(mddev->sysfs_state);
5601
+ if (mddev->sysfs_level)
5602
+ sysfs_put(mddev->sysfs_level);
52665603
52675604 if (mddev->gendisk)
52685605 del_gendisk(mddev->gendisk);
....@@ -5304,7 +5641,8 @@
53045641 {
53055642 if (mddev->writes_pending.percpu_count_ptr)
53065643 return 0;
5307
- if (percpu_ref_init(&mddev->writes_pending, no_op, 0, GFP_KERNEL) < 0)
5644
+ if (percpu_ref_init(&mddev->writes_pending, no_op,
5645
+ PERCPU_REF_ALLOW_REINIT, GFP_KERNEL) < 0)
53085646 return -ENOMEM;
53095647 /* We want to start with the refcount at zero */
53105648 percpu_ref_put(&mddev->writes_pending);
....@@ -5369,12 +5707,10 @@
53695707 mddev->hold_active = UNTIL_STOP;
53705708
53715709 error = -ENOMEM;
5372
- mddev->queue = blk_alloc_queue(GFP_KERNEL);
5710
+ mddev->queue = blk_alloc_queue(NUMA_NO_NODE);
53735711 if (!mddev->queue)
53745712 goto abort;
5375
- mddev->queue->queuedata = mddev;
53765713
5377
- blk_queue_make_request(mddev->queue, md_make_request);
53785714 blk_set_stacking_limits(&mddev->queue->limits);
53795715
53805716 disk = alloc_disk(1 << shift);
....@@ -5400,6 +5736,7 @@
54005736 * remove it now.
54015737 */
54025738 disk->flags |= GENHD_FL_EXT_DEVT;
5739
+ disk->events |= DISK_EVENT_MEDIA_CHANGE;
54035740 mddev->gendisk = disk;
54045741 add_disk(disk);
54055742
....@@ -5420,6 +5757,7 @@
54205757 if (!error && mddev->kobj.sd) {
54215758 kobject_uevent(&mddev->kobj, KOBJ_ADD);
54225759 mddev->sysfs_state = sysfs_get_dirent_safe(mddev->kobj.sd, "array_state");
5760
+ mddev->sysfs_level = sysfs_get_dirent_safe(mddev->kobj.sd, "level");
54235761 }
54245762 mddev_put(mddev);
54255763 return error;
....@@ -5496,7 +5834,9 @@
54965834 if (!mddev->raid_disks) {
54975835 if (!mddev->persistent)
54985836 return -EINVAL;
5499
- analyze_sbs(mddev);
5837
+ err = analyze_sbs(mddev);
5838
+ if (err)
5839
+ return -EINVAL;
55005840 }
55015841
55025842 if (mddev->level != LEVEL_NONE)
....@@ -5601,8 +5941,8 @@
56015941 rdev_for_each(rdev, mddev)
56025942 rdev_for_each(rdev2, mddev) {
56035943 if (rdev < rdev2 &&
5604
- rdev->bdev->bd_contains ==
5605
- rdev2->bdev->bd_contains) {
5944
+ rdev->bdev->bd_disk ==
5945
+ rdev2->bdev->bd_disk) {
56065946 pr_warn("%s: WARNING: %s appears to be on the same physical disk as %s.\n",
56075947 mdname(mddev),
56085948 bdevname(rdev->bdev,b),
....@@ -5649,15 +5989,28 @@
56495989 mddev->bitmap = bitmap;
56505990
56515991 }
5652
- if (err) {
5653
- mddev_detach(mddev);
5654
- if (mddev->private)
5655
- pers->free(mddev, mddev->private);
5656
- mddev->private = NULL;
5657
- module_put(pers->owner);
5658
- md_bitmap_destroy(mddev);
5659
- goto abort;
5992
+ if (err)
5993
+ goto bitmap_abort;
5994
+
5995
+ if (mddev->bitmap_info.max_write_behind > 0) {
5996
+ bool create_pool = false;
5997
+
5998
+ rdev_for_each(rdev, mddev) {
5999
+ if (test_bit(WriteMostly, &rdev->flags) &&
6000
+ rdev_init_serial(rdev))
6001
+ create_pool = true;
6002
+ }
6003
+ if (create_pool && mddev->serial_info_pool == NULL) {
6004
+ mddev->serial_info_pool =
6005
+ mempool_create_kmalloc_pool(NR_SERIAL_INFOS,
6006
+ sizeof(struct serial_info));
6007
+ if (!mddev->serial_info_pool) {
6008
+ err = -ENOMEM;
6009
+ goto bitmap_abort;
6010
+ }
6011
+ }
56606012 }
6013
+
56616014 if (mddev->queue) {
56626015 bool nonrot = true;
56636016
....@@ -5674,8 +6027,6 @@
56746027 blk_queue_flag_set(QUEUE_FLAG_NONROT, mddev->queue);
56756028 else
56766029 blk_queue_flag_clear(QUEUE_FLAG_NONROT, mddev->queue);
5677
- mddev->queue->backing_dev_info->congested_data = mddev;
5678
- mddev->queue->backing_dev_info->congested_fn = md_congested;
56796030 }
56806031 if (pers->sync_request) {
56816032 if (mddev->kobj.sd &&
....@@ -5683,6 +6034,8 @@
56836034 pr_warn("md: cannot register extra attributes for %s\n",
56846035 mdname(mddev));
56856036 mddev->sysfs_action = sysfs_get_dirent_safe(mddev->kobj.sd, "sync_action");
6037
+ mddev->sysfs_completed = sysfs_get_dirent_safe(mddev->kobj.sd, "sync_completed");
6038
+ mddev->sysfs_degraded = sysfs_get_dirent_safe(mddev->kobj.sd, "degraded");
56866039 } else if (mddev->ro == 2) /* auto-readonly not meaningful */
56876040 mddev->ro = 0;
56886041
....@@ -5692,7 +6045,7 @@
56926045 if (mddev_is_clustered(mddev))
56936046 mddev->safemode_delay = 0;
56946047 else
5695
- mddev->safemode_delay = (200 * HZ)/1000 +1; /* 200 msec delay */
6048
+ mddev->safemode_delay = DEFAULT_SAFEMODE_DELAY;
56966049 mddev->in_sync = 1;
56976050 smp_wmb();
56986051 spin_lock(&mddev->lock);
....@@ -5700,8 +6053,7 @@
57006053 spin_unlock(&mddev->lock);
57016054 rdev_for_each(rdev, mddev)
57026055 if (rdev->raid_disk >= 0)
5703
- if (sysfs_link_rdev(mddev, rdev))
5704
- /* failure here is OK */;
6056
+ sysfs_link_rdev(mddev, rdev); /* failure here is OK */
57056057
57066058 if (mddev->degraded && !mddev->ro)
57076059 /* This ensures that recovering status is reported immediately
....@@ -5716,6 +6068,13 @@
57166068 md_new_event(mddev);
57176069 return 0;
57186070
6071
+bitmap_abort:
6072
+ mddev_detach(mddev);
6073
+ if (mddev->private)
6074
+ pers->free(mddev, mddev->private);
6075
+ mddev->private = NULL;
6076
+ module_put(pers->owner);
6077
+ md_bitmap_destroy(mddev);
57196078 abort:
57206079 bioset_exit(&mddev->bio_set);
57216080 bioset_exit(&mddev->sync_set);
....@@ -5723,7 +6082,7 @@
57236082 }
57246083 EXPORT_SYMBOL_GPL(md_run);
57256084
5726
-static int do_md_run(struct mddev *mddev)
6085
+int do_md_run(struct mddev *mddev)
57276086 {
57286087 int err;
57296088
....@@ -5747,13 +6106,13 @@
57476106 md_wakeup_thread(mddev->sync_thread); /* possibly kick off a reshape */
57486107
57496108 set_capacity(mddev->gendisk, mddev->array_sectors);
5750
- revalidate_disk(mddev->gendisk);
6109
+ revalidate_disk_size(mddev->gendisk, true);
57516110 clear_bit(MD_NOT_READY, &mddev->flags);
57526111 mddev->changed = 1;
57536112 kobject_uevent(&disk_to_dev(mddev->gendisk)->kobj, KOBJ_CHANGE);
57546113 sysfs_notify_dirent_safe(mddev->sysfs_state);
57556114 sysfs_notify_dirent_safe(mddev->sysfs_action);
5756
- sysfs_notify(&mddev->kobj, NULL, "degraded");
6115
+ sysfs_notify_dirent_safe(mddev->sysfs_degraded);
57576116 out:
57586117 clear_bit(MD_NOT_READY, &mddev->flags);
57596118 return err;
....@@ -5868,7 +6227,8 @@
58686227 static void __md_stop_writes(struct mddev *mddev)
58696228 {
58706229 set_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
5871
- flush_workqueue(md_misc_wq);
6230
+ if (work_pending(&mddev->del_work))
6231
+ flush_workqueue(md_misc_wq);
58726232 if (mddev->sync_thread) {
58736233 set_bit(MD_RECOVERY_INTR, &mddev->recovery);
58746234 md_reap_sync_thread(mddev);
....@@ -5890,6 +6250,9 @@
58906250 mddev->in_sync = 1;
58916251 md_update_sb(mddev, 1);
58926252 }
6253
+ /* disable policy to guarantee rdevs free resources for serialization */
6254
+ mddev->serialize_policy = 0;
6255
+ mddev_destroy_serial_pool(mddev, NULL, true);
58936256 }
58946257
58956258 void md_stop_writes(struct mddev *mddev)
....@@ -5918,7 +6281,8 @@
59186281 md_bitmap_destroy(mddev);
59196282 mddev_detach(mddev);
59206283 /* Ensure ->event_work is done */
5921
- flush_workqueue(md_misc_wq);
6284
+ if (mddev->event_work.func)
6285
+ flush_workqueue(md_misc_wq);
59226286 spin_lock(&mddev->lock);
59236287 mddev->pers = NULL;
59246288 spin_unlock(&mddev->lock);
....@@ -5935,6 +6299,7 @@
59356299 /* stop the array and free an attached data structures.
59366300 * This is called from dm-raid
59376301 */
6302
+ __md_stop_writes(mddev);
59386303 __md_stop(mddev);
59396304 bioset_exit(&mddev->bio_set);
59406305 bioset_exit(&mddev->sync_set);
....@@ -6049,7 +6414,6 @@
60496414
60506415 __md_stop_writes(mddev);
60516416 __md_stop(mddev);
6052
- mddev->queue->backing_dev_info->congested_fn = NULL;
60536417
60546418 /* tell userspace to handle 'inactive' */
60556419 sysfs_notify_dirent_safe(mddev->sysfs_state);
....@@ -6061,7 +6425,7 @@
60616425 set_capacity(disk, 0);
60626426 mutex_unlock(&mddev->open_mutex);
60636427 mddev->changed = 1;
6064
- revalidate_disk(disk);
6428
+ revalidate_disk_size(disk, true);
60656429
60666430 if (mddev->ro)
60676431 mddev->ro = 0;
....@@ -6352,7 +6716,7 @@
63526716 return 0;
63536717 }
63546718
6355
-static int add_new_disk(struct mddev *mddev, mdu_disk_info_t *info)
6719
+int md_add_new_disk(struct mddev *mddev, struct mdu_disk_info_s *info)
63566720 {
63576721 char b[BDEVNAME_SIZE], b2[BDEVNAME_SIZE];
63586722 struct md_rdev *rdev;
....@@ -6398,7 +6762,7 @@
63986762 }
63996763
64006764 /*
6401
- * add_new_disk can be used once the array is assembled
6765
+ * md_add_new_disk can be used once the array is assembled
64026766 * to add "hot spares". They must already have a superblock
64036767 * written
64046768 */
....@@ -6511,7 +6875,7 @@
65116875 return err;
65126876 }
65136877
6514
- /* otherwise, add_new_disk is only allowed
6878
+ /* otherwise, md_add_new_disk is only allowed
65156879 * for major_version==0 superblocks
65166880 */
65176881 if (mddev->major_version != 0) {
....@@ -6758,7 +7122,7 @@
67587122 }
67597123
67607124 /*
6761
- * set_array_info is used two different ways
7125
+ * md_set_array_info is used two different ways
67627126 * The original usage is when creating a new array.
67637127 * In this usage, raid_disks is > 0 and it together with
67647128 * level, size, not_persistent,layout,chunksize determine the
....@@ -6770,9 +7134,8 @@
67707134 * The minor and patch _version numbers are also kept incase the
67717135 * super_block handler wishes to interpret them.
67727136 */
6773
-static int set_array_info(struct mddev *mddev, mdu_array_info_t *info)
7137
+int md_set_array_info(struct mddev *mddev, struct mdu_array_info_s *info)
67747138 {
6775
-
67767139 if (info->raid_disks == 0) {
67777140 /* just setting version number for superblock loading */
67787141 if (info->major_version < 0 ||
....@@ -6894,7 +7257,7 @@
68947257 md_cluster_ops->update_size(mddev, old_dev_sectors);
68957258 else if (mddev->queue) {
68967259 set_capacity(mddev->gendisk, mddev->array_sectors);
6897
- revalidate_disk(mddev->gendisk);
7260
+ revalidate_disk_size(mddev->gendisk, true);
68987261 }
68997262 }
69007263 return rv;
....@@ -7061,6 +7424,8 @@
70617424
70627425 mddev->bitmap_info.nodes = 0;
70637426 md_cluster_ops->leave(mddev);
7427
+ module_put(md_cluster_mod);
7428
+ mddev->safemode_delay = DEFAULT_SAFEMODE_DELAY;
70647429 }
70657430 mddev_suspend(mddev);
70667431 md_bitmap_destroy(mddev);
....@@ -7121,7 +7486,6 @@
71217486 case GET_DISK_INFO:
71227487 case HOT_ADD_DISK:
71237488 case HOT_REMOVE_DISK:
7124
- case RAID_AUTORUN:
71257489 case RAID_VERSION:
71267490 case RESTART_ARRAY_RW:
71277491 case RUN_ARRAY:
....@@ -7167,13 +7531,6 @@
71677531 case RAID_VERSION:
71687532 err = get_version(argp);
71697533 goto out;
7170
-
7171
-#ifndef MODULE
7172
- case RAID_AUTORUN:
7173
- err = 0;
7174
- autostart_arrays(arg);
7175
- goto out;
7176
-#endif
71777534 default:;
71787535 }
71797536
....@@ -7214,9 +7571,8 @@
72147571
72157572 }
72167573
7217
- if (cmd == ADD_NEW_DISK)
7218
- /* need to ensure md_delayed_delete() has completed */
7219
- flush_workqueue(md_misc_wq);
7574
+ if (cmd == ADD_NEW_DISK || cmd == HOT_ADD_DISK)
7575
+ flush_rdev_wq(mddev);
72207576
72217577 if (cmd == HOT_REMOVE_DISK)
72227578 /* need to ensure recovery thread has run */
....@@ -7276,7 +7632,7 @@
72767632 err = -EBUSY;
72777633 goto unlock;
72787634 }
7279
- err = set_array_info(mddev, &info);
7635
+ err = md_set_array_info(mddev, &info);
72807636 if (err) {
72817637 pr_warn("md: couldn't set array info. %d\n", err);
72827638 goto unlock;
....@@ -7330,7 +7686,7 @@
73307686 /* Need to clear read-only for this */
73317687 break;
73327688 else
7333
- err = add_new_disk(mddev, &info);
7689
+ err = md_add_new_disk(mddev, &info);
73347690 goto unlock;
73357691 }
73367692 break;
....@@ -7398,7 +7754,7 @@
73987754 if (copy_from_user(&info, argp, sizeof(info)))
73997755 err = -EFAULT;
74007756 else
7401
- err = add_new_disk(mddev, &info);
7757
+ err = md_add_new_disk(mddev, &info);
74027758 goto unlock;
74037759 }
74047760
....@@ -7493,7 +7849,7 @@
74937849 atomic_inc(&mddev->openers);
74947850 mutex_unlock(&mddev->open_mutex);
74957851
7496
- check_disk_change(bdev);
7852
+ bdev_check_media_change(bdev);
74977853 out:
74987854 if (err)
74997855 mddev_put(mddev);
....@@ -7509,23 +7865,21 @@
75097865 mddev_put(mddev);
75107866 }
75117867
7512
-static int md_media_changed(struct gendisk *disk)
7868
+static unsigned int md_check_events(struct gendisk *disk, unsigned int clearing)
75137869 {
75147870 struct mddev *mddev = disk->private_data;
7871
+ unsigned int ret = 0;
75157872
7516
- return mddev->changed;
7517
-}
7518
-
7519
-static int md_revalidate(struct gendisk *disk)
7520
-{
7521
- struct mddev *mddev = disk->private_data;
7522
-
7873
+ if (mddev->changed)
7874
+ ret = DISK_EVENT_MEDIA_CHANGE;
75237875 mddev->changed = 0;
7524
- return 0;
7876
+ return ret;
75257877 }
7526
-static const struct block_device_operations md_fops =
7878
+
7879
+const struct block_device_operations md_fops =
75277880 {
75287881 .owner = THIS_MODULE,
7882
+ .submit_bio = md_submit_bio,
75297883 .open = md_open,
75307884 .release = md_release,
75317885 .ioctl = md_ioctl,
....@@ -7533,8 +7887,7 @@
75337887 .compat_ioctl = md_compat_ioctl,
75347888 #endif
75357889 .getgeo = md_getgeo,
7536
- .media_changed = md_media_changed,
7537
- .revalidate_disk= md_revalidate,
7890
+ .check_events = md_check_events,
75387891 };
75397892
75407893 static int md_thread(void *arg)
....@@ -7618,17 +7971,22 @@
76187971
76197972 void md_unregister_thread(struct md_thread **threadp)
76207973 {
7621
- struct md_thread *thread = *threadp;
7622
- if (!thread)
7623
- return;
7624
- pr_debug("interrupting MD-thread pid %d\n", task_pid_nr(thread->tsk));
7625
- /* Locking ensures that mddev_unlock does not wake_up a
7974
+ struct md_thread *thread;
7975
+
7976
+ /*
7977
+ * Locking ensures that mddev_unlock does not wake_up a
76267978 * non-existent thread
76277979 */
76287980 spin_lock(&pers_lock);
7981
+ thread = *threadp;
7982
+ if (!thread) {
7983
+ spin_unlock(&pers_lock);
7984
+ return;
7985
+ }
76297986 *threadp = NULL;
76307987 spin_unlock(&pers_lock);
76317988
7989
+ pr_debug("interrupting MD-thread pid %d\n", task_pid_nr(thread->tsk));
76327990 kthread_stop(thread->tsk);
76337991 kfree(thread);
76347992 }
....@@ -8006,13 +8364,12 @@
80068364 return mask;
80078365 }
80088366
8009
-static const struct file_operations md_seq_fops = {
8010
- .owner = THIS_MODULE,
8011
- .open = md_seq_open,
8012
- .read = seq_read,
8013
- .llseek = seq_lseek,
8014
- .release = seq_release,
8015
- .poll = mdstat_poll,
8367
+static const struct proc_ops mdstat_proc_ops = {
8368
+ .proc_open = md_seq_open,
8369
+ .proc_read = seq_read,
8370
+ .proc_lseek = seq_lseek,
8371
+ .proc_release = seq_release,
8372
+ .proc_poll = mdstat_poll,
80168373 };
80178374
80188375 int register_md_personality(struct md_personality *p)
....@@ -8063,6 +8420,7 @@
80638420
80648421 int md_setup_cluster(struct mddev *mddev, int nodes)
80658422 {
8423
+ int ret;
80668424 if (!md_cluster_ops)
80678425 request_module("md-cluster");
80688426 spin_lock(&pers_lock);
....@@ -8074,7 +8432,10 @@
80748432 }
80758433 spin_unlock(&pers_lock);
80768434
8077
- return md_cluster_ops->join(mddev, nodes);
8435
+ ret = md_cluster_ops->join(mddev, nodes);
8436
+ if (!ret)
8437
+ mddev->safemode_delay = 0;
8438
+ return ret;
80788439 }
80798440
80808441 void md_cluster_stop(struct mddev *mddev)
....@@ -8094,7 +8455,7 @@
80948455 idle = 1;
80958456 rcu_read_lock();
80968457 rdev_for_each_rcu(rdev, mddev) {
8097
- struct gendisk *disk = rdev->bdev->bd_contains->bd_disk;
8458
+ struct gendisk *disk = rdev->bdev->bd_disk;
80988459 curr_events = (int)part_stat_read_accum(&disk->part0, sectors) -
80998460 atomic_read(&disk->sync_io);
81008461 /* sync IO will cause sync_io to increase before the disk_stats
....@@ -8273,8 +8634,7 @@
82738634 {
82748635 struct mddev *mddev = thread->mddev;
82758636 struct mddev *mddev2;
8276
- unsigned int currspeed = 0,
8277
- window;
8637
+ unsigned int currspeed = 0, window;
82788638 sector_t max_sectors,j, io_sectors, recovery_done;
82798639 unsigned long mark[SYNC_MARKS];
82808640 unsigned long update_time;
....@@ -8331,7 +8691,7 @@
83318691 * 0 == not engaged in resync at all
83328692 * 2 == checking that there is no conflict with another sync
83338693 * 1 == like 2, but have yielded to allow conflicting resync to
8334
- * commense
8694
+ * commence
83358695 * other == active in resync - this many blocks
83368696 *
83378697 * Before starting a resync we must have set curr_resync to
....@@ -8405,9 +8765,17 @@
84058765 else if (!mddev->bitmap)
84068766 j = mddev->recovery_cp;
84078767
8408
- } else if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery))
8768
+ } else if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery)) {
84098769 max_sectors = mddev->resync_max_sectors;
8410
- else {
8770
+ /*
8771
+ * If the original node aborts reshaping then we continue the
8772
+ * reshaping, so set j again to avoid restart reshape from the
8773
+ * first beginning
8774
+ */
8775
+ if (mddev_is_clustered(mddev) &&
8776
+ mddev->reshape_position != MaxSector)
8777
+ j = mddev->reshape_position;
8778
+ } else {
84118779 /* recovery follows the physical size of devices */
84128780 max_sectors = mddev->dev_sectors;
84138781 j = MaxSector;
....@@ -8454,7 +8822,7 @@
84548822 /*
84558823 * Tune reconstruction:
84568824 */
8457
- window = 32*(PAGE_SIZE/512);
8825
+ window = 32 * (PAGE_SIZE / 512);
84588826 pr_debug("md: using %dk window, over a total of %lluk.\n",
84598827 window/2, (unsigned long long)max_sectors/2);
84608828
....@@ -8468,7 +8836,7 @@
84688836 } else
84698837 mddev->curr_resync = 3; /* no longer delayed */
84708838 mddev->curr_resync_completed = j;
8471
- sysfs_notify(&mddev->kobj, NULL, "sync_completed");
8839
+ sysfs_notify_dirent_safe(mddev->sysfs_completed);
84728840 md_new_event(mddev);
84738841 update_time = jiffies;
84748842
....@@ -8496,7 +8864,7 @@
84968864 mddev->recovery_cp = j;
84978865 update_time = jiffies;
84988866 set_bit(MD_SB_CHANGE_CLEAN, &mddev->sb_flags);
8499
- sysfs_notify(&mddev->kobj, NULL, "sync_completed");
8867
+ sysfs_notify_dirent_safe(mddev->sysfs_completed);
85008868 }
85018869
85028870 while (j >= mddev->resync_max &&
....@@ -8603,7 +8971,7 @@
86038971 !test_bit(MD_RECOVERY_INTR, &mddev->recovery) &&
86048972 mddev->curr_resync > 3) {
86058973 mddev->curr_resync_completed = mddev->curr_resync;
8606
- sysfs_notify(&mddev->kobj, NULL, "sync_completed");
8974
+ sysfs_notify_dirent_safe(mddev->sysfs_completed);
86078975 }
86088976 mddev->pers->sync_request(mddev, max_sectors, &skipped);
86098977
....@@ -8658,8 +9026,10 @@
86589026 mddev_lock_nointr(mddev);
86599027 md_set_array_sectors(mddev, mddev->pers->size(mddev, 0, 0));
86609028 mddev_unlock(mddev);
8661
- set_capacity(mddev->gendisk, mddev->array_sectors);
8662
- revalidate_disk(mddev->gendisk);
9029
+ if (!mddev_is_clustered(mddev)) {
9030
+ set_capacity(mddev->gendisk, mddev->array_sectors);
9031
+ revalidate_disk_size(mddev->gendisk, true);
9032
+ }
86639033 }
86649034
86659035 spin_lock(&mddev->lock);
....@@ -8731,7 +9101,7 @@
87319101 }
87329102
87339103 if (removed && mddev->kobj.sd)
8734
- sysfs_notify(&mddev->kobj, NULL, "degraded");
9104
+ sysfs_notify_dirent_safe(mddev->sysfs_degraded);
87359105
87369106 if (this && removed)
87379107 goto no_add;
....@@ -8758,10 +9128,9 @@
87589128
87599129 rdev->recovery_offset = 0;
87609130 }
8761
- if (mddev->pers->
8762
- hot_add_disk(mddev, rdev) == 0) {
8763
- if (sysfs_link_rdev(mddev, rdev))
8764
- /* failure here is OK */;
9131
+ if (mddev->pers->hot_add_disk(mddev, rdev) == 0) {
9132
+ /* failure here is OK */
9133
+ sysfs_link_rdev(mddev, rdev);
87659134 if (!test_bit(Journal, &rdev->flags))
87669135 spares++;
87679136 md_new_event(mddev);
....@@ -9004,6 +9373,8 @@
90049373 void md_reap_sync_thread(struct mddev *mddev)
90059374 {
90069375 struct md_rdev *rdev;
9376
+ sector_t old_dev_sectors = mddev->dev_sectors;
9377
+ bool is_reshaped = false;
90079378
90089379 /* resync has finished, collect result */
90099380 md_unregister_thread(&mddev->sync_thread);
....@@ -9013,14 +9384,16 @@
90139384 /* success...*/
90149385 /* activate any spares */
90159386 if (mddev->pers->spare_active(mddev)) {
9016
- sysfs_notify(&mddev->kobj, NULL,
9017
- "degraded");
9387
+ sysfs_notify_dirent_safe(mddev->sysfs_degraded);
90189388 set_bit(MD_SB_CHANGE_DEVS, &mddev->sb_flags);
90199389 }
90209390 }
90219391 if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery) &&
9022
- mddev->pers->finish_reshape)
9392
+ mddev->pers->finish_reshape) {
90239393 mddev->pers->finish_reshape(mddev);
9394
+ if (mddev_is_clustered(mddev))
9395
+ is_reshaped = true;
9396
+ }
90249397
90259398 /* If array is no-longer degraded, then any saved_raid_disk
90269399 * information must be scrapped.
....@@ -9041,9 +9414,18 @@
90419414 clear_bit(MD_RECOVERY_RESHAPE, &mddev->recovery);
90429415 clear_bit(MD_RECOVERY_REQUESTED, &mddev->recovery);
90439416 clear_bit(MD_RECOVERY_CHECK, &mddev->recovery);
9417
+ /*
9418
+ * We call md_cluster_ops->update_size here because sync_size could
9419
+ * be changed by md_update_sb, and MD_RECOVERY_RESHAPE is cleared,
9420
+ * so it is time to update size across cluster.
9421
+ */
9422
+ if (mddev_is_clustered(mddev) && is_reshaped
9423
+ && !test_bit(MD_CLOSING, &mddev->flags))
9424
+ md_cluster_ops->update_size(mddev, old_dev_sectors);
90449425 wake_up(&resync_wait);
90459426 /* flag recovery needed just to double check */
90469427 set_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
9428
+ sysfs_notify_dirent_safe(mddev->sysfs_completed);
90479429 sysfs_notify_dirent_safe(mddev->sysfs_action);
90489430 md_new_event(mddev);
90499431 if (mddev->event_work.func)
....@@ -9093,8 +9475,7 @@
90939475 if (rv == 0) {
90949476 /* Make sure they get written out promptly */
90959477 if (test_bit(ExternalBbl, &rdev->flags))
9096
- sysfs_notify(&rdev->kobj, NULL,
9097
- "unacknowledged_bad_blocks");
9478
+ sysfs_notify_dirent_safe(rdev->sysfs_unack_badblocks);
90989479 sysfs_notify_dirent_safe(rdev->sysfs_state);
90999480 set_mask_bits(&mddev->sb_flags, 0,
91009481 BIT(MD_SB_CHANGE_CLEAN) | BIT(MD_SB_CHANGE_PENDING));
....@@ -9115,7 +9496,7 @@
91159496 s += rdev->data_offset;
91169497 rv = badblocks_clear(&rdev->badblocks, s, sectors);
91179498 if ((rv == 0) && test_bit(ExternalBbl, &rdev->flags))
9118
- sysfs_notify(&rdev->kobj, NULL, "bad_blocks");
9499
+ sysfs_notify_dirent_safe(rdev->sysfs_badblocks);
91199500 return rv;
91209501 }
91219502 EXPORT_SYMBOL_GPL(rdev_clear_badblocks);
....@@ -9159,7 +9540,7 @@
91599540 {
91609541 pr_debug("md: sizeof(mdp_super_t) = %d\n", (int)sizeof(mdp_super_t));
91619542
9162
- proc_create("mdstat", S_IRUGO, NULL, &md_seq_fops);
9543
+ proc_create("mdstat", S_IRUGO, NULL, &mdstat_proc_ops);
91639544 }
91649545
91659546 static int __init md_init(void)
....@@ -9173,6 +9554,10 @@
91739554 md_misc_wq = alloc_workqueue("md_misc", 0, 0);
91749555 if (!md_misc_wq)
91759556 goto err_misc_wq;
9557
+
9558
+ md_rdev_misc_wq = alloc_workqueue("md_rdev_misc", 0, 0);
9559
+ if (!md_rdev_misc_wq)
9560
+ goto err_rdev_misc_wq;
91769561
91779562 if ((ret = register_blkdev(MD_MAJOR, "md")) < 0)
91789563 goto err_md;
....@@ -9195,6 +9580,8 @@
91959580 err_mdp:
91969581 unregister_blkdev(MD_MAJOR, "md");
91979582 err_md:
9583
+ destroy_workqueue(md_rdev_misc_wq);
9584
+err_rdev_misc_wq:
91989585 destroy_workqueue(md_misc_wq);
91999586 err_misc_wq:
92009587 destroy_workqueue(md_wq);
....@@ -9240,8 +9627,12 @@
92409627 }
92419628
92429629 if (role != rdev2->raid_disk) {
9243
- /* got activated */
9244
- if (rdev2->raid_disk == -1 && role != 0xffff) {
9630
+ /*
9631
+ * got activated except reshape is happening.
9632
+ */
9633
+ if (rdev2->raid_disk == -1 && role != 0xffff &&
9634
+ !(le32_to_cpu(sb->feature_map) &
9635
+ MD_FEATURE_RESHAPE_ACTIVE)) {
92459636 rdev2->saved_raid_disk = role;
92469637 ret = remove_and_add_spares(mddev, rdev2);
92479638 pr_info("Activated spare: %s\n",
....@@ -9250,7 +9641,6 @@
92509641 * perform resync with the new activated disk */
92519642 set_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
92529643 md_wakeup_thread(mddev->thread);
9253
-
92549644 }
92559645 /* device faulty
92569646 * We just want to do the minimum to mark the disk
....@@ -9268,6 +9658,30 @@
92689658 ret = update_raid_disks(mddev, le32_to_cpu(sb->raid_disks));
92699659 if (ret)
92709660 pr_warn("md: updating array disks failed. %d\n", ret);
9661
+ }
9662
+
9663
+ /*
9664
+ * Since mddev->delta_disks has already updated in update_raid_disks,
9665
+ * so it is time to check reshape.
9666
+ */
9667
+ if (test_bit(MD_RESYNCING_REMOTE, &mddev->recovery) &&
9668
+ (le32_to_cpu(sb->feature_map) & MD_FEATURE_RESHAPE_ACTIVE)) {
9669
+ /*
9670
+ * reshape is happening in the remote node, we need to
9671
+ * update reshape_position and call start_reshape.
9672
+ */
9673
+ mddev->reshape_position = le64_to_cpu(sb->reshape_position);
9674
+ if (mddev->pers->update_reshape_pos)
9675
+ mddev->pers->update_reshape_pos(mddev);
9676
+ if (mddev->pers->start_reshape)
9677
+ mddev->pers->start_reshape(mddev);
9678
+ } else if (test_bit(MD_RESYNCING_REMOTE, &mddev->recovery) &&
9679
+ mddev->reshape_position != MaxSector &&
9680
+ !(le32_to_cpu(sb->feature_map) & MD_FEATURE_RESHAPE_ACTIVE)) {
9681
+ /* reshape is just done in another node. */
9682
+ mddev->reshape_position = MaxSector;
9683
+ if (mddev->pers->update_reshape_pos)
9684
+ mddev->pers->update_reshape_pos(mddev);
92719685 }
92729686
92739687 /* Finally set the event to be up to date */
....@@ -9315,7 +9729,7 @@
93159729 if (rdev->recovery_offset == MaxSector &&
93169730 !test_bit(In_sync, &rdev->flags) &&
93179731 mddev->pers->spare_active(mddev))
9318
- sysfs_notify(&mddev->kobj, NULL, "degraded");
9732
+ sysfs_notify_dirent_safe(mddev->sysfs_degraded);
93199733
93209734 put_page(swapout);
93219735 return 0;
....@@ -9323,16 +9737,18 @@
93239737
93249738 void md_reload_sb(struct mddev *mddev, int nr)
93259739 {
9326
- struct md_rdev *rdev;
9740
+ struct md_rdev *rdev = NULL, *iter;
93279741 int err;
93289742
93299743 /* Find the rdev */
9330
- rdev_for_each_rcu(rdev, mddev) {
9331
- if (rdev->desc_nr == nr)
9744
+ rdev_for_each_rcu(iter, mddev) {
9745
+ if (iter->desc_nr == nr) {
9746
+ rdev = iter;
93329747 break;
9748
+ }
93339749 }
93349750
9335
- if (!rdev || rdev->desc_nr != nr) {
9751
+ if (!rdev) {
93369752 pr_warn("%s: %d Could not find rdev with nr %d\n", __func__, __LINE__, nr);
93379753 return;
93389754 }
....@@ -9378,7 +9794,7 @@
93789794 }
93799795 }
93809796
9381
-static void autostart_arrays(int part)
9797
+void md_autostart_arrays(int part)
93829798 {
93839799 struct md_rdev *rdev;
93849800 struct detected_devices_node *node_detected_dev;
....@@ -9457,6 +9873,7 @@
94579873 * destroy_workqueue() below will wait for that to complete.
94589874 */
94599875 }
9876
+ destroy_workqueue(md_rdev_misc_wq);
94609877 destroy_workqueue(md_misc_wq);
94619878 destroy_workqueue(md_wq);
94629879 }
....@@ -9466,7 +9883,7 @@
94669883
94679884 static int get_ro(char *buffer, const struct kernel_param *kp)
94689885 {
9469
- return sprintf(buffer, "%d", start_readonly);
9886
+ return sprintf(buffer, "%d\n", start_readonly);
94709887 }
94719888 static int set_ro(const char *val, const struct kernel_param *kp)
94729889 {